Download
(17 Kb)
Download
Updated: 05/01/14 12:16 PM
Pictures
File Info
Compatibility:
Live (1.0)
Updated:05/01/14 12:16 PM
Created:03/15/14 10:15 PM
Monthly downloads:136
Total downloads:51,147
Favorites:164
MD5:
Categories:Discontinued & Outdated, Auction House & Vendors
ins:JunkYard  Popular! (More than 5000 hits)
Version: 1.0a1
by: ins, YelloDello
==========================
insjunkyard
by: instant
==========================

Introduction:
==============
insJunkyard is an addon that can automatically sell _EVERY_
item you have marked as "Junk" whenever you visit a STORE.

It can automatically mark ANY item you have added to a stored list
as junk, and will remember this for your next game session.

It can auto mark TRASH items as Junk, so you do not have to do that
every time you loot a junk item.

You can be told which items are sold, the quantity, and the sum value
of said item as they are sold.

When you exit the store, you can be told the number of items sold and
the total sum gained.

When you loot an item you can get a message in chat with what you
looted as a clickable link.

It also has an option to let you know what your party members looted.

You can be informed when your inventory size is getting dangeorusly low.

It can also automatically mark as junk any item with the "Ornate" trait.
I.e. items with "This item will sell for %". So you can easily sell these.

It can semi-automatically destroy items that are in your junk bag,
on the junkyard list and are worth 0 gold.


==================================================================
To use JunkYard just as a Loot Info Addon you can do the following:

/junkyard set loot (to true)
/junkyard set party (to true)
/junkyard set junkyard (to false)
/junkyard set warn 0 (disabled inventory warnings)
/junkyard set autosell (Disables autoselling)

This will set the addon to display messages for all your loot
and for any loot your party members get. It will disable the
autoselling of junk items, the automarking of junk items and
the auto-warnings on low inventory space.
==================================================================

Commands:
==========
Type /junkyard to see a list of commands.
Type "/junkyard setup" or "/jy setup" for a GUI Option Screen.

Toggle between GLOBAL Configuration options and CHAR Specific:
* /junkyard set global

Toggle between GLOBAL or PER-CHARACTER "Junk" Profile.
(This is the list of all items that are regarded as junk)
* /junkyard set globaljunk

Toggle to have a startup message or not.
* /junkyard set welcome

Current working ITEMLIST commands:
* List all inventory items (/junkyard list all)
* List all junk items in inventory (/junkyard list junk)
* List all items of a set quality (0-5) (/junkyard list q 0-5)

* See a listing of all settings (/junkyard set)

Current Settings:
(at vendors)
* Feedback per item sold (/junkyard set salespam)
* Summary of sales on store exit (/junkyard set vendor)
* Autoselling JUNK items when at vendor (/Junkyard set autosell)

(when looting)
* Loot messages in chat (/junkyard set loot)
* Loot messages from party members (/junkyard set party)
* Inventory Size Warning (/junkyard set warn) Toggle to warn when you have 5 slots or less free
(This is also when AutoDestroy would kick in)

(dangerous)
* Autodestroy JUNK items that are worthless when low on inventory (/junkyard set destroy) !! WARNING !!
For an item to be destroyed it
a. Must be in the JUNK bag
b. Must be worth 0
c. Must be on the MARK list and match EXACTLY the MARK link.
And the mouse cursor must be 'clear'

(junk related)
* Notification each time an item is added to junk (/junkyard set junkspam)
* Automark TRASH items as junk (/junkyard set junkyard)
* Automark "Vendor Sell %" trait items as Junk (/junkyard set trait)
** With /junkyard set trait #0-5 as an optional number you can set a limit to which items will be put in JUNK based
on their item quality in addition to having the "Will sell to vendor for %xx more" trait. Any other number disables
the quality check.

0 - Worn/Trash (Gray)
1 - Normal (White)
2 - Fine (Green)
3 - Superior (Blue)
4 - Epic (Purple)
5 - Legendary (Gold)

Special AutoMarking Options are:
/junkyard add all - This option will add all items from your CURRENT Junk Inventory to Autojunk.
/junkyard add # - Where # is the ID you see when typing LIST or LIST JUNK options
/junkyard remove # - Where # is the ID you see when typing LIST/List Junk option.
/junkyard list mark - Lists the items on the saved AutoJunk list and their autojunk setting.
/junkyard delmark # - Remove a marked item from the MARK List.
/junkyard dm # (Same as above)

Note; You will have to ADD items to the MARK list from LIST/LIST JUNK for them
to be saved. Autojunk must be enabled for the auto-junking to work.

Todo:
======
* Prettier output / Reduce spam.
* Translations
* Help
* Less bugs and "hacky"
* Rewrite when I have the time

Changelist:
============
* See file "Change.log"


License:
=========


This work is licensed under a Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License
Code:
v1.0a1	- 2014-05-01
[Added]
* Option to have the junkmark list global or per character (/jy set globaljunk)
* Option to delete everything on the mark list. (/jy delmark all)
* "dm" as an option instead of typing "delmark"

[Bugfix]
* (More) input validation on /jy delmark
* Fixed the listbox selection for quality levels
* Small bug with party loot output.

 0.9999 2014-04-28 
 [BugFix:] (I hope).
 Some problems with all the settings being reset and either set to all TRUE or all FALSE. 
 I hopefully fixed it. 

 0.999 2014-04-27 
 [New:]
 +Not yet a full rewrite, but I did spend two days getting a setup screen working without using LibAddonMenu
 as I didn't want the list to grow any larger.  Type '/junkyard setup' to use it.
 
 [New:]
 + Autodestrction of 0 value, marked and junked items when low inventory
   "/junkyard set destroy"
 
 [New:]
 + GLOBAL or Character-specific settings. (Yes, this will destroy your savedvariables).
   "/junkyard set global" to toggle it.
   Remember to RELOAD THE UI _AND_ confirm your settings after using this option.
 
 [New:]
 + Added a itemstrip function to get a lot of itemdata. This will be used in a future update that will
 destroy your JUNK list but also make it more 'flexible'. 

 [New:]
 + Toggle to see the welcome message on addon loading or not.
   /junkyard set welcome

 [Change:]
 * Changed some of the "/jy list" listings to include more information about the items, such as
 the trait, value and type of item. Did you know there are two types of Disguises for example.
 
 

 0.99  2014-04-22
 [Bugfix:]
 +Apparently using global variables and function names is not a good idea, as this addon and other unnamed
 addons also using global variables ran into a bit of a fight.

 Change:
 +Redid everything to local, then had to swap things around as they were refering to functions that didn't exist yet. 
 What came first, the function or the call? Well, with Globals it doesn't matter, with locals it does.
 			

 0.98  [NEW] With "/junkyard set auto" option enabled, any time you add an item to JUNK through the UI, it will 
       automatically be added to the Junkyard list, so it will be remembered for other gaming sessions.
       This also works the other way, so if you remove something from 'junk' it will also be removed from the MARK list.
       
       [NEW] Added a option to /Junkyard set trait #0-5<- which identifies the item quality the trait must be equal to or 
       below for it to be auto-added to the junk list.
       
       [NEW] Shortcut /jy added in addition to /junkyard -- save you all that typing. :)
       
       [CHANGE] If an item is "TRASH" item, and is autojunked, it will not be added to the MARK list, since the 
       whole purpose of the addon as for these items to be Junked to begin with. (Should make the MARK list shorter)
          + Need to change how this works in v2.x 
          
       I really should get an option menu for this soon..
       

 0.97  [CHANGE] Had to redo the saved-variables as I suspect another addon used the same name which might have caused problems.
       [CHANGE] Changed the way inventory size warnings work. 

 0.96  [NEW] Toggle for messages when items are added to junk (/junkyard set junkspam)
 			 [NEW] Now shows 'stack count' for stackable items (those that go to 100) when looted.
 			        Note: Might bug if you have multiple stacks of 100. 
       [CHANGE] Toggle for item sale feedback moved to (/junkyard set salespam)      
       [CHANGE] Items added to junk list are now "Links" instead of "Names". Hopefully this means
       that "Cake"(gray) and "Cake"(white) are no longer mistaken for the same "cake". 
       We all know Pie is better anyway. Blueberry pie. 
       [CHANGE] Savedvariables has changed, so all settings had to be reset.
       (I added a few extra "backup settings" so maybe I wont have to reset this again as I can reuse them)

 0.95  [NEW] Toggle automarking items with "Sell to vendor for % more" as junk (/junkyard set trait)
       [NEW] Added (/junkyard help) for help text. (Currently it only tells you to read this read.me)
       [CHANGE] Savedvariable setup. After this you'll only need to redo your settings when there are options added.
       [CHANGE] (/junkyard set) will now show all the settings available (and the current value)
       (moved it out from the default /junkyard command list to reduce spam.)
       

 0.94  [NEW] Autojunk will now also add items with the trait
       "This item will sell to vendors for 125%" etc. to the junk. 
       (This option may not add every item with these traits, please send
       a bug report when it does so I can troubleshoot it. )

 0.92  [BUGFIX] Pesky bug. Had a slight error that caused the mark list fail
       on anything but the first entry.

 0.91  [BUGFIX] Fixed a bug with the saving of the marked list :-(
       [ADDED] A listing option to see items of a particular quality 
        /junkyard list q #
              0  = trash
              1  = normal
              2  = magical
              3  = superior
              4  = epic
              5  = legendary          

 0.9   [NEW] Added option "/junkyard add all" to add ALL ITEMS you currently have
       in your junk inventory to the autojunk list.
       
 0.85- [NEW] Save a list of items to be marked as junk
       [NEW] Add items to list of items to be marked as junk
       [NEW] Remove items from auto+junk list. (TRASH items will be marked regardless)
       [CHANGE] Modified the LIST and LIST ALL output to include Item Quality and ID.
       [CHANGE] Inventory Size warnings set on a 40 second timer. Hopefully.

 0.7 - [NEW] Configure Autosell ON/OFF
       [NEW] Configure Inventory size warning (0 disables). 
       [CHANGE] Some output changes

 0.6c- [BUGFIX] Renamed Readme.txt to Read.ME as the game thinks all TXT 
       files are addons.

 0.6b- [BUGFIX] Local Colours are bad, Globals are bad too - Seems like there
       is no such thing as magic. (: 
       Easter egg bug found by ESOUI@Graywind! Thanks.
       
 0.6 - [NEW]More configuration options
       * Automark TRASH as Junk (/junkyard set junkyard)
       * Vendor feedbar per item (/junkyard set spam)
       * Vendor summary on store exit (/junkyard set vendor)
       * Loot messages in chat (/junkyard set loot)
       * Loot messages from party members (/junkyard set party)
       
       [CHANGE]Internal code for handling input events
       [CHANGE]Did some things with the output to make it more magic

 0.5 - [NEW]Automark TRASH ITEMS as JUNK. (/wave to ESOUI@Ayuki & ESOUI@Garkin)

 0.4 - [NEW]Toggle chat spam on/off
       * [BONUS FEATURE] Save the setting! 
       [NEW]List all inventory items
       [NEW]List all JUNK items in inventory     

 0.2 - Bugfix: Clear the junk history on vendor exit.
Optional Files (1)
File Name
Version
Size
Author
Date
Type
1.03
18kB
09/20/14 03:36 PM
Patch


Archived Files (1)
File Name
Version
Size
Uploader
Date
0.9999
16kB
ins
04/28/14 02:55 PM


Post A Reply Comment Options
Unread 04/26/14, 05:46 PM  
Cerelia
 
Cerelia's Avatar

Forum posts: 0
File comments: 15
Uploads: 0
Originally Posted by choekstr
Originally Posted by ins
Originally Posted by Saiasanc
This would be great. But is there a way to do it so it only deletes items with a gold value of 0 (zero)? Perhaps something to look into for a future feature.
Yes, it can be done quite easily. Just going from value alone is dangerous however.
It can indeed be dangerous but if it has been classified as junk AND it is value 0 then there is Zero value at all to the item. An option to destroy in this scenario is highly desired and should be safe assuming the logic is sound.
This would be a GREAT feature!! **imagining never having to worry about those stale radishes (and other similar low level lootable foods) again**
Report comment to moderator  
Reply With Quote
Unread 04/26/14, 01:51 PM  
Khorrhxe

Forum posts: 5
File comments: 35
Uploads: 0
fantastic addon.. possible to add a '/quietstart' whatever option to prevent to addon from displaying the initial addon load message? thx!
Report comment to moderator  
Reply With Quote
Unread 04/25/14, 06:48 AM  
Veideon

Forum posts: 0
File comments: 34
Uploads: 0
When i use "/junkyard set trait false" it doesn't works and following messages appears:

Report comment to moderator  
Reply With Quote
Unread 04/23/14, 10:06 AM  
ins
AddOn Author - Click to view AddOns

Forum posts: 76
File comments: 84
Uploads: 5
Originally Posted by Eleventeen
Originally Posted by ins
Are you using a older version by the way? I think I removed the "insJY" output in a more recent version. Where I Hopefully fixed the bug?
Hi updated to latest.

The 4 line spam bug is not fixed sorry =/

The /mb conflict is fixed =)

Cheers. I'll look at it today hopefully
Report comment to moderator  
Reply With Quote
Unread 04/23/14, 07:27 AM  
Eleventeen

Forum posts: 16
File comments: 122
Uploads: 0
Originally Posted by ins
Are you using a older version by the way? I think I removed the "insJY" output in a more recent version. Where I Hopefully fixed the bug?
Hi updated to latest.

The 4 line spam bug is not fixed sorry =/

The /mb conflict is fixed =)
Report comment to moderator  
Reply With Quote
Unread 04/22/14, 01:09 PM  
choekstr
 
choekstr's Avatar

Forum posts: 14
File comments: 391
Uploads: 0
Originally Posted by ins
Originally Posted by Saiasanc
This would be great. But is there a way to do it so it only deletes items with a gold value of 0 (zero)? Perhaps something to look into for a future feature.
Yes, it can be done quite easily. Just going from value alone is dangerous however.
It can indeed be dangerous but if it has been classified as junk AND it is value 0 then there is Zero value at all to the item. An option to destroy in this scenario is highly desired and should be safe assuming the logic is sound.
Report comment to moderator  
Reply With Quote
Unread 04/22/14, 11:09 AM  
ins
AddOn Author - Click to view AddOns

Forum posts: 76
File comments: 84
Uploads: 5
Code:
0.99  2014-04-22
 Bugfix:
 +Apparently using global variables and function names is not a good idea, as this addon and other unnamed
 addons also using global variables ran into a bit of a fight.

 Change:
 +Redid everything to local, then had to swap things around as they were refering to functions that didn't exist yet. 
 What came first, the function or the call? Well, with Globals it doesn't matter, with locals it does.
Guess delete option got pushed till 1.0
Report comment to moderator  
Reply With Quote
Unread 04/22/14, 09:56 AM  
Saiasanc

Forum posts: 0
File comments: 11
Uploads: 0
Todo:
======
* Maybe an option to "autoDelete" your Junk if your inventory is full
This would be great. But is there a way to do it so it only deletes items with a gold value of 0 (zero)? Perhaps something to look into for a future feature.
Report comment to moderator  
Reply With Quote
Unread 04/22/14, 09:56 AM  
ins
AddOn Author - Click to view AddOns

Forum posts: 76
File comments: 84
Uploads: 5
Originally Posted by Saiasanc
I am running into the same issue where it adds an item on my junk list, but indicates in chat that it removed/un-marked it as junk. Example:



Note: It isn't actually removing them. It just seems like it based on the chat feedback. The same item looted later still results in the item being marked as junk and put in the junk tab.
Thanks for that. I'll look into that now. Good to know it works as it should in the background, it just appears to be broken .

Are you using a older version by the way? I think I removed the "insJY" output in a more recent version. Where I Hopefully fixed the bug?



Originally Posted by Eleventeen
Also notice a new issue today:
Uncompatible with:
http://www.esoui.com/downloads/info251-MobileBank.html

Because for whatever reason, doing /mb to access the mobile bank commands, dumps me insjunkyard commands list?
I'll download MobilBank to find out what I (or they) did wrong.
Some of the code comments are in Russian. This is going to be tricky, only done a few hours of language lessons so far

Edit2: Found the error I think. Will upload a version shortly that will be compatible.
Edit3: We both did something wrong. Junkyard is ready for a total rewrite I think.

Originally Posted by Saiasanc
This would be great. But is there a way to do it so it only deletes items with a gold value of 0 (zero)? Perhaps something to look into for a future feature.
Yes, it can be done quite easily. Just going from value alone is dangerous however.



Edit 5:
Testing the changes now. Seems ok. Pretty sure I fixed that "junk/unjunk" spam in an update. Can you download 0.98 and see if you get the same problem, or wait another 20 minutes for 0.99 to be uploaded where I fix that other issue with MiniBank etc.
Last edited by ins : 04/22/14 at 10:47 AM.
Report comment to moderator  
Reply With Quote
Unread 04/22/14, 09:40 AM  
Eleventeen

Forum posts: 16
File comments: 122
Uploads: 0
Originally Posted by Saiasanc
I am running into the same issue where it adds an item on my junk list, but indicates in chat that it removed/un-marked it as junk. Example:
Yep, pretty frequent bug, seems to happen to about 30-40% of em. Though it's visual only, they don't actually get unmarked.

Also notice a new issue today:
Uncompatible with:
http://www.esoui.com/downloads/info251-MobileBank.html

Because for whatever reason, doing /mb to access the mobile bank commands, dumps me insjunkyard commands list?
Last edited by Eleventeen : 04/22/14 at 09:41 AM.
Report comment to moderator  
Reply With Quote
Unread 04/22/14, 09:34 AM  
Saiasanc

Forum posts: 0
File comments: 11
Uploads: 0
I am running into the same issue where it adds an item on my junk list, but indicates in chat that it removed/un-marked it as junk. Example:



Note: It isn't actually removing them. It just seems like it based on the chat feedback. The same item looted later still results in the item being marked as junk and put in the junk tab.
Last edited by Saiasanc : 04/22/14 at 09:46 AM.
Report comment to moderator  
Reply With Quote
Unread 04/22/14, 09:22 AM  
ins
AddOn Author - Click to view AddOns

Forum posts: 76
File comments: 84
Uploads: 5
Originally Posted by pandachu
For your default settings when a person first installs the add on, you should consider turning off the "mark trait items as junk." I'm suggesting this because after updating, I realized I had been losing gear to the autojunk/autosell options because I did not even realize there was a new trait option for it.... Some people might want to sell those but that gear is actually useful to wear at low levels, or for deconstructing for crafting.
Cheers. Good suggestion. I always tend to customize addons before I start using them, so I suppose it kinda "crept through".

Maybe there should be a notice the first time you use the addon to put attention to the fact that there are many options to be configured?

And I suppose I should add a GUI for configuring it.

Need more hours in the day for this
Report comment to moderator  
Reply With Quote
Unread 04/21/14, 01:10 PM  
pandachu

Forum posts: 0
File comments: 5
Uploads: 0
For your default settings when a person first installs the add on, you should consider turning off the "mark trait items as junk." I'm suggesting this because after updating, I realized I had been losing gear to the autojunk/autosell options because I did not even realize there was a new trait option for it.... Some people might want to sell those but that gear is actually useful to wear at low levels, or for deconstructing for crafting.
Report comment to moderator  
Reply With Quote
Unread 04/19/14, 08:17 PM  
ins
AddOn Author - Click to view AddOns

Forum posts: 76
File comments: 84
Uploads: 5
I been playing with the following options enabled today and haven't really run into any problems:

Salespam - False
Junkspam - True
Summary - True
Loot - True
Party - True

Related to items/junk:
Junkyard (True) (Automarking items)
Auto (true) - Adds to mark list when adding through UI
trait (True) (Normal) - Adds Normal and Trash item with "%sell" to junk.
Autosell (false) - not selling items

Warn (5) - Warn me when i'm below 5 slots inventory. (once).


I suppose I should rename the settings to make them more 'streamlined'. Other than that, there is an issue with the "junk" code running through twice when you do stuff, which I have to fix.

I suppose translations should be added as well.


Let me know if you are able to reproduce issues where it breaks, I been busy trying to level up a bit today, as I was falling far behind guild when all I do ingame is to look at lua code


Originally Posted by choekstr
[EDIT: Nope, it is set on. I keep marking things as junk and it seems to work even after a relog but I swear there are items I repeatedly mark as junk and they just don't go automatically into junk. I need to do more testing. It could just be that since 0.98 I haven't trained those items yet and still working through the massive amount of items to be collected]
It could be that these items are not 100% identical. I'll recheck the method. I digged into item links a bit more and deciphered most of them, so I should be able to get items more accurately now - once I code it into the addon that is. It really needs a rewrite from the ground up though.
Last edited by ins : 04/19/14 at 08:20 PM.
Report comment to moderator  
Reply With Quote
Unread 04/19/14, 11:14 AM  
choekstr
 
choekstr's Avatar

Forum posts: 14
File comments: 391
Uploads: 0
Originally Posted by Faustus
Originally Posted by choekstr
[EDIT: Turns out we need to do a /junkyard set auto before the UI marking as Junk works. I would vote this is default behavior but understand why it isn't set by default.]
Even worse, it seems you have to set it to auto every single time you relog?
Ahh, maybe that is why it had stopped working for me. I kept thinking, I junked these things already why isn't junkyard picking it up?

[EDIT: Nope, it is set on. I keep marking things as junk and it seems to work even after a relog but I swear there are items I repeatedly mark as junk and they just don't go automatically into junk. I need to do more testing. It could just be that since 0.98 I haven't trained those items yet and still working through the massive amount of items to be collected]
Last edited by choekstr : 04/19/14 at 03:43 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.