request: fake role tracker for new group finder
Can we get an addon that somehow notifies us when someone joins with one role and then changes it (they're already tricking the group finder so we won't be getting tanks). It would help for trials if we knew which dps faked it so we can kick that person for a real tank instead of having to guess or just not have a tank.
<3 Thanks |
If something like this is created, my vote is to have the addon "disable" itself for custom made groups and Normal difficulty queues. We don't need more toxicity or gatekeeping in entry-level content.
|
Addons cannot track such afaik, unless the ones doing it got the same addon enabled too. And guess what they would do:D
|
Quote:
|
Quote:
|
Quote:
|
Could just be a chat notification, if the group is listening for a group finder, a "@username, role joined the group" notification in chat..
|
Quote:
|
I did some testing and yes you can get the roles of players joining and when they change it.
BUT and this is a big but, the event for role changes fires everytime someone starts a teleport(enters loading screen), finishes teleport(end loading screen) or when going offline/online. Also it seems like the role is not always directly given when a player joins for the first time. You might be able to get around this if you save the last "real" role they had and check against it before you print a new role change message to chat, but I don't know enough about coding to figure out how to do this. |
I did not try this but for anyone wanting to give it a try here is some example code how it could work (similar like Antisenil explained I yesterday just pseudo coded this with saving the role as someone enters a group and checking on that saved role as someone changes the role).
It's saved by charactername but maybe displayname works too if the OnGroupMemberLeft event's param characterName is actually the displayName (haven't tested this as I said) And: If you change the zone or have a loading screen/reloadui the saved roles are gone, so one needs to add them to SavedVariables if they need to persists a reloadui!!! Function OnGroupMemberJoined needs some love about finding the characterName of the groupMember who joined. The part with the 0 to GetGroupSize() and find the unitTag by the index, could need a change. Code:
local groupMemberRoles = {} |
this is what i did so far. it's a combination of "GroupNotifications" by CaptainBlagbird and Baertrams code here.
the only thing to be done might be some clean up of bad code ( i realy dont know what i'm doing :D ) GoogleDrive updated the addon, changelog is included |
Thanks for throwing this together!
I've reviewed the code and changed it (removed some globally leaking variables / fixed translation strings to be properl created, using LFG_ROLE_TANK etc. constants for the group roles instead of the numbers, using the proper SavedVariables table and not the defaults, and others). Will test this and link the updated code here then afterwards Edit: GroupRoleSnitch fixed and improved Tested it as good as possible and should work now. Roles are only alerted if they really change "since joining the group", and the alerts will be repeated if they still are wrong as you zone/reload the UI |
All times are GMT -6. The time now is 07:43 AM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI