ESOUI

ESOUI (https://www.esoui.com/forums/index.php)
-   AddOn Search/Requests (https://www.esoui.com/forums/forumdisplay.php?f=165)
-   -   [Request] ChatMultiWindow Update (https://www.esoui.com/forums/showthread.php?t=1931)

Wisshard 07/08/14 01:31 AM

[Request] ChatMultiWindow Update
 
Hey,

With five guild chats, a zone chat, occasionally a group chat and tells, it is quite hard to keep track of the chats in ESO - especially when you only have one chat window.

ChatMultiWindow provides the option to create multiple chat windows, which makes the social life in ESO a lot easier and comforting, but unfortunately it has yet to be updated to patch 2.3, and so I would greatly appreciate if some kind soul could take it upon themselves to get it up and running again.

Thanks in advance.

CrazyDutchGuy 07/08/14 03:31 AM

Personally for a few of my addons i think it is usefull. I'll see if i can get it back to working state. No promises though as i never used this addon yet :P

Wisshard 07/08/14 04:01 AM

Great! Thank you, I hope you'll be able to manage it. :)

mra4nii 07/08/14 05:09 AM

I use older, original version and i can say that it works without any problem. Need to update just API version in manifest.
I guess, patched version should work fine too.

Garkin 07/08/14 05:16 AM

I have just a quick look to the addon code and there is virtually nothing to fix, it should be working just fine. I will check it in game.

Only thing I do not like is replacing of the original function of CHAT_SYSTEM instead of hooking it.
Instead of the last function in the code. I'd rather use this hook (but it is matter of personal preference):
lua Code:
  1. -- Hook the original function so we can fix the anchors
  2. local TransferWindow = CHAT_SYSTEM.TransferWindow
  3. function CHAT_SYSTEM.TransferWindow(...)
  4.     -- First, do what the original function did...
  5.     TransferWindow(...)
  6.  
  7.     -- Second, fix the anchors so the text is visible
  8.     if container ~= CHAT_SYSTEM.containers[1] then
  9.         ChatMultiWindow.FixContainerAnchor(container)
  10.     end
  11. end

Wisshard 07/08/14 05:18 AM

The current available version of ChatMultiWindow hasn't worked for me at all since patch 2.3 unfortunately.

CrazyDutchGuy 07/08/14 05:24 AM

I'll take a peek and see what i can do, as soon i am done with my normal payed job :P

Wisshard 07/08/14 05:30 AM

Alright, I just checked again (I've had it disabled since it stopped working post-patch 2.3) and it now appears to be working for me. Must've been some compatibility issue with with some other addon I had at the time patch 2.3 came around.

I apologize for calling attention to something that there was no problem with. :o

While we're here and talking about ChatMultiWindows though, I do wonder if it's possibly to add some features to it. Specifically, the option to lock any additional windows you create in place, and placing the chat windows behind trade windows.

Garkin 07/08/14 05:12 PM

Changes in ChatMultiWindow.txt:
- updated API version
- version bump

Warning: Spoiler


Changes in ChatMultiWindow.lua:
- version bump
- replaced function DestroyContainer(...) with CHAT_SYSTEM.DestroyContiner(...)
- correctly unregister EVENT_ADD_ON_LOADED event
- hook CHAT_SYSTEM:TransferWindow(...) instead of replacing (it's not functionality change)

Warning: Spoiler

CrazyDutchGuy 07/09/14 01:20 PM

nice work Garkin, You got more time then me too spend ;) Can you submit it as a patch for the original addon ?

Garkin 07/09/14 02:10 PM

Quote:

Originally Posted by CrazyDutchGuy (Post 10347)
nice work Garkin, You got more time then me too spend ;) Can you submit it as a patch for the original addon ?

Uploaded: http://www.esoui.com/downloads/info6...atch1.2.3.html


All times are GMT -6. The time now is 03:22 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI