Download
(39 Kb)
Download
Updated: 04/07/24 04:53 PM
Pictures
File Info
Compatibility:
Scions of Ithelia (9.3.0)
Endless Archive (9.2.5)
base-game patch (9.1.5)
Necrom (9.0.0)
Scribes of Fate (8.3.5)
Firesong (8.2.5)
Lost Depths (8.1.5)
High Isle (8.0.0)
Updated:04/07/24 04:53 PM
Created:05/18/15 12:09 PM
Monthly downloads:1,001
Total downloads:122,451
Favorites:147
MD5:
Categories:Bags, Bank, Inventory, Miscellaneous
FCO CraftFilter (Filter bank/inventory/craftbag items at crafting tables & Favorites)  Popular! (More than 5000 hits)
Version: 0.6.7
by: Baertram [More]
IMPORTANT CHANGE - Version 0.2.1
This addon depends on the following libraries:
-LibAddonMenu-2.0
-LibFilters-3.0
Optional:
LibCustomMenu




FCO Craft Filter

This addon will add buttons to the crafting stations/retrait stations and the research trait popup dialog top left side which will easily filter your items located at your bank from the crafting station's panel.
It is able to only show banked items, only show items in your inventory or show both.
It will distinguish and remember your settings for the different crafting stations (blacksmithing, clothing, woodworking, enchanting, retrait) and their different panels (armor, weapon, jewelry e.g.).

It also adds a new filter button (enable it at the settings) at the crafting tables "research" horizontal scroll bar (research icon, left of the horizontal scroll bar):
It can show only currently researched items (green button, shine through), or show all items (uncolored, normal button).
The button's state should be remembered per craftingType (woodworking, blacksmithing, clothier, jewelry).

The addon is working in combination with other filter addons using "LibFilters 3", like e.g. FCOItemSaver and AdvancedFilters UPDATED.

Supported panels for the "inventory only/bank only/craftbag only/all" button are:
-Deconstruction (armor/weapon/jewelry)
-Improvement (armor/weapon/jewelry)
-Research (armor/weapon/jewelry)
-Research trait popup dialog
-Enchanting creation
-Enchanting extraction
-Retrait
-Universal Deconstruction



With 1 click on the button you can change which items are shown: Only bank, only inventory, both.
The standard settings only switch between "show inventory items" and "show all items".
The tooltip of the button shows you what items are currently shown and which ones are hidden.

This must be enabled in the settings ("Enable 'show only bank' filter"):
You can add a 3rd state which will only show the icons in your bank.

A settings panel is able to change the language and save the settings account wide, or for each character,
and enable the extra "medium" filter to ONLY show the bank items.



Provides settings to set the default crafting table tab to a defined entry too.
Each time you open the crafting table this tab will be selected


And it provides favorite sets at the Grand Master Crafting tables, where you can define up to 6 custom categories (default are e.g. Tank, Mag Heal, Stam Heal, Mag DD, Stam DD and Hybrid DD), which can be renamed.
A context menu at the set entries allows you to add/remove/remove all at the category.
That way you always got your ost valuable sets sorted and easily selectable.
-> The set search box will not search or filter the sets in your favorites though! It will always find those in the appropriate standard category, e.g. "DLC" or "PVP" so you easily see where they origin from.


This addon was coded upon request (ingame).



API functions:
Code:
FCOCF.GetActiveCraftPanelFilterSetting(filterPanelId)
-> Returns the active settings of FCOCS at the given LibFilters 3 filterPanelId (e.g. FCOCF_SHOW_ALL or FCOCF_ONLY_SHOW_INVENTORY etc.)

FCOCF.GetFilterCallbackFunction()
-> Returns the filter function used within FCOCS (parameters are bagId, slotIndex), which recognizes the filtered bags. Can be used to filter items at other addons e.g.

FCOCF.CallCurrentlyResearchedItemsFilter()
-> Calls the horizontal scrollBar filters "skipTable" to filter (only show) the currently researched items if enabled at the settins. Will be used from other addons like AdvancedFilters.
IMPORTANT:
This addon won't include the needed libraries anymore since this version 0.2.1!
YOU need to manually download & install them.

Be sure to check if your extraction software e.g. WinZIP, WINRAR, etc. did create a folder with the name of the zip file and has put the contents of the zip file in there: THIS IS WRONG! The contents of the zip file need to be in your AddOns directory (e.g. c:\users\your windows username\documents\elder scrolls online\live\AddOns) without a new created subfolder with the name of the zip file!.
Or use the addon manager "Minion" to do so, the following libraries in order to let this addon be enabled in the ingame addon manager & let the addon work properly:
-LibAddonMenu-2.0
-LibFilters-3.0
Optional: LibCustomMenu

Attention:
You may need to close and restart the game to recognize the new libraries in the addon manager!

Please read the description for further details and the reason. Thanks for your support!

0.6.7 2024-04-08
Fixed possible errors with LibLazyCrafting (WritWorthy e.g.)


0.6.6 2024-03-19
Fixed global leaking self

0.6.5 2024-03-18
-Updated API and version
-Updated dependencies
-Updated Russian translation, thanks to mychaelo

0.6.4 2024-01-16
-Added improvement/retrait extra filter for "Show only worn items" -> Setting
-Show worn items at inventory button too, if enabled in the settings
-Fixed showing worn items at "All" button

0.6.3 2024-01-14
Provides favorite sets at the Grand Master Crafting tables now, where you can define up to 6 custom categories (default are e.g. Tank, Mag Heal, Stam Heal, Mag DD, Stam DD and Hybrid DD), which can be renamed.
A context menu at the set entries allows you to add/remove/remove all at the category.
That way you always got your ost valuable sets sorted and easily selectable.
-> The set search box will not search or filter the sets in your favorites though! It will always find those in the appropriate standard category, e.g. "DLC" or "PVP" so you easily see where they origin from.

0.6.2 2023-04-21
-Updated API and versions
-Added settings to set the default crafting table tab to a defined entry
Each time you open the crafting table this tab will be selected

0.6.1 2023-01-03
-Fixed settings menu research headline
-Fixed opacity of the new "Show only researched" button (should be solid if enabled, and not if disabled)

0.6.0 2023-01-02
Added new filter button (enable it at the settings) at the crafting tables "research" horizontal scroll bar (research icon, left of the horizontal scroll bar):
It can show only currently researched items (green button, shine through), or show all items (uncolored, normal button).
The button's state should be remembered per craftingType (woodworking, blacksmithing, clothier, jewelry).
Attention: Please update LibFilters-3.0 and AdvancedFilters (if you use that addon)!

0.5.4 2022-12-04
Added compatibility with PerfectPixel addon (Giladil universal decon, smithing, woodworking, clothier, enchanting, jewerly, retrait)

0.5.3 2022-11-06
-Updated API versions
-Fixed rare errors at crafting panel open
-Added support for UniversalDeconstruction (using LibFilters panel show/hide callbacks)

0.5.2 2022-04-25
-Updated API for High Isle
-Fixed PTS buttons not clickable

0.5.1 2021-10-17
-Updated API
-Removed dependency to LibLoadedAddons
-Added debug function FCOCF.debugChangeFilter(LibFilters_LF_Constant number, changeSettings boolean)

0.5.0
-Updated API
-Updated dependencies
-Fixed include banked items checkbox to get enabled automatically if FCOCS is enabled
-Changed handling of the filter functions and integration into other addons like AdvancedFilters
-Added API functions:

FCOCF.GetActiveCraftPanelFilterSetting(filterPanelId)
-> Returns the active settings of FCOCS at the given LibFilters 3 filterPanelId (e.g. FCOCF_SHOW_ALL or FCOCF_ONLY_SHOW_INVENTORY etc.)

FCOCF.GetFilterCallbackFunction()
-> Returns the filter function used within FCOCS (parameters are bagId, slotIndex), which recognizes the filtered bags. Can be used to filter items at other addons e.g.


0.4.0
Your SavedVariables will be reset so please reconfigure the few settings!
-Changed SavedVariables to server dependent ones
-Improved button texture and tooltip update code
-Added constants for the different filter states of the button:
FCOCF_SHOW_ALL = 1
FCOCF_ONLY_SHOW_INVENTORY = 2
FCOCF_ONLY_SHOW_BANKED = 3
FCOCF_ONLY_SHOW_CRAFTBAG = 4
FCOCF_DO_NOT_SHOW_CRAFTBAG = -4
-Added filter state at the refine crafting tables: Only show Craftbag, Hide Craftbag items
-Fixed a few typos
-Enabled the "Only show banked" filter by default in the settings

0.3.9
Fixed quest checkbox at enchanting table if AdvancedFilters is not used

0.3.8
-Updated API
-Updated library/dependency versions needed
-Fixed "quest checkbox" at enchanting create panel not overlaying the FCOCraftFilter button

0.3.7
-Made compatible with PTS API 100033 Markarth retrait station changes, and live server
Attention: As PTS hits live in November 2020 you will need an update to LibFilters-3.0 in order to make this addon work properly!


0.3.6
-Updated API
-New ZOs checkbox "Include banked" will be enabled and hidden automatically if FCOCraftFilter is enabled,
as FCOCF is able to filter MORE (like ONLY SHOW BANKED) and at MORE PANELS (improvement, research popup, enchanting) compared to the ZOs checkbox
-->Please update LibFilters 3.0 as it will be released as it is needed to fix the prefiltering of this new checkbox!


0.3.5
API update for Harrowstorm
Fixed research list refresh after research was started: Not showing filtered items anymore

0.3.4
API update for Dragonhold
Changed crafting table PreHooks to SecurePostHook

0.3.3
Fixed the settings menu to show again

0.3.2
Re-anchored the buttons so they are pretty much at the same positions at each panel (except maybe retrait)

0.3.1
Added button to normal research panels

0.3.0
Fixed typo, changed ZO_Enchanting usage of ENCHANTING variable to rather use self pointer to it

0.2.9
Made compatible with PTS "Scalebreaker" Enchanting panel, and live

0.2.8
Removed OptionalDependsOn: PerfectPixel again as PP will be updated soon.

0.2.7
Added support for the research trait popup dialog.
Important:
If you are using the addon PerfectPixel the research trait popup dialog will only work ONCE after each reloadui due to a bug raised through code in PP's file dialogsMenu.lua.
You can comment (put -- in front of) the following line in the folder /AddOns/PerfectPixel/dialogsMenu.lua, line 30, to fix this until the addon PP get's updated:
Code:
--v:SetHandler("OnShow", nil)
0.2.6
Fixed itemCount update function with AdvancedFilters and FCOItemSaver enabled (was run twice, once in FCOIS and again via AF afterwards)

0.2.5
Fixed retrait station

0.2.4
-Updated API to Elsweyr
-Added support for LibStub and non-LibStub libraries

0.2.3
-Raised API
-Fixed retrait station to show the button again if other retrait station addons like "AdvancedFilters BETA" are loaded

0.2.2
-Raised API
-Added support for AdvancedFilters "item count at crafting stations" update function (AdvancedFilters.util.UpdateCraftingInventoryFilteredCount) and the custom update callback functions you can implement via AF function
Code:
AdvancedFilters_RegisterSubfilterbarRefreshFilter(subfilterRefreshFilterInformationTable)
-> Please download AdvancedFilters beta version >= 1.5.06 to test it:
https://www.esoui.com/downloads/info2215-AdvancedFilters-BETA.html

0.2.1
-Updated API
-Removed the libraries (see addon description, changelog and comments for more details).

0.2.0
-Updated API version to Summerset
-Added: Support for jewelry crafting
-Updated: libraries (libFilters, libAddonMenu-2.0)

0.1.9
-Updated libFilters library
-Added support for transmutation / retrait tables

0.1.8
Updated API and libraries

0.1.6
Fixed libFilters

0.1.5
Changed hook of smithing and enchanting craft stations to support hooks for other addons too

0.1.4
-Updated API version
-Updated LAM
-Changed "Only show inventory items" to the bag icon (before: gray bank icon)

0.1.3
-Updated libFilters to fix filters at crafting stations

0.1.2
-Updated API
-Updated libFilters to fix filters at crafting stations

0.1.1
Added support for the new subscriber bank

0.0.9g
-Raised API version for Homestead patch
-Updated library libFilters 2.0 to the newest version

0.0.9f
Updated library libFilters 2.0 again ... :-)

0.0.9e
Updated library libFilters 2.0 again as some more things needed to change

0.0.9d
Updated library libFilters 2.0

0.0.9c
Added Russian translations.

0.0.9b
Added Japanese translations.
Added option to use the game client's language.

0.0.9a
Updated library libAddonMenu 2.0 r23

0.0.9
Fixed: Addon was not initializing libFilters 2.0 properly

0.0.8
Updated API
Updated libraries

0.0.7
-Updated LAM to 2.0 r22
-Updated libFilters to version 2
-Adopted addon to libFilters 2

0.0.6g
-Updated LAM to 2.0 r21
-Updated API to Shadows of the Hist

0.0.6f
API raised to Dark Brotherhood

0.0.6e
-Updated: Library libAddonMenu 2.0 to version 20

0.0.6d
-Updated: API version to Thieves Guild
-Updated: Library libAddonMenu 2.0 to version 19

0.0.6c
Fixed incompatibility bug with addon "Multicraft"

0.0.6b
Updated library libFilters to v16.1 (Alchemy bug fix)

0.0.6a
Updated library libFilters to v16

0.0.6
-Updated API version to support patch 2.2
-Added support for FastAPI tool: http://www.esoui.com/downloads/info1220-FastAPI.html

0.0.5a
Updated: API to version 100012

0.0.5
-Updated: LibStub v4
-Added on request: Distinguish different crafting station types (blacksmithing, clothing, woodworking, enchanting) in addition to their panels (deconstruction, improvement, enchanting)

0.0.4
-Updated: LibFilters to v15.1
-Fixed: Addon refreshes all 3 possible filter methods now (was changed in libFilters RegisterFilter/UnregisterFilter methods)

0.0.3
Updated: LibStub v3 & LibAddonMenu 2.0 r18

0.0.2a
Changed: French translation
-> Thanks to Ayantir

0.0.2
Fixed: Button textures were corrected

Changed: Tooltips were modified so you will see what is currently shown and what will be coming if you click the button again

Added feature: "Show only bank items"
Enable this option and you will be able to switch the bank buttons between
"Show all items" (Gray items symbol)
"Hide bank items" (gray bank symbol)
"Only show bank items" (white smaller bank symbol)


0.0.1
Initial release
Archived Files (66)
File Name
Version
Size
Uploader
Date
0.6.6
37kB
Baertram
03/19/24 05:55 AM
0.6.5
37kB
Baertram
03/18/24 04:15 AM
0.6.4
37kB
Baertram
01/15/24 07:27 PM
0.6.3
36kB
Baertram
01/14/24 06:57 AM
0.6.2
29kB
Baertram
04/20/23 07:11 PM
0.6.1
26kB
Baertram
01/03/23 09:21 AM
0.6.0
26kB
Baertram
01/02/23 11:55 AM
0.5.4
23kB
Baertram
12/04/22 05:08 PM
0.5.3
22kB
Baertram
11/06/22 03:48 PM
0.5.2
20kB
Baertram
04/24/22 04:24 PM
0.5.1
20kB
Baertram
10/17/21 01:00 PM
0.5.0
20kB
Baertram
06/12/21 05:35 PM
0.4.0
19kB
Baertram
12/05/20 05:18 PM
0.3.9
19kB
Baertram
11/15/20 04:56 PM
0.3.8
19kB
Baertram
11/04/20 10:59 AM
0.3.7
19kB
Baertram
10/11/20 02:08 PM
0.3.6
19kB
Baertram
08/24/20 03:30 PM
0.3.5
18kB
Baertram
02/23/20 06:58 PM
0.3.4
18kB
Baertram
10/21/19 08:23 AM
0.3.3
18kB
Baertram
09/22/19 02:06 PM
0.3.2
18kB
Baertram
08/31/19 03:52 PM
0.3.1
18kB
Baertram
08/30/19 03:30 PM
0.3.0
17kB
Baertram
08/09/19 03:33 PM
0.2.9
17kB
Baertram
08/09/19 10:54 AM
0.2.8
17kB
Baertram
07/18/19 12:29 PM
0.2.7
17kB
Baertram
07/18/19 09:49 AM
0.2.7
16kB
Baertram
07/01/19 03:48 PM
0.2.5
16kB
Baertram
05/20/19 12:34 PM
0.2.4
16kB
Baertram
05/19/19 06:57 PM
0.2.3
15kB
Baertram
03/11/19 05:27 PM
0.2.2
15kB
Baertram
12/10/18 08:02 AM
0.2.1
15kB
Baertram
09/17/18 03:43 AM
0.2.0
65kB
Baertram
05/21/18 07:57 AM
0.1.9
64kB
Baertram
04/13/18 03:57 PM
0.1.8
64kB
Baertram
03/04/18 08:09 AM
0.1.6
64kB
Baertram
11/29/17 02:45 PM
0.1.5
63kB
Baertram
11/13/17 12:54 PM
0.1.4
63kB
Baertram
10/29/17 04:09 PM
0.1.3
62kB
Baertram
08/16/17 07:53 PM
0.1.2
62kB
Baertram
08/15/17 03:30 PM
0.1.1
61kB
Baertram
06/08/17 06:17 PM
0.0.9g
61kB
Baertram
01/29/17 03:31 PM
0.0.9f
61kB
Baertram
11/08/16 04:22 PM
0.0.9e
61kB
Baertram
11/07/16 03:37 PM
0.0.9d
60kB
Baertram
11/07/16 12:05 PM
0.0.9c
65kB
Baertram
11/06/16 03:41 PM
0.0.9b
65kB
Baertram
11/05/16 09:31 AM
0.0.9a
63kB
Baertram
10/30/16 01:51 PM
0.0.9
60kB
Baertram
10/09/16 12:12 PM
0.0.8
60kB
Baertram
10/02/16 07:32 PM
0.0.7
60kB
Baertram
09/02/16 07:41 AM
0.0.6g
53kB
Baertram
07/17/16 01:13 PM
0.0.6f
55kB
Baertram
05/14/16 03:39 PM
0.0.6e
55kB
Baertram
03/26/16 04:56 PM
0.0.6d
50kB
Baertram
03/07/16 02:03 PM
0.0.6c
45kB
Baertram
11/21/15 03:11 PM
0.0.6b
45kB
Baertram
11/15/15 01:24 PM
0.0.6a
45kB
Baertram
11/15/15 08:17 AM
0.0.6
44kB
Baertram
11/01/15 03:34 PM
0.0.5a
51kB
Baertram
08/31/15 05:11 PM
0.0.5
52kB
Baertram
08/05/15 08:18 AM
0.0.4
44kB
Baertram
07/19/15 05:22 PM
0.0.3
44kB
Baertram
06/14/15 02:09 PM
0.0.2a
42kB
Baertram
05/20/15 10:05 AM
0.0.2
42kB
Baertram
05/19/15 12:03 PM
0.0.1
41kB
Baertram
05/18/15 12:09 PM


Post A Reply Comment Options
Unread 05/20/19, 08:45 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 5054
File comments: 6119
Uploads: 78
Working on fixes, so please only report error messages which are NOT
posted in the comments here already!

And important:
ALWAYS LOGOUT before updating libraries or addons.
It may cause some errors like this if you did update the addons or especially libraries if the game was already running as the addon manager will do all "dependency" checks in the logged out character selection, and not again poroperly if you are logged in already and open the addon manager!

If you have updated your addons/libs as the game was running please logout and log back in.
If you still got problems report the error message here please, BUT first read the comments below to check if it wasn't posted already.
Last edited by Baertram : 05/20/19 at 08:45 AM.
Report comment to moderator  
Reply With Quote
Unread 07/18/19, 08:13 AM  
Marazota
AddOn Author - Click to view AddOns

Forum posts: 260
File comments: 1523
Uploads: 2
hey mate, can you add same filter to Reserach tab?
ie i want to see only items in my inventory, and dont want to accidentally research item from my bank

if possible
Report comment to moderator  
Reply With Quote
Unread 07/18/19, 08:22 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 5054
File comments: 6119
Uploads: 78
Originally Posted by Marazota
hey mate, can you add same filter to Reserach tab?
ie i want to see only items in my inventory, and dont want to accidentally research item from my bank

if possible
I'm already working on something like this.
But I can only add it to the research popup (the one you see after double clicking a row on the research tab, showing you the items vailable for research for this trait).
I'm not able to filter the research tab itsself, sorry.

Without FCOItemSaver and PerfectPixel it works fine but with the others there are some problems.
Trying to fix those first to make them all compatible.

Edit:
Works now but only once if PerfectPixel is active, due to a bug in PP. KL1SK needs to fix this on his end unfortunately.
Last edited by Baertram : 07/18/19 at 09:39 AM.
Report comment to moderator  
Reply With Quote
Unread 07/18/19, 09:51 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 5054
File comments: 6119
Uploads: 78
0.2.7
Added support for the research trait popup dialog.

Important:
If you are using the addon PerfectPixel the research trait popup dialog will only work ONCE after each reloadui due to a bug raised through code in PP's file dialogsMenu.lua.
You can comment (put -- in front of) the following line in the folder /AddOns/PerfectPixel/dialogsMenu.lua, line 30, to fix this until the addon PP get's updated:

Lua Code:
  1. --v:SetHandler("OnShow", nil)
Report comment to moderator  
Reply With Quote
Unread 08/10/19, 11:11 AM  
SneakyWitchTheif

Forum posts: 1
File comments: 42
Uploads: 0
I get this error randomly while using FCOCraftFilter.

user:/AddOns/FCOCraftFilter/FCOCraftFilter.lua:930: attempt to index a nil value
stack traceback:
user:/AddOns/FCOCraftFilter/FCOCraftFilter.lua:930: in function 'FCOCraftFilter_PreHookButtonHandler'
|caaaaaa<Locals> comingFrom = 16, settings = tbl, locVars = tbl, zoVars = tbl, localizationVars = tbl, tooltipVar = "" </Locals>|r
user:/AddOns/FCOCraftFilter/FCOCraftFilter.lua:1013: in function 'func'
EsoUI/Libraries/Globals/globalapi.lua:207: in function '(anonymous)'
Report comment to moderator  
Reply With Quote
Unread 08/10/19, 12:54 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 5054
File comments: 6119
Uploads: 78
Originally Posted by SneakyWitchTheif
I get this error randomly while using FCOCraftFilter.
What are you doing where as the error occurs?
Please always provide steps/info to rebuild the error or tell the dev what you were doing where as the error occurred. It helps a lot.
Report comment to moderator  
Reply With Quote
Unread 08/10/19, 01:06 PM  
SneakyWitchTheif

Forum posts: 1
File comments: 42
Uploads: 0
Originally Posted by Baertram
Originally Posted by SneakyWitchTheif
I get this error randomly while using FCOCraftFilter.
What are you doing where as the error occurs?
Please always provide steps/info to rebuild the error or tell the dev what you were doing where as the error occurred. It helps a lot.
Yes, I know. Hence the "randomly."

It just happens as I go about my business playing. Sometimes it's when I'm harvesting, sometimes when picking up dailies, sometimes when talking to NPCs, sometimes when I'm standing in town doing nothing.

If I were to take an educated guess, I'm assuming something is crossing over my reticle and produces the error. I just don't know what.
Last edited by SneakyWitchTheif : 08/10/19 at 01:18 PM.
Report comment to moderator  
Reply With Quote
Unread 08/10/19, 01:25 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 5054
File comments: 6119
Uploads: 78
No way
This addon does nothing with reticle stuff and the error message says something about comingfrom=16 which means you were at a crafting table as the error happened. And this addon also only adds or hides the buttons at the Crafting tables. So your examples cannot be true at all, sorry

If you get the error at a crafting table or leaving one, this could be ok. Everything else cannot have to do with this addon.


Originally Posted by SneakyWitchTheif
Originally Posted by Baertram
Originally Posted by SneakyWitchTheif
I get this error randomly while using FCOCraftFilter.
What are you doing where as the error occurs?
Please always provide steps/info to rebuild the error or tell the dev what you were doing where as the error occurred. It helps a lot.
Yes, I know. Hence the "randomly."

It just happens as I go about my business playing. Sometimes it's when I'm harvesting, sometimes when picking up dailies, sometimes when talking to NPCs, sometimes when I'm standing in town doing nothing.

If I were to take an educated guess, I'm assuming something is crossing over my reticle and produces the error. I just don't know what.
Last edited by Baertram : 08/10/19 at 02:46 PM.
Report comment to moderator  
Reply With Quote
Unread 08/10/19, 02:44 PM  
SneakyWitchTheif

Forum posts: 1
File comments: 42
Uploads: 0
Originally Posted by Baertram
No way
This addon does nothing with reticle stuff and the error message says something about comingfrom=16 which means you were at a crafting table as the error happened. And this addon also only adds or hides the buttons at the Crafting tables. So your examples cannot be true at all, sorry

If you get the error at a crafting table or leaving one, this could be ok. Everything else cannot have to do with this addon.
Okay, well.

I don't get the error at a crafting table, so I'm not sure what to tell you. Next time it pops up I'll be sure to mark down exactly what I was doing. Which won't be crafting, by the way.

I know bugs can be elusive and code is fickle. Might be an addon conflict. Suppose we'll see.
Last edited by SneakyWitchTheif : 08/10/19 at 02:45 PM.
Report comment to moderator  
Reply With Quote
Unread 08/10/19, 02:47 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 5054
File comments: 6119
Uploads: 78
Very strange.
The code lines mentioned in the error message got to do with the state of the button to switch between bank/inventory/both items shown.
And this code is only run if you are at any crafting table.

Edit:
You could uncomment line 929 in file FCOCraftFilter.lua (remove the -- in front of d(">gLastCraftingType: "...) and save the file. This will output some chatMessage as this code is run.
You could check, next time the error message appears again, what the chat is telling you there as extra info for me.
Some of the variables needed are empty at this time.
The chat output should be something like this:
Code:
>gLastCraftingType: 2, gLastPanel: 16
If one of these is NIL this seems to be the problem. But if THIS code is run outside of any craftingstation this would be really strange. That's the main problem then.

Edit2:
Maybe it got to do with some code which is run as you open a dialog like repair item/enchant/research. Try if this triggers the error please.

Originally Posted by SneakyWitchTheif
Originally Posted by Baertram
No way
This addon does nothing with reticle stuff and the error message says something about comingfrom=16 which means you were at a crafting table as the error happened. And this addon also only adds or hides the buttons at the Crafting tables. So your examples cannot be true at all, sorry

If you get the error at a crafting table or leaving one, this could be ok. Everything else cannot have to do with this addon.
Okay, well.

I don't get the error at a crafting table, so I'm not sure what to tell you. Next time it pops up I'll be sure to mark down exactly what I was doing. Which won't be crafting, by the way.

I know bugs can be elusive and code is fickle. Might be an addon conflict. Suppose we'll see.
Last edited by Baertram : 08/10/19 at 02:55 PM.
Report comment to moderator  
Reply With Quote
Unread 08/10/19, 05:21 PM  
SneakyWitchTheif

Forum posts: 1
File comments: 42
Uploads: 0
Originally Posted by Baertram
-snip-
Alrighty, so!

The error occurred today in the Rimmen crafting area. I logged into my character, spun around and ran towards Turami (the khajiit woodworking merchant). It appeared after turning to face her and the woodworking bench. I attempted to reproduce the error by completing exiting the game and then logging back in, thus doing the same thing. No error.

Curious, I logged into a completely new character and went over to Rimmen. No error when looking towards the woodworking bench, however the error popped up again when I turned to look towards the alchemy station. "But my addon doesn't do anything to the alchemy station..." you say. I know!

Logged in another completely new character in an attempt to reproduce the issue again and confirm it, only to port over to Rimmen and look at every crafting bench without issue.

I then deleted my saved variables for FCOCraftFilter (just to be safe) and sequentially tested each character with the aforementioned code uncommented in FCOCraftFilter.lua.

I was frustratingly error free until logging back into the third character (whom if you recall did not previously produce an error). I ran around the crafting error in Rimmen until, upon running towards the enchanting table for a third or fourth time, the error occured!

We did get a NIL value, it seems!

Code:
[07:17 pm] >gLastCraftingType: nil, gLastPanel: 16
I also want to apologise for being snarky in my post down below. I always believed the issue was due to the crafting benches, just not while using them! I'm going to leave the code uncommented and see if I can get the error to appear while no where near a crafting station.

Thoughts?
Last edited by SneakyWitchTheif : 08/10/19 at 05:27 PM.
Report comment to moderator  
Reply With Quote
Unread 08/10/19, 05:26 PM  
SneakyWitchTheif

Forum posts: 1
File comments: 42
Uploads: 0
Had the error occur in the Bonesnap Ruins public dungeon and running through Stormhaven killing world bosses. Same error, same NIL value.
Last edited by SneakyWitchTheif : 08/10/19 at 09:29 PM.
Report comment to moderator  
Reply With Quote
Unread 08/11/19, 04:36 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 5054
File comments: 6119
Uploads: 78
Originally Posted by SneakyWitchTheif
Had the error occur in the Bonesnap Ruins public dungeon and running through Stormhaven killing world bosses. Same error, same NIL value.
This is really weird. I'll have a look if I'm able to rebuild this. This piece of code shouldn't be run if you look at something or are not at a crafting station. Not sure why it is but we'll find out
Thanks for the details.

1 question:
Did you test this with ONLY FCOCF enabled, or were other addons enabled as well? If so, are there any addons enabled meant to be related to crafting? Could you test maybe if the error happens if all addons except FCOCF are disabled? I'm asking as I'm not able to get this error message a single time so far

Edit:
A fix for you so the error will be gone. Edit the same file where you have removed the - - and add the - - again.
Then, in the row above this row, add:

Lua Code:
  1. If FCOCF.locVars.gLastCraftingType == nil then return end

This should check the nil value and abort the code execution there. Maybe you'll get following errors then, but I don't hope so.

Edit2:
I'm working on a version with some more debug messages so we can see how the function gets called for you.
I'll provide you the link and you can install and use it then. Each time you get the error message check the chat please what is written there as infirmation like
Code:
FCOCraftFilter_PreHookButtonHandler, comingFrom: 16, calledBy: SMITHING deconstruction SetMode
This will hopefully help me to find out why the function is called.

Explanation:
The code that gets an error for you is within a function FCOCraftFilter_PreHookButtonHandler which will show the button to filter inventory/bank/both items at the crafting stations. It ONLY is called if some base game functions are called, and they normally ONLY are called as you ARE at the crafting station.
I could easily implement some checks so even if it's called and you are somewhere else it will just return silently. But I hope to find the reason why the game calls this if you are in public dungeon e.g.
The only thing I can think of is some other addon for crafting, like Dolgubons Lazy Set Creator, which call these functions even if you are not at the crafting station at the moment.
This is why I've asked you to test with all other addons disabled except FCOCF.
MAybe another addon which hacks into the reticle is giving/reading info from the game variables and triggers these SetMode functions somehow...

Here is the link for the FCOCraftFilter version 0_3_1 with debug messages in the chat
Last edited by Baertram : 08/11/19 at 09:29 AM.
Report comment to moderator  
Reply With Quote
Unread 08/11/19, 09:01 AM  
SneakyWitchTheif

Forum posts: 1
File comments: 42
Uploads: 0
Originally Posted by Baertram
-snip-
I DO think it's most likely a compatibly issue with another addon at this point. I'll download and get to testing later today for you! Thank you for the explanation. It'll help in the testing legwork.
Report comment to moderator  
Reply With Quote
Unread 08/18/19, 12:47 PM  
SneakyWitchTheif

Forum posts: 1
File comments: 42
Uploads: 0
Originally Posted by SneakyWitchTheif
Originally Posted by Baertram
-snip-
I DO think it's most likely a compatibly issue with another addon at this point. I'll download and get to testing later today for you! Thank you for the explanation. It'll help in the testing legwork.
Alright! I'm back!

I can confirm, without a doubt, that the error is caused by using FCOCraftFilter alongside another addon, Mass Deconstructor.

I have no idea what Mass Deconstructor is doing to call up the smiting window while not at a station, but there we go.

It is also, by the way, consistently the following error:

Code:
 >FCOCraftFilter_PreHookButtonHandler, comingFrom: 16, calledBy: SMITHING deconstruction SetMode
 >gLastCraftingType: nil, gLastPanel: 16
I've used your recommended method of just disabling the error. I'll also cross post to the Mass Deconstructor author. I appreciate your patience and assistance.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.