Originally Posted by AlbertVonMoosseedorf

I implemented new rules for Companion gear, because it stacks faster than it is sellable.
I use a pricemarker of 5000G in the rule, because the price() is much higher as the real market value.
The rule seems to work, but there are no junked items after.

Originally Posted by demawi

id() == 46786

Originally Posted by ExVault

Is function id() even working? Whatever id I pass in, it just returns true for all items I have.

Originally Posted by Random

See the smaller grey box below it? Try typing a rule name in there, and hitting New, then typing in your rule.

Originally Posted by ggurman

Thanks for replying but I definitely think the addon isn't working properly because there is no Add button on the Rules page. There's a gray rectangle that could be where the text of the rule is supposed to go, but nothing happens when I click on it. As I said in my original post, almost everything is grayed out. I took a screenshot but it's not showing up here. You can see it at https://photos.app.goo.gl/mKD1qjhtwg7PuFtbA

Originally Posted by demawi

hi!

The first thing would be adding (set a name and hit 'add') and defining a rule. Within the content of the rule you have to define the item-selection using the functions shown in the wiki. In the wiki are also some starter examples. A good start for the junk rule would be: type('trash')
After that, you have to assign this rule to the junk task (normally as "fit any") which will activating the task. And the task will be running from now on the items, you have defined with your rule.

Originally Posted by demawi

Hi! there was already a discussion about ordering items for autoresearch or fencing most valueable items between Random and the previous developer TaxTalis. The original statement was

Originally Posted by demawi

Currently a rule will be executed directly as lua-code for each item, so your code will not be working in that way. So something like trait('bolstered') or quality('legendary') will only return a boolean, which we can not be sorted and the sort-function also have to return a boolean.
Your sort-functions have to be more like sort(trait, 'bolstered', 'vigorous', ['quickened', 'augmented']). The first argument would define the concrete function to use and after that, we define the order.
The by-function has to be called before the sort (to set an variable in the rule execution context) or perhaps directly as additional definition in the sort-function.
So I would suggest following calls: (I would like to take 'order' as name, because it is also a part of SQL)
the second function reference (here: equipType) could be optional.

Originally Posted by demawi

Currently this approach can only select all items with the best priority. I would also like to find a way to select the items more specifically (so perhaps selecting the best x-items), but this will make it more difficult, so I think in the first step we should stay with the first approach

Originally Posted by demawi

Hi!
welcome back Export would definitely be easy. But the import would be difficult. So how will the import work? Erase all existing rules, update only existing, add only...!? So perhaps with some optional choices.
The references from Task, RuleSet, Profile have to be checked. So renaming of rules only can be functional, when Task, RuleSet, Profiles are included.

Originally Posted by czer323

I want to say, I love your addon and I appreciate all the hard work you've put into it. It is a cornerstone in improving my efficiency while playing the game - and it's saved me a LOT of time. Also, sorry if this has been asked before - I tried looking through a few of the previous comments, but there's a lot to cover.

Can you imagine a function - that would help with identifying items using a priority list? For example, I have companion equipment, and I would like to setup a filter to prioritize specific pieces to fit various roles I might use.

With a function like this, I believe it would be easier to manage sets of gear. As an MVP, if a sort function is introduced - it would allow for identifying lesser gear and allowing a rule to manage it (Sell or Deconstruct).

For example, as a tanking companion, I would like to identify pieces that are:
Now, even if it doesn't meet this criteria, I'd like to keep at least one piece so I have a set. But I'd like to do that using a priority system. For example:
After the sort function is created, I think the next thing is creating a rule to distinguish different equipTypes as their own entity. This would be to allow a rule - to manage multiple equipment types and find the best item - or all lesser items to be disposed.

If you're able to develop a 'By' function, you could even potentially identify the items by setIds or SetNames.

I'm unsure if I'm explaining this well, but I'm very willing to continue discussing it to help refine the development requirements. Ultimately, I imagine that RuleBased Inventory can serve as a replacement for 'Set Junker' and be much more flexible in how it identifies gear to keep.

Originally Posted by Random

BTW, how is the "default character order" for NeedLearnInOrder determined? Is it the order of chars on my login screen, top to bottom?

Originally Posted by Random

I've still been running with my rules for a while, but hadn't checked the update notes in a while. And now I look and see:

Character Name tests
Calling rules within rules
Motif Knowledge
Using of items
... more



With these changes, as well as some of the game changes, I'm in a mood to go and rework a bunch of my rules. Which got me thinking.

What hopefully shouldn't be too hard to build, and would be really helpful is the ability to Export all of the current rules to a box I can copy to clipboard, drop in a real text editor, mess around, then copy it all to the clipboard, hit an Import button in RBI, past the rules in, and have RBI mass update all my rules at once.

The buffer format could be something simple like:
Could possibly also add #Task and #RuleSet items, and be able to import an entire profile at once. Likely best to have Rules as one import/export pairs, and then profiles as another. Not sure how that part would work, but just the ability to edit all the rules at once would be a major help.

This would also make it a lot easier to distribute the greatness of RBI to those less inclined at building their own rules. Might let you include a couple default templates people can load to get started.