Download
(118 Kb)
Download
Updated: 06/05/22 11:03 PM
Patch for:
Bank Manager Revived.
Pictures
File Info
Compatibility:
Lost Depths (8.1.5)
High Isle (8.0.0)
Updated:06/05/22 11:03 PM
Created:04/23/19 05:03 PM
Monthly downloads:200
Total downloads:39,936
Favorites:54
MD5:
Categories:Plug-Ins & Patches, Bags, Bank, Inventory
Bank Manager Revived - Slim Edition  Popular! (More than 5000 hits)
Version: 14.90
by: Gamer1986PAN, @DeadSoon
Bank Manager Revived - Slim Edition

Depends on this Librarys:
LibResearch
LibAddonMenu2.0

Make sure to install this librarys for a working addon

The new Version can be used as Slim and as Full version with the "Global Addon Profile" feature. This is especially to help the non ESO+ Users. But keep in mind with this slim versions you only got 10 profiles in total (for now) - instead of 10 profiles for each char like in the non slim versions.


I only commented some features of the orignal "Bank Manager Revived" or rather from the "Jewelry Crafting Fix of Bank Manager Revived" out in order to have less features but smaller saved variables and related to this smaller saved varibles -better performance.

To benefit from the smaller saved variables, the original ones must be deleted/renamed and new files + profiles must be created. (don't forget to backup your saved variables, so you are able to go back to the original version if you are not satisfied with the slim edition. If you want to reactivate one special option you had in the last version but missing here - i can try to help you make it work again (minor code tweaks and leads again to bigger saved variables)

All credits goes to the original Authors. Ayantir, SnowmanDK, Eldrni and (not original team, but he also did some bugfixes that version depends on) Lexynide


If you found a bug you have here but not in the "Jewelry Crafting Fix Version" let me know and i try to find a solution. If the bug also exists in "Jewelry Crafting Fix Version" i can not guarantee that i can fix that, because i don't master LUA and i only be able to modify small things. If there is a real bug i just can hope some real author is willing to help me out there.


*Notice*: I know that some items - e.g. trophys don't work 100% properly - like they also don't work in original version. When i have some time i try to find a fix for that problem.


If you want to help with this addon just let me know in the comment section and i add you to the team. If you master LUA and want to get some practice in finding and removing bugs you are very welcome.


Bank Manager Revived will help you manage your bank & your guild bank (at guild bank - deposit only)

BMR will automatically deposit the preset items from your current character inventory to the bank or withdraw them from your bank to your inventory.


Features:

Global features
  • bank & guild bank support
  • auto move when opening bank (item/currencies)
  • display a detail of each move and/or summary
  • don't move items protected by ItemSaver / FCO Item Filter addon
  • don't move items moved by other addons while interacting
  • import setting between characters
  • auto restack bank / bag /guild bank after completion
  • fully localized (English, French, Deutsch and Russian)
  • pull your writs items needed for quests

Global Addon Profile

There are 4 global addon profiles predefined:
  1. ESO+ no crafting
  2. ESO+ with crafting
  3. no ESO+ no crafting
  4. no ESO+ with crafting
with the "ESO+" profiles material that can be deposited in the crafting bag can no longer be selected in the options
"with crafting" profiles also shows e.g. intricate armor/weapons as options


Profile support

You can have 9 accountwide profiles defined with their own rules. If 2+ profiles are defined or the current profile is not set to automatically transfer items, an UI will appear at bank to let you switch between profiles. You can easily set a name, and reset a profile. For more profiles there is a posting in the comments how to use up to 39 profiles with manual edit

Currencies (Gold / Tel Var Stones / Alliance Points / Writ Vouchers)

2 individual sliders to choose how much to keep in bag (e.g enough to feed your horse the next 10 days) or how much to grab from bank if you don't have enough. (0 to disable the 2nd function). Gold sliders are 0 up to 200K, Tel Var up to 10K, Alliance Points up to 200k and Writ Vouchers up to 5k.
You can also use the option "Don't keep any ..." to deposit the full amount of this currency to the bank or activate additional to that the option "Keep in Bank instead of Bag" to withdraw everything of that specific currency.



Provisioning
  • Choose to push/pull known recipes
  • Choose to push/pull unknown recipes

Enchanting (up to 50) of the same type
  • Choose to push/pull glyphs

Trophies (up to 50 stacks) of the same type
  • Choose to push/pull treasure maps
  • Choose to push/pull survey maps
  • Choose to push/pull style motif fragments
  • Choose to push/pull recipe fragments
  • Choose to push/pull imperial city trophies

Housing
  • Choose to push/pull known recipes
  • Choose to push/pull unknown recipes
  • Choose to push/pull Furnishing

Misc
  • Choose to push/pull AvA repair
  • Choose to push/pull disguises
  • Choose to push/pull lockpics
  • Choose to push/pull potions
  • Choose to push/pull racial motif books
  • Choose to push/pull containers (does not work with containers you also can not move manually)
  • Choose to push/pull (crown) repair kits
  • Choose to push/pull soul gems, empty or charged

Crafting
  • Choose to push/pull 1 or + (up to 50) stacks of any material <- had to bundle potency runes at all levels with the changes from 14.2
  • Choose to push/pull weapons/armor/jewelry (sets excluded)
  • Choose to push/pull intricate weapons/armor/jewelry (sets excluded)
  • Choose to push/pull researchable weapons/armor/jewelry (sets excluded) <- CraftStore addon support inside

Known Bugs
  • Runes not working (only Ta and Glyphs) Fixed with 14.2
  • Identical Intricate (Jewelry) Items can not be moved together to target (if you have e.g. 4 identical rings BMR will only move 1 of them - no matter what settings you made) - fixed with 14.4
  • Intricate Items can not be pushed to guildbank - working for Jewelry and Woodworking with 14.4
  • If you interact with a storage box (furnishing item) all items you push automatically to bank will be deposited in the bank (even if you do not have the banker NPC), if you want to place that items in the storage box, you have to change your profile or change the options in your current profile to not auto push in bank in order to keep them in your inventory and deposit them manually


Upcoming changes
  • Choose to push/pull intricate jewelry items Done with 14.3 - provided by LordKor -> thank you
  • Change to global saved varibles instead of different profiles for every character - Done with 13.0
  • Optional Setting to switch back to Full Version (if you are not ESO+) - Done with 14.0
  • Find a way that invisible options are also not performing any action
  • Find a way to move intricate items into guildbank - working for Jewelry and Woodworking with 14.4
Information only for non slim users!
since 13.0:
- Change to use accountwide profiles
Please Backup your data first if you want to keep them especially if you are new to the slim version and maybe want to switch back to the non slim version


___________________________________________________________________________
___________________________________________________________________________


Start of most recent changelog:

14.90:
- Optional additional profiles (sadly you have to edit it manually because i can't find a dynamic way and its a huge memory waste if you don't need them)

here is how to use more profiles:
To use more profiles you have to open the Bank Manager.lua file with a notepad app (i prefer notepad++ but any notepad will do)
Lets say you want to change it from 9 to 19 profiles, here are the steps:

First you go to line 217 and delete the "--[["
then you switch to line 367 and add the "--[[" part before the [20]
Then you go to line 1611 and switch the 9 with 19
same with line 1671, 1749, 2800, 3101 and 3172.
you save the file and make a reload. Now you should be able to choose between 19 profiles.

I am not really satisfied with this but it does at least work for now until someone comes up with a dynamic option and you can make up to 39 profiles this way right now (do not recommed it because of the memory waste)

14.86:
- API Bump to 101034


14.85:
- API Bump for next DLC (not yet announced)
- bugfix with FCO Itemsaver provided from Baertram (big thanks as always)


14.84:
- API Bump
- raised max transfered gold from 200000 to 1000000 (request from Lexynide)
- raised max transfered alliance points from 200000 to 1000000
- raised max transfered telvar stones from 10000 to 100000

14.83:
- API Bump to 100034 to work with Flames of Ambition


14.82:
- API Bump to 100033 to work with Markarth

14.81:
- changed max stack to 500 from 50 (you could now deposit e.g. 500 identical glyphs in your guild bank if you want to)

14.8:
- only API Bump to 100032 to work with Stonethorn
- more changes and fixes are on the to-do-list but we did not find the time yet

14.7:
- API Bump to 100031 to work with Greymoor

14.6:
- removed libs from the bundle, please make sure to install them seperatly:
https://www.esoui.com/downloads/info517-LibResearch.html
https://www.esoui.com/downloads/info7-LibAddonMenu.html
to be honest i let them remove by Baertram, because he knows how to do it without breaking the addon, thanks for it

14.5:
- moved MasterWrits to it's final destination tab "Quests: Crafting"

14.4:
- you can now move identical intricate jewelry and woodworking items into the bank AND/OR guildbank by using its own max stack slider - coming for smithing and clothier in later updates hopefully
- temporary moved MasterWrits to trophys and forgot to move it where i really wanted it -> will be moved in 14.5 again (Quest Tab)

14.3:
- Added changes to Jewelry handling provided by LordKor -> thank you
-> you can now move intricate jewelry to/from bank not working for guild banks for now


14.2:
- Added changes to Poison/Poison Solvent handling provided by LordKor -> thank you
- Reworked Runes and Glyphs handling and sorting (works now for guild bank as well)
- API Bump to 100030 for the upcoming DLC
- minor changes i can't remember


14.1:
- Associated Guild Bank for smith, clothier and woodworker reactivated (still no movement for intricate items into guildbank)
- API bump to 100029 Dragonhold (its working with both Live and PTS)


14.0:
- API bump to 100028 Scalebreaker
- Global Addon Profiles added (this hides some options but if you did not deactivate one option before you change the profile - BMR will still perform an action - i am trying to fix this in future updates)
- saved variables will grow a bit, but it should not affect your performance really bad - however i will try to reduce it even more or at least back to the size you had with 13.0


13.0:
- Change to use accountwide profiles
Please Backup your data first if you want to keep them - because the first reload/logout with the new version will reset the current char. Because of that login/logout trough the chars for the first time, the size of the saved variables will be smaller with every character logging out.

If you want to make extra space delete the saved variables and create them new from the scratch (highly recommended)
- Some Minor Changes (outcommenting of some unneeded elements)

- in the comment section is a zip-archive with all functions of BMR Jewelry Crafting version reactivated but with accountwide profiles. This is especially to help the non ESO+ Users - but we will have a look if we can combine them into one version and switch between slimmed ESO+ and non ESO+ version. But first we want to take a look for remake of "intricate items".



12.2:
- Commented the furnishing material out (e.g. Bast, Regulus, Heartwood)

Next steps will be:
- change the saved variables to global/accountwide
(should reduce the size again for better performance, if needed i can think about implementing more profiles instead - let me know in the comments if you would need them but i don't really think they are needed) and you have to make future changes in one profile on one character only instead of importing the same profile to every other char or make the same changes)

- bring back the intricate item movement back - goal is for each individual profession and intricate items in general - all optional



12.1:
- Release
Archived Files (17)
File Name
Version
Size
Uploader
Date
14.90
117kB
Gamer1986PAN
06/05/22 09:47 PM
14.85
117kB
Gamer1986PAN
12/05/21 09:39 AM
14.84
117kB
Gamer1986PAN
09/19/21 09:22 AM
14.83
117kB
Gamer1986PAN
02/22/21 09:12 AM
14.82
117kB
Gamer1986PAN
11/01/20 05:50 PM
14.81
117kB
Gamer1986PAN
08/12/20 01:38 PM
14.8
117kB
Gamer1986PAN
05/17/20 05:34 AM
14.6
117kB
Gamer1986PAN
02/09/20 03:56 PM
14.5
170kB
Gamer1986PAN
01/18/20 11:49 PM
14.4
170kB
Gamer1986PAN
01/18/20 10:20 PM
14.3
170kB
Gamer1986PAN
01/07/20 05:33 PM
14.2
169kB
Gamer1986PAN
01/06/20 06:00 PM
14.1
169kB
Gamer1986PAN
08/14/19 12:29 PM
14.0
169kB
Gamer1986PAN
08/13/19 02:50 PM
13.0
169kB
Gamer1986PAN
05/18/19 10:59 AM
12.2
169kB
Gamer1986PAN
05/17/19 12:22 PM
12.1
169kB
Gamer1986PAN
04/23/19 05:03 PM


Post A Reply Comment Options
Unread 09/16/20, 02:39 AM  
Lars

Forum posts: 0
File comments: 3
Uploads: 0
Re: Re: Text not visible

Originally Posted by Gamer1986PAN
Originally Posted by Lars
Hi I installed this mod and all libarys you said it needs but when I open the settings I´m only able to see the overview topics but I am missing the actual setting texts. For example I´m able to see the topic trophies but when I open that topic I only see the 6 diverent selection bars but not text. Is this a bug or my own fault and how can i fix it ?
also I switched to no eso+ and crafting and tought I could push or pull everything like in the original one + jewlerys
Thx Lars
please try to reinstall. additional informations
-what client language do you play
-and some screenshots about the problem would be nice.

I´m playing with german as client language

and unfotunatlly i don´t know how to put screenshots in here
Report comment to moderator  
Reply With Quote
Unread 09/15/20, 11:04 AM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 651
Uploads: 2
Re: Text not visible

Originally Posted by Lars
Hi I installed this mod and all libarys you said it needs but when I open the settings I´m only able to see the overview topics but I am missing the actual setting texts. For example I´m able to see the topic trophies but when I open that topic I only see the 6 diverent selection bars but not text. Is this a bug or my own fault and how can i fix it ?
also I switched to no eso+ and crafting and tought I could push or pull everything like in the original one + jewlerys
Thx Lars
please try to reinstall. additional informations
-what client language do you play
-and some screenshots about the problem would be nice.
Report comment to moderator  
Reply With Quote
Unread 09/15/20, 07:11 AM  
Lars

Forum posts: 0
File comments: 3
Uploads: 0
Text not visible

Hi I installed this mod and all libarys you said it needs but when I open the settings I´m only able to see the overview topics but I am missing the actual setting texts. For example I´m able to see the topic trophies but when I open that topic I only see the 6 diverent selection bars but not text. Is this a bug or my own fault and how can i fix it ?
also I switched to no eso+ and crafting and tought I could push or pull everything like in the original one + jewlerys
Thx Lars
Last edited by Lars : 09/15/20 at 07:12 AM.
Report comment to moderator  
Reply With Quote
Unread 09/04/20, 04:49 AM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 651
Uploads: 2
Originally Posted by steelwrist
Originally Posted by Gamer1986PAN
Originally Posted by steelwrist
Originally Posted by Gamer1986PAN
Originally Posted by steelwrist
Hello!

First of all, AMAZING IDEA!

I was just lucking for something and thanks for converting this into a slim version.

But I am struggling with something. I am trying to push all my researchable armors and weapons into my bank. Some of them are pushed but not all.

Is this a bug or am I missing some configuration options?

I set "Armor : Heavy" and "Armor : Heavy (Researchable)" settings to "Push to Bank" and it also goes for medium armor and all weapons (woodworking etc.)

How can I fix this? :')
is it by any chance that there are some items set items and some not? Because Set items are not moved as far as i can remember (have all traits researched nearly on all chars so i can not really remember - and i did not use that function)
Well know that I've checked yea that seems to be the problem... :/ Any chance you can change the code? ツ
That was intended by the original Author to prevent from moving gear you might want to use, i guess. And i see that there would be more problems if i would make all items moveable - so i would leave that untouched and advise you to deconstruct those items and craft level 1 items with the same trait on your main char. Most of the time you are going to make profit with that technique because of more expensive style materials and raw materials/hardeners.
Thanks for the advise I am using Auto Research addon as well. It uses the items on my bank so I put the ones that are researchable to the bank, that's why I'd wanted to push them to the bank automatically :/ Anyways thanks again :')

Yeah i totally get your problem here. But i prefer to do some hand movement instead of having to deal with some users searching for gear X because of auto movement from some items they did not want to move. Also with CraftStore you can at least mark items you need to research on other chars so you can see pretty fast what items you have to deposit.
Report comment to moderator  
Reply With Quote
Unread 09/03/20, 09:15 AM  
steelwrist

Forum posts: 0
File comments: 9
Uploads: 0
Originally Posted by Gamer1986PAN
Originally Posted by steelwrist
Originally Posted by Gamer1986PAN
Originally Posted by steelwrist
Hello!

First of all, AMAZING IDEA!

I was just lucking for something and thanks for converting this into a slim version.

But I am struggling with something. I am trying to push all my researchable armors and weapons into my bank. Some of them are pushed but not all.

Is this a bug or am I missing some configuration options?

I set "Armor : Heavy" and "Armor : Heavy (Researchable)" settings to "Push to Bank" and it also goes for medium armor and all weapons (woodworking etc.)

How can I fix this? :')
is it by any chance that there are some items set items and some not? Because Set items are not moved as far as i can remember (have all traits researched nearly on all chars so i can not really remember - and i did not use that function)
Well know that I've checked yea that seems to be the problem... :/ Any chance you can change the code? ツ
That was intended by the original Author to prevent from moving gear you might want to use, i guess. And i see that there would be more problems if i would make all items moveable - so i would leave that untouched and advise you to deconstruct those items and craft level 1 items with the same trait on your main char. Most of the time you are going to make profit with that technique because of more expensive style materials and raw materials/hardeners.
Thanks for the advise I am using Auto Research addon as well. It uses the items on my bank so I put the ones that are researchable to the bank, that's why I'd wanted to push them to the bank automatically :/ Anyways thanks again :')
Report comment to moderator  
Reply With Quote
Unread 08/31/20, 03:51 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 651
Uploads: 2
Originally Posted by steelwrist
Originally Posted by Gamer1986PAN
Originally Posted by steelwrist
Hello!

First of all, AMAZING IDEA!

I was just lucking for something and thanks for converting this into a slim version.

But I am struggling with something. I am trying to push all my researchable armors and weapons into my bank. Some of them are pushed but not all.

Is this a bug or am I missing some configuration options?

I set "Armor : Heavy" and "Armor : Heavy (Researchable)" settings to "Push to Bank" and it also goes for medium armor and all weapons (woodworking etc.)

How can I fix this? :')
is it by any chance that there are some items set items and some not? Because Set items are not moved as far as i can remember (have all traits researched nearly on all chars so i can not really remember - and i did not use that function)
Well know that I've checked yea that seems to be the problem... :/ Any chance you can change the code? ツ
That was intended by the original Author to prevent from moving gear you might want to use, i guess. And i see that there would be more problems if i would make all items moveable - so i would leave that untouched and advise you to deconstruct those items and craft level 1 items with the same trait on your main char. Most of the time you are going to make profit with that technique because of more expensive style materials and raw materials/hardeners.
Report comment to moderator  
Reply With Quote
Unread 08/31/20, 07:05 AM  
steelwrist

Forum posts: 0
File comments: 9
Uploads: 0
Originally Posted by Gamer1986PAN
Originally Posted by steelwrist
Hello!

First of all, AMAZING IDEA!

I was just lucking for something and thanks for converting this into a slim version.

But I am struggling with something. I am trying to push all my researchable armors and weapons into my bank. Some of them are pushed but not all.

Is this a bug or am I missing some configuration options?

I set "Armor : Heavy" and "Armor : Heavy (Researchable)" settings to "Push to Bank" and it also goes for medium armor and all weapons (woodworking etc.)

How can I fix this? :')
is it by any chance that there are some items set items and some not? Because Set items are not moved as far as i can remember (have all traits researched nearly on all chars so i can not really remember - and i did not use that function)
Well know that I've checked yea that seems to be the problem... :/ Any chance you can change the code? ツ
Report comment to moderator  
Reply With Quote
Unread 08/17/20, 05:53 AM  
True_Bach

Forum posts: 0
File comments: 43
Uploads: 0
Originally Posted by Gamer1986PAN
Originally Posted by True_Bach
Originally Posted by Gamer1986PAN
to your nuances:
1.) maybe i am gooing to raise it to 100 but if not you would be able to do it by yourself pretty easy. i will let you know how if i am not implementing it.
Tell me please about this fix ) I need it so much )
Update 14.81 makes it possible to change the max stack to 500. What basically means you could deposit 500 identically glyphs in your guild bank to level up your alts. Because you can also type in the value i think its ok for everyone.
It's great!! Thx you!!! ^_^
Report comment to moderator  
Reply With Quote
Unread 08/12/20, 01:49 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 651
Uploads: 2
Originally Posted by True_Bach
Originally Posted by Gamer1986PAN
to your nuances:
1.) maybe i am gooing to raise it to 100 but if not you would be able to do it by yourself pretty easy. i will let you know how if i am not implementing it.
Tell me please about this fix ) I need it so much )
Update 14.81 makes it possible to change the max stack to 500. What basically means you could deposit 500 identically glyphs in your guild bank to level up your alts. Because you can also type in the value i think its ok for everyone.
Report comment to moderator  
Reply With Quote
Unread 08/06/20, 01:31 PM  
True_Bach

Forum posts: 0
File comments: 43
Uploads: 0
Originally Posted by Gamer1986PAN
to your nuances:
1.) maybe i am gooing to raise it to 100 but if not you would be able to do it by yourself pretty easy. i will let you know how if i am not implementing it.
Tell me please about this fix ) I need it so much )
Last edited by True_Bach : 08/11/20 at 08:05 AM.
Report comment to moderator  
Reply With Quote
Unread 07/13/20, 05:54 PM  
jayman10000

Forum posts: 2
File comments: 160
Uploads: 0
Originally Posted by Gamer1986PAN
Originally Posted by jayman10000
Originally Posted by Gamer1986PAN
Originally Posted by jayman10000
Since the last update I have had an issue where some stacks are only partially deposited to bank. For example say I have 5x200 stacks + 1 stack of 43 of lure I have setup to deposit to bank. Then the addon will split the full stacks and only deposit some of it. It's looks like (Im not 100% sure though) that it counts 43 from the stack of 43 and then only takes the remainder 157 (200-43) from the next stack which then leaves 43 again and then it continues so forth for all the stacks. Again Im not 100% that this is exactly how it happens, but the issue remains that stacks are not fully deposited to the bank.

Now an interesting result is that if I then withdraw all the lure from the bank and make sure to stack them again and then go to the bank again a few times and withdraw them all again and restack, then after a few times doing this, the addon will then finally be able to deposit all the stacks in one go without splitting them. Unfortunately, later again when I have more stacks to deposit the problem happens again.
I did not change anything that could cause that problems in the last updates. Maybe you did install another addon that might interfere?
How many of that items do you have in your bank and how many do you have in your iventory? Does it work if you enter the bank 2 times in a row without taking anything from the bank?
But maybe the issue already started when ZOS updated their game earlier and I didn't notice it until later, so please excuse me for saying it happened after YOUR latest update, I realize I cannot be certain of that. Maybe ZOS changed something that introduced the error?

Exscuse for a bit of long text, but I want to explain the issue that happens properly for you:
I have now also tried on my sons pc, he had no addons installed, so I installed this addon and it does the same thing. I tried testing with only full stacks (so no semi full stacks like in my first example), and it doesn't happen there, with ONLY full stacks all are deposited correctly. And I also then tested having 3 stacks of 200, where I then splitted one of those stacks into a 150 stack and a 50 stack (so that in my inventory I now have 1x50, 1x150, 2x200). When opening the bank the addon ends up partially depositing as follows:

50,150,200,200 in player bag before opening bank -> 50,50,100 in player bag after opening bank.

And another test with the following:
25,200,200,200 in player bag before opening bank -> 168, 168, 164 in player bag after opening bank.
Exiting bank and opening bank 2nd time produced this:
168, 168, 164 in player bag before opening bank -> 73,130,149 in player bag after opening bank a 2nd time.
Exiting bank and opening bank 3rd time produced this:
73,130,149 in player bag before opening bank -> 67,117 in player bag after opening bank a 3rd time.

But with only full(200) stacks and no partial stacks it works like it should, I think this is an important result.

These tests performed with only Bank Manager Revived Slim Edition active (+ dependent libraries)

I could record a video for you if you'd like, maybe it is better to see it happen than to read my poor explanations...

So far i can tell you that i have seen the bug now but i am not sure how long it will take me to fix it because right now i have no idea where to start. I tried to stack inventory and bank before the auto movement begins but even that does not work. That will be a challenge to fix and i do not know when we find the time to get into it. Because of the new update we might make it working on PTS so its save in the future and we can release it as pts ready.

Sorry but i have to ask you for being patient on this one.
That's cool, at least you now know the problem is there. Things take time, I'll just look forward to an eventual solution how long it may take. I wish I was better at LUA so I could help (but I have a looong way to go before I understand what is going on with the code. I like to look through stuff like that to learn more, but that's something I also have to be patient with )
Report comment to moderator  
Reply With Quote
Unread 07/13/20, 04:18 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 651
Uploads: 2
Originally Posted by jayman10000
Originally Posted by Gamer1986PAN
Originally Posted by jayman10000
Since the last update I have had an issue where some stacks are only partially deposited to bank. For example say I have 5x200 stacks + 1 stack of 43 of lure I have setup to deposit to bank. Then the addon will split the full stacks and only deposit some of it. It's looks like (Im not 100% sure though) that it counts 43 from the stack of 43 and then only takes the remainder 157 (200-43) from the next stack which then leaves 43 again and then it continues so forth for all the stacks. Again Im not 100% that this is exactly how it happens, but the issue remains that stacks are not fully deposited to the bank.

Now an interesting result is that if I then withdraw all the lure from the bank and make sure to stack them again and then go to the bank again a few times and withdraw them all again and restack, then after a few times doing this, the addon will then finally be able to deposit all the stacks in one go without splitting them. Unfortunately, later again when I have more stacks to deposit the problem happens again.
I did not change anything that could cause that problems in the last updates. Maybe you did install another addon that might interfere?
How many of that items do you have in your bank and how many do you have in your iventory? Does it work if you enter the bank 2 times in a row without taking anything from the bank?
But maybe the issue already started when ZOS updated their game earlier and I didn't notice it until later, so please excuse me for saying it happened after YOUR latest update, I realize I cannot be certain of that. Maybe ZOS changed something that introduced the error?

Exscuse for a bit of long text, but I want to explain the issue that happens properly for you:
I have now also tried on my sons pc, he had no addons installed, so I installed this addon and it does the same thing. I tried testing with only full stacks (so no semi full stacks like in my first example), and it doesn't happen there, with ONLY full stacks all are deposited correctly. And I also then tested having 3 stacks of 200, where I then splitted one of those stacks into a 150 stack and a 50 stack (so that in my inventory I now have 1x50, 1x150, 2x200). When opening the bank the addon ends up partially depositing as follows:

50,150,200,200 in player bag before opening bank -> 50,50,100 in player bag after opening bank.

And another test with the following:
25,200,200,200 in player bag before opening bank -> 168, 168, 164 in player bag after opening bank.
Exiting bank and opening bank 2nd time produced this:
168, 168, 164 in player bag before opening bank -> 73,130,149 in player bag after opening bank a 2nd time.
Exiting bank and opening bank 3rd time produced this:
73,130,149 in player bag before opening bank -> 67,117 in player bag after opening bank a 3rd time.

But with only full(200) stacks and no partial stacks it works like it should, I think this is an important result.

These tests performed with only Bank Manager Revived Slim Edition active (+ dependent libraries)

I could record a video for you if you'd like, maybe it is better to see it happen than to read my poor explanations...

So far i can tell you that i have seen the bug now but i am not sure how long it will take me to fix it because right now i have no idea where to start. I tried to stack inventory and bank before the auto movement begins but even that does not work. That will be a challenge to fix and i do not know when we find the time to get into it. Because of the new update we might make it working on PTS so its save in the future and we can release it as pts ready.

Sorry but i have to ask you for being patient on this one.
Report comment to moderator  
Reply With Quote
Unread 07/10/20, 04:36 PM  
jayman10000

Forum posts: 2
File comments: 160
Uploads: 0
Originally Posted by Gamer1986PAN
Originally Posted by jayman10000
Since the last update I have had an issue where some stacks are only partially deposited to bank. For example say I have 5x200 stacks + 1 stack of 43 of lure I have setup to deposit to bank. Then the addon will split the full stacks and only deposit some of it. It's looks like (Im not 100% sure though) that it counts 43 from the stack of 43 and then only takes the remainder 157 (200-43) from the next stack which then leaves 43 again and then it continues so forth for all the stacks. Again Im not 100% that this is exactly how it happens, but the issue remains that stacks are not fully deposited to the bank.

Now an interesting result is that if I then withdraw all the lure from the bank and make sure to stack them again and then go to the bank again a few times and withdraw them all again and restack, then after a few times doing this, the addon will then finally be able to deposit all the stacks in one go without splitting them. Unfortunately, later again when I have more stacks to deposit the problem happens again.
I did not change anything that could cause that problems in the last updates. Maybe you did install another addon that might interfere?
How many of that items do you have in your bank and how many do you have in your iventory? Does it work if you enter the bank 2 times in a row without taking anything from the bank?
But maybe the issue already started when ZOS updated their game earlier and I didn't notice it until later, so please excuse me for saying it happened after YOUR latest update, I realize I cannot be certain of that. Maybe ZOS changed something that introduced the error?

Exscuse for a bit of long text, but I want to explain the issue that happens properly for you:
I have now also tried on my sons pc, he had no addons installed, so I installed this addon and it does the same thing. I tried testing with only full stacks (so no semi full stacks like in my first example), and it doesn't happen there, with ONLY full stacks all are deposited correctly. And I also then tested having 3 stacks of 200, where I then splitted one of those stacks into a 150 stack and a 50 stack (so that in my inventory I now have 1x50, 1x150, 2x200). When opening the bank the addon ends up partially depositing as follows:

50,150,200,200 in player bag before opening bank -> 50,50,100 in player bag after opening bank.

And another test with the following:
25,200,200,200 in player bag before opening bank -> 168, 168, 164 in player bag after opening bank.
Exiting bank and opening bank 2nd time produced this:
168, 168, 164 in player bag before opening bank -> 73,130,149 in player bag after opening bank a 2nd time.
Exiting bank and opening bank 3rd time produced this:
73,130,149 in player bag before opening bank -> 67,117 in player bag after opening bank a 3rd time.

But with only full(200) stacks and no partial stacks it works like it should, I think this is an important result.

These tests performed with only Bank Manager Revived Slim Edition active (+ dependent libraries)

I could record a video for you if you'd like, maybe it is better to see it happen than to read my poor explanations...
Last edited by jayman10000 : 07/10/20 at 05:12 PM.
Report comment to moderator  
Reply With Quote
Unread 07/10/20, 10:39 AM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 651
Uploads: 2
Originally Posted by jayman10000
Since the last update I have had an issue where some stacks are only partially deposited to bank. For example say I have 5x200 stacks + 1 stack of 43 of lure I have setup to deposit to bank. Then the addon will split the full stacks and only deposit some of it. It's looks like (Im not 100% sure though) that it counts 43 from the stack of 43 and then only takes the remainder 157 (200-43) from the next stack which then leaves 43 again and then it continues so forth for all the stacks. Again Im not 100% that this is exactly how it happens, but the issue remains that stacks are not fully deposited to the bank.

Now an interesting result is that if I then withdraw all the lure from the bank and make sure to stack them again and then go to the bank again a few times and withdraw them all again and restack, then after a few times doing this, the addon will then finally be able to deposit all the stacks in one go without splitting them. Unfortunately, later again when I have more stacks to deposit the problem happens again.
I did not change anything that could cause that problems in the last updates. Maybe you did install another addon that might interfere?
How many of that items do you have in your bank and how many do you have in your iventory? Does it work if you enter the bank 2 times in a row without taking anything from the bank?
Report comment to moderator  
Reply With Quote
Unread 07/10/20, 09:58 AM  
jayman10000

Forum posts: 2
File comments: 160
Uploads: 0
Since the last update I have had an issue where some stacks are only partially deposited to bank. For example say I have 5x200 stacks + 1 stack of 43 of lure I have setup to deposit to bank. Then the addon will split the full stacks and only deposit some of it. It's looks like (Im not 100% sure though) that it counts 43 from the stack of 43 and then only takes the remainder 157 (200-43) from the next stack which then leaves 43 again and then it continues so forth for all the stacks. Again Im not 100% that this is exactly how it happens, but the issue remains that stacks are not fully deposited to the bank.

Now an interesting result is that if I then withdraw all the lure from the bank and make sure to stack them again and then go to the bank again a few times and withdraw them all again and restack, then after a few times doing this, the addon will then finally be able to deposit all the stacks in one go without splitting them. Unfortunately, later again when I have more stacks to deposit the problem happens again.
Last edited by jayman10000 : 07/10/20 at 10:06 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: