Shissu Guild Tools Elsweyr Patch V1.3 : Plug-Ins & Patches : Elder Scrolls Online AddOns

Addon Info.

Comments (41)

(187 Kb)

Download

Updated: 05/24/19 01:12 PM

Patch for:
Shissu's Guild Tools.

Add Favorite

Install Help

Portal

Bugs

Features

Compatibility:	Elsweyr (5.0.5)
Updated:	05/24/19 01:12 PM
Created:	05/24/19 01:12 PM
Monthly downloads:	55
Total downloads:	8,612
Favorites:	5
MD5:

Shissu Guild Tools Elsweyr Patch V1.3 Popular! (More than 5000 hits)

Version: 1.3

by: Splat, Sordrak

Update of all Shissu modules to enable functionality after the Elsweyr release.

This patch has been worked on by both Splat and Sodrak. Thank you to those who have helped with testing.

This patch file has been tested and is expected to work in most cases, although a number of bugs remain.
Most are related to the additional rank that was added to enable the new invite system to work. The 'Welcomer' module of shissu (whilst it will now place the correct message in the correct guild) has issue with dropping 2 message and is a known bug that will hopefully be addressed in a future update.

I strongly advise that you first BACKUP your AddOns and SavedVariables Folders before installing.

Install this at your own risk. No warranties are offered whatsoever.

Installation:
- Download zip file to a temporary directory (or your desktop)
- Extract all files
- Copy the file to your ...\Documents\Elder Scrolls Online\live\AddOns folder replacing all exisiting shissu files

Comment Options

Page 2 of 3

06/19/19, 10:15 AM
patdrum Forum posts: 0 File comments: 4 Uploads: 0	guild member status this add-on used to be terrific until the update. Now you can't remove the status of players going online and off-line in certain things in the add-on that it used to have used to have blocks where you can click it on and off. Now it just is okay and gives you no option to turn it off needs an update like it used to be. Otherwise, I gonna have to stop using it makes it difficult to keep up in the chat box with all these people going online and off-line. Like I said they used to be an option to turn it off, but not anymore. So I going to look for another add-on until it's been fixed. I love certain things in this add-on, but it's very annoying when you can customize some options anymore.

06/08/19, 08:58 AM
JN Slevin Forum posts: 10 File comments: 85 Uploads: 4	I found an Issue, it appears that on external Windows (Notebook / DonateFee...) the UI Elements (Buttons to be precise) are missing. https://imgur.com/a/9Ch09Xa

06/04/19, 11:13 AM

Sordrak

Forum posts: 52

File comments: 358

Uploads: 4

Originally Posted by ProfKnibble

Hi there,

I got an error when try to change a letter in guild "About us":

Code:

bad argument #4 to 'string.format' (string expected, got nil)
stack traceback:
[C]: in function 'string.format'
EsoUI/Libraries/Globals/globalapi.lua:154: in function 'zo_iconFormat'
|caaaaaa<Locals> width = 24, height = 24 </Locals>|r
user:/AddOns/ShissuNotifications/ShissuNotifications.lua:409: in function '_addon.guildDescriptionChanged'
|caaaaaa<Locals> _ = 327716, guildId = 515298, guildId = 0, guildName = "", guildDescription = "", guildAlliance = 0 </Locals>|r

Did you apply the patch I mentioned below?

I think i found two issues in the notifications.

Original Code at line 405:

Code:

-- EVENT_GUILD_DESCRIPTION_CHANGED (integer eventCode, integer guildId) 
function _addon.guildDescriptionChanged(_, guildId)
  local guildId = GetGuildId(guildId)
  local guildName = GetGuildName(guildId)
  local guildDescription = GetGuildDescription(guildId)

New code:

Code:

-- EVENT_GUILD_DESCRIPTION_CHANGED (integer eventCode, integer guildId) 
function _addon.guildDescriptionChanged(_, guildId)
  --local guildId = GetGuildId(guildId)
  local guildName = GetGuildName(guildId)
  local guildDescription = GetGuildDescription(guildId)

Original Code at line #495:

Code:

function _addon.memberRankChanged(_, guildId, displayName, rankIndex)
  local guildId = GetGuildId(guildId)
  local guildName = GetGuildName(guildId)
  local guildAlliance = GetGuildAlliance(guildId)

Code:

function _addon.memberRankChanged(_, guildId, displayName, rankIndex)
  --local guildId = GetGuildId(guildId)
  local guildName = GetGuildName(guildId)
  local guildAlliance = GetGuildAlliance(guildId)

As far as I know both EVENTS should receive the guildId.

06/04/19, 07:41 AM

JN Slevin

Forum posts: 10

File comments: 85

Uploads: 4

Is it possible to make an Event (Screen / Chat Message) whenever a Guild Member Donates something? Like ATT / MM / Traitbuddy do?

Code:

Guild Bank
Search on ESOUI Source Code EVENT_CLOSE_GUILD_BANK (number eventCode)
Search on ESOUI Source Code EVENT_GUILD_BANKED_MONEY_UPDATE (number eventCode, number newBankedMoney, number oldBankedMoney)
Search on ESOUI Source Code EVENT_GUILD_BANK_DESELECTED (number eventCode)
Search on ESOUI Source Code EVENT_GUILD_BANK_ITEMS_READY (number eventCode)
Search on ESOUI Source Code EVENT_GUILD_BANK_ITEM_ADDED (number eventCode, number slotId, boolean addedByLocalPlayer, number ItemUISoundCategory itemSoundCategory)
Search on ESOUI Source Code EVENT_GUILD_BANK_ITEM_REMOVED (number eventCode, number slotId, boolean addedByLocalPlayer, number ItemUISoundCategory itemSoundCategory)
Search on ESOUI Source Code EVENT_GUILD_BANK_OPEN_ERROR (number eventCode, GuildBankResult reason)
Search on ESOUI Source Code EVENT_GUILD_BANK_SELECTED (number eventCode, number guildId)
Search on ESOUI Source Code EVENT_GUILD_BANK_TRANSFER_ERROR (number eventCode, GuildBankResult reason)
Search on ESOUI Source Code EVENT_GUILD_BANK_UPDATED_QUANTITY (number eventCode, number slotId)
Search on ESOUI Source Code EVENT_OPEN_GUILD_BANK (number eventCode)

this is the only thing i found but i dont know enough about Programming to do it myself.

06/04/19, 03:54 AM

ProfKnibble

Forum posts: 0

File comments: 15

Uploads: 0

Hi there,

I got an error when try to change a letter in guild "About us":

Code:

bad argument #4 to 'string.format' (string expected, got nil)
stack traceback:
[C]: in function 'string.format'
EsoUI/Libraries/Globals/globalapi.lua:154: in function 'zo_iconFormat'
|caaaaaa<Locals> width = 24, height = 24 </Locals>|r
user:/AddOns/ShissuNotifications/ShissuNotifications.lua:409: in function '_addon.guildDescriptionChanged'
|caaaaaa<Locals> _ = 327716, guildId = 515298, guildId = 0, guildName = "", guildDescription = "", guildAlliance = 0 </Locals>|r

06/03/19, 07:05 AM
Sordrak Forum posts: 52 File comments: 358 Uploads: 4	If I get the permissions to upload my current changes, I will do so. For all new requests / changes, I do not know when I have the time to look at them as I'm currently running some tests with my new AddOn which should be released soon (and there is plenty of stuff to fix / adjust /add) >_< But I certainly will spend some time on this here, once the other AddOn is in a decent state and can be released.

06/02/19, 08:48 AM
Verbalinkontinenz Forum posts: 11 File comments: 247 Uploads: 2	Found something new: There must be a code fragment, deleting at least the join-date and refreshing it, when someone joins into the guild, who had been there already. it seems as it doesnt work properly as well.

06/01/19, 09:28 AM
Verbalinkontinenz Forum posts: 11 File comments: 247 Uploads: 2	For reproducing check: Maybe it only doesnt update join date in SGT, if someone else accepts the request (officers as example) edit: nope, nevermind. Last edited by Verbalinkontinenz : 06/01/19 at 09:33 AM.

06/01/19, 03:57 AM

Verbalinkontinenz

Forum posts: 11

File comments: 247

Uploads: 2

Originally Posted by Splat

Only just had the chance to login and look at comments.

I have (and am currently having) very little spare time atm due to rl stuff.

I have had a quick scan down the comments and most of the stuff is on the to do list.

As soon as I get a chance to go back over things I will update what I can.

For those with the UI error about roster and framework, from talking to a few other people it appears to be oddly random and fixed with a full reinstall of the patch.

As Sodrak says, some of the issues are not easy to reproduce or will reproduce randomly so are not as simple to fix.

In the meantime if anyone wanted to add a new revision (V1.4) based of my V1.3 then please feel free to do so. I don't want my lack of spare time to stop any fixes being added.

I dont know, what @s0rdrak thinks, but what about adding him as co-author with update rights?

Last edited by Verbalinkontinenz : 06/01/19 at 03:57 AM.

06/01/19, 03:42 AM
Splat Forum posts: 7 File comments: 51 Uploads: 7	Only just had the chance to login and look at comments. I have (and am currently having) very little spare time atm due to rl stuff. I have had a quick scan down the comments and most of the stuff is on the to do list. As soon as I get a chance to go back over things I will update what I can. For those with the UI error about roster and framework, from talking to a few other people it appears to be oddly random and fixed with a full reinstall of the patch. As Sodrak says, some of the issues are not easy to reproduce or will reproduce randomly so are not as simple to fix. In the meantime if anyone wanted to add a new revision (V1.4) based of my V1.3 then please feel free to do so. I don't want my lack of spare time to stop any fixes being added.

05/31/19, 05:11 PM

Verbalinkontinenz

Forum posts: 11

File comments: 247

Uploads: 2

Originally Posted by Sordrak

Originally Posted by Verbalinkontinenz

Originally Posted by Sordrak

Originally Posted by Verbalinkontinenz

Still failing to update some join dates. Those are people joining via guild search, but doesnt happen always. I dont know yet, wether its just saved wrong and doesnt update anymore due to that. When I am back home, I will check that wrong wrong infos, delete them from the savedvars and check, wether SGT restarts searching for that infos.... idk...

Is this still an issue or got some more feedback on this one?

It is, and I dont see any reason to fix my savedvars now, since also newly joined members happen to sometimes not get a join date by sgt. So its nothing old, or wrong data. And i dont see any pattern, why it sometimes happens, and when not. Some people joining via guild finder have correct time stamp, others dont.

Can't reproduce it easily. I might have to use my second account to join a guild and test a few things, but i would need some assistance on that.

Message me ingame, in case you need some help. I can provide guilds to join *g

05/31/19, 04:10 PM

Sordrak

Forum posts: 52

File comments: 358

Uploads: 4

Originally Posted by Verbalinkontinenz

Originally Posted by Sordrak

Originally Posted by Verbalinkontinenz

Is this still an issue or got some more feedback on this one?

Can't reproduce it easily. I might have to use my second account to join a guild and test a few things, but i would need some assistance on that.

05/31/19, 10:19 AM

Verbalinkontinenz

Forum posts: 11

File comments: 247

Uploads: 2

Originally Posted by Sordrak

Originally Posted by Verbalinkontinenz

Is this still an issue or got some more feedback on this one?

Last edited by Verbalinkontinenz : 05/31/19 at 10:19 AM.

05/30/19, 03:44 PM

Sordrak

Forum posts: 52

File comments: 358

Uploads: 4

Originally Posted by Verbalinkontinenz

Is this still an issue or got some more feedback on this one?

05/30/19, 03:43 PM

Sordrak

Forum posts: 52

File comments: 358

Uploads: 4

Originally Posted by orcashow

Started getting some errors in the Chat module. I removed the old mod folder & replaced it with your updated version so it was a clean install. After getting the errors, I renamed the ShissuChat.lua save file to re-create it. This seems to have fixed the issue for the last 7hrs. After re-loading the game, I'm now getting errors again. Thanks for your hard work maintaining this addon.

https://cdn.discordapp.com/attachmen...525_181747.png

It seems to be related to gchat or links in it? Hopefully helps.
https://cdn.discordapp.com/attachmen...525_204236.png

First Issue:

Original Code at line ~417:

Code:

                  local charAlliance = charInfo[5]
		  charAlliance = zo_iconFormat(GetAllianceBannerIcon(charAlliance), 24, 24)

New code:

Code:

                  local charAlliance = charInfo[5]
		  if charAlliance ~= nil and charAlliance ~= 0 then
			charAlliance = zo_iconFormat(GetAllianceBannerIcon(charAlliance), 24, 24)
		  end

Second Issue (not so happy with the fix, rather a hack, but should work fine):

Original code at line ~209:

Code:

function _addon.core.createLinkURL(text)
  if (string.find(text, "www.") or string.find(text, "http://") or string.find(text, "https://")) then
    local cache = 0  
    local cache2 = 0
    local cache3 = 0
    
    local onlyWWW = string.find(text, "www.")
    
    if (onlyWWW and not string.find(text, "http")) then
      text = string.gsub(text, "www.", "http://www.")
    end
    
    if (string.sub(text, 1, 4) == "http" or string.sub(text, 1, 3) == "www") then
      cache2 = 1
      text = "shissu meow " .. text .. " meow shissu meow"
    end
               
    local preT, url, nextT = text:match( "(.+)%s+(https?%S+)%s+(.*)$" )
    
    if (nextT == nil) then
      cache3 = 1
      text = text .. " meow shissu meow"
      
      preT, url, nextT = text:match( "(.+)%s+(https?%S+)%s+(.*)$" )
    end

    local stringLen = string.len(url)  
    local last = string.sub(url, stringLen, stringLen)
        
    if (last== "," or last == ".") then
      url = string.sub(url, 0, stringLen-1)
      cache = 1
    end
   
    local urlLink = stdColor .. string.format("|H1:%s:%s:%s|h%s|h", _addon.LINK, 1, _addon.urlLINK, url) .. "|r"
  
    if (cache2 == 0) then  	
      local stringLen2 = string.len(preT)
      local stringLen3 = string.len(text)
         
      local newNextT = string.sub(text, stringLen + stringLen2 + 2, stringLen3)  
     
      if (cache3 == 1) then
        text = preT .. " " .. urlLink 
      elseif (cache == 1) then
        text = preT .. " " .. urlLink .. newNextT
      else
       text = preT .. " " .. urlLink .. " " .. newNextT
      end
    else
      text = urlLink
    end

  end
    
  return text
end

New code:

Code:

function _addon.core.createLinkURL(text)
  if (string.find(text, "www.") or string.find(text, "http://") or string.find(text, "https://")) then
    local oldText = text
    local cache = 0  
    local cache2 = 0
    local cache3 = 0
    
    local onlyWWW = string.find(text, "www.")
    
    if (onlyWWW and not string.find(text, "http")) then
      text = string.gsub(text, "www.", "http://www.")
    end
    
    if (string.sub(text, 1, 4) == "http" or string.sub(text, 1, 3) == "www") then
      cache2 = 1
      text = "shissu meow " .. text .. " meow shissu meow"
    end
               
    local preT, url, nextT = text:match( "(.+)%s+(https?%S+)%s+(.*)$" )
    
    if (nextT == nil) then
      cache3 = 1
      text = text .. " meow shissu meow"
      
      preT, url, nextT = text:match( "(.+)%s+(https?%S+)%s+(.*)$" )
    end
    if url ~= nil then
    local stringLen = string.len(url)  
    local last = string.sub(url, stringLen, stringLen)
        
    if (last== "," or last == ".") then
      url = string.sub(url, 0, stringLen-1)
      cache = 1
    end
   
    local urlLink = stdColor .. string.format("|H1:%s:%s:%s|h%s|h", _addon.LINK, 1, _addon.urlLINK, url) .. "|r"
  
    if (cache2 == 0) then  	
      local stringLen2 = string.len(preT)
      local stringLen3 = string.len(text)
         
      local newNextT = string.sub(text, stringLen + stringLen2 + 2, stringLen3)  
     
      if (cache3 == 1) then
        text = preT .. " " .. urlLink 
      elseif (cache == 1) then
        text = preT .. " " .. urlLink .. newNextT
      else
       text = preT .. " " .. urlLink .. " " .. newNextT
      end
    else
      text = urlLink
    end
	else
	  return oldText
	end
  end
    
  return text
end

@Splat: Please verify the fixes (all, incl. deepcopy) and update the addon, thx

Page 2 of 3

Report this File