Go to Page... |
Compatibility: | Markarth (6.2.5) Stonethorn (6.1.5) Greymoor (6.0.5) |
Updated: | 10/25/20 09:12 AM |
Created: | 08/14/19 05:26 AM |
Monthly downloads: | 286 |
Total downloads: | 24,840 |
Favorites: | 20 |
MD5: |
File Name |
Version |
Size |
Uploader |
Date |
1.4.9 |
188kB |
Splat |
08/07/20 03:45 AM |
|
1.4.8 |
188kB |
Splat |
05/26/20 04:10 AM |
|
1.4.7 |
188kB |
Splat |
03/28/20 05:48 AM |
|
1.4.6 |
391kB |
Splat |
03/02/20 10:13 AM |
|
1.4.5 |
188kB |
Splat |
02/24/20 09:53 AM |
|
1.4.4 |
188kB |
Splat |
11/10/19 05:33 AM |
|
1.4.3 |
188kB |
Splat |
11/04/19 05:52 AM |
|
1.4.2 |
188kB |
Splat |
09/27/19 06:42 AM |
|
1.4.1 |
188kB |
Splat |
09/10/19 04:49 AM |
|
1.4 |
188kB |
08/14/19 05:26 AM |
![]() |
Comment Options |
![]() |
|
Where are welcome messages saved? I had to reinstall and have a backup, but cannot seem to restore them.
Last edited by mlq88 : 09/12/20 at 02:18 PM.
|
|
![]() |
![]() |
mlq88 |
View Public Profile |
Send a private message to mlq88 |
Find More Posts by mlq88 |
Add mlq88 to Your Buddy List |
Kwoung |
View Public Profile |
Send a private message to Kwoung |
Find More Posts by Kwoung |
Add Kwoung to Your Buddy List |
Splat |
View Public Profile |
Send a private message to Splat |
Send email to Splat |
Find More Posts by Splat |
Add Splat to Your Buddy List |
![]() |
||
|
If you wish to take over the updates to Shissu you are welcome to do so. THat
|
|
![]() |
![]() |
Splat |
View Public Profile |
Send a private message to Splat |
Send email to Splat |
Find More Posts by Splat |
Add Splat to Your Buddy List |
![]() |
|
https://github.com/ESOUIMods/ShissuG...e/dev-shar.zip
I apologize Splat not trying to step on your toes I just need the practice with Trade mods. So as I mentioned I have been testing this and getting feedback from other people that had already asked for my help updating the mod. Feel free to upload this as a new version if you like. Since I am trying to learn as much as I can about guild history requests I continue to tinker with this. I can see that for the most part the changes you are making Splat are for the GuildId and GuildName changes since that seems to be what changed with the API and that's what's different from the last official version by Shissu. So after I saw your update I merged all the changes I could and opened every file and started scouring the code for any occurrence of GetNumGuilds(). From there I just made sure the vars were correct. I didn't like the English translation on the Roster Page. So I changed it to This Week and Last Week. I added Globals because of all the times that were scattered all over the place. The Kiosk timer has been updated to use the 9 day week and then automatically use a 7 day week after the 11th. The gold totals on the guild roster tab will be correct if you scan the guild history manually, reload your UI, and then wait about 20 minutes. It might be a good idea to backup saved vars but if you do what I mentioned the mod will pick up everything and then the totals will become more accurate. I also added a quality of life update for those using GuildHallButton so that the button and the timer are not overlapping. I have also updated all the version numbers and manifest files. Should be pretty thorough. The two bugs I'm trying to resolve are the icon when you are in multiple guilds and how that shows in the chat window. The other bug seems to be when a player logs onto different characters eventually the GM should see that on the tooltip for the players account. So if I figure those out I'll let you know.
Last edited by Sharlikran : 08/08/20 at 01:31 AM.
|
|
![]() |
![]() |
Sharlikran |
View Public Profile |
Send a private message to Sharlikran |
Send email to Sharlikran |
Find More Posts by Sharlikran |
Add Sharlikran to Your Buddy List |
Splat |
View Public Profile |
Send a private message to Splat |
Send email to Splat |
Find More Posts by Splat |
Add Splat to Your Buddy List |
Sharlikran |
View Public Profile |
Send a private message to Sharlikran |
Send email to Sharlikran |
Find More Posts by Sharlikran |
Add Sharlikran to Your Buddy List |
![]() |
||
|
Due to the way it is written atm it would take longer to add the api function in than it has done to adjust the timings, as they are used in an odd way in multiple places in the modules. The test I ran on PTS today worked as expected and Gina has got back to me to confirm that the EU trader will be at 14:00 UTC on Tuesdays (not 13:00 UTC as mentioned in the support article). I am running a further test later today and again tomorrow to check that the data is correct saved for donations on a Tuseday based week, but asssuming they both pass, the patch for Shissu should be good to go live. I will update here once the patch is live. @Sharlikran - I am assuming from your reply that MM is going to be showing weekly sales based on a Tuesday to Tuesday week.
Last edited by Splat : 08/04/20 at 12:10 PM.
|
|
![]() |
![]() |
Splat |
View Public Profile |
Send a private message to Splat |
Send email to Splat |
Find More Posts by Splat |
Add Splat to Your Buddy List |
![]() |
||||
However, as I have mentioned the rest of the code when it comes to time is jacked. Sorry for the slang. It has a calculation to adjust the current time. That routine is currently deducting 7 hours. Why would that be needed? The routine is even called "currentTime"! Well if the current time locally for me is 7PM at night why would I want the mod to deduct 7 hours which puts me at noon or 12:00 PM my time. But in the past? Don't get me wrong I am not criticizing you. You asked me for help and I provided the Kiosk fix. I am interested in looking at the rest but it is really confusing code and will take time to analyze. I know you are picking this up because the original author has not made updates and that's great. I know many people that use it. I am sorry if the code is confusing it seems confusing to me also. So when I make comments it's directed at the code, not at you Splat. The API has simply been updated over the last 4 years and new features are there to avoid unnecessary calculations. It's just a matter of knowing what they are. I am very new to this and only learned about the Kiosk times being provided directly from Zenimax. There are probably other features that could be updated as well.
Last edited by Sharlikran : 08/04/20 at 11:51 AM.
|
||||
![]() |
![]() |
Sharlikran |
View Public Profile |
Send a private message to Sharlikran |
Send email to Sharlikran |
Find More Posts by Sharlikran |
Add Sharlikran to Your Buddy List |
![]() |
|
|
Ok, time for an update and a bit of clarification on a few things.
ATM the exact change of timings for the EU server is a bit of a mystery as the info that ZOS published contradicts itself. The new date for the trader bid will be Tuesday but its unclear if it will be 13:00 or 14:00 UTC - I have asked ZOS for clarification. Despite the PTS being on an EU character copy it appears (from the current trader countdown on PTS) that they are testing the NA trader bid timings on PTS today so I am not able to test the EU and confirm anything. We will be seeing a 9 day week this week (from the 2nd to the 11th August) so any addons using 'this week', 'weekly', 'since kiosk' etc will be incorrect by 2 days so that is worth bearing in mind wehn looking at promotions/demotions etc I have made all neccessary changes to Shissu for it to work correctly on the new timings (currently guessing at a 14:00 UTC time) and a patch will be released once I am able to confirm the exact timing. Once we have passed the trader bid on PTS today, and once I have a reply from ZOS on exactly whe the new timings are, I will publish the new patch. This will hopefully be before next Sunday but is dependant on testing and ZOS providing the correct info to me. I will add that I have been in contact with a number of GM's to discuss if it is more sensible to keep a regular week instead of, or alongside, the new Tuesday week. It is 50/50 atm with those I have discussed this with and is to some degree dependant on what other addons decide to do, especially for those guilds running a X amount of sales or X donation style quota. Implementing this is a bit of a pain atm and is hard to do and test on PTS without the correct data over the new time periods but is something I can look into once we are up and running on the new timing system.
Last edited by Splat : 08/04/20 at 05:08 AM.
|
![]() |
![]() |
Splat |
View Public Profile |
Send a private message to Splat |
Send email to Splat |
Find More Posts by Splat |
Add Splat to Your Buddy List |
![]() |
|
Forum posts: 0
File comments: 12
Uploads: 0
|
Hi there - first off, really terrific add-on and thanks for keeping it up-to-date!
ZoS is changing the guild trader kiosk window (in case not seen, ZoS is moving the kiosk change-over to Tuesday - so kiosks won this week will continue past the usual Sunday window to Tuesday 11th; from that point the bids will close each Tuesday). I was wondering :- 1. Do you have a plan re. how that might be addressed within the add-on, if at all? Appreciate you got no notice!! 2. If you're taking requests, it would be GREAT to have an option in the drop-downs or via a toggle to show data (e.g. donations) by either the "kiosk reset" window, or based on a calendar week (i.e. Monday to Sunday) (where you can select "last week", "since kiosk" etc). Personally, I'd much rather maintain a calendar week for my guild members, Monday 00:01 to Sunday 23:59 and I'll worry about when ZoS wants me to bid. Appreciate it! ![]() |
![]() |
![]() |
age |
View Public Profile |
Send a private message to age |
Send email to age |
Find More Posts by age |
Add age to Your Buddy List |
![]() |
|
There is way more to the time management then just those two routines. This is a bit too much to work on I'm afraid. It would need quite a lot of work. So those two routines only return the proper kiosk time in seconds. So the countdown clock will be correct. Anything is anyone's guess
|
|
![]() |
![]() |
Sharlikran |
View Public Profile |
Send a private message to Sharlikran |
Send email to Sharlikran |
Find More Posts by Sharlikran |
Add Sharlikran to Your Buddy List |
![]() |
|
I didn't like how MM did things but it made sense because it used the entire value from the game's internal way of managing time. It usually is not good practice to make your own time calculations and use the OS because it will account for Leap Year and Daylight Savings time and so on.
This just does too much for me to know if it will be 100% reliable. I added comments in case someone else wants to look at it. I override the calculated value with the value from the server, or Zenimax. The current flip seems to be happening again on Sunday and no idea if they will flip things on Tuesday and have a 2 day week or extend it to have a 9 day week. Either way you don't have to adjust anything. You can pretty much ignore the last lines for when the guild store is offline because if it is then you can't request guild history anyway. So all that does is return a week in seconds so the calculations don't cause Lua errors. What should happen is if Zenimax keeps it at Sunday then this will be correct. If they decide to change it to a 9 day week and flip on Tuesday this will also be correct as long as their server transmits the proper time to be Aug 11 19:00 UTC which is about 3pm EDT / 2pm EST according to the post. functions.lua Code:
-- Zeit bis zum nächsten Gildenhändler??? -- Time to the next guild trader function _func.getKioskTime(which, additional, day) local hourSeconds = 60 * 60 local daySeconds = 60 * 60 *24 local weekSeconds = 7 * daySeconds local additional = additional or 0 -- Erste Woche 1970 beginnt Donnerstag -> Verschiebung auf Gebotsende -- First week of 1970 begins Thursday -> postponement to end of bid local firstWeek = 1 + (3 * daySeconds) + (19 * hourSeconds) local currentTime = _func.currentTime() -- Anzahl der Wochen seit 01.01.1970 -- Number of weeks since 01/01/1970 local week = math.floor(currentTime / weekSeconds) + additional local beginnKiosk = firstWeek + (weekSeconds * week) + 60 * 60 --[[ Rather then eliminate all of the code I will add this 1: This fuction is not called using other parameters such as additional or day. If that changes this will not work 2: _func.getKioskTime function gets the ammount of seconds remaining until the next trader flip. ]]-- local _, weekCutoff = GetGuildKioskCycleTimes() beginnKiosk = weekCutoff -- Gebots Ende -- Bidding end if (which == 1) then beginnKiosk = beginnKiosk - 300 -- Ersatzhändler -- Replacement dealer elseif (which == 2) then beginnKiosk = beginnKiosk + 300 end -- Restliche Zeit in der Woche -- Remaining time in the week local restWeekTime = beginnKiosk - GetTimeStamp() --[[ if (day) then restWeekTime = beginnKiosk end ]]-- if restWeekTime < 0 then restWeekTime = 7 * 86400 -- one week if guild store is offline end return restWeekTime end Code:
function _addon.getKioskTime(which) local hourSeconds = 60 * 60 local daySeconds = 60 * 60 *24 local weekSeconds = 7 * daySeconds -- Erste Woche 1970 beginnt Donnerstag -> Verschiebung auf Gebotsende -- First week 1970 beginning Thursday -> postponement to end of bid local firstWeek = 1 + (3 * daySeconds) + (19 * hourSeconds) local currentTime = _addon.currentTime() -- Anzahl der Wochen seit 01.01.1970 -- Number of weeks since 01/01/1970 local week = math.floor(currentTime / weekSeconds) local beginnKiosk = firstWeek + (weekSeconds * week) + 60 *60 --[[ Rather then eliminate all of the code I will add this 1: This fuction is not called using other parameters such as additional or day. If that changes this will not work 2: _addon.getKioskTime function gets the ammount of seconds remaining until the next trader flip. ]]-- local _, weekCutoff = GetGuildKioskCycleTimes() beginnKiosk = weekCutoff -- Gebots Ende -- Bidding end if (which == 1) then beginnKiosk = beginnKiosk - 300 -- Ersatzhändler -- Replacement dealer elseif (which == 2) then beginnKiosk = beginnKiosk + 300 end -- Restliche Zeit in der Woche -- Remaining time in the week local restWeekTime = beginnKiosk - GetTimeStamp() if restWeekTime < 0 then restWeekTime = 7 * 86400 -- one week if guild store is offline end return restWeekTime end |
|
![]() |
![]() |
Sharlikran |
View Public Profile |
Send a private message to Sharlikran |
Send email to Sharlikran |
Find More Posts by Sharlikran |
Add Sharlikran to Your Buddy List |
![]() |
|
|
I am aware of the upcoming change to the trader bid timings, its not fully clear yet on how this will impact many addons, or on the best solution, given the new week would effectively be starting on a Tuesday morning.
|
![]() |
![]() |
Splat |
View Public Profile |
Send a private message to Splat |
Send email to Splat |
Find More Posts by Splat |
Add Splat to Your Buddy List |
![]() |
|
Forum posts: 0
File comments: 242
Uploads: 0
|
Hey, in case you hadn't heard, ZOS is changing the date and time for when the traders will flip effective starting August 11. I'm not sure if there is anything in the code that references the current time that would need to be updated. Gold made since trader flip?
Last edited by wolfstar : 07/31/20 at 09:53 PM.
|
![]() |
![]() |
wolfstar |
View Public Profile |
Send a private message to wolfstar |
Send email to wolfstar |
Find More Posts by wolfstar |
Add wolfstar to Your Buddy List |
![]() |