Quantcast
Download
(6 Kb)
Download
Updated: 01/02/22 07:56 AM
Patch for:
Fisherman's Friend.
Pictures
File Info
Compatibility:
Deadlands (7.2.5)
Updated:01/02/22 07:56 AM
Created:01/17/21 03:58 PM
Monthly downloads:795
Total downloads:5,708
Favorites:19
MD5:
7.2.5
Fisherman's Friend - Update  Popular! (More than 5000 hits)
Version: 1.4.5
by: Sem [More]
Fisherman's Friend automatically equips the appropriate bait when looking at a fishing hole and changes bait when you run out of one type.
May inform you briefly if no appropriate bait is available; disabled by default.


###
This is an updated version fixing some bugs and adding language support.
The AddOn is originally authored by Zention.
###


Defaults to using the alternate baits first that you receive from fishing (chub, shad, fish roe, and minnow).
Alternate bait increases the chance to catch rare fish.
Settings menu has an option to use the regular baits first instead (worms, guts, insect parts, and crawlers).


Current languages supported: EN, DE, RU, FR
You can help with translation. Just give me all the names for fishing holes for your language and I can add them to the list.


Attention: If you substitute Fisherman 1.1 by Zention with this Patch the savedvar has to be deleted. Usually it is located in:
"C:\Users\< username >\Documents\Elder Scrolls Online\live\SavedVariables\FishermansFriend.lua"
1.4.5
- fix broken addon folder name

1.4.4
- update API version
- fix french again

1.4.3
- update API version

1.4.2
- downgrade calculation of bait quantity

1.4.1
- fix french

1.4.0
- change the calculation of bait quantity
- add french language support, merci Frackou

1.3.3
- add russian language support, спасибо Aspect

1.3.2
- update API version
- add message (optional) if no appropriate bait is available
- change variable names internally

1.3.1
- simplifiy menu

1.3.0
- remove unused code
- use preHookHandler instead of hooking into ZOS functions by hand

1.2.0
- bugfix: equipping bait at start now works
- bugfix: changing bait when the other type is empty now works
- language support for english and german
- improved code readability
Archived Files (8)
File Name
Version
Size
Uploader
Date
1.4.4
5kB
Sem
11/21/21 12:05 PM
1.4.3
5kB
Sem
08/29/21 01:37 AM
1.4.2
5kB
Sem
08/28/21 08:20 AM
1.4.1
5kB
Sem
08/20/21 09:56 AM
1.3.3
4kB
Sem
08/10/21 12:06 PM
1.3.2
4kB
Sem
03/23/21 07:26 AM
1.3.1
3kB
Sem
02/21/21 06:22 AM
1.2.0
5kB
Sem
01/17/21 03:58 PM


Post A Reply Comment Options
Unread 08/20/21, 09:58 AM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Originally Posted by Frackou
About last version and french you have to use UTF-8 instead ANSI cause of the "é, è, ê, à" etc or they are showed as a square.
This was one of two problems with the french translation which created the bug. Since the addon compares the full string of the fishing hole you had to send me the full translated string. I added the missing words and now it works in french as well. I can't vouch for mystic and oily water since I dont have the addon.
Last edited by Sem : 08/20/21 at 09:59 AM.
Report comment to moderator  
Reply With Quote
Unread 08/20/21, 07:54 AM  
Frackou
 
Frackou's Avatar

Forum posts: 2
File comments: 62
Uploads: 0
Originally Posted by Sem
I tested this today and can't reproduce your findings. For me everything works.
Same with votans new function, which I will use in the future, because it is way more elegant.

Originally Posted by Frackou
maybe u should work together on it
I think those two addons have their own use cases. In fact I am using both at the same time.
it's weird i don't know why it doesn't work

About last version and french you have to use UTF-8 instead ANSI cause of the "é, è, ê, à" etc or they are showed as a square.
Last edited by Frackou : 08/20/21 at 07:55 AM.
Report comment to moderator  
Reply With Quote
Unread 08/20/21, 01:49 AM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
I tested this today and can't reproduce your findings. For me everything works.
Same with votans new function, which I will use in the future, because it is way more elegant.

Originally Posted by Frackou
maybe u should work together on it
I think those two addons have their own use cases. In fact I am using both at the same time.
Report comment to moderator  
Reply With Quote
Unread 08/13/21, 04:18 PM  
Frackou
 
Frackou's Avatar

Forum posts: 2
File comments: 62
Uploads: 0
and mmm votan fisherman already have this option (who is working but i never activated it, infact i discovered this option in fisherman when i installed yours and taking a look on my other fishing addons, in case it could make a conflict lol) , it just do not allow the way to choose the alternative one, and ok maybe not on a new hole if i read well) on my side i just change manually baits btw, but i wanted to translate it at first , maybe u should work together on it
Last edited by Frackou : 08/13/21 at 04:28 PM.
Report comment to moderator  
Reply With Quote
Unread 08/13/21, 09:24 AM  
votan
 
votan's Avatar
AddOn Author - Click to view AddOns

Forum posts: 553
File comments: 1509
Uploads: 37
@Sem
HasCraftBagAccess() checks for permission to put something *into* the craft bag. Not having that permission does not mean the craft bag is empty.

May this is easier:
Create an itemLink for the itemId and use
GetItemLinkStacks(itemLink)

Add the first and third return result.
__________________
@votan73 (EU - megaserver)
Last edited by votan : 08/13/21 at 09:24 AM.
Report comment to moderator  
Reply With Quote
Unread 08/13/21, 07:54 AM  
Frackou
 
Frackou's Avatar

Forum posts: 2
File comments: 62
Uploads: 0
Originally Posted by Sem
Originally Posted by Frackou
No it changes nothing
Thats not good.

You can try and change that function so that it will allways use BAG_VIRTUAL (which should be the craft bag).

Change this:
Lua Code:
  1. local quantity = 0
  2.     if HasCraftBagAccess() then
  3.         quantity = CountBag(BAG_VIRTUAL, itemId) + CountBag(BAG_BACKPACK, itemId)
  4.     else
  5.         quantity = CountBag(BAG_BACKPACK, itemId)
  6.     end
  7.     return quantity
to this:
Lua Code:
  1. local quantity = 0
  2.         quantity = CountBag(BAG_VIRTUAL, itemId) + CountBag(BAG_BACKPACK, itemId)
  3.     return quantity
Still not work and it even doesn't work when i put baits in my bag
Report comment to moderator  
Reply With Quote
Unread 08/12/21, 01:42 PM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Originally Posted by Frackou
No it changes nothing
Thats not good.

You can try and change that function so that it will allways use BAG_VIRTUAL (which should be the craft bag).

Change this:
Lua Code:
  1. local quantity = 0
  2.     if HasCraftBagAccess() then
  3.         quantity = CountBag(BAG_VIRTUAL, itemId) + CountBag(BAG_BACKPACK, itemId)
  4.     else
  5.         quantity = CountBag(BAG_BACKPACK, itemId)
  6.     end
  7.     return quantity
to this:
Lua Code:
  1. local quantity = 0
  2.         quantity = CountBag(BAG_VIRTUAL, itemId) + CountBag(BAG_BACKPACK, itemId)
  3.     return quantity

Originally Posted by Frackou
anyway here the french translation
Thank you very much! Gonna add this soon.
Report comment to moderator  
Reply With Quote
Unread 08/12/21, 01:28 PM  
Frackou
 
Frackou's Avatar

Forum posts: 2
File comments: 62
Uploads: 0
Originally Posted by Sem
Originally Posted by Frackou
hi, it looks it doesn't see baits in eso+ bag
Hey, I can't debug this since I don't have the craft bag. But I have a clue on the problem.
Can you please change your addon accordingly and report if it is fixed:

In the file "C:\Users\< your username >\Documents\Elder Scrolls Online\live\AddOns\FishermansFriend\FishermansFriend.lua"
change the line 192 (add brackets)
from if HasCraftBagAccess then to if HasCraftBagAccess() then
and restart the game.
No it changes nothing

anyway here the french translation

Code:
ZO_CreateStringId("FISHERMANSFRIEND_LAKE_FISHING_HOLE", "Lacustre")
ZO_CreateStringId("FISHERMANSFRIEND_SALT_FISHING_HOLE", "Eau de mer")
ZO_CreateStringId("FISHERMANSFRIEND_MYST_FISHING_HOLE", "Mystique")
ZO_CreateStringId("FISHERMANSFRIEND_FOUL_FISHING_HOLE", "Sale")
ZO_CreateStringId("FISHERMANSFRIEND_OILY_FISHING_HOLE", "Huileux")
ZO_CreateStringId("FISHERMANSFRIEND_RIVR_FISHING_HOLE", "Rivière")

ZO_CreateStringId("FISHERMANSFRIEND_CNF_DESCRIPTION", "Fisherman's Friend permet d'équiper automatiquement l'appât approprié lorsque vous regardez un trou de pêche et d'en changer lorsque vous manquez d'un type. Ci-dessous, vous pouvez choisir si vous souhaitez ou non utiliser d'abord les appâts alternatifs (Shad, Chevesne, Œufs de poisson et Méné) plutôt que les appâts ordinaires (Morceaux d'insectes, Vers, Rampants, Entrailles) ainsi qu'afficher un message vous indiquant que vous n'avez pas l'appât approprié dans votre sac.")
ZO_CreateStringId("FISHERMANSFRIEND_CNF_SET", "Utiliser un appât de meilleur qualité en premier :")
ZO_CreateStringId("FISHERMANSFRIEND_CNF_MSG", "Indiquer si vous n'avez pas l'appât approprié :")
ZO_CreateStringId("FISHERMANSFRIEND_NO_BAIT", "L'appât approprié n'est pas disponible dans votre sac!")
ZO_CreateStringId("FISHERMANSFRIEND_NO_BAIT_RST", "Maintenir pour sélectionner un appât")
Report comment to moderator  
Reply With Quote
Unread 08/12/21, 01:14 PM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Originally Posted by Frackou
hi, it looks it doesn't see baits in eso+ bag
Hey, I can't debug this since I don't have the craft bag. But I have a clue on the problem.
Can you please change your addon accordingly and report if it is fixed:

In the file "C:\Users\< your username >\Documents\Elder Scrolls Online\live\AddOns\FishermansFriend\FishermansFriend.lua"
change the line 192 (add brackets)
from if HasCraftBagAccess then to if HasCraftBagAccess() then
and restart the game.
Report comment to moderator  
Reply With Quote
Unread 08/12/21, 12:31 PM  
Frackou
 
Frackou's Avatar

Forum posts: 2
File comments: 62
Uploads: 0
hi, it looks it doesn't see baits in eso+ bag
Last edited by Frackou : 08/12/21 at 01:18 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: