Download
(34 Kb)
Download
Updated: 07/12/23 01:15 AM
Pictures
File Info
Compatibility:
Necrom (9.0.0)
Updated:07/12/23 01:15 AM
Created:03/08/21 06:02 AM
Monthly downloads:867
Total downloads:142,746
Favorites:190
MD5:
Categories:Character Advancement, TradeSkill Mods, Miscellaneous, Utility Mods
Jack of all Trades - Automatic CP Respec  Popular! (More than 5000 hits)
Version: 1.2.29
by: CyberOnEso, Kyzeragon

Automatically adjust your green champion bar depending on what you want to achieve

New with V.1.2 Adjust which slot each star gets slotted into.

Crafting
  • Automatically slots Master Gatherer and Plentiful Harvest when you start harvesting a crafting node.
  • Automatically slots Meticulous Disassembly when you start crafting, ensuring you always get optimal refining results!
  • Also works with the new deconstruction assistant.
Looting
  • Automatically slots Treasure Hunter, and Homemaker whenever you are looting the relevant container.
Fishing
  • Slots Reel Technique and Angler's Instincts whenever you start fishing.
Thieving
  • Slots Infamous whenever you interact with a fence, helping you always get the best selling price.
  • Slots Cutpurse's Art whenever you pickpocket someone.
Riding
  • Slots Gifted Rider and War Mount whenever you mount up!
Miscellaneous
  • Slots Professional Upkeep when you talk with a merchant, ensuring you always get your gear repaired for less!
  • Slots rationer whenever you switch quick slot slots!

Optional Features
  • Get a notification whenever any skill you wish to be notified of is slotted
  • Receive a warning message whenever you don't have enough points into a star for it to be automatically slotted
  • Disable automatically slotting any skill you wish
  • Change which slot any stars are slotted into.
  • Slot rationer whenever you port into nBRP.
  • A bunch more intricacies to customize it to your every desire.


Jack of all Trades addon will not respec your champion points, and will not charge you 3000 gold etc.
It will only equip the skills if you have enough points into them already.
It is intended to be a seamless quality of life improvement.

Full German, French, Russian and Spanish translations are available.
V 1.2.29
  • Fixed slotting for thieves troves. Thanks lancerchan!
V.1.2.28
  • Fixed error / interact CP not slotting for Necrom
  • I (@Kyzeragon) will be maintaining the addon to fix issues, so I most likely won't be adding new features unless ZOS adds new green CP
V.1.2.27
  • Added Japaneese translation. Massive thanks to Snorunt361!!
V.1.2.26
  • Fixed bug where Rationer and Liquid Efficency were not slotting in High Isle. Thanks Kyzeragon!
  • Fixed bug where harvesting water plants was not slotting Master Gatherer and Plentiful Harvest when playing in German. Thanks Schrappe!
V.1.2.25
  • Fixed bug where Treasure Hunrter was being slotted when interacting with crafting stations. Thanks Kyzeragon & Caaraamon
V.1.2.24
  • Added support for the deconstruction assistant. Thanks Kyzeragon
  • Improved robustness of the interact key text checking. Thanks to IsJustaGhost
V.1.2.23
  • Added toggle to automatically allocate points into stars, which is disabled by default. Thanks m-ree.
V.1.2.22
  • If you have the points to spare Jack of all Trades will slot the CP Star and all pre-requisite stars that are required to slot the star, whilst spending the minimum amount of points to do so. Real-world application of Dijkstra's algorithm!
  • Improved cooldown code to ensure that the cooldown is not set whilst assigning a start to a slot for the first time.
  • These features may cause issues as they can be kind of complex, if they cause any issues for you please let me know ASAP and I will try to fix it as soon as I can.
V.1.2.21
  • Fixed an issue where warning text would be shown in no- cp environments. Thanks Yoav!
V.1.2.20
  • API bumb to Deadlands
V.1.2.19
  • Major additions to the Spanish Translations! Thank you very much loneloba/ Inval1d for these, they are greatly appreciated.
  • Improved localization by adding more strings to language files.
V.1.2.18
  • Added a setting, which is enabled by default, to automatically slot Rationer when entering nBRP, to make sure you make the most out of your ult pots.
V.1.2.17
  • Fixed a bug where the treasure hunter CP would not get slotted when porting into a dungeon.
V.1.2.16
  • Fixed a bug where warning messages shown as an alert would cause an error. Thanks Yoav!
V.1.2.15
  • Added sustaining shadows to the menu to allow you to select where the skill should be slotted.
V.1.2.14
  • Added optional automatic slotting of Sustaining Shadows. Thank you A_Darklore for the suggestion!
  • Fixed an issue with the German client where the addon sometimes would not realise you had been collecting resources. Thank you Irniben!
  • API bump to Waking Flame
V.1.2.13
  • Fixed an issue where the folder was called JackOfAllTrades-main, this may cause unexpected side effects if it does please redownload it. Thank you Anceane!
V.1.2.12
  • Added a new sub- menu category for harvesting nodes. Thank you Sonwon!
V.1.2.11
  • Improved notifications by allowing users to select whether to show the notification/ warning as a top-right alert instead of in the chat. Thank you Saenic!
  • Added ability to remove the icon from notification if the user wishes.
V.1.2.10
  • API bumb to Blackwood
V.1.2.9
  • Fixed an issue where the Jack of all Trades CP cooldown would not be reset upon changing zones. Which it is. Thank you Kyzeragon!!
V.1.2.8
  • Added option to always post a notification when the CP cooldown ends. Thank you LoneStar2911!
V.1.2.7
  • Added additional French translations provided by Jakez31. Thank you very much!!
V.1.2.6
  • Added additional French translations provided by Jakez31. Thank you very much!!
  • Fixed a bug where "CP Cooldown complete" could show up multiple times. Thank you LoneStar2911!
  • Added localization support for more strings
V.1.2.5
  • Added the option to post a notification to chat when the cooldown is complete if you have disabled 'Automatically slotting stars after the cooldown ends' Thank you LoneStar2911!
  • Updated the menu text
V.1.2.4
  • Added menu option to enable automatically slotting treasure hunter (and homemaker if you have them as a pair) whenever you enter a dungeon. Thank you Cruxa
V.1.2.3
  • Fixed an issue where Gifted Rider and War Mount weren't working as intended. Thank you Provinzheld, FrostByghte and Baertram
V.1.2.2
  • Fixed how checking if you have the required amount of points is calculated. Thanks Baertram!
V.1.2.1
  • Fixed an issue that caused the cooldown to break, thus not allowing any stars to be slotted after an initial change, thanks Kyzeragon!
  • If you are experiencing any issues make sure you are not on V.1.2.0.
V.1.2.0
  • Added a menu option to change which skills will be slotted where.
  • Added riding stars (Gifted Rider and War Mount). These are disabled by default as I don't want to put people on cooldown too often. I still recommend you slot the movement speed passives in slot 1 and 2. But it's your call if you want to use them.
  • Fixed an issue that was causing the cooldown to not start if the CP was triggered by other addons. Thank you Kyzeragon!
V.1.1.19
  • Added a system that will ensure that pairs of passives are slotted correctly even if one is slotted in the intended slot of another.
V.1.1.18
  • Changed the priority of gathering passives to prioritize Plentiful Harvest.
  • I am going to work on a more robust system that will dynamically change the slotting of stars if you have them in the unintended order.
V.1.1.17
  • Will no longer slot Professional Upkeep if your repair cost is 0.
  • Fixed an issue causing notifications to not fully work as intended.
V.1.1.16
  • Gathering stars will no longer be slotted while in Stone Garden, as the gathering passives do not affect 'Gloomspore Agaric'. Thank you Scrofula!
V.1.1.15
  • Added the option to not Liquid Efficiency if the potion that is selected is a trash pot. Thank you Kyzeragon!
V.1.1.14
  • Will no longer slot treasure hunter when unlocking a door to a house, thanks NettleCarrier.
  • Fixed a bug where sometimes treasure hunter and homemaker slotting as a pair wasn't acting as intended. Thank you @DeadSoon!
  • Added more containers where homemaker should be slotted.
V.1.1.13
  • Added the option to disable slotting Meticulous Dissasembly whilst doing writs. Thank you gabbo1928.
V.1.1.12
  • Added the ability to disable automatically slotting queued skills after the cooldown ends. Thank you Cruxa for the suggestion
  • Changed Plentiful Harvest to slot 4 as it is the more important of the two. (Master Gatherer will now be slotted in slot 3)
V.1.1.11
  • Improved the fix substantially, should now only put the user on cooldown when they modify the hotbar.
V.1.1.10
  • Provided a temporary fix for overly aggressive cooldown blocking, if you disable the 'Show alert when attempting to slot CP on cooldown' box in the menu you will be able to use the less aggressive cooldown blocking. Thank you Kyzeragon
V.1.1.9
  • Added Russian translations, thank you Lyniss!
  • Added the option for Treasure Hunter and Homemaker to be slotted as a pair. Thank you Scrofula!
  • Fixed an issue where Liquid Efficiency wasn't being slotted as intended, also added the options for Liquid Efficiency to the menu
V.1.1.8
  • Added liquid efficency. Thank you Lumber!
  • Fixed an issue where CP stars would occasionally be reslotted if you already had them slotted.
  • When you are on CP cooldown a more helpful cooldown text will be shown in the top right, rather than in chat.
V.1.1.7
  • Rationer will not only be slotted when switching to a food/ drink item. Thank you FormlessOne
  • Added more lootables for homemaker to slot with, added the German translations for all homemaker lootables. Thank you @DeadSoon!
  • Gathering stars will not be slotted when looting Psijic Portals anymore. Thank you M-ree!
V.1.1.6
  • Fixed an issue where gathering stars would be slotted when looting corpses on occasion.
V.1.1.5
  • Professional upkeep will no longer be slotted when talking to Nuzhimeh
  • Attempted to fix the bug where notification messages would not be correct. Please let me know if the notification messages are still sometimes incorrect.
V.1.1.4
  • Fixed a bug that caused CP stars to not be correctly slotted
V.1.1.3
  • Added an option to disable homemaker when looting corpses (On by default)
  • Fixed the bug where Rationer would be slotted regardless of if you disabled it.
  • Fixed the bug where the notification would sometimes not post when a skill is slotted
V.1.1.2
  • Added togglable to show/ hide the default ZOS Alert Text when you attempt to slot CP whilst on cooldown
  • Will send a notification when the skill is actually slotted if a skill gets queued to be slotted in X seconds.
  • Fixed spelling issue on the CP cooldown text
V.1.1
  • Rewrote the addon from scratch to allow it to obey the 30-second cooldown on changing CP's
  • The addon will now only slot skills in the 3rd and 4th slot on your champion bar. This allows you to keep slots 1 and 2 the same, I suggest you slot 'Steed's Blessing' and 'Gifted Rider' in slots 1 and 2.
Optional Files (0)


Archived Files (49)
File Name
Version
Size
Uploader
Date
1.2.28
34kB
Kyzeragon
06/11/23 02:18 PM
1.2.27
34kB
CyberOnEso
01/22/23 02:31 PM
1.2.26
30kB
CyberOnEso
06/21/22 04:31 AM
1.2.25
30kB
CyberOnEso
03/30/22 12:26 PM
1.2.24
30kB
CyberOnEso
03/30/22 10:34 AM
1.2.23
30kB
CyberOnEso
12/25/21 02:52 PM
1.2.22
29kB
CyberOnEso
12/24/21 02:21 PM
1.2.21
28kB
CyberOnEso
11/06/21 01:33 PM
1.2.20
28kB
CyberOnEso
10/31/21 03:58 PM
1.2.19
29kB
CyberOnEso
10/23/21 01:55 PM
1.2.18
27kB
CyberOnEso
10/16/21 06:20 PM
1.2.17
27kB
CyberOnEso
09/17/21 07:48 PM
1.2.16
27kB
CyberOnEso
09/09/21 04:37 AM
1.2.15
27kB
CyberOnEso
08/25/21 05:42 AM
1.2.14
27kB
CyberOnEso
08/24/21 04:43 AM
1.2.13
27kB
CyberOnEso
06/19/21 08:52 AM
1.2.12
27kB
CyberOnEso
06/19/21 06:15 AM
1.2.11
26kB
CyberOnEso
06/14/21 05:18 PM
1.2.10
25kB
CyberOnEso
06/01/21 06:46 PM
1.2.9
25kB
CyberOnEso
05/07/21 05:01 AM
1.2.8
25kB
CyberOnEso
04/23/21 06:18 PM
1.2.7
25kB
CyberOnEso
04/18/21 03:22 PM
1.2.6
24kB
CyberOnEso
04/18/21 05:16 AM
1.2.5
23kB
CyberOnEso
04/17/21 10:47 AM
1.2.4
23kB
CyberOnEso
04/10/21 06:22 AM
1.2.3
23kB
CyberOnEso
04/02/21 07:13 AM
1.2.2
23kB
CyberOnEso
03/25/21 06:07 PM
1.2.1
23kB
CyberOnEso
03/23/21 02:13 AM
1.2.0
23kB
CyberOnEso
03/22/21 05:50 PM
1.1.19
21kB
CyberOnEso
03/20/21 06:59 AM
1.1.17
21kB
CyberOnEso
03/19/21 06:11 PM
1.1.16
21kB
CyberOnEso
03/19/21 06:18 AM
1.1.15
21kB
CyberOnEso
03/18/21 07:24 PM
1.1.14
21kB
CyberOnEso
03/18/21 10:27 AM
1.1.13
21kB
CyberOnEso
03/17/21 12:04 PM
1.1.12
21kB
CyberOnEso
03/17/21 10:37 AM
1.1.11
20kB
CyberOnEso
03/17/21 05:48 AM
1.1.10
20kB
CyberOnEso
03/17/21 05:23 AM
1.1.9
20kB
CyberOnEso
03/16/21 10:40 AM
1.1.8
20kB
CyberOnEso
03/15/21 05:54 PM
1.1.7
20kB
CyberOnEso
03/14/21 07:55 AM
1.1.6
19kB
CyberOnEso
03/13/21 03:36 PM
1.1.5
19kB
CyberOnEso
03/12/21 04:49 PM
1.1.4
19kB
CyberOnEso
03/12/21 11:36 AM
1.1.3
19kB
CyberOnEso
03/12/21 10:54 AM
1.1.2
18kB
CyberOnEso
03/11/21 05:13 AM
1.1.1
178kB
CyberOnEso
03/10/21 08:50 AM
1.0.1
362kB
CyberOnEso
03/08/21 09:51 AM
1
362kB
CyberOnEso
03/08/21 06:02 AM


Post A Reply Comment Options
Unread 03/26/21, 10:07 AM  
jpor

Forum posts: 3
File comments: 47
Uploads: 0
I am using v.1.2.2 and I have "Show warning if you do not have enough points allocated..." set to OFF.

I do not have Meticulous purchased and I have less than 50 green points available for all of my toons.

When I do writs, I get these chat messages:
:Not enought points. Min: 50 Curreont 0.

I think the warnings only appear for cloth/metal/wood/jewelry writs.

These warnings show multiple times per writ.

This isn't a big deal at all, just an FYI.
Report comment to moderator  
Reply With Quote
Unread 03/25/21, 06:07 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Hey'a! This should be fixed with V.1.2.2 Thank you very much for letting me know!

Please let me know if the issue persists!

Originally Posted by Baertram
Thanks for your addon!

Somehow got a bug as it seems:
I always get the info that I did not invest enough points into the gifted rider CPs to slot it.
But it's at max 100, and I'm able to manually slot it.



This message appears on mounting:
Code:
||t24:24:esoui/art/champion/champion_points_stamina_icon-hud-32.dds||tDu hast nicht genügend Punkte in den Stern Begabter Reiter investiert, um zu aktivieren.|r

And there is no cooldown which prevents the slot.
German client, if this is imporant.
Report comment to moderator  
Reply With Quote
Unread 03/25/21, 10:37 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4964
File comments: 6032
Uploads: 78
Thanks for your addon!

Somehow got a bug as it seems:
I always get the info that I did not invest enough points into the gifted rider CPs to slot it.
But it's at max 100, and I'm able to manually slot it.



This message appears on mounting:
Code:
||t24:24:esoui/art/champion/champion_points_stamina_icon-hud-32.dds||tDu hast nicht genügend Punkte in den Stern Begabter Reiter investiert, um zu aktivieren.|r

And there is no cooldown which prevents the slot.
German client, if this is imporant.
Last edited by Baertram : 03/25/21 at 10:39 AM.
Report comment to moderator  
Reply With Quote
Unread 03/23/21, 12:05 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Okay, awesome! Thank you for letting me know.

If it causes any inconsistencies in the future then I will be happy to look back into it and try to solve it for you!
Originally Posted by jpor
With v.1.2.1 I did 5-6x treasure chests and the 4th slot MG/TH/MG slotting worked perfectly, thank you!

Steeds - Gifted - Plentiful - Master Gatherer >> start
>> open treasure chest
Steeds - Gifted - Plentiful - Treasure Hunter >> open chest
>> harvesting is slow/normal and gets me a warning:
>> Master Gatherer will be slotted in X seconds.
>> 30secs pass: Master Gatherer gets re-slotted
Steeds - Gifted - Plentiful - Master Gatherer >> correct re-slotting
Report comment to moderator  
Reply With Quote
Unread 03/23/21, 11:29 AM  
jpor

Forum posts: 3
File comments: 47
Uploads: 0
With v.1.2.1 I did 5-6x treasure chests and the 4th slot MG/TH/MG slotting worked perfectly, thank you!

Steeds - Gifted - Plentiful - Master Gatherer >> start
>> open treasure chest
Steeds - Gifted - Plentiful - Treasure Hunter >> open chest
>> harvesting is slow/normal and gets me a warning:
>> Master Gatherer will be slotted in X seconds.
>> 30secs pass: Master Gatherer gets re-slotted
Steeds - Gifted - Plentiful - Master Gatherer >> correct re-slotting
Report comment to moderator  
Reply With Quote
Unread 03/23/21, 10:49 AM  
satoi

Forum posts: 0
File comments: 7
Uploads: 0
Originally Posted by CyberOnEso
Hey'a, my sincere apologies for this it should be fixed now, with V.1.2.1!

Thank you very much Kyzeragon for finding the fix.
All works fine now. Thank you for fixing it so fast. And thanks to Kyzeragon also.
Report comment to moderator  
Reply With Quote
Unread 03/23/21, 02:14 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Hey'a, my sincere apologies for this it should be fixed now, with V.1.2.1!

Thank you very much Kyzeragon for finding the fix.
Last edited by CyberOnEso : 03/23/21 at 02:14 AM.
Report comment to moderator  
Reply With Quote
Unread 03/23/21, 12:36 AM  
Kyzeragon
 
Kyzeragon's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 268
Uploads: 8
Re: Several stars not slotting

Sending as a new comment in case you miss edit:
Looks like you have an extra instance of setting the cooldown that you didn't remove when adding the other thing I suggested about watching purchase result:

Line 111 of JackOfAllTrades.lua (or somewhere around there, I may have added debug statements so the line might be a bit off):
Code:
if currentCPCooldown == 30 then JackOfAllTrades.isOnCooldown = true end
That line is not needed because StartCooldown() is already setting isOnCooldown = true. If I comment this line out, everything works as expected (so far). It's because isOnCooldown == true so when the code gets to StartCooldown() it skips the rest of the function and does not call into the Update that decrements cooldown.
Last edited by Kyzeragon : 03/23/21 at 12:37 AM.
Report comment to moderator  
Reply With Quote
Unread 03/23/21, 12:29 AM  
Azmodan

Forum posts: 0
File comments: 33
Uploads: 0
Re: Infamous

Originally Posted by satoi
I just noticed a problem with Infamous in Version 1.2.0. The addon wrote in the chat, that Infamous is slotted, but I didn't have the proper amount of bonus in the selling window of the fence. So I checked the slotted perks and they were like before: Homemaker, Treasure, Harvest, Gatherer. I waited, if it was a cooldown problem, but no, the addon wont slot Infamous. And I try to change Infamous in the options to slot in slot 3 (instead of slot 4), but no slotting. It only shows the slotting massage in chat.
I just have the same problem with Meticulous Disassembly. The addon just spam in chat every time I use the station that MD is slottet but actualy it was not slotted. So I try to manual slot it with no luck, cos CP tells me about 30 sec cooldown.
I have to relog and all works as it shoud for now.
Report comment to moderator  
Reply With Quote
Unread 03/23/21, 12:20 AM  
Kyzeragon
 
Kyzeragon's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 268
Uploads: 8
Several stars not slotting

After updating to v1.2.0, a lot of stuff seems to not be working.

Meticulous Disassembly isn't slotting for me when going to a crafting station. It keeps saying "Meticulous Disassembly slotted." in chat, but doesn't actually slot it. My currently slotted stars are 1. Liquid Efficiency 2. Treasure Hunter 3. Homemaker 4. Rationer
I also tried harvesting a node, and it did not slot either of the node-gathering stars, despite displaying in chat that they were slotted.
Manually swapped slot 1 to Gifted Rider, and then selected a potion on my quickslot while still within the 30s cooldown, and chat said Liquid Efficiency slotted but did not slot it again.

I reinstalled through Minion and reloaded UI. Selected a potion and this time Liquid Efficiency did slot automatically, into slot 3. Manually changed back to the original slots I had above, tried to harvest a node again, and chat said the stars slotted but they did not. Going back to a crafting station also said MD slotted but did not.

^ Just dumping the exact steps I did here for now, but I'll look through it and see if I can help find the problem later when I have time.

EDIT: On second pass through, it seems like the FIRST instance of auto swapping works fine after a reload, but not after that. Probably some bad state, possibly the cooldown?

EDIT2: Seems the cooldown is not actually counting down. It is remaining at 30, and the registerforupdate is not getting called at all.

EDIT3: Found the problem and posted it as a new comment so it's not missed.
Last edited by Kyzeragon : 03/23/21 at 12:38 AM.
Report comment to moderator  
Reply With Quote
Unread 03/22/21, 11:42 PM  
xen32
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 104
Uploads: 1
Thanks for slot number feature!
Report comment to moderator  
Reply With Quote
Unread 03/22/21, 09:12 PM  
satoi

Forum posts: 0
File comments: 7
Uploads: 0
Infamous

I just noticed a problem with Infamous in Version 1.2.0. The addon wrote in the chat, that Infamous is slotted, but I didn't have the proper amount of bonus in the selling window of the fence. So I checked the slotted perks and they were like before: Homemaker, Treasure, Harvest, Gatherer. I waited, if it was a cooldown problem, but no, the addon wont slot Infamous. And I try to change Infamous in the options to slot in slot 3 (instead of slot 4), but no slotting. It only shows the slotting massage in chat.

In previous versions Infamous were slotted in slot 4 functionally correct.

Edit: I try to slot Infamous manually, but I can't, because I can't confirm the change. When I wait a minute, I still can't confirm. This applies to all green perks. They were shown correctly, when I leave the green tree window, then enter the window again. But the confirm button still is "open" and the perks didn't function.

Next step I disabled your addon, reload ui. Tried to slot manually and all works fine. Confirm button works. Tried several slotting changes, all works fine.

It seemed to me, that somehow your addon makes a conflict with the confirmation after a change involving Homemaker, Treasure, Harvest and Gatherer. The addon seems to prevent these four changes from being made.

Next step I activated the addon again. Slotting: Homemaker, Treasure, Harvest, Infamous. Gathered a ressource node. Addon changed Infamous to Gatherer in proper way: Homemaker, Treasure, Harvest, Gatherer (the glorious four ). But when I try to manually slot an other perk like Infamous or Friends in Low Places or Disassembly in any slot, than the confirm button problem occurs again. So I have to disable your addon currently, when I want to use other perks then "the glorious four"

I hope, I described the problem in a useful way. And I hope you can fix it soon, I can't play without your addon

Edit 2: activated the addon with slotted Homemaker, Treasure, Harvest, Gatherer. Went to a crafting station. Information in chat: Disassembly slottet. Checkt it: proper exchange from Gatherer to Disassembly. So the automatic change to Disassembly works fine, only the manually change to Disassembly doesn't work.

For other perks like Infamous, neither the automatic nor the manually change works properly.
Last edited by satoi : 03/23/21 at 12:08 AM.
Report comment to moderator  
Reply With Quote
Unread 03/22/21, 08:45 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Re: Re: why does something slot when it is

Originally Posted by iarao
Originally Posted by CyberOnEso
Originally Posted by iarao
already slotted? i then get a cd.

tyty
Thank you for your comment.

Could you explain the scenario that this is happening with?

The addon does do a check that the skill is not already slotted before attempting to slot anything.

Lua Code:
  1. local function isCPSlotted(skillId)
  2.     for index=1, 4 do
  3.         if GetSlotBoundId(index, HOTBAR_CATEGORY_CHAMPION) == skillId then
  4.             if JackOfAllTrades.savedVariables.debug then d("Skill is already slotted so won't reallocate it") end
  5.             return true
  6.         end
  7.     end
  8.     return false
  9. end
  10.  
  11.  
  12. -- Adds the CP node to the queue of stars to be slotted, when the player is off cooldown these stars can be slotted
  13. function JackOfAllTrades.AddCPNodeToQueue(skillId, skillIndex)
  14.  
  15.     -- Check if the skill is already slotted
  16.     if isCPSlotted(skillId) then return false end

The addon only attempts to slot the skill if the 'AddCPNodeToQueue' function returns true.

I am more than happy to look into this issue further if you can provide me with a way to replicate the issue you are having. However, for the meantime please ensure you are using the latest version of the addon.

Many thanks for your feedback
hi. ok here is what happened. i checked to see if my green slots were gtg: the 2 speed ones in slots 1,2; plentiful harvest in slot 3 and master gatherer in slot 4 cuz i would prefer to get more even if it should mean i take longer to harvest. i harvested a wood node and in my chat it said "master gatherer slotted". it was slotted before i harvested and so i am confused by the message. did it slot it into 4 again or was it just telling me that i had put it there?

i'm thinking not as the next toon i tried had the 2 speeds, treasure hunter in 3 and plentiful in 4. harvesting a flower showed "master gatherer slotted" in my chat, which is how it should work. it slotted into 3. so why did i get it on the other toon when it was already slotted? was it cuz it was in slot 4?

third toon: had speedies slotted, then plentiful harvest in 3 and treasure in 4. harvested a wood node, it said master gath slotted and when i looked at the stars, i had master gath slotted in place of treasure chest.

reslotted the chest into 4 and harvested rune. showed mast gath slotting in 18 secs. slotted treasure in 3 and harvest in 4. harvested rune and it said mast gather would slot in 16 secs. then said it was slotted. it was not. found a metal node. it fast harvested like mast gath, but slots still have hunter and harvest, no gatherer. tried a cloth node. same thing: fast gather, 6 mats. plentiful slotted but master gath not slotted.

next toon appears to work properly, but told me harvest was slotted when it switched treasure for gatherer. no mention of gatherer.

i am confused. but i am old, so....

ok new day. toon 5 had fasties, treasure, harvest slotted. harvested a rune and gatherer slotted into 3 and told me in chat, but no mention of cd. this is correct action, right?
I believe that is correct yes. I am happy to look with you if you're confused about something or you think something is not working as intended.

You can quickly contact me on discord Cyber#0042
Last edited by CyberOnEso : 03/22/21 at 08:48 PM.
Report comment to moderator  
Reply With Quote
Unread 03/22/21, 05:51 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Hey'a, I just added a menu option to change where skills are automatically slotted with V. 1.2.0 Hopefully that helps you out!

Originally Posted by xen32
Originally Posted by xen32
I personally really disliked latest change where it slots single star into 3rd slot instead of 4th as before.

The only 'pair' that I have is node yield and speed, others (like fishing and such) I don't have, so my "permanent" setup was:
Steed, Chests, Double Nodes, and 4th is dynamic.

If I just looted a backpack and then went to platinum node, downside would be slower speed, but I could still get 8 platinum out of it, which I'd prefer. Now that it started slotting into third slot, I get no potential double yield.

Should I just change double node star into 4th slot now? I want these three to be sort of permanent for my comfort.
So I looked into code and turns out positions are fixed, so I just tuned them to my liking
Report comment to moderator  
Reply With Quote
Unread 03/22/21, 05:05 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Cooldown is not properly registered

Originally Posted by Kyzeragon
Jack of all Trades does not properly register the cooldown starting when the purchase request does not go through the confirmation dialog hook. To reproduce:
1. Send a purchase request without hitting the confirmation dialog, i.e. through addon or script:
Code:
/script PrepareChampionPurchaseRequest(false) AddHotbarSlotToChampionPurchaseRequest(4, nil) SendChampionPurchaseRequest()
2. Do something to make Jack of all Trades want to switch a star, like attempt to harvest a node, etc.
3. Notice that Jack of all Trades displays "X slotted." but it actually fails to do so because user is still on cooldown

You'll probably want to StartCooldown() on successful purchase requests instead, i.e. EVENT_CHAMPION_PURCHASE_RESULT -> CHAMPION_PURCHASE_SUCCESS
Will get that fixed, thank you!

This should be fixed with V.1.2.0, Thank you very much!
Last edited by CyberOnEso : 03/22/21 at 05:56 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: