Download
(16 Kb)
Download
Updated: 11/01/22 02:41 PM
Pictures
File Info
Compatibility:
Firesong (8.2.5)
Updated:11/01/22 02:41 PM
Created:04/16/14 09:03 PM
Monthly downloads:279
Total downloads:59,358
Favorites:150
MD5:
JunkBuster  Popular! (More than 5000 hits)
Version: 1.91
by: ADH, Atoom
Now compatible with 8.2.0 Firesong!

This addon provides a rule-based system to put items in your junk bag or destroy them

Unlike the other automatic junking addons, JunkBuster allows you to filter items by any combination of the following criteria:
  • Name
  • Item Type
  • (Specialized) Item Type
  • Equipment slot
  • Weapon/Armor type
  • Level
  • Price
  • Quality
  • Trait
  • Actor type (Player or Companion)
  • Item is crafted or not
  • Item is stolen or not
  • Item has a set bonus or not
  • Recipee is known or not

For example, you can set it to only junk the ingredients you loot that have 0g price value, or the normal quality (white) stolen treasures (but not the green ones).

Other Features:
  • The addon can automatically sell junked items to a merchant (not stolen items) or a fence (stolen items) when visiting them
  • You can add exemption rules that save and unjunk any special item that you want skipped by junkBuster
  • You can add rules to DESTROY items upon looting
    Warning: Be very careful with the destroy option. Destroyed items CAN NOT be returned.

The screenshots show some sample rules that I use when playing.
There is an extended logging option available which provides the info for every looted item in the chatbox so you can fine-tune or make new junking rules.

Planned future additions:
  • Allow <=, >=, == selections for item quality
  • Add support for FCO Item Saver
  • Allow addon to apply rules to (guild) bank too?
v1.91
* Updated API version for game patch 8.2.0

v1.90
* Updated API version for game patch 8.1.5

v1.89
* Updated API version for game patch 8.0.0

v1.88
* Fixed bug affecting rule creation with specialised item type filter
* Updated API version for game/pts version 7.3.5

v1.87
* Fixed bug in matching item names in rules
* Updated API version for game patch 7.2.5

v1.86
* Updated API version for game patch 7.1.5, fixed removed API constants

v1.85
* New filters:
-- Actor type (Player or Companion)
-- Is recipe known (or not)
* Updated API version for game patch 7.0.5 Blackwood and added new item trait and collectible types from the new release

v1.84
* Made additional item types available for rules
-- Crown Item
-- Crown Repair
-- Dye Stamp
-- Master Writ
-- Recall Stone
-- Tabard

v1.83
* Updated API version for game patch 6.3.5

v1.82
* Updated API version for game patch 6.2.5

v1.81
* Updated API version for game patch 6.1.5
* Overhauled chat messages made by this addon
* Removed leftover usage of a LibStub function
* Small bug fixes

v1.80
* Added possibility to customize the order rules are evaluated
-> This required some changes to the way rules are handled from now on
--- Newly added keep rules are inserted at position 1 of the list
--- Newly added junk or destroy rules are added at the bottom of the list
--- Previously created rules and their order should be preserved on updating to this version of the addon
---> Check your rules after updating!
* Added filter for specialized type for item types that have those
* Reorganized settings page layout

v1.79
* Updated API version for game patch 6.0.5

v1.78
* Updated API version for game patch 5.3.4
* Added new item type "Group repair" (or however its called ingame, I'm open for better names)

v1.77
* Updated API version for game patch 5.2.5
* Removed local LibAddonMenu files from the addon and changed it to depend on a external instance of the lib
* Compressed the space taken by some controls in the settings menu
* Added a new Config field "Max. junk sales" where it is possible to configure the maximum amount of items simultaneously sold by the auto junk sell function. If you occasionally get kicked back to the login screen on selling junk you can try lowering this number

v1.76:
* Fixed bug that could display rules twice in the settings menu

v1.75:
* Updated API version for game patch 5.1.5

v1.74:
* Updated API version for game patch 5.0.5
* Updated LAM to 2.0r29
* Added new Itemtype "Currency Container"

v1.73:
* Updated API version for game patch 4.3

v1.72:
* Updated API version for game patch 4.2

v1.71:
* Updated API version for game patch 4.1

v1.70:
* Reworked structure of saved character settings (now based on unique character id instead of the characters displayed name)
* Added a seperate account wide settings profile which can be switched on/off for each character seperately. On first time switching it on after installing/upgrading it will import the current characters settings.

v1.63:
* Fixed displaying of wrong message when one of the "Do Save/Destroy/Junk" settings is disabled
* If a item fits a save, destroy or junk rule which is disabled, addon will now check if one of the other rules apply instead
* Reduced maximum number of items sold at once by the auto junk sale to 89 in hope to avoid triggering zos' action spam protection

v1.62:
* Updated API version for game patch 4.0
* Updated LAM to 2.0r26

v1.61:
* Updated API version for game patch 3.3

v1.60:
* new Filters:
Filter Weapons by Weapon type (Sword, Axe,...)
Filter Armor by Armor Type (Light, Medium, Heavy, Clothing/No Armor)
* Removed a useless lone "0 items sold for 0g" message
* A little more realigning of rule creation controls

v1.52:
* Reworked item level filter to include CP levels
* Realigned the controls in the create rule section to save some vertical space
* Updated LAM to 2.0r25

v1.51:
* Updated API version for game patch 3.2

v1.50:
* New Filters:
Filter equipable items (weapons and armor) by their slot (Head, chest, one handed, ...)
Filter items by them having a set bonus or not
* Stolen junk is now sold sorted by price instead of quality at a fence
* Updated, sorted and corrected item types for rules. Tell me if a item type that you need / were using is missing
* Dollar signs for item prices changed to small g (gold)

v1.40:
* Added option to automatically sell junk when visiting a merchant (non stolen junk) or fence (stolen junk)
* Added option to filter for stolen or not stolen items
* Added option to add crafted items to rules
* You can now open the settings panel by typing /jb into the chat
* Corrected some trait and item quality names
* Item qualityies except Normal now colored in their respective colors in the rules display
* Grouped the on/off settings a bit

v1.31:
* Provisional fix for the rules display in the settings panel disappearing

v1.3:
* Updated for HotR / API 100020
* Changed Settings Pannel from LAM-1.0 to LAM-2.0r24
* Items crafted by a player are currently ignored (will not be junked or deleted)
* Many small fixes and improvements
- Disabled junk Trial run (never worked for me, may be fixed and reenabled in the future)
- Disabled Filter by crafting type (never found a use for this filter, tell me if you want it back)

v1.21:
* Update to new API version
* Removed a couple of item types that were obsolete

v1.2:
* Updated API version
* Changed the way rules are stored (thanks Alisu@)
* Rulesets can individually be turned on or off
* Laid the foundation for autobanking framework

v1.12: Added minimum level and price options

v1.11: Fixed a bug in item trait comparison. Thanks alisu!

v1.1:
* Several bug fixes
* Added rules to save and unjunk items
* Added rules to destroy items

v1.02: Added 'No Traits' option as per requests

v1.01: Made reporting in chat box to appear the same style as the rules in settings box.
Optional Files (0)


Archived Files (32)
File Name
Version
Size
Uploader
Date
1.90
15kB
Atoom
08/24/22 05:00 PM
1.89
15kB
Atoom
05/27/22 04:31 AM
1.88
15kB
Atoom
02/23/22 10:43 AM
1.87
15kB
Atoom
10/25/21 04:09 AM
1.86
15kB
Atoom
08/23/21 10:12 AM
1.85
15kB
Atoom
06/01/21 12:26 PM
1.84
14kB
Atoom
05/04/21 01:02 PM
1.83
14kB
Atoom
03/08/21 10:32 AM
1.82
14kB
Atoom
11/04/20 11:29 AM
1.81
14kB
Atoom
09/12/20 02:47 PM
1.80
14kB
Atoom
06/01/20 04:20 PM
1.79
12kB
Atoom
05/27/20 10:59 AM
1.78
12kB
Atoom
02/24/20 01:26 PM
1.77
12kB
Atoom
10/24/19 12:47 PM
1.76
57kB
Atoom
08/18/19 03:48 PM
1.75
57kB
Atoom
08/12/19 09:57 AM
1.74
57kB
Atoom
05/20/19 01:22 PM
1.73
55kB
Atoom
02/26/19 01:38 PM
1.72
55kB
Atoom
10/23/18 04:31 PM
1.71
55kB
Atoom
08/15/18 07:32 AM
1.70
55kB
Atoom
07/07/18 11:26 AM
1.63
54kB
Atoom
05/24/18 04:09 PM
1.62
54kB
Atoom
05/23/18 12:10 PM
1.61
53kB
Atoom
02/13/18 04:03 PM
1.60
53kB
Atoom
11/01/17 10:02 AM
1.52
52kB
Atoom
10/26/17 08:42 AM
1.51
52kB
Atoom
10/23/17 11:34 AM
1.50
52kB
Atoom
09/09/17 11:36 AM
1.40
51kB
Atoom
09/04/17 01:50 PM
1.31
50kB
Atoom
09/01/17 10:30 AM
1.3
50kB
Atoom
08/23/17 01:58 PM
1.21
12kB
ADH
06/25/14 07:19 PM


Post A Reply Comment Options
Unread 10/26/20, 06:16 AM  
Octopuss
 
Octopuss's Avatar

Forum posts: 176
File comments: 817
Uploads: 0
Could you add a standalone jewelry category? I keep having jewelry from writs destroyed along with armour, which doesn't make sense.

Also, is "is NOT crafted" filter possible?
Last edited by Octopuss : 10/26/20 at 06:16 AM.
Report comment to moderator  
Reply With Quote
Unread 10/27/20, 11:41 AM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Originally Posted by Octopuss
Could you add a standalone jewelry category? I keep having jewelry from writs destroyed along with armour, which doesn't make sense.

Also, is "is NOT crafted" filter possible?
Jewelry is considered armor by eso, just different slots. It's Item Type is armor. To change the behaviour of this selection in Junkbuster I'd have to invent a completely new Item Type property which is identical to the existing dozens of item types except for when armor is selected. Then i'd need to combine that item type with a selection of which equipment slots the item occupies (that you could already select for rules in a seperate dropdown). Ofc this would get quite convoluted very fast (also it would most likely make previously existing rules of all users invalid). So sorry, this i will probably not be able to implement.

There is already a "is not crafted" filter. In fact all rules that don't include any expicit setting ("could be crafted", "is crafted") in the "Crafted" dropdown already exclude crafted items from the rule. This is the same for keep, destroy and junk rules.
Last edited by Atoom : 10/27/20 at 11:42 AM.
Report comment to moderator  
Reply With Quote
Unread 10/27/20, 03:41 PM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Addendum: One possible workaround for your problem might be to create 2 simple Keep rules that exclude armor with slots ring and neck and place them in front of the rules which should not apply to jewelry. It's not perfect but it should solve this particular problem without requiring the addons code to turn into more of a big pile of spaghetti than it already is
Report comment to moderator  
Reply With Quote
Unread 10/28/20, 12:54 AM  
Octopuss
 
Octopuss's Avatar

Forum posts: 176
File comments: 817
Uploads: 0
Oh ok, I get it.
BUT it's confusing. Instead of automatically excluding crafted items when nothing in the crafted dropdown menu is selected, how about just adding a third value in there? It makes more sense to me, and large part of the people won't even mouse over the exclamation marks, I think.
Report comment to moderator  
Reply With Quote
Unread 10/28/20, 12:57 AM  
Octopuss
 
Octopuss's Avatar

Forum posts: 176
File comments: 817
Uploads: 0
Also a question.
What rules are unneeded in this?
Report comment to moderator  
Reply With Quote
Unread 10/28/20, 02:44 PM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Originally Posted by Octopuss
Also a question.
What rules are unneeded in this?
...
Hmm...
I'd say rules 1-2 and 4-6 aren't needed because no junk or destroy rules include these items with a "is crafted" or "could be crafted" filter. And as previously stated any rules that don't have those filters automatically exclude crafted items
Report comment to moderator  
Reply With Quote
Unread 10/29/20, 08:35 AM  
Octopuss
 
Octopuss's Avatar

Forum posts: 176
File comments: 817
Uploads: 0
Yea, it's like I said, I think it would make the filters more intuitive or something.
Report comment to moderator  
Reply With Quote
Unread 11/04/20, 11:30 AM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Update v1.82 released!

v1.82
* Updated API version for game patch 6.2.5
Report comment to moderator  
Reply With Quote
Unread 11/14/20, 12:39 AM  
Octopuss
 
Octopuss's Avatar

Forum posts: 176
File comments: 817
Uploads: 0
Hm, how about a checkboxes in front of rules to toggle them on and off? For example, I have a rule to destroy all white quality treasure, but I can use the same ones for levelling thieves guild skill, especially those coming from stolen shipments.


Also, is there any more user friendly way of approaching moving the position of rules? The current implementation is quite confusing and chaotic. It took me a while to realize what number I need to put where and what the fields really mean.
Report comment to moderator  
Reply With Quote
Unread 01/10/21, 04:34 PM  
ECWasHere

Forum posts: 0
File comments: 5
Uploads: 0
Been using this for 3 years. Now when I go to create a rule and select "Mark as Junk" from the combo box I get a screen full of errors.

Downloaded and installed the latest version along with the latest LibAddonMenu-2.0 and nothing changes. Still get a screen full of errors any time I select "Mark as Junk".


user:/AddOns/AutoCategory/Libs/LibAddonMenu-2.0/LibAddonMenu-2.0.lua:147: attempt to index a nil value
stack traceback:
user:/AddOns/AutoCategory/Libs/LibAddonMenu-2.0/LibAddonMenu-2.0.lua:147: in function 'RefreshReloadUIButton'
user:/AddOns/AutoCategory/Libs/LibAddonMenu-2.0/LibAddonMenu-2.0.lua:157: in function 'RequestRefreshIfNeeded'
|caaaaaa<Locals> control = ud, panel = ud, panelData = [table:1]{slashCommand = "/jb", name = "JunkBuster", version = "1.82", registerForRefresh = T, registerForDefaults = F, author = "@ADH + @Atoom", type = "panel", displayName = "|c777777Junk|cffffffBuster|r"} </Locals>|r
user:/AddOns/AutoCategory/Libs/LibAddonMenu-2.0/controls/dropdown.lua:63: in function 'UpdateValue'
|caaaaaa<Locals> control = ud, forceDefault = F, value = "Mark as Junk" </Locals>|r
user:/AddOns/AutoCategory/Libs/LibAddonMenu-2.0/controls/dropdown.lua:71: in function 'DropdownCallback'
|caaaaaa<Locals> control = [table:2]{m_isDropdownVisible = T, m_sortsItems = F, m_sortOrder = T, m_name = "LAMCombobox7", m_spacing = 0}, choiceText = "Mark as Junk", choice = [table:3]{name = "Mark as Junk"} </Locals>|r
EsoUI/Libraries/ZO_ComboBox/ZO_ComboBox_Base.lua:216: in function 'ZO_ComboBox_Base:ItemSelectedClickHelper'
|caaaaaa<Locals> self = [table:2], item = [table:3], oldItem = [table:3], selectionChanged = F </Locals>|r
EsoUI/Libraries/ZO_ComboBox/ZO_ComboBox.lua:23: in function 'OnSelect'
EsoUI/Libraries/ZO_ContextMenus/ZO_ContextMenus.lua:451: in function 'ZO_Menu_ClickItem'
|caaaaaa<Locals> control = ud, button = 1, menuEntry = [table:4]{itemYPad = 0} </Locals>|r
ZO_MenuItem1_MouseUp:4: in function '(main chunk)'
|caaaaaa<Locals> self = ud, button = 1, upInside = T, ctrl = F, alt = F, shift = F, command = F </Locals>|r
Last edited by ECWasHere : 01/10/21 at 04:42 PM.
Report comment to moderator  
Reply With Quote
Unread 01/13/21, 12:36 PM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Originally Posted by ECWasHere
Been using this for 3 years. Now when I go to create a rule and select "Mark as Junk" from the combo box I get a screen full of errors.

Downloaded and installed the latest version along with the latest LibAddonMenu-2.0 and nothing changes. Still get a screen full of errors any time I select "Mark as Junk".
You get those errors when you mark any item as junk through the context menu in the inventory? Or does it only happen with specific items?
I couldn't reproduce such an error in my game atm. Could you try disabling all other addons appart from Junkbuster (and the required LibAddonMenu) and check if you still see those error messages?
Report comment to moderator  
Reply With Quote
Unread 01/18/21, 06:55 PM  
ECWasHere

Forum posts: 0
File comments: 5
Uploads: 0
Originally Posted by Atoom
Originally Posted by ECWasHere
Been using this for 3 years. Now when I go to create a rule and select "Mark as Junk" from the combo box I get a screen full of errors.

Downloaded and installed the latest version along with the latest LibAddonMenu-2.0 and nothing changes. Still get a screen full of errors any time I select "Mark as Junk".
You get those errors when you mark any item as junk through the context menu in the inventory? Or does it only happen with specific items?
I couldn't reproduce such an error in my game atm. Could you try disabling all other addons appart from Junkbuster (and the required LibAddonMenu) and check if you still see those error messages?

As I said the error occurs when I try to create a new rule.

To replicate the error:
1. Hit ESC
2. Select "SETTINGS" from the ESO menu.
3. Select "Addons" from the sub-menu.
4. Select "JunkBuster" in the ADDONS dialog.
5. Scroll down and select "ADD NEW RULE"
6. From the top left control (a combo box) labeled "Action" select "Mark as Junk"
Last edited by ECWasHere : 01/18/21 at 06:55 PM.
Report comment to moderator  
Reply With Quote
Unread 01/19/21, 02:16 PM  
ECWasHere

Forum posts: 0
File comments: 5
Uploads: 0
Originally Posted by ECWasHere
Originally Posted by Atoom
Originally Posted by ECWasHere
Been using this for 3 years. Now when I go to create a rule and select "Mark as Junk" from the combo box I get a screen full of errors.

Downloaded and installed the latest version along with the latest LibAddonMenu-2.0 and nothing changes. Still get a screen full of errors any time I select "Mark as Junk".
You get those errors when you mark any item as junk through the context menu in the inventory? Or does it only happen with specific items?
I couldn't reproduce such an error in my game atm. Could you try disabling all other addons appart from Junkbuster (and the required LibAddonMenu) and check if you still see those error messages?

As I said the error occurs when I try to create a new rule.

To replicate the error:
1. Hit ESC
2. Select "SETTINGS" from the ESO menu.
3. Select "Addons" from the sub-menu.
4. Select "JunkBuster" in the ADDONS dialog.
5. Scroll down and select "ADD NEW RULE"
6. From the top left control (a combo box) labeled "Action" select "Mark as Junk"
Noticed some things, did some more investigation. Determined that the problem is with LibAddonMenu. If I only have JunkBuster and LibAddonMenu loaded (not other addons at all) the error does not occur.

All addons which use LibAddonMenu can be made to throw the same error, specifically
user:/AddOns/AutoCategory/Libs/LibAddonMenu-2.0/LibAddonMenu-2.0.lua:147: attempt to index a nil value
The error only occurs if one or more out-of-date addons which also use LibAddonMenu are also loaded. So for example if I have JunkBuster and an out of date version of Combat Metrics loaded, JunkBuster will throw the error.

I had an out-of-date version of Combat Metrics because Minion failed to update it.
Report comment to moderator  
Reply With Quote
Unread 01/23/21, 03:59 AM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Originally Posted by ECWasHere
Originally Posted by ECWasHere
Originally Posted by Atoom
Originally Posted by ECWasHere
Been using this for 3 years. Now when I go to create a rule and select "Mark as Junk" from the combo box I get a screen full of errors.

Downloaded and installed the latest version along with the latest LibAddonMenu-2.0 and nothing changes. Still get a screen full of errors any time I select "Mark as Junk".
You get those errors when you mark any item as junk through the context menu in the inventory? Or does it only happen with specific items?
I couldn't reproduce such an error in my game atm. Could you try disabling all other addons appart from Junkbuster (and the required LibAddonMenu) and check if you still see those error messages?

As I said the error occurs when I try to create a new rule.

To replicate the error:
1. Hit ESC
2. Select "SETTINGS" from the ESO menu.
3. Select "Addons" from the sub-menu.
4. Select "JunkBuster" in the ADDONS dialog.
5. Scroll down and select "ADD NEW RULE"
6. From the top left control (a combo box) labeled "Action" select "Mark as Junk"
Noticed some things, did some more investigation. Determined that the problem is with LibAddonMenu. If I only have JunkBuster and LibAddonMenu loaded (not other addons at all) the error does not occur.

All addons which use LibAddonMenu can be made to throw the same error, specifically

The error only occurs if one or more out-of-date addons which also use LibAddonMenu are also loaded. So for example if I have JunkBuster and an out of date version of Combat Metrics loaded, JunkBuster will throw the error.

I had an out-of-date version of Combat Metrics because Minion failed to update it.
Ah, I missunderstood you then. But thanks for your investigation!
Interesting though that an out of date version of another addon can cause libaddonmenu to malfunction. Since quite some time the practice to include libraries directly inside an addon should have stopped (which in that case can cause a lot of weird bugs like this). Current version of Combat metrics seems to not include a library within itself anymore. So i guess the unupdated version you had was quite old?

In this case the "attempted to index a nil value" error makes sense too. Apparently Junkbuster uses a property of - in the case of the Rule type field - dropdown controls that didin't exist in the out of date version that the old Combat metrics loaded into the game.
Last edited by Atoom : 01/23/21 at 04:05 AM.
Report comment to moderator  
Reply With Quote
Unread 03/08/21, 10:33 AM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Update v1.83 released!

v1.83
* Updated API version for game patch 6.3.5
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: