Download
(3 Kb)
Download
Updated: 07/04/19 03:34 PM
Pictures
File Info
Compatibility:
Elsweyr (5.0.5)
Updated:07/04/19 03:34 PM
Created:06/11/19 10:04 AM
Monthly downloads:49
Total downloads:4,810
Favorites:10
MD5:
BSCs-AntiCombatInteract
Version: 1.2
by: BloodStainCHild [More]
Libraries
This Addon depends on the following libraries:
No libs are needed

This addon is quit simple, everyone knows how annoying it is to be in a raid as group/guild leader trying to resurrecting a mate and the interaction menu shows up and kicking someone of your group / guild by mistake.

This addon just block's the menu while you are fighting but when you are not in a fight it works fine
also resurrecting a mate should be still possible
V 1.2
+ changed table call
+ added menu to enable/disable
V 1.1
+ Using ZO_PreHook
- Removed "override function"
Optional Files (0)


Archived Files (2)
File Name
Version
Size
Uploader
Date
1.1
1kB
BloodStainCHild
06/12/19 09:59 AM
1.0
1kB
06/11/19 10:04 AM


Post A Reply Comment Options
Unread 06/11/19, 03:51 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
Thanks for the addon. I like this idea a lot!

One hint about your code:
Overwriting a function is not that good as it will break other addons if they rely on this function as well!
One would need to know (and update on new addons) all of them and add them to your addons ##OptionalDependsOn: OtherAddon1 OtherAddon2 tag in order to load the other ones first, before your addon is loaded and overwrites the needed function...

Better use ZO_PreHook (see the ESOUI WIKI) to add a pre function to the original function. It will be executed before the other code then, and if you return with true the other following code won't be executed anymore. Like this :

Lua Code:
  1. ZO_PreHook(ZO_PlayerToPlayer, "ShowPlayerInteractMenu", function(isIgnored)    
  2.         if IsUnitInCombat("player") then
  3.             return true - - do not run original code
  4.                end 
  5.     end)
Last edited by Baertram : 06/11/19 at 03:53 PM.
Report comment to moderator  
Reply With Quote
Unread 06/12/19, 09:49 AM  
BloodStainCHild
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 56
Uploads: 14
Thanks!

Big thanks for the info!

Originally Posted by Baertram
Thanks for the addon. I like this idea a lot!

One hint about your code:
Overwriting a function is not that good as it will break other addons if they rely on this function as well!
One would need to know (and update on new addons) all of them and add them to your addons ##OptionalDependsOn: OtherAddon1 OtherAddon2 tag in order to load the other ones first, before your addon is loaded and overwrites the needed function...

Better use ZO_PreHook (see the ESOUI WIKI) to add a pre function to the original function. It will be executed before the other code then, and if you return with true the other following code won't be executed anymore. Like this :

Lua Code:
  1. ZO_PreHook(ZO_PlayerToPlayer, "ShowPlayerInteractMenu", function(isIgnored)    
  2.         if IsUnitInCombat("player") then
  3.             return true - - do not run original code
  4.                end 
  5.     end)
Report comment to moderator  
Reply With Quote
Unread 06/13/19, 01:57 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
Yw.
Btw, another hint:
Use the changelog tab as you update your addon so users and yourself are easily able to see what was changed for what version.
And if something does not work anymore can test around these changes.
The changelog is shown in Minion as well.
Report comment to moderator  
Reply With Quote
Unread 06/15/19, 02:41 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 642
Uploads: 2
Thx for the addon. Have requested it to come along with "No Interact" but Rhyono seems busy with his addons so i am glad i can mark this request as done now.
Report comment to moderator  
Reply With Quote
Unread 07/08/19, 04:16 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
Originally Posted by Gamer1986PAN
Thx for the addon. Have requested it to come along with "No Interact" but Rhyono seems busy with his addons so i am glad i can mark this request as done now.
Funny, just found I had started to fullfill this reuqest (maybe you have asked me in the past about it) within FCOChangeStuff but never got it to work properly. The files are still in there but commented
Good that someone else brought it to life, thanks BloodStainCHild.
Report comment to moderator  
Reply With Quote
Unread 03/16/21, 08:00 AM  
Zinival
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 53
Uploads: 4
Thank You!!

This addon is ridiculously underrated. I actually forgot I had it installed until I was testing without addons one day and kept accidentally opening interaction menus. It's horribly annoying!

With BSCs-AntiCombatInteract and In Combat Menu Block I am blissfully unaware of all my accidental clicks and can fully focus on combat and resurrecting. Thank you!
Report comment to moderator  
Reply With Quote
Unread 07/12/22, 02:52 PM  
mlq88
 
mlq88's Avatar

Forum posts: 0
File comments: 98
Uploads: 0
I think the new quickslot wheel broke this. Any chance of an update?
Report comment to moderator  
Reply With Quote
Unread 07/16/22, 07:41 PM  
BloodStainCHild
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 56
Uploads: 14
Originally Posted by mlq88
I think the new quickslot wheel broke this. Any chance of an update?
it has nothing to do with the qickslot wheel, still working for me
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: