Download
(16 Kb)
Download
Updated: 11/01/22 02:41 PM
Pictures
File Info
Compatibility:
Firesong (8.2.5)
Updated:11/01/22 02:41 PM
Created:04/16/14 09:03 PM
Monthly downloads:321
Total downloads:59,473
Favorites:150
MD5:
JunkBuster  Popular! (More than 5000 hits)
Version: 1.91
by: ADH, Atoom
Now compatible with 8.2.0 Firesong!

This addon provides a rule-based system to put items in your junk bag or destroy them

Unlike the other automatic junking addons, JunkBuster allows you to filter items by any combination of the following criteria:
  • Name
  • Item Type
  • (Specialized) Item Type
  • Equipment slot
  • Weapon/Armor type
  • Level
  • Price
  • Quality
  • Trait
  • Actor type (Player or Companion)
  • Item is crafted or not
  • Item is stolen or not
  • Item has a set bonus or not
  • Recipee is known or not

For example, you can set it to only junk the ingredients you loot that have 0g price value, or the normal quality (white) stolen treasures (but not the green ones).

Other Features:
  • The addon can automatically sell junked items to a merchant (not stolen items) or a fence (stolen items) when visiting them
  • You can add exemption rules that save and unjunk any special item that you want skipped by junkBuster
  • You can add rules to DESTROY items upon looting
    Warning: Be very careful with the destroy option. Destroyed items CAN NOT be returned.

The screenshots show some sample rules that I use when playing.
There is an extended logging option available which provides the info for every looted item in the chatbox so you can fine-tune or make new junking rules.

Planned future additions:
  • Allow <=, >=, == selections for item quality
  • Add support for FCO Item Saver
  • Allow addon to apply rules to (guild) bank too?
v1.91
* Updated API version for game patch 8.2.0

v1.90
* Updated API version for game patch 8.1.5

v1.89
* Updated API version for game patch 8.0.0

v1.88
* Fixed bug affecting rule creation with specialised item type filter
* Updated API version for game/pts version 7.3.5

v1.87
* Fixed bug in matching item names in rules
* Updated API version for game patch 7.2.5

v1.86
* Updated API version for game patch 7.1.5, fixed removed API constants

v1.85
* New filters:
-- Actor type (Player or Companion)
-- Is recipe known (or not)
* Updated API version for game patch 7.0.5 Blackwood and added new item trait and collectible types from the new release

v1.84
* Made additional item types available for rules
-- Crown Item
-- Crown Repair
-- Dye Stamp
-- Master Writ
-- Recall Stone
-- Tabard

v1.83
* Updated API version for game patch 6.3.5

v1.82
* Updated API version for game patch 6.2.5

v1.81
* Updated API version for game patch 6.1.5
* Overhauled chat messages made by this addon
* Removed leftover usage of a LibStub function
* Small bug fixes

v1.80
* Added possibility to customize the order rules are evaluated
-> This required some changes to the way rules are handled from now on
--- Newly added keep rules are inserted at position 1 of the list
--- Newly added junk or destroy rules are added at the bottom of the list
--- Previously created rules and their order should be preserved on updating to this version of the addon
---> Check your rules after updating!
* Added filter for specialized type for item types that have those
* Reorganized settings page layout

v1.79
* Updated API version for game patch 6.0.5

v1.78
* Updated API version for game patch 5.3.4
* Added new item type "Group repair" (or however its called ingame, I'm open for better names)

v1.77
* Updated API version for game patch 5.2.5
* Removed local LibAddonMenu files from the addon and changed it to depend on a external instance of the lib
* Compressed the space taken by some controls in the settings menu
* Added a new Config field "Max. junk sales" where it is possible to configure the maximum amount of items simultaneously sold by the auto junk sell function. If you occasionally get kicked back to the login screen on selling junk you can try lowering this number

v1.76:
* Fixed bug that could display rules twice in the settings menu

v1.75:
* Updated API version for game patch 5.1.5

v1.74:
* Updated API version for game patch 5.0.5
* Updated LAM to 2.0r29
* Added new Itemtype "Currency Container"

v1.73:
* Updated API version for game patch 4.3

v1.72:
* Updated API version for game patch 4.2

v1.71:
* Updated API version for game patch 4.1

v1.70:
* Reworked structure of saved character settings (now based on unique character id instead of the characters displayed name)
* Added a seperate account wide settings profile which can be switched on/off for each character seperately. On first time switching it on after installing/upgrading it will import the current characters settings.

v1.63:
* Fixed displaying of wrong message when one of the "Do Save/Destroy/Junk" settings is disabled
* If a item fits a save, destroy or junk rule which is disabled, addon will now check if one of the other rules apply instead
* Reduced maximum number of items sold at once by the auto junk sale to 89 in hope to avoid triggering zos' action spam protection

v1.62:
* Updated API version for game patch 4.0
* Updated LAM to 2.0r26

v1.61:
* Updated API version for game patch 3.3

v1.60:
* new Filters:
Filter Weapons by Weapon type (Sword, Axe,...)
Filter Armor by Armor Type (Light, Medium, Heavy, Clothing/No Armor)
* Removed a useless lone "0 items sold for 0g" message
* A little more realigning of rule creation controls

v1.52:
* Reworked item level filter to include CP levels
* Realigned the controls in the create rule section to save some vertical space
* Updated LAM to 2.0r25

v1.51:
* Updated API version for game patch 3.2

v1.50:
* New Filters:
Filter equipable items (weapons and armor) by their slot (Head, chest, one handed, ...)
Filter items by them having a set bonus or not
* Stolen junk is now sold sorted by price instead of quality at a fence
* Updated, sorted and corrected item types for rules. Tell me if a item type that you need / were using is missing
* Dollar signs for item prices changed to small g (gold)

v1.40:
* Added option to automatically sell junk when visiting a merchant (non stolen junk) or fence (stolen junk)
* Added option to filter for stolen or not stolen items
* Added option to add crafted items to rules
* You can now open the settings panel by typing /jb into the chat
* Corrected some trait and item quality names
* Item qualityies except Normal now colored in their respective colors in the rules display
* Grouped the on/off settings a bit

v1.31:
* Provisional fix for the rules display in the settings panel disappearing

v1.3:
* Updated for HotR / API 100020
* Changed Settings Pannel from LAM-1.0 to LAM-2.0r24
* Items crafted by a player are currently ignored (will not be junked or deleted)
* Many small fixes and improvements
- Disabled junk Trial run (never worked for me, may be fixed and reenabled in the future)
- Disabled Filter by crafting type (never found a use for this filter, tell me if you want it back)

v1.21:
* Update to new API version
* Removed a couple of item types that were obsolete

v1.2:
* Updated API version
* Changed the way rules are stored (thanks Alisu@)
* Rulesets can individually be turned on or off
* Laid the foundation for autobanking framework

v1.12: Added minimum level and price options

v1.11: Fixed a bug in item trait comparison. Thanks alisu!

v1.1:
* Several bug fixes
* Added rules to save and unjunk items
* Added rules to destroy items

v1.02: Added 'No Traits' option as per requests

v1.01: Made reporting in chat box to appear the same style as the rules in settings box.
Optional Files (0)


Archived Files (32)
File Name
Version
Size
Uploader
Date
1.90
15kB
Atoom
08/24/22 05:00 PM
1.89
15kB
Atoom
05/27/22 04:31 AM
1.88
15kB
Atoom
02/23/22 10:43 AM
1.87
15kB
Atoom
10/25/21 04:09 AM
1.86
15kB
Atoom
08/23/21 10:12 AM
1.85
15kB
Atoom
06/01/21 12:26 PM
1.84
14kB
Atoom
05/04/21 01:02 PM
1.83
14kB
Atoom
03/08/21 10:32 AM
1.82
14kB
Atoom
11/04/20 11:29 AM
1.81
14kB
Atoom
09/12/20 02:47 PM
1.80
14kB
Atoom
06/01/20 04:20 PM
1.79
12kB
Atoom
05/27/20 10:59 AM
1.78
12kB
Atoom
02/24/20 01:26 PM
1.77
12kB
Atoom
10/24/19 12:47 PM
1.76
57kB
Atoom
08/18/19 03:48 PM
1.75
57kB
Atoom
08/12/19 09:57 AM
1.74
57kB
Atoom
05/20/19 01:22 PM
1.73
55kB
Atoom
02/26/19 01:38 PM
1.72
55kB
Atoom
10/23/18 04:31 PM
1.71
55kB
Atoom
08/15/18 07:32 AM
1.70
55kB
Atoom
07/07/18 11:26 AM
1.63
54kB
Atoom
05/24/18 04:09 PM
1.62
54kB
Atoom
05/23/18 12:10 PM
1.61
53kB
Atoom
02/13/18 04:03 PM
1.60
53kB
Atoom
11/01/17 10:02 AM
1.52
52kB
Atoom
10/26/17 08:42 AM
1.51
52kB
Atoom
10/23/17 11:34 AM
1.50
52kB
Atoom
09/09/17 11:36 AM
1.40
51kB
Atoom
09/04/17 01:50 PM
1.31
50kB
Atoom
09/01/17 10:30 AM
1.3
50kB
Atoom
08/23/17 01:58 PM
1.21
12kB
ADH
06/25/14 07:19 PM


Post A Reply Comment Options
Unread 08/12/19, 10:07 AM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
If someone still experiences the "rules being displayed twice"-bug (totally possible as I haven't observed it myself yet, thus couldn't do anything to fix it):
If this bug happens for you, does it happen constantly or can you describe how to trigger it? If yes, could you send me your saved variables file for Junkbuster? You find it there:
C:\Users\<yourWinAccount>\Documents\Elder Scrolls Online\live\SavedVariables\JunkBuster.lua
Please also note which charater (name) it happens or if you have account wide settings enabled. Any speciffic steps needed to trigger the bug (apart from opening the JunkBuster settings page) would be very helpful too
Report comment to moderator  
Reply With Quote
Unread 08/18/19, 03:52 PM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Update v1.76 released!

v1.76:
* Fixed bug that could display rules twice in the settings menu

(Finally wittnessed the bug myself. For me it only happened the first time openening JunkBuster's settings menu after logging in or after /reloadui . For this I could find the source and implement a fix, let me know if you still get rules displayed twice in other cases )
Last edited by Atoom : 08/19/19 at 03:07 AM.
Report comment to moderator  
Reply With Quote
Unread 08/19/19, 08:36 AM  
Neverlands
 
Neverlands's Avatar

Forum posts: 7
File comments: 573
Uploads: 0
Re: Update v1.76 released!

Originally Posted by Atoom
v1.76:
* Fixed bug that could display rules twice in the settings menu

(Finally wittnessed the bug myself. For me it only happened the first time openening JunkBuster's settings menu after logging in or after /reloadui . For this I could find the source and implement a fix, let me know if you still get rules displayed twice in other cases )

Hello Atoom,
at the first look it seems to work for me, thank you
Report comment to moderator  
Reply With Quote
Unread 08/24/19, 07:58 PM  
jayman10000

Forum posts: 2
File comments: 160
Uploads: 0
Hello, how can I prevent spamming the game when I enable auto selling junk? I have my merchant assist but she does not have the "sell all junk" button that normal vendors have. Here Junkbuster would be perfect, but when using the auto sell feature I get the "ZoS limit of 89 sales per transaction reached, wait 10 seconds before trying again" message and then get logged out of the game.

It's pretty horrible to press E 167 times to sell all my junk, can this feature work so it doesnt spam the game?
Last edited by jayman10000 : 08/24/19 at 08:12 PM.
Report comment to moderator  
Reply With Quote
Unread 08/26/19, 11:33 AM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Originally Posted by jayman10000
Hello, how can I prevent spamming the game when I enable auto selling junk? I have my merchant assist but she does not have the "sell all junk" button that normal vendors have. Here Junkbuster would be perfect, but when using the auto sell feature I get the "ZoS limit of 89 sales per transaction reached, wait 10 seconds before trying again" message and then get logged out of the game.

It's pretty horrible to press E 167 times to sell all my junk, can this feature work so it doesnt spam the game?
First (probably too obvious) question would be: Did you wait atleast 10 seconds before opening the merchants menu again after that message from my addon pops up?
(If so please try waiting a bit)

Or alternatively: Do you get logged out imediatelly after the frist time oppening the merchants menu?
(If so that nebolous limit of simultaneous shop interactions set by ZoS is (again) smaller than it used to be, need to lower that on my side then... It would be great if you could find what the maximum amount of items (seperate entries/stacks in your junk inventory) is that doesn't get you kicked out of the game)

Alternatively visit a merchant more often xD If there aren't too many items in your junk tab it won't trigger the spam limit xD
Last edited by Atoom : 08/26/19 at 11:38 AM.
Report comment to moderator  
Reply With Quote
Unread 09/22/19, 12:52 PM  
NeuroticPixels
Addon Addict
 
NeuroticPixels's Avatar
Premium Member

Forum posts: 211
File comments: 869
Uploads: 0
Exclamation Error

EsoUI/Libraries/Globals/GlobalVars.lua:47: attempt to index a nil value
stack traceback:
EsoUI/Libraries/Globals/GlobalVars.lua:47: in function 'GetControl'
|caaaaaa<Locals> suffix = "Flash" </Locals>|r
EsoUI/Ingame/Inventory/Inventory.lua:1281: in function 'ZO_InventoryManager:PlayItemAddedAlert'
|caaaaaa<Locals> self = tbl, filterData = tbl, tabFilters = tbl, filterKey = 1, tabFilter = tbl, filterIndex = 1 </Locals>|r
EsoUI/Ingame/Inventory/Inventory.lua:1358: in function 'ZO_InventoryManager:OnInventoryItemAdded'
|caaaaaa<Locals> self = tbl, inventoryType = 1, bagId = 1, slotIndex = 58, newSlotData = tbl, inventory = tbl </Locals>|r
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
(tail call): ?
EsoUI/Ingame/Inventory/Inventory.lua:680: in function 'callback'
|caaaaaa<Locals> bagId = 1, slotIndex = 58, newSlotData = tbl, inventory = 1 </Locals>|r
EsoUI/Libraries/Utility/ZO_CallbackObject.lua:111: in function 'ZO_CallbackObject:FireCallbacks'
|caaaaaa<Locals> self = tbl, eventName = "SlotAdded", registry = tbl, callbackInfoIndex = 1, callbackInfo = tbl, callback = EsoUI/Ingame/Inventory/Inventory.lua:677, deleted = false </Locals>|r
EsoUI/Ingame/Inventory/SharedInventory.lua:494: in function 'ZO_SharedInventoryManager:HandleSlotCreationOrUpdate'
|caaaaaa<Locals> self = tbl, bagCache = tbl, bagId = 1, slotIndex = 58, isNewItem = true, slotData = tbl, result = 2 </Locals>|r
EsoUI/Ingame/Inventory/SharedInventory.lua:267: in function 'ZO_SharedInventoryManager:RefreshSingleSlot'
|caaaaaa<Locals> self = tbl, bagId = 1, slotIndex = 58, isNewItem = true, itemSoundCategory = 0, updateReason = 0, bagCache = tbl </Locals>|r
EsoUI/Ingame/Inventory/SharedInventory.lua:56: in function 'RefreshSingle'
EsoUI/Libraries/Refresh/Refresh.lua:65: in function 'ZO_Refresh:UpdateRefreshGroups'
|caaaaaa<Locals> self = tbl, refreshGroup = "inventory", refreshData = tbl, _ = 1, singleData = tbl </Locals>|r
EsoUI/Ingame/Inventory/SharedInventory.lua:93: in function 'OnInventorySlotUpdated'
|caaaaaa<Locals> eventCode = 131223, bagId = 1, slotIndex = 58, isNewItem = true, itemSoundCategory = 0, updateReason = 0 </Locals>|r
I got this after making a rule to destroy. "Destroy any item that has 'Lockpick' in its name that is stolen" is the rule.
I looted a thieves trove that contained 6 lockpicks, and I got this error. Then my inventory UI was broken and wouldn't update until after I used the /reloadui command. After using /reloadui, I can see the stolen lockpicks were destroyed as intended, but I never got a chat notification. (I have the "show destroyed items in chat box" turned to "ON".)

I'm fairly certain this error is due to JunkBuster. Please let me know if you think I'm incorrect.
Report comment to moderator  
Reply With Quote
Unread 09/25/19, 11:55 AM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Re: Error

Originally Posted by amber1019
I got this after making a rule to destroy. "Destroy any item that has 'Lockpick' in its name that is stolen" is the rule.
I looted a thieves trove that contained 6 lockpicks, and I got this error. Then my inventory UI was broken and wouldn't update until after I used the /reloadui command. After using /reloadui, I can see the stolen lockpicks were destroyed as intended, but I never got a chat notification. (I have the "show destroyed items in chat box" turned to "ON".)

I'm fairly certain this error is due to JunkBuster. Please let me know if you think I'm incorrect.
Hmm, that's actually not easy to say. The error message doesn't mention any file which is part of JunkBuster, only files from ZOS own interface. However that doesn't necessarily mean that JunkBuster has no part in your problem.
Are you sure your problem is caused only by JunkBuster? Aka does it also happen if JunkBuster is the only addon that is currently enabled? I somewhat suspect this could be a problem between my addon and another both trying to do something with newly added inventory items.
(As with the destroy option the new item that just got added to your inventory ceases to exist as soon as my event handler is finished. I don't know how the addon api handles other addons that might also have functions added to the "EVENT_INVENTORY_SINGLE_SLOT_UPDATE" event after mine as then the api could try to call those other functions with a reference to an item that doesn't exist anymore.)
Last edited by Atoom : 09/25/19 at 12:44 PM.
Report comment to moderator  
Reply With Quote
Unread 10/15/19, 10:03 AM  
myrthril

Forum posts: 0
File comments: 6
Uploads: 0
Line Break

I have a line break between rule #'s 28 and 29. Does that mean one of these rules contradicts a previous rule? I'm not sure what the line break is intended to mean.
Report comment to moderator  
Reply With Quote
Unread 10/17/19, 09:43 PM  
jayman10000

Forum posts: 2
File comments: 160
Uploads: 0
Originally Posted by Atoom
Originally Posted by jayman10000
Hello, how can I prevent spamming the game when I enable auto selling junk? I have my merchant assist but she does not have the "sell all junk" button that normal vendors have. Here Junkbuster would be perfect, but when using the auto sell feature I get the "ZoS limit of 89 sales per transaction reached, wait 10 seconds before trying again" message and then get logged out of the game.

It's pretty horrible to press E 167 times to sell all my junk, can this feature work so it doesnt spam the game?
First (probably too obvious) question would be: Did you wait atleast 10 seconds before opening the merchants menu again after that message from my addon pops up?
(If so please try waiting a bit)

Or alternatively: Do you get logged out imediatelly after the frist time oppening the merchants menu?
(If so that nebolous limit of simultaneous shop interactions set by ZoS is (again) smaller than it used to be, need to lower that on my side then... It would be great if you could find what the maximum amount of items (seperate entries/stacks in your junk inventory) is that doesn't get you kicked out of the game)

Alternatively visit a merchant more often xD If there aren't too many items in your junk tab it won't trigger the spam limit xD
Sorry for me being very slow to respond. Yes get logged out after the first time opening merchant. I open the merchant, it sells and junkbuster tells it reached 89 limit and then immediatly I can see that I cant interact with anything anymore, and after 10-15 seconds logged out to login screen). I have tested this alot, it does take a bunch of time because it seems to vary how much it happens. Some play sessions I dont see it at all, with the standard 89 sales limit, having reached the limit multiple times when pulling out my nuzhimeh vendor. Other times it seems to happen a lot. Maybe ZOS uses dynamic limits based on server load or something? In any case I tried setting the max sales limit to 69 and for a long time it hasnt happened (as long as I make sure to wait at least 10 seconds in between). 69 is sort of a low limit, but afaict this is the safe limit where it never happens; at least for me.
Last edited by jayman10000 : 10/17/19 at 09:46 PM.
Report comment to moderator  
Reply With Quote
Unread 10/19/19, 01:16 AM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Re: Line Break

Originally Posted by myrthril
I have a line break between rule #'s 28 and 29. Does that mean one of these rules contradicts a previous rule? I'm not sure what the line break is intended to mean.
Heya, are you refering to the blank line appearing between some rules in the list? That line is of no concern. Reason for its existance is that there is a maxmum limit of characters for a single text box control in a menu. So my addon uses multiple textboxes to fit in all the rules. The line break is a result of the empty space between 2 controls. (Same reason for the large empty space between the end of the list and the delete control, those are the empty spare text controls).

Originally Posted by jayman10000
Sorry for me being very slow to respond. Yes get logged out after the first time opening merchant. I open the merchant, it sells and junkbuster tells it reached 89 limit and then immediatly I can see that I cant interact with anything anymore, and after 10-15 seconds logged out to login screen). I have tested this alot, it does take a bunch of time because it seems to vary how much it happens. Some play sessions I dont see it at all, with the standard 89 sales limit, having reached the limit multiple times when pulling out my nuzhimeh vendor. Other times it seems to happen a lot. Maybe ZOS uses dynamic limits based on server load or something? In any case I tried setting the max sales limit to 69 and for a long time it hasnt happened (as long as I make sure to wait at least 10 seconds in between). 69 is sort of a low limit, but afaict this is the safe limit where it never happens; at least for me.
Thanks for the research! I might lower the limit to 69 in the next update. However im not sure, maybe for some people that limit might be a bit low (as it seems to be kinda random when you actually get kicked out), so probably make it configurable.
Report comment to moderator  
Reply With Quote
Unread 10/24/19, 12:29 PM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Re: Problem with storage coffer

Originally Posted by Mitaa
After yesterday's ESO update I can no longer add items to my storage coffer. Disabling the addon fixes the problem so it must be JunkBuster. See below for full error message.

EsoUI/Ingame/Inventory/InventorySlot.lua:736: Attempt to access a private function 'PickupInventoryItem' from insecure code. The callstack became untrusted 1 stack frame(s) from the top.
stack traceback:
EsoUI/Ingame/Inventory/InventorySlot.lua:736: in function 'TryBankItem'
|caaaaaa<Locals> inventorySlot = ud, bag = 1, index = 33, bankingBag = 7, canAlsoBePlacedInSubscriberBank = F </Locals>|r
EsoUI/Ingame/Inventory/InventorySlot.lua:1607: in function 'INDEX_ACTION_CALLBACK'
EsoUI/Ingame/Inventory/InventorySlotActions.lua:96: in function 'ZO_InventorySlotActionsoPrimaryAction'
|caaaaaa<Locals> self = [table:1]{m_hasActions = T, m_numContextMenuActions = 0, m_contextMenuMode = F}, primaryAction = [table:2]{1 = "Deposit"}, success = T </Locals>|r
EsoUI/Ingame/Inventory/ItemSlotActionController.lua:30: in function 'callback'
EsoUI/Libraries/ZO_KeybindStrip/ZO_KeybindStrip.lua:645: in function 'ZO_KeybindStrip:TryHandlingKeybindDown'
|caaaaaa<Locals> self = [table:3]{batchUpdating = F, insertionId = 415, allowDefaultExit = T}, keybind = "UI_SHORTCUT_PRIMARY", buttonOrEtherealDescriptor = ud, keybindButtonDescriptor = [table:4]{addedForSceneName = "houseBank", order = 500, alignment = 3, keybind = "UI_SHORTCUT_PRIMARY"} </Locals>|r
(tail call): ?
(tail call): ?
Heya,
I'm sorry that I to have to say to you about the same to you as I've said to amber1019 a few weeks ago. There is no File or function from my addon directly mentioned in the error message that you provided. So appart from that your problem seems to have to do something with inventory handling I can not say anything more.

I also tried reproducing the problem you described on my end, but here I din't get any error on depositing or retrieving items from either a housing storage container or the bank. So for now my only advice can again be to check if its really my addon that's causing your problem by testing if you still get the problem if JunkBuster is the only currently active addon. :/
If then the problem still apears it is indeed something on my side and i'd need to ask you for more detailed description of exactly what you do to produce the error.
If the problem stops apearing when JunkBuster is the only addon, it might be very interesting to find out which one of your other addons has to be enabled together with mine to make the error appear.
Report comment to moderator  
Reply With Quote
Unread 10/24/19, 12:48 PM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Update v1.77 released!

v1.77:
* Updated API version for game patch 5.2.5
* Removed local LibAddonMenu files from the addon and changed it to depend on a external instance of the lib
* Compressed the space taken by some controls in the settings menu
* Added a new Config field "Max. junk sales" where it is possible to configure the maximum amount of items simultaneously sold by the auto junk sell function. If you occasionally get kicked back to the login screen on selling junk you can try lowering this number
Report comment to moderator  
Reply With Quote
Unread 10/29/19, 06:05 AM  
CJ_Fatbird

Forum posts: 0
File comments: 5
Uploads: 0
Re: Re: Problem with storage coffer

Originally Posted by Atoom
Originally Posted by Mitaa
After yesterday's ESO update I can no longer add items to my storage coffer. Disabling the addon fixes the problem so it must be JunkBuster. See below for full error message.

EsoUI/Ingame/Inventory/InventorySlot.lua:736: Attempt to access a private function 'PickupInventoryItem' from insecure code. The callstack became untrusted 1 stack frame(s) from the top.
stack traceback:
EsoUI/Ingame/Inventory/InventorySlot.lua:736: in function 'TryBankItem'
|caaaaaa<Locals> inventorySlot = ud, bag = 1, index = 33, bankingBag = 7, canAlsoBePlacedInSubscriberBank = F </Locals>|r
EsoUI/Ingame/Inventory/InventorySlot.lua:1607: in function 'INDEX_ACTION_CALLBACK'
EsoUI/Ingame/Inventory/InventorySlotActions.lua:96: in function 'ZO_InventorySlotActionsoPrimaryAction'
|caaaaaa<Locals> self = [table:1]{m_hasActions = T, m_numContextMenuActions = 0, m_contextMenuMode = F}, primaryAction = [table:2]{1 = "Deposit"}, success = T </Locals>|r
EsoUI/Ingame/Inventory/ItemSlotActionController.lua:30: in function 'callback'
EsoUI/Libraries/ZO_KeybindStrip/ZO_KeybindStrip.lua:645: in function 'ZO_KeybindStrip:TryHandlingKeybindDown'
|caaaaaa<Locals> self = [table:3]{batchUpdating = F, insertionId = 415, allowDefaultExit = T}, keybind = "UI_SHORTCUT_PRIMARY", buttonOrEtherealDescriptor = ud, keybindButtonDescriptor = [table:4]{addedForSceneName = "houseBank", order = 500, alignment = 3, keybind = "UI_SHORTCUT_PRIMARY"} </Locals>|r
(tail call): ?
(tail call): ?
Heya,
I'm sorry that I to have to say to you about the same to you as I've said to amber1019 a few weeks ago. There is no File or function from my addon directly mentioned in the error message that you provided. So appart from that your problem seems to have to do something with inventory handling I can not say anything more.

I also tried reproducing the problem you described on my end, but here I din't get any error on depositing or retrieving items from either a housing storage container or the bank. So for now my only advice can again be to check if its really my addon that's causing your problem by testing if you still get the problem if JunkBuster is the only currently active addon. :/
If then the problem still apears it is indeed something on my side and i'd need to ask you for more detailed description of exactly what you do to produce the error.
If the problem stops apearing when JunkBuster is the only addon, it might be very interesting to find out which one of your other addons has to be enabled together with mine to make the error appear.
Just to note - I get this error, and I do not have Junk Buster enabled - I am trying to figure out what the error is relating to, but it is NOT Junk Buster, at least in my case.
From the error, it is obviously something to do with inventory handling, just have to work out which now. But I am narrowing it down and testing all the inventory 'touching' addons I have, and will then slowly combine them to reproduce. Just wanted to say that Junk Buster itself, doesn't seem to be the culprit - so it may be that another addon is causing it - that may be due to the other addon, or it's compatibility WITH Junk Buster.

--------------------------
Edit:

I've found the issue and the resolution - Well, rather I found information from someone who spoke to ZOS about the same issue popping up with their addon, and got a response.

Short Answer and Fix:
Upon loading the character, or reloading the character, you MUST open the character inventory at least once BEFORE using any inventory addons where you are seeing this error. Then it doesn't error.


LONGER answer and Reason: This is taken from Baetrum in a post relating to the same issue, in his FCO Item Saver comments:

Originally Posted by Baetrum
Known problems

1) Getting an "insecure" error message if you deposit items to the bank/use item/containers:
Got an info from ZOs about the error messages:
It's because the security of the handlers comes from the security of the function plus the security level when they are set (this second part is new). So when an addon tells the inventory to build a bunch of inventory slots, all those handlers are insecure and cannot call private functions. The next patch will change that so those handlers will be secure which will make these errors go away.

The explanation more in detail was finished with this information:
Things that change the bag that is shown by calling UpdateList on the inventory for example.

If you open the inventory first then the stock UI will make all the slots securely.
Then when the addon does it they'll already be there to use.
So this is why opening the inv first made the errors stop for some time.

As the addons, and especially filter addons using LibFilters, use an update function to show/update the inventory rows this shoudl relate to all of the addons like AdvancedFilters, FCOItemSaver, Inventory Grid List and others which add marker icons to the inventory rows (maybe even Craftstore or Alphagear).

Use the workaround showed below at 2) for the moment until ZOS's patch is live please!

2) Depositing items at bank not working::
This is a bug raised by ZOs and cannot be fixed in the addons. Please just WAIT for ZOS to fix this. Thank you.
Workaround: Reloadui. Open the inventory at least once and close it again. After that the bank deposit should work. Always open inv. once after reloadui/login. See technical description above at 1)
Last edited by CJ_Fatbird : 10/29/19 at 06:51 AM.
Report comment to moderator  
Reply With Quote
Unread 10/29/19, 12:17 PM  
Atoom
 
Atoom's Avatar

Forum posts: 0
File comments: 124
Uploads: 0
Thanks for the information!
Report comment to moderator  
Reply With Quote
Unread 01/02/20, 01:35 PM  
Octopuss
 
Octopuss's Avatar

Forum posts: 176
File comments: 817
Uploads: 0
Could you implement rule position change please?
edit: Do you still have plans to implement this? It would be REALLY useful.
Last edited by Octopuss : 01/02/20 at 01:37 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: