CompanionInfo : Graphic UI Mods : Elder Scrolls Online AddOns

(5 Kb)

Download

Updated: 11/01/21 06:43 PM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Compatibility:	Deadlands (7.2.5)
Updated:	11/01/21 06:43 PM
Created:	06/03/21 08:20 PM
Monthly downloads:	614
Total downloads:	40,924
Favorites:	41
MD5:

CompanionInfo Popular! (More than 5000 hits)

Version: 101032.1

by: SkOODaT [More]

Moveable Frame To Show Companion Information + Tooltip With Extended Information.

Required Lib: LibAddonMenu-2.0

Main Frame Example:
Name Level (Expierence) XP% [XP Gains] RapportLevel (PreviousRapportAmount) [RapportChanges] (RapportCurrentAmount)

Color Codes:
https://htmlcolorcodes.com/

Recommended Addons To Use With CompanionInfo:
Summon Key bindings
https://www.esoui.com/downloads/info...eKeybinds.html
No Interaction With Companion
https://www.esoui.com/downloads/info...oInteract.html

Detailed Changes:
https://github.com/SkOODaT/ElderScrollsOnline

If You Like The Work, Help Out With Some Sub Time (I Don't Own All The DLC... lol)....

Donations

-- API Update 101032 For V7.2.5 And Any Related Fixes
-- API Update 101031 For V7.1.5 And Any Related Fixes
-- 100035.19 Forgot Max Level Check On Main Frame
-- 100035.18 Fix Bad Operator Text, Change Saved Vars To Account Wide, Fixed Lock Tooltip, Fixed Dialog Zero Out, Added Compass Pin Hide, Fixed "-nan(ind)%", Added Max Level Check (Removes XP At Max Level), And Moved Startup Events Around
-- 100035.17 Added Dialog Hide As Per Request/Reworked Some Hide Stuff For It And Toggle
-- 100035.16 Added Setting Menu To Customize Info, Bugfixes
-- 100035.15 Changed Main Frame Display + Sight Tooltip Rearrange
-- 100035.14 Added XP And RAP Difference And RAP Previous Amount To Tip, Bug Fixes
-- 100035.13 Bugfix Icon On First Load In/Reloading
-- 100035.12 Added XP Percentage, Companion Warnings To Chat
-- 100035.11 Added Some Color To Tip, Hopefully Fixed Nil Errors
-- 100035.10 Added Proper Companion Icons, Added Min/Current/Max For Rap, Changed Text To White, Added Outfit Status
-- 100035.9 Fixed #@@$% Leftover Code, Broke Lock
-- 100035.8 Fixed Experience Totals
-- 100035.7 Reworked Code To Fix Overlapping Text Issue
-- 100035.6 Bugfix Another Overlapping Text Issue
-- 100035.5 Bugfix Overlapping Text Issue
-- 100035.4 Added Experience, Raw Rapport, First Companion Name Only On Frame
-- 100035.3 Added More Tooltip Infos, Reworked Some Code To Be More Robust
-- 100035.2 Added Tooltip With Passive Infos, Fixed Icon Stuff, Fixed Misc Char On Names

Optional Files (0)

Archived Files (20)

File Name	Version	Size	Uploader	Date
CompanionInfo	101031.1	5kB	SkOODaT	08/23/21 11:45 AM
CompanionInfo	100035.19	5kB	SkOODaT	06/14/21 02:42 PM
CompanionInfo	100035.18	5kB	SkOODaT	06/14/21 02:35 PM
CompanionInfo	100035.17	5kB	SkOODaT	06/07/21 10:39 PM
CompanionInfo	100035.16	5kB	SkOODaT	06/07/21 07:32 PM
CompanionInfo	100035.15	4kB	SkOODaT	06/06/21 06:05 PM
CompanionInfo	100035.14	4kB	SkOODaT	06/05/21 11:29 PM
CompanionInfo	100035.13	3kB	SkOODaT	06/05/21 06:56 PM
CompanionInfo	100035.12	3kB	SkOODaT	06/05/21 05:14 PM
CompanionInfo	100035.11	3kB	SkOODaT	06/05/21 03:47 PM
CompanionInfo	100035.10	3kB	SkOODaT	06/05/21 03:00 PM
CompanionInfo	100035.9	3kB	SkOODaT	06/04/21 10:49 PM
CompanionInfo	100035.8	3kB	SkOODaT	06/04/21 10:36 PM
CompanionInfo	100035.7	3kB	SkOODaT	06/04/21 10:29 PM
CompanionInfo	100035.6	3kB	SkOODaT	06/04/21 07:57 PM
CompanionInfo	100035.5	3kB	SkOODaT	06/04/21 07:32 PM
CompanionInfo	100035.4	3kB	SkOODaT	06/04/21 06:38 PM
CompanionInfo	100035.3	3kB	SkOODaT	06/03/21 11:24 PM
CompanionInfo	100035.2	3kB	SkOODaT	06/03/21 10:42 PM
CompanionInfo	100035.1	2kB	SkOODaT	06/03/21 08:20 PM

Comment Options

Page 2 of 4

06/07/21, 09:48 AM
SkOODaT Forum posts: 58 File comments: 169 Uploads: 11	just noticed that their are circumstances where the companion can be de-summoned .... Ie player house .... but their not actually deactivated..... thus the addon stays on screen and can produce an nil error on tooltip, i will get that fixed.... i noticed a "pending" function but didnt know what it did ... i think i do now Last edited by SkOODaT : 06/07/21 at 09:49 AM.

06/07/21, 01:36 PM
lilo_81 Forum posts: 0 File comments: 1 Uploads: 0	Thanks for the addon! There is a small thing that bothered me: The CompanionInfo window is one of the few things that are not automatically hidden when I start a dialog with an NPC. I solved that by adding the following lines to the code: Code: EVENT_MANAGER:RegisterForEvent(AddName.."_Hide", EVENT_CHATTER_BEGIN, function() CIFramesHide() end) EVENT_MANAGER:RegisterForEvent(AddName.."_Show", EVENT_CHATTER_END, function() CIFramesShow() CIFramesUpdate() end) Could you please add these to your addon? I would have created a pull request, but I couldn't find you on Github. Thanks in advance!

06/07/21, 08:07 PM

SkOODaT

Forum posts: 58

File comments: 169

Uploads: 11

Originally Posted by lilo_81

Thanks for the addon! There is a small thing that bothered me: The CompanionInfo window is one of the few things that are not automatically hidden when I start a dialog with an NPC. I solved that by adding the following lines to the code:

Code:

EVENT_MANAGER:RegisterForEvent(AddName.."_Hide", EVENT_CHATTER_BEGIN, function() CIFramesHide() end)
EVENT_MANAGER:RegisterForEvent(AddName.."_Show", EVENT_CHATTER_END, function() CIFramesShow() CIFramesUpdate() end)

Could you please add these to your addon? I would have created a pull request, but I couldn't find you on Github. Thanks in advance!

yes i can add that ...... ive prolly spent more time figuring this out then playing i haven't noticed the dialog issue yet lol

thier might be other occasions where it should be hidden too ~ WIP

its not on github yet ..... i do have a github but i donno just havent added this there yet lol

Last edited by SkOODaT : 06/07/21 at 08:08 PM.

06/08/21, 01:49 AM
kruq21 Forum posts: 0 File comments: 1 Uploads: 0	Error After update: user:/AddOns/CompanionInfo/CompanionInfo.lua:193: attempt to index a nil value stack traceback: user:/AddOns/CompanionInfo/CompanionInfo.lua:193: in function 'CIFramesUpdate'

06/08/21, 07:19 AM

Baertram

Super Moderator

Forum posts: 4993

File comments: 6047

Uploads: 78

Hey,

thanks for the addon.

Please add the needed dependencies of your addon(s) to the description (here: LibAddonMenu-2.0) so that users installing the addon via Minion/esoui see at a glance what is needed. Thanks a lot!

P.S. Maybe remove the changelog from the description, and add it to the changelog only

Makes reading the "features" way easier!
Especially within Minion!

EVENT_MANAGER:RegisterForEvent(AddName.."_Hide", EVENT_CHATTER_BEGIN, function() CIFramesHide() end)
EVENT_MANAGER:RegisterForEvent(AddName.."_Show", EVENT_CHATTER_END, function() CIFramesShow() CIFramesUpdate() end)

If you do not only want to hide it as you start a chatter you need to add a scene fragment to the HUD_SCENE and the HUD_UI_SCENE scenes to auto close/show if inventory/menus/npc chatter/etc. are shown (HUD_UI scene)/hidden (HUD scene):
https://wiki.esoui.com/Fragments_in_...t_state_change

Last edited by Baertram : 06/08/21 at 07:23 AM.

06/08/21, 03:02 PM

SkOODaT

Forum posts: 58

File comments: 169

Uploads: 11

Re: Error

Originally Posted by kruq21

After update:

user:/AddOns/CompanionInfo/CompanionInfo.lua:193: attempt to index a nil value
stack traceback:
user:/AddOns/CompanionInfo/CompanionInfo.lua:193: in function 'CIFramesUpdate'

i have not seen that error yet can you provide any other details maybe where you are in game.... you have settings toggled on or off etc?

i think i know whats causing it i have seen it aswell on initial load the companion can spam an event i added and if things arent ready we get an error ... im checking it out

Last edited by SkOODaT : 06/08/21 at 07:28 PM.

06/08/21, 03:11 PM

SkOODaT

Forum posts: 58

File comments: 169

Uploads: 11

Originally Posted by Baertram

Makes reading the "features" way easier!
Especially within Minion!

If you do not only want to hide it as you start a chatter you need to add a scene fragment to the HUD_SCENE and the HUD_UI_SCENE scenes to auto close/show if inventory/menus/npc chatter/etc. are shown (HUD_UI scene)/hidden (HUD scene):
https://wiki.esoui.com/Fragments_in_...t_state_change

added the dep needed ... ive been looking into the HUD_SCENE stuff ty

06/09/21, 02:50 AM
Snow Forum posts: 0 File comments: 66 Uploads: 0	Hi, I really like Your addon. So I do have some suggestions. If you have a max Level companion you get "-nan(ind)%" as XP Percent. A possible solution is: Warning: Spoiler change line 81 of CompanionInfo.lua form Code: local XPPercent = zo_floor(XP / TotalXP * 100) to Code: local XPPercent = 0 if not (TotalXP == 0) then XPPercent = zo_floor(XP / TotalXP * 100) end The changed Rapport value is not shown, when you hand in a daylie the compaion likes (Bastian - Mages Guild / Mirri - Fighters Guild) A possible solution is: Warning: Spoiler change line 339 of CompanionInfo.lua from Code: EVENT_MANAGER:RegisterForEvent(AddName.."_Hide", EVENT_CHATTER_BEGIN, function() CIFramesHide() end) to Code: EVENT_MANAGER:RegisterForEvent(AddName.."_Hide", EVENT_CHATTER_BEGIN, function() CIFramesNoZeroHide() end) If you received positive rapport and then negative rapport the changed Rapport value shows as "+-1" A possible soltuion is: Warning: Spoiler add the transition after line 227 of CompanionInfo.lua: Code: if currentRapport > previousRapport then RAPOperator = "+" end becomes Code: if currentRapport > previousRapport then RAPOperator = "+" else RAPOperator = "" end The function CISsavedVariables() uses ZO_SavedVars:New. The data is stored per char with the charname as it's key. Warning: Spoiler This is the oldes function dating from before it was possible to change the name of the chars. If you really think it is necessary to have the settings per char I would suggest to uses the newer ZO_SavedVars:NewCharacterIdSettings function. What I really would prefer is to change to ZO_SavedVars:NewAccountWide for account wide settings and add after your default array as next parameter "GetWorldName()" to get one account wide setting for the NA-Server and one for the EU-Server. so line 243 following Code: CISaved = ZO_SavedVars:New(AddName.."_SavedVariables", Version, nil, { ... }) becomes Code: CISaved = ZO_SavedVars:NewAccountWide(AddName.."_SavedVariables", Version, nil, { ... }, GetWorldName()) And at last something general. I noticed that all your functions are global functions. You prefixed them mostly with CI. But a function name like "CILock" might be used in another addon as well and might even by mistake overwrite your function. Warning: Spoiler There are different approches on how to minimize the pollution of the global namespace. I like the approch to have a class table with a unique name like "CompanionInfoLongClassName" and add all functions and variables to that table that need to be global for the addon. Something like: Code: if not CompanionInfoLongClassName then CompanionInfoLongClassName = { AddName = "CompanionInfo", ... } end local CI = _G["CompanionInfoLongClassName"] CI.ChangedRapport = 0 function CI.Lock() ... end Then you can later in game inspect and modify those vars with (zgoo) /zgoo CompanionInfoLongClassName or run functions with /script CompanionInfoLongClassName.Lock() Maybe Baertram can point you to a good tutorial about that. Sorry for that wall of text and thank you for your addon. Last edited by Snow : 06/09/21 at 03:08 AM.

06/09/21, 08:46 AM
thatlaurachick Forum posts: 0 File comments: 109 Uploads: 0	Mouseover disappears Hi there, love the addon! Just an FYI - the mouseover text disappears when you lock the display frame. Otherwise a great addon! (yes I like long pop-up descriptions)

06/09/21, 09:51 AM
SkOODaT Forum posts: 58 File comments: 169 Uploads: 11	thank you everyone .... ill take a look into locked text issue, i dont lock it ... ill also see about making some of the code changes, i took my older addon and just started with that as a template so some functions might be "OLD" lol -nan(ind)% is being caused by EVENT_ACTIVE_COMPANION_STATE_CHANGED its fires frequently and can cause the text to show liek that ....its also causing the nil error below, im going to look into that, ill get the daily event added (had no idea i dont do dailys yet)... ill fix the operator, ill look at the saved vars (i knew they needed a bit of work lol) and ill look into making things more unique so they dont conflict in any way i need to look into scenes too etc wip i run a pokemon go community too among actually playing the games lol so might take a bit to get everything added/done Last edited by SkOODaT : 06/09/21 at 01:13 PM.

06/09/21, 01:15 PM
SkOODaT Forum posts: 58 File comments: 169 Uploads: 11	Latest Fixes Can Be Found~ https://github.com/SkOODaT/ElderScro.../CompanionInfo History: https://github.com/SkOODaT/ElderScro.../CompanionInfo Ill Prolly Upload A Bit less Here, Until Bugs Are Figured Out And Changes Finalized Last edited by SkOODaT : 06/09/21 at 01:16 PM.

06/10/21, 12:32 AM

Snow

Forum posts: 0

File comments: 66

Uploads: 0

Originally Posted by SkOODaT

thank you everyone .... ill take a look into locked text issue, i dont lock it

... ill also see about making some of the code changes, i took my older addon and just started with that as a template so some functions might be "OLD" lol

-nan(ind)% is being caused by EVENT_ACTIVE_COMPANION_STATE_CHANGED its fires frequently and can cause the text to show liek that ....its also causing the nil error below, im going to look into that,

ill get the daily event added (had no idea i dont do dailys yet)... ill fix the operator, ill look at the saved vars (i knew they needed a bit of work lol) and ill look into making things more unique so they dont conflict in any way

i need to look into scenes too etc wip

i run a pokemon go community too among actually playing the games lol so might take a bit to get everything added/done

Thank you very much and take your time

.

PS:
you get "-nan(ind)" in lua e.g. if you divide by zero,
there may be more operations with this result but division by zero is a good common guess
"nan" stands for "not a number" so the result of a math operation was e. g. infinite
this happens for a max Level because TotalXP is initialized to 0 and 100 * 0 = 0
if you get it in other cases take a look at the parameters you divide by if one might be set to zero

06/10/21, 09:58 AM

Baertram

Super Moderator

Forum posts: 4993

File comments: 6047

Uploads: 78

ill look at the saved vars (i knew they needed a bit of work lol) and ill look into making things more unique so they dont conflict in any way

If you change the SavedVars to e.g.respect the unique characterId instead of the names

Code:

ZO_SavedVars:New -> ZO_SavedVars:NewCharacterIdSettings

AND maybe also different servers to play on

Code:

3rd parameter of the ZO_SavedVars funcions could use GetWorldName() e.g. to create a subtable "EU Megaserver" or "NA Megaserver"

the actual character name SV will be still existung but not used anymore.
And the users need to re-configure their settings if you do not provide an automated migration of the already configured data.

And SV will be all reset to NIL (defualt values will be used again then!) if you change the SV version number in ZO_SavedVars.

Just keep that in mind

Last edited by Baertram : 06/10/21 at 09:59 AM.

06/10/21, 04:09 PM
Duplomancer Forum posts: 2 File comments: 6 Uploads: 0	Any chance of account wide configuration? I am loving this addon and have been hyping it up! Any chance you can add Account Wide Configuration? It will help those of us with many toons greatly!

06/11/21, 07:38 AM

SkOODaT

Forum posts: 58

File comments: 169

Uploads: 11

Re: Any chance of account wide configuration?

Originally Posted by Duplomancer

I am loving this addon and have been hyping it up! Any chance you can add Account Wide Configuration? It will help those of us with many toons greatly!

account wide is added its on the github tho, not uploading here as often until everything is finalized

Page 2 of 4

Report this File