Quantcast
Download
(4 Kb)
Download
Updated: 08/16/20 06:39 PM
Pictures
File Info
Compatibility:
Greymoor (6.0.5)
Updated:08/16/20 06:39 PM
Created:08/07/20 09:29 PM
Monthly downloads:268
Total downloads:4,718
Favorites:7
MD5:
Fisherman's Friend
Version: 1.1
by: Zention [More]
Automatically swaps to the appropriate bait when you look at a fishing hole.

Defaults to using the alternative baits that you get while fishing (chub, shad, fish roe, and minnow) first. Settings menu has an option to disable this and use the regular baits first (worms, guys, insect parts, and crawlers).

When you run out of one, it'll swap to the other automatically.
Version 1.1:
- Update to fix some framerate drop issues that were reported.

Version 1.0
- Initial release
Optional Files (1)
File Name
Version
Size
Author
Date
Type
1.4.5
6kB
01/02/22 07:56 AM
Patch


Archived Files (1)
File Name
Version
Size
Uploader
Date
1.0
2kB
08/07/20 09:29 PM


Post A Reply Comment Options
Unread 04/02/21, 04:26 PM  
Zention
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 4
Uploads: 1
Hi Sem,

Thanks for investigating and solving these issues and updating the mod. Been a rough few months so ESO took a backseat. I can update the main mod here with your changes and credit you if you'd like. Let me know if you'd like this or if you just want to keep it over at the updated mod you posted. I'll PM you this as well just so you don't miss it.

Thanks again,
~ GameDude/Zention
Last edited by Zention : 04/02/21 at 04:26 PM.
Report comment to moderator  
Reply With Quote
Unread 12/22/20, 04:17 PM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
So, I investigated the issues with this addon myself and found two bugs that are mostly easy to solve.
Get the Update here!

1. When you log into the game the variable setBait is false. This AddOn will only equip lure when it is true.
I don't know why this is, but it can be fixed by setting it in the init function:
Lua Code:
  1. function FishermansFriend:Initialize()
  2.     FishermansFriend.SavedVariables = ZO_SavedVars:New("FishermansFriendSavedVariables", 1, nil, FishermansFriend.defaults)
  3.     FishermansFriend.CreateSettings()
  4.     setBait = true
  5. end



2. Getting the Quantity of bait was plain wrong. The function GetItemInfo won't give the wanted return value. The Problem shows when one type of lure is empty and the next should be equipped.

Using Votans solution from VotansFishFillet did the trick.
I had to fiddle around with the itemId though. (Why are there no build-in functions for that?..)
Lua Code:
  1. --Source: VotansFishFillet
  2. local function CountBag(bagId, itemId)
  3.     local slotIndex = ZO_GetNextBagSlotIndex(bagId, nil)
  4.     local stack, _, count
  5.     local sum = 0
  6.     while slotIndex do
  7.         local i = GetItemId(bagId, slotIndex)
  8.         if i == itemId then
  9.             _, count = GetItemInfo(bagId, slotIndex)
  10.             sum = sum + count
  11.         end
  12.         slotIndex = ZO_GetNextBagSlotIndex(bagId, slotIndex)
  13.     end
  14.     return sum
  15. end
  16.  
  17. function FishermansFriend.GetItemQuantity(itemId)
  18.     local quantity = 0
  19.     if HasCraftBagAccess then
  20.         quantity = CountBag(BAG_VIRTUAL, itemId) + CountBag(BAG_BACKPACK, itemId)
  21.     else
  22.         quantity = CountBag(BAG_BACKPACK, itemId)
  23.     end
  24.     return quantity
  25. end



3. I also added language support for german.
Files en.lua and de.lua go into FishermansFriend/lang/ directory.
Last edited by Sem : 01/17/21 at 05:16 PM.
Report comment to moderator  
Reply With Quote
Unread 08/18/20, 05:42 AM  
Dingodan
 
Dingodan's Avatar

Forum posts: 49
File comments: 253
Uploads: 0
Originally Posted by Zention
Originally Posted by votan
Originally Posted by Zention
Originally Posted by Dingodan
For me this addon didn't work.
Maybe a problem with the language? I play on german client.
It's due to how I check what hole you're out. I just check the name of the interactable you are looking at then call an API function to set your bait to the correct type when its one of the fishing holes.

If you can provide what the text is that appears when you look at the different hole types. For example, for English, I check for names like "Lake Fishing Hole" and "Foul Fishing Hole" and "Saltwater Fishing Hole" and "River Fishing Hole"

I'd just throw those in Google translate, but I'm not sure if that'd accurately match what ESO's translation is or how I'd be able to check. But if you are able to provide them to me, I can easily add them and then it should work for you.
Oh, yes. It will be even worst. Clockwork City and Artaeum using different text for Saltwater.
Feel free to use the localization strings from Fisherman.
Thanks, I'll look into that then. Didn't really think about localization differences or the different hole names in some DLC zones. This was just something I originally threw together to make getting Master Angler just a bit less of a hassle when running around between the different hole types that a friend said I should release. Thanks for sharing that with me and your addons have been great so awesome job to you!

Other update regarding first issue, should have a fix for the FPS drop coming probably tonight. Had my friend help out since I guess my PC is powerful enough it wasn't super noticeable, but he was able to reproduce
I checked it out. I changed the language to English and your Addon select the needed Bait but not if I start the Game in German language.
Report comment to moderator  
Reply With Quote
Unread 08/13/20, 10:24 AM  
Zention
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 4
Uploads: 1
Originally Posted by votan
Originally Posted by Zention
Originally Posted by Dingodan
For me this addon didn't work.
Maybe a problem with the language? I play on german client.
It's due to how I check what hole you're out. I just check the name of the interactable you are looking at then call an API function to set your bait to the correct type when its one of the fishing holes.

If you can provide what the text is that appears when you look at the different hole types. For example, for English, I check for names like "Lake Fishing Hole" and "Foul Fishing Hole" and "Saltwater Fishing Hole" and "River Fishing Hole"

I'd just throw those in Google translate, but I'm not sure if that'd accurately match what ESO's translation is or how I'd be able to check. But if you are able to provide them to me, I can easily add them and then it should work for you.
Oh, yes. It will be even worst. Clockwork City and Artaeum using different text for Saltwater.
Feel free to use the localization strings from Fisherman.
Thanks, I'll look into that then. Didn't really think about localization differences or the different hole names in some DLC zones. This was just something I originally threw together to make getting Master Angler just a bit less of a hassle when running around between the different hole types that a friend said I should release. Thanks for sharing that with me and your addons have been great so awesome job to you!

Other update regarding first issue, should have a fix for the FPS drop coming probably tonight. Had my friend help out since I guess my PC is powerful enough it wasn't super noticeable, but he was able to reproduce
Report comment to moderator  
Reply With Quote
Unread 08/12/20, 12:23 PM  
votan
 
votan's Avatar
AddOn Author - Click to view AddOns

Forum posts: 553
File comments: 1509
Uploads: 37
Originally Posted by Zention
Originally Posted by Dingodan
For me this addon didn't work.
Maybe a problem with the language? I play on german client.
It's due to how I check what hole you're out. I just check the name of the interactable you are looking at then call an API function to set your bait to the correct type when its one of the fishing holes.

If you can provide what the text is that appears when you look at the different hole types. For example, for English, I check for names like "Lake Fishing Hole" and "Foul Fishing Hole" and "Saltwater Fishing Hole" and "River Fishing Hole"

I'd just throw those in Google translate, but I'm not sure if that'd accurately match what ESO's translation is or how I'd be able to check. But if you are able to provide them to me, I can easily add them and then it should work for you.
Oh, yes. It will be even worst. Clockwork City and Artaeum using different text for Saltwater.
Feel free to use the localization strings from Fisherman.
__________________
@votan73 (EU - megaserver)
Report comment to moderator  
Reply With Quote
Unread 08/12/20, 11:56 AM  
Zention
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 4
Uploads: 1
Originally Posted by Dingodan
For me this addon didn't work.
Maybe a problem with the language? I play on german client.
It's due to how I check what hole you're out. I just check the name of the interactable you are looking at then call an API function to set your bait to the correct type when its one of the fishing holes.

If you can provide what the text is that appears when you look at the different hole types. For example, for English, I check for names like "Lake Fishing Hole" and "Foul Fishing Hole" and "Saltwater Fishing Hole" and "River Fishing Hole"

I'd just throw those in Google translate, but I'm not sure if that'd accurately match what ESO's translation is or how I'd be able to check. But if you are able to provide them to me, I can easily add them and then it should work for you.
Report comment to moderator  
Reply With Quote
Unread 08/11/20, 11:24 AM  
Dingodan
 
Dingodan's Avatar

Forum posts: 49
File comments: 253
Uploads: 0
For me this addon didn't work.
Maybe a problem with the language? I play on german client.
Report comment to moderator  
Reply With Quote
Unread 08/09/20, 12:11 PM  
Zention
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 4
Uploads: 1
Thanks for letting me know, I'd been running around with it for a while before releasing it and hadn't noticed anything myself. I'll take a look into it.
Report comment to moderator  
Reply With Quote
Unread 08/09/20, 09:56 AM  
ryh

Forum posts: 0
File comments: 33
Uploads: 0
FPS goes down when targetting containers

Hi!
Thx for funny and good add-on.

Found one problem.
When tragetting (just by camera movement) some containers like sacks, baskets etc. my FPS goes down from 100-120 to 10-20. When Fisherman's Friends is turne off - that problem doesnt exist.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: