Download
(22 Kb)
Download
Updated: 03/27/24 08:06 PM
Pictures
File Info
Compatibility:
Scions of Ithelia (9.3.0)
Updated:03/27/24 08:06 PM
Created:02/01/23 11:04 AM
Monthly downloads:1,164
Total downloads:20,308
Favorites:14
MD5:
Categories:Group, Guild & Friends, Bags, Bank, Inventory, Combat Mods, PvP, Utility Mods
9.3.0
RidinDirty  Updated less than 3 days ago!  Popular! (More than 5000 hits)
Version: 2024.03.27
by: sinnereso, MisB
"They see me rollin... They be hatin... Neva gonna catch me RidinDirty"
  • RidinDirty is specifically aimed at but not limited to small groups, friends and significant others for events, dungeons, questing and pvp etc. The features within are targeted at enhancing that playstyles fun, comfort, efficiency and mobility in one easy to configure place and is of particular benefit to non eso+ subscribers.
  • High performance, lightweight and designed for english language only and keyboard mode.
  • COMPATIBILITY: Dolgubon's Lazy Writ Crafter - Daily Alchemy - Daily Provisioning - WritWorthy - Mass Deconstructor
  • DEPENDENCIES: LibAddonMenu - LibCustomMenu
MAIN FEATURES
  • Main features that can be disabled may have continued event monitoring for multiple function merged events.
  • Mount a group members multi rider mount using keybind if they are within 5m of you and have available seat.
  • Teleport to "saved player" in group or locally in zone from guilds and friends using keybind with selectable effects.
  • Teleport to primary home inside or outside using keybind with selectable effects in settings panel & IC EVAC.
  • Teleport to overland zones or specific player houses with /tp partialzonename or /tp exact@name partialhousename.
  • All teleports include a toggleable queue system when in combat and will initiate the teleport when combat ends.
  • Leaderboards, Emperor & Group windows follow your display name preferences(character name or @name).
  • Withdraw one item at a time from bank, guild banks and house storage chests with context menu.
  • Auto bank / house deposit fills ONLY existing stacks. Option to stack foods, drinks, potions, poisons, soul gems and tools.
  • Auto gold, alliance point, telvar & writ voucher bank deposit with reserve & display all bank currency balances in chat.
  • Keybinds for leave group, exit instance, reloadui and siege camera toggle functions.
  • Settings panel to display & adjust features instantly.
ADDITIONAL FEATURES
  • All additional feature modules can be individually turned off and disabled completely.
  • Lock armory save build from settings panel with temporary unlock keybind and auto re-lock.
  • Nameplate font boost increases nameplate font size from 20pt to 28pt for slightly easier reading.
  • Whisper audio notifications so you can hear when someone sends you a whisper.
  • Log all companion rapport changes to chat and display current / maximum rapport values.
  • Reticle taunt assist displays taunt time left on any non-player taunted target in the center of reticle.
  • Reticle crux assist indicates crux stacks with outer reticle crosshair colors and size.
  • Auto swaps meticulous disassembly at crafting stations & assistants and gifted rider when mounting.
  • PvP personal / group kill feed & total daily killing blows, deaths & ratio% in cyrodiil, imperial city & battlegrounds.
  • PvP personal / group kill feed chat output follows your display name preferences(character name or @name).
  • Auto recharge & repair weapons & armor with gems & kits with adjustable threshold & fully repairs all at merchants.
  • Auto accept queues for dungeons, battlegrounds, cyrodiil & imperial city.
  • AP and telvar log to chat with adjustable minimum threshold.
*Special thanks to Baertram, Votan, EXoY and wookiefriseur for ALOT of help with many functions and features. Also CrazyDutchGuy and Garkin for some code from retired CDG Bank Stacker. Also Criscal and amuridee for some inspiration from TANK. Also Jarva & Masteroshi430 for providing code from Group User ID for the leaderboards and group displayname by preferences feature.
Code:
                   ***** KNOWN ISSUES *****
- /tp partialzonename MUST be only one word.
- /tp exact@name partialhousename MUST be only two words.
- If saved player has recently left pvp they may be pvp flagged for
  UNKNOWN period of time and unable to be travelled to.
- Need to reloadui after changing temporary armory unlock keybind
  to update in armory.
2024.03.27
- Code optimizations.

2024.03.24
- Removed experimental off balance and off balance immunity indicator via taunt assist and optimized more for performance.

2024.03.18
- Experimental off balance and off balance immunity indicator via taunt assist in (light blue).

2024.03.16
- Performance enhancements.

2024.03.13
- FIX for banking attempting to stack partially used siege when "Bank ALL" is enabled.

2024.03.11
- Added "Willowpond Haven" and "Sword-Singer's Redoubt" to housing list for u41.
- Added default "no bank deposit" to AvA recall stones and the new AvA repair items and stackable siege.

2024.03.07
- Pre-U41 api adjustments and update.

2024.03.01
- Added some pvp performance improvements.

2024.02.21
- Code optimizations in preparation for u41.

2024.02.01
- HAPPY 1YR RidinDirty ANNIVERSARY!!!
- Reduced auto meticulous delay down to 300ms.

2024.01.31
- Preparing for U41 and tweaked auto repair equipment to only use the "green" single item repair kits while in combat. Crown and Group repair kits have to be done manually out of combat.
- Refined /tp parsing to handle wildy crazy entries better and offer instructions.

2024.01.30
- FIXED Crux Assist and now indicates in and out of combat properly with new high performance filtering. :)
- Revamped the "/tp" zone blacklist into a MUCH shorter zone whitelist of overland zones. If I missed any overland zones please let me know.
- *Added "the brass fortress" and "tideholm" to "/tp" whitelist.

2024.01.29
- FIXED Crux Assist reticle indicator getting stuck after teleporting if buff expired mid teleport.
- Returned to previous crux indicator only showing in combat. Was nessissary(until I come up with a plan that works) to keep current high performance implementation bug free after teleporting.

2024.01.28
- Improved Crux Assist performance by better event filtering.
- Crux Assist now indicates crux in and out of combat.
- Improved Crux Assist performance even further by even better event filtering.
- Updated settings panel warning info.

2024.01.27
- Auto meticulous is now more silent with less chat output. Now only makes an error sound if there's an issue with your cp setup. This allows more temporary freedom for different setups when desired without too much annoyance.

2024.01.26
- Code optimizations. FINAL Auto meticulous adjustments.
- Minor settings panel decription tweaks.

2024.01.25
- Added 1sec delay to auto meticulous / gifted rider for smoothyness.
- Minor cosmetic adjustments.
- Reduced auto meticulous delay to 0.5sec and additional minor tweaks.
- Decided on 1200+ cp minimum for auto meticulous to engage as an advanced feature since theres little point in using it if you dont have other abilities as well.

2024.01.24
- Completely revamped auto meticulous after great work and thought. It was getting far too complex to account for every possible variable and scenario for every possible CP with timers and delays etc so I have revamped auto meticulous to only swap back and forth between meticulous disasembly at crafting stations(+ enchanting for mass deconstructor compatibility) and gifted rider when mounting. The new system requires a minimum of 360cp to function unfortunatly but is 100% reliable.
- It's still in a beta phase but should require minimal tweaks going forward to achieve perfection.
- Couple auto meticulous / gifted rider checks and chat output tweaks.

2024.01.21
- Still attempting to fix a random auto meticulous issue and improved it.
- Returned back to not activating auto meticulous while writ quest is active since you cant deconstruct anyway without likely losing your writ products. I wanted it but it just wasn't practical.
- Auto meticulous is now capable of just slotting meticulous dissassembly in an empty cp slot if one is available and leaving it that way.

2024.01.20
- Attempting to fix a random auto meticulous issue and improved it.
- Auto meticulous now activates while having a writ active but won't deactivate until they have been turned in. Also resets when loading an armory build and making CP changes.

2024.01.18
- *FIX* taunted timer stuck in crosshair if you happen to queue into pvp while in combat elsewhere.

2024.01.17
- *FIXED* home campaign leaderboard rank and score displaying much more often than intended. Now only displays it once upon entry to your home campaign.

2024.01.16
- Code optimizations & improved intelligent ic evac to ANY unlocked low pop cyro campaign with 5s delayed return to original IC campaign if not moving to explore/shop etc.
- Added chat notification of current rank on leaderboard and points upon entering your home campaign.

2024.01.12
- Changed whisper notification sound to new mail sound for a more consistant feel.
- Tweaked taunt assist to partially disable while in a pvp campaign or battleground to improve performance.
- Code optimizations.

2024.01.11
- *NEW* AP reserve option in banking settings with choices of 0, 10,000, 50,000, 100,000. 500,000, 1,000,000 & 10,000,000.

2024.01.10
- Reverted back to audio only personal kill feed notifications when ingame global kill feed is enabled.

2024.01.09
- Performance improvements.

2024.01.08
- Tweaked pvp personal kill feed to disable ingame kill feed when enabling and disable itself if ingame kill feed is enabled at daily reset. No sense in running both for performance reasons.

2024.01.07
- Updated pvp kill feed to only function when ingame kill feed is disabled and now also uses the standard and faster client based 2cell radius instead of the slower server based 10cell radius.

2023.12.29
- Updated chat output for travel to home to include the nickname of the house.

2023.12.21
- Minor pvp kill feed code adjustments. May need to manually reset daily pvp kill data in RidinDirty settings.

2023.12.20
- Minor pvp kill feed tweaks.
- Updated /tp lists to account for Infinite Archive name change.
- ADDED /ritualcasting emote effect as an in-combat queue effect choice to pre-teleport effects.

2023.12.19
- FIXED pvp personal kill feed double chat spam issue. Still trying to decide on the larger 10cell(location) radius or the standard 2cell radius. Its currently on the larger 10cell.

2023.12.17
- ADDED siege camera toggle keybinding in siege controls section.

2023.12.15
- NEW Whisper notifications. Dings when you receive an incoming whisper. Still deciding on the best sound for this.
- ADDED group kills / deaths to pvp personal kill feed.
- Working on a revamp for the kill feed filter to filter out ocasional double entries caused by the ingame kill feed event firing multiple times.

2023.12.12
- FIXED punctuation issue with "/tp partialzonename" causing it to occasionally find Hakkvild's High Hall.
- Code optimizations

2023.12.08
- Slightly increased Auto Meticulous initial return skill delay to make it less of a rush doing daily writs etc.

2023.12.07
- Tweaked Crux Assist reticle sizing.
- Code optimizations.

2023.12.06
- *NEW* Arcanist Reticle Crux Assist. Outer reticle crosshairs turn yellow, green and grow when at max 3 crux.
- Tweaked save player to not be able to save yourself since you cannot mount or teleport to yourself anyway.
- Code optimizations.

2023.12.04
- Fixed Auto Meticulous not returning original CP after relog/reload.

2023.12.02
- Fixed Auto Meticulous attempting to return a previously slotted CP after changing builds in armory.

2023.11.30
- Corrected a spelling error of shadow queen's labyrinth in housing database.

2023.11.27
- Code optimizations.

2023.11.20
- Minor control panel cosmetic tweak.

2023.11.19
- Minor fix for PvP Kill Feed divide by zero chat output issue.

2023.11.17
- Added additional checks for companion currently being summoned when attempting to teleport or mount which would prevent it.
- Control panel cosmetics.

2023.11.16
- Switched back to account wide pvp kills/deaths and added kill ratio% display as well per kill.
- PvP personal kill feed chat output tweaks and reset timing adjustment.

2023.11.15
- Partial fix for pvp personal kill feed resetting on alts early between 12 and daily reset time. Now is set to not reset until after 5am for DST reset. Working on automating DST and non DST for future update.

2023.11.14
- *FIX* Double PvP Personal Kill Feed reset spam upon login when daily login rewards triggers it a second time.
*** PERFORM A RESET IN RIDINDIRTY ADDON SETTINGS IF EXPERIENCING ANY ISSUES FROM PREVIOUS PERSONAL KILL FEED UPDATES ***

2023.11.13
- *FIX* Issue with only 1 character resetting daily personal kill feed data after daily reset. Now resets HOME campaign data upon daily reset or 1st login of EACH character.
- *FIX* For Auto Meticulous repeatedly swapping CP over extended periods of time in player housing doing daily or master writs. Now only returns original CP outside of any housing.
*** PERFORM A RESET IN RIDINDIRTY ADDON SETTINGS IF EXPERIENCING ANY ISSUES FROM PREVIOUS PvP Personal Kill Feed UPDATES ***

2023.11.12
- *FIX* for daily total AP earned using wrong variable and storing current RANK AP instead of leaderboard AP.
- Added a RESET button in settings panel to fix previous incorrect data and so you can reset it as you see fit per character.
- Removed per kill daily AP earned chat output due to leaderboard updating only periodically, polling leaderboard for every kill may have had negative performance impact and for repeating the same amount for long periods until leaderboard updated. I left it for during daily reset to show how much you earned yesterday or since last reset if you hadn't logged in for days etc.
*** PERFORM A RESET IN RIDINDIRTY ADDON SETTINGS IF EXPERIENCING ANY ISSUES FROM PREVIOUS UPDATES ***

2023.11.10
- Added 10mil gold reserve option for alts.
- Added an Admin Setting section in control panel for admin feature testing purposes.
- Code optimizations.

2023.11.04
- API bump to U40(Endless Archive).
- Updated internal housing dungeon and trial lists used for teleporting etc.

2023.10.26
- Completed rework of "mount saved player" function. Is now called "Mount Group Member" and will mount any group member within 5m that is actually ON a multi-rider mount with a seat available.
- Added chat output for "Mount Group Member" function so you can see who your attempting to mount incase many group members are nearby and mountable.

2023.10.25
- Re-working "mount saved player" feature to be more intellegent to mount ANY group member near you riding a dual-mount. Its a crude setup at the moment because one of the api functions required for it are not working as intended and cannot tell if the target is actually ON theyre dual-mount. It has been reported but does work as long as only one person(other than yourself) is near you and mounted on theyre dual-mount.

2023.10.22
- Enhanced 99% of functions to adhere to the ingame display name preferences. Looking at friends/guild lists in future.

2023.10.20
- Added Swarm of Crows to pre-teleport effects. Useable if unlocked like the rest.

2023.10.19
- FIXED long standing but just discovered /tp to zone or player house combat queue not teleporting to the correct location after combat ends.
- Changed pre-teleport effects to be saved per character instead of account wide as per request which mostly made sense. Different characters have unique styles.

2023.10.15
- FIXED random pvp kill feed popup error related to stripping the gender code from character names.
- Code optimizations

2023.10.14
- Attempting to correct a semi-rare pvp kill feed fancy character chat output bug.

2023.10.13
- Code optimizations.

2023.10.10
- FIXED random ocasional kill feed error popup.
- Tweaked pvp personal kill feed to reset daily along with daily login rewards or after when u next log in & switched to account wide kills/deaths.

2023.10.09
- Fixed pvp kill feed chat output to strip off the male / female trailing code when "prefer character names" setting is set in ingame options.
- Returned to previous chat output suppression when ingame pvp kill feed is enabled for those who prefer just the added audio notification.

2023.10.08
- Added Kelesan'ruhn to housing teleport lists.
- Tweaked pvp personal kill feed appearance and to disable ingame global kill feed when enabled.

2023.10.07
- Added total daily pvp kills and deaths to pvp personal kill feed. Still experimental and resets daily at midnight. Working on efficient logic to reset at 6am with all other daily resets.

2023.10.04
- Tweaked Pvp personal kill feed to disable ingame chat kill feed notification only when enabling. Can turn ingame pvp kill feed back on after if desired.

2023.10.03
- Tweaked chat color of pvp personal kill feed feature so it stands out a bit better.

2023.10.02
- FIXED pvp kill feed double audio notification.
- Added personal chat kill feed when ingame kill feed is disabled.

2023.10.01
- *NEW* PvP Kill Feed Audio Feedback option. Dings when you get a killing blow in cyrodiil, imperial city & battlegrounds.

2023.09.26
- Changed "/rd" teleport features to "/tp" with Teleport and EasyTravel compatibility. Disables feature if either of the other addons are present.
- Added "Gladesong Arboretum" and "Tower of Unutterable Truths" to the teleport housing list preparing for update 40.
- Removed CompanionFix feature from RidinDirty and left it as a standalone temporary fix addon.

2023.09.19
- Fixed CompanionFix double chat spam.

2023.09.18
- Added CompanionFix settings panel option merged in from CompanionFix addon. Auto re-summons companion when experiencing errors summoning companion after zoning.

2023.09.06
- Corrected fontboost tooltip to display updated 28pt size.

2023.09.04
- Slightly increased fontboost size from 26pt to 28pt.

2023.08.28
- Fixed Armory auto re-lock not returning "unlock keybind description".

2023.08.21
- API BUMP Update 39 (101039).
- Enhanced armory save build to now auto lock going through doors and zoning etc as well as reloadui / login.

2023.08.03
- Fixed auto meticulous attempting to swap when not enough points are in the cp to be slotted.

2023.07.18
- Added companion rapport change logged to chat feature in options.
- Fixed error caused by incorrect spelling of a saved variable.

2023.07.14
- Tweaked temporary armory unlock keybind to only function from within armory.

2023.07.13
- Added skyreach catacombs to /rd blacklist.
- Added keybind to temporarily unlock armory save build button. Shows keybind in armory to unlock and auto relocks after zoning or reload.
- *** WILL NEED TO SET KEYBIND FOR TEMPORARY ARMORY UNLOCK & PERFORM A RELOADUI ***

2023.07.12
- Minor chat output adjustments for /rd teleports
- Planning on reworking Armory Lock to have a lock/unlock button in armory or keybind rather than a settings panel option soon if possible.

2023.07.08
- Minor settings panel cosmetics.
- Increased IC EVAC return delay an additional (3s) to account for high pop / event latency and added a movement check to cancel the auto return to IC.

2023.07.07
- Added settings panel option to enable/disable bank balance chat output.
- Added 2 experimental features:
1. "Leave Group" keybind now leaves group if in one, leaves instance if not in group, invites "saved player" to group if not in group or instance.
2. A possible fix for an erroneous "1" that could display in reticle under certain circumstances.

2023.06.29
- Enhanced /rd filtering to detect more improper use and display instructions.
- Fixed a incorrect delay added to teleporting to saved player in some situations.
- Tweaked banking code to allow bank balance display when its disabled by daily writ compatibility etc.
- Removed the extra space in the banking compatibility chat message.
- Enhanced Auto meticulous compatibility to temporarily disable ONLY if you have an active writ AND have at least one of the following addons enabled: Dolgubon's Lazy Writ Crafter, Daily Alchemy or Daily Provisioning. Or if you have either JackOfAllTrades or DynamicCP enabled.
- Added many pvp zones and delves to the /rd blacklist.

2023.06.28
- Added banking compatibility reminder chat messages so you know when its temporarily disabled and why. Its still silent for Auto Meticulous to avoid too much spam.
- FIXED finally the /rd blacklist issue incorrectly triggering on a few select zones and preventing teleport.
- **Changed** /tp teleport functions to /rd as I've been told of a possibility RidinDirty was overwriting other teleport addon slash commands.
- Added group search for /rd teleport functions. Now searches within group members for desired overland zone as well.
- Added cyrodiil, imperial city and battlegrounds to the /rd blacklist.
- Removed compatibility mode in settings. After heavy thought its useful in very very few scenarios and in those scenarios its more harm and annoyance than good if you have the incompatible addons enabled.
- Added a sort of "help" for /rd. You can now type JUST /rd to get instructions on how to use it.
- Added all known solo zones I could find into the /rd blacklist. Should be nearly impossible now for it to try teleporting anywhere you can't or don't want to go.

2023.06.27
- Revamped /tp [partial zone name] to a complete blacklist preventing all dungeons, trials, arenas and player housing.
- Removed /played time upon login feature.
- Added compability mode switch in settings to disable the already existing compatibility features for other addons if needed.
- Added Teleport and EasyTravel compatibility.
- Added cyrodiil, imperial city and battlegrounds to the /tp blacklist.

2023.06.26
- Tweaking /tp [partial zone name] to not teleport to player houses. Refined it a bit to match up not only similar names but also zoneID's to make it more accurate and reliable.
- Added character played time in chat once upon login.

2023.06.24
- (BETA)Added teleport to zone or delve etc with /tp [partial zone name] or to to specific player housing with /tp [exact username] [partial housename] using friends and guild members. Will be adding group members soon. Still experimental and currently might not teleport to zones with names similar to houses like galen and tel galen but working on it and is currently 99% functional.
- Added Exit Instance function to the Leave Group keybind. Its now dual function.. Press it once to leave group and again to leave instance. :)

2023.06.22
- Minor auto meticulous timing tweaks.
- Adjusted telvar gain/loss chat output.
- Remove Fetish of Anger and Darkswarm Talisman teleport effects.. Theyre just too long to be a good fit.
- Code optimizations.

2023.06.19
- *NEW* auto meticulous now saves swapped out skill PER CHARACTER even after a reloadui or logout to a new toon. Now you can hit a crafting machine and log onto another toon instantly or reloadui and it will save that data and return THAT skill later, tomorrow or next week!! Whenever you log back into THAT toon it will return the original skill auto meticulous swapped out. TY beartram for the saved variable advice :)

2023.06.18
- Minor withdraw from banks tweaks and fix for not shutting down the close bank event.
- Added offhand and backup offhand to auto repair with kits. Minor oversight =p
- Removed chat spam when auto repairing with green repair kits.

2023.06.17
- Fixed withdrawing one item from bank multiple times not stacking in inventory. Now stacks after exiting bank and guild bank automatically.
- Minor tweaks to auto repair with kits settings panel adjustments.

2023.06.16
- *NEW* Added auto repair with repair kits and crown repair kits with a preference for standard repair kits 1st. (BETA)
- Merged the new auto repair features into the auto recharge function in settings so ALL recharge and repairs controlled by one option.

2023.06.15
- Fixed auto meticulous trying to return original cp multiple times.

2023.06.13
- More auto meticulous tweaks to eliminate any errors or failed cp swaps. Couple intermittent bugs im trying to work out.
- Reimplemented the delay returning original CP due to the system shutting it down again randomly with instant swapping for spamming I have to assume.
- Fixed auto meticulous listing blank skill when returning original CP.
- Added saved variable for auto meticulous so now it will still function or correct itself after a reloadui. Still need to deal with swapping characters mid cycle. Working on it next.
- Changed JackOfAllTrades compatibility. Now disables auto meticulous if JackOfAllTrades is enabled, not just the meticulous disassembly feature due to the way it works and the high probability of multiple short duration cp swap attempts out in the field with giladil etc and the cp change spamming disabling both our addons functionality until a relog.
- Added Dynamic CP compatibility with auto meticulous.
2023.06.12
- Adjusted auto meticulous return delay and additional tweaks to prevent it trying to swap cp while zoning.

2023.06.10
- Added an additional auto meticulous check for loading screen to prevent it trying to swap in original cp while zoning.
- Added withdraw one item from bank and guild banks with context menu.(BETA)

2023.06.08
- Implementing a debug mode for easier bug testing.

2023.06.05
- API bump to 101038(necrom)

2023.06.04b
- Fix for ".lua:451: attempt to index a nil value".

2023.06.04
- Removed temporary daily writ fix and applied a different fix the pro's believe will be more reliable.

2023.06.03
- Added temporary fixed for IC Next Boss not reliably hiding timer window if you had it disabled.
- Added temporary fix for one and possibly more bugged enchanting daily writs that don't register like all other crafting writs. For banking compatibility.

2023.06.02
- Added tooltips for gold reserve selections representing character QOL.

2023.06.01
- Code optimizations.

2023.05.31
- Added auto telver reserve "withdraw" ability if below reserve.
- Adjusted telvar reserve in options panel to display comma delimited numbers with descriptive tooltips.
- Adjusted travel home chat output to once again display inside or outside.
- Changed gold reserve slider to a dropdown list of choices with a snazzy coin to match the telvar reserve asthetics.

2023.05.30
- Added telvar reserve. Reserves chosen amount on person for telvar X multiplier farming. Does not withdraw.

2023.05.29
- Code optimizations.

2023.05.28
- Refined auto meticulous compatibility with JackOfAllTrades by disabling ONLY if meticulous disassembly is enabled in JackOfAllTrades.

2023.05.27
- FIXED auto meticulous "not enough champion points" error.
- Tweaked auto meticulous error handling and added an additional check to make sure you have enough points to slot meticulous disassembly.

2023.05.26
- Added JackOfAllTrades compatibility. Temporarily disables auto meticulous when running JackOfAllTrades.

2023.05.25
- Adjusted some auto meticulous code to help future proof against api changes.

2023.05.24
- Finally got fully automatic auto meticulous working properly. Still in BETA though while I iron out any other unforseen bugs. Theres been 2 known issues I've been working on. (1) You can't swap cp an unknown rediculous amount of times in an unknown short period of time. (2) If you happen to crash while swapped there is no way I've found to know this even with a saved variable when you log back in because a crash doesn't save the variables.

2023.05.23
- Added Mass Deconstructor compatibility simply by enabling auto meticulous to the enchanting tables which dont actually benefit from meticulous disassembly but Mass Deconstructor thinks it does so we go with that =p.
- Revamped auto meticulous events down to 2 from 6 that can now be fully turned off when feature disabled.
- Revamped auto meticulous to now activate at any related station or assistant and then deactivate 30secs later if not at a station or assistant. If you ARE still at a station or assistant then it will continue to check every 10secs until your done and then return your primary champion skill.
- Added (BETA) to the auto meticulous name so its clear that its still in testing.

2023.05.22
- Fixed auto currency deposits not coloring the amounts correctly.
- Added auto withdraw gold when below reserve and enough gold in bank to do it.
- Added a 30 second mute to the Auto Meticulous Active message so it doesn't spam as much.
- Various tweaks to auto meticulous disassembly. Its still a work in progress. Disable if having issues for the moment.

2023.05.20
- Reverted back to a previous version with the below fixes. *** YOU WILL NEED TO SELECT SWAP SKILL AGAIN IN ADDON SETTINGS *** I'll continue working on the fully automated Auto Meticulous slowly on the side.

2023.05.20
- Fixed ALL auto currency deposits showing the telvar image. Sorry I just realized it was doing this. It was functioning correctly though just displaying the wrong currency image.
- Fixed Auto Meticulous Disassembly not enabling events imediately after enabling feature and added all champion point choices.
- Auto Meticulous is still BETA. Im fine tuning it still.

2023.05.19
- Fix for "Compatibility test" message" doing writs.
-- Added Auto Meticulous Disassembly at crafting stations & assistants option. Swaps with selected champion skill(will add more choices if needed).

2023.05.18
- Settings panel cosmetic adjustments.
- Enhanced auto bank deposit compatibility for ALL daily writ addons.

2023.05.16
- Added an option to disable gold auto deposit for ONE main gold hoarding character per account.
- Increased maximum auto gold deposit reserve to 1,000,000 in 25k steps. Can still manually enter any amount you wish between 0 and 1mil.

2023.05.14
- Added auto deposit gold(slider to adjust reserve 0 - 500k), auto deposit ap & auto deposit writ voucher banking options.
- Settings panel cosmetic adjustments.

2023.05.12
- Added "Deposit ALL" options for auto bank deposit and auto house deposit features.

2023.05.11
- Added poisons to the list of NOT auto stacked in bank or house storages.

2023.05.10
- Minor settings panel visual tweaks and added tooltips to describe each feature in more detail.

2023.05.09 *New feature*
- Added House Storage Deposit option in settings for those that would find that useful.
- YOU WILL NEED TO RE-ENABLE AUTO BANK DEPOSIT AND TELVAR DEPOSIT(IF YOU USED THEM).
- Updated RidinDirty naming in settings panel, keybinds and controls to just RidinDirty.

2023.05.08
- Added banking compatibility with Daily Alchemy & Daily Provisioning addons. Appears to be some unusual inhouse withdrawl messages still between Daily Alchemy/Provisioning and Dolgubons Lazy Writ Crafter but unrelated to RidinDirty and functional regardless. I recommend disabling Daily Alchemy/Provisioning bank withdrawls if you have Dolgubon's(UNLESS YOU ARE ONLY USING HOUSE STORAGES FOR MATS). Daily Alchemy/Provisioning CAN grab from house storages but seems to grab from bank 1st instead of the housing container that was opened.

2023.05.07
- Banking code optimizations.

2023.05.06
- Dolgubon's Lazy Writ Crafter 100% compatibility complete. Now ONLY disables RidinDirty banking functions during Dolgubon's Lazy Writ Crafter banking operations.
- Removed attempted Personal Assistant compatibility. After thinking about it more I realized it was not needed. You decide what options to enable/disable.

2023.05.05 - MAJOR UPDATE
- Added compatibility with Personal Assistant. Disables any overlapping RidinDirty features with Personal Assistant enabled features.
- Added compatibility with Dolgubon's Lazy Writ Crafter. Temporarily disables auto banking while lazy writ creator 'Withdraw writ items' is enabled and accessing assistant banker. To continue using RidinDirty banking features with assistants you will have to disable Lazy Writ Crafter 'Withdraw writ items' when you're done with it for the time being until I find a better "only doing writs" solution.

2023.05.04
- Updated and shortened ALL text output logos from [RidinDirty] to [RD] to save chat line space and the eyes!
- Updated and condensed considerable code into reusable variables to save HD space and the environment!
- Updated keybind category name in controls.
- Updated remaining text output to be consistant everywhere.
- Beginning to look into compatability with other big addons like "Dolgubon's lazywrit creator" and more. Ive found some conflicts with auto banking functions. Will be some updates soon.

2023.05.02
- Updated list of non-teleportable zones.
- Added currency icons to bank balances display when opening bank, AP/Telvar gains in pvp and repairs.

2023.05.01
- In an effort to prevent effects firing off when you can't teleport to the saved player at their location, I've added a table for easy additions to a list of zones that can't be travelled to that I know of already. If you find any others please let me know in the feedback in settings panel or in game PC/NA @sinnereso.

2023.04.30
- Lock armory save build revamped and working 100% now. It's highly efficient with no more delay timers and 0 event monitoring :)
- Cleaned up remaining unused code and notes from the creation of the armory lock.
- Fixed random unable to teleport to saved player bug caused by using zoneIndex instead of zoneID.
- Adding specific zones you can't teleport to manually since the game doesn't provide a proper way to check this in advance. So far have "Eyevea" and "The Earth Forge". Will be a slow process getting them all but please feel free to let me know of any via feedback.

2023.04.29
- Optimized keybinding code.
- Organized Ouroboros hourglass animation code into a seperate function
- Added some additional checks when teleporting to saved player to make sure you CAN travel to them at they're location. This will save you mental energy not wasting effects!
- Added additional checks when teleporting home to make sure you CAN from YOUR current location.
- RE-Added Armory hide save build button as an experimental feature. I want it but am not happy with the implementation yet.

2023.04.28
- Fixed a rare show taunted targets variable bug.

2023.04.24
- Greatly optimized code and reduced addon size by approx 10% while retaining all its original juicy goodness!

2023.04.23
- Adjusted travel home output and queue messages to all be the same format.

2023.04.21
- Adjusted bank currency output and cleaned up any and all unused notes in code.

2023.04.20
- API bump for PTS

2023.04.19
- Removed the (G) (AP) (T) (WV) from bank balance display since they are color coded to make more room on 1 line for BiG monies!

2023.04.18
- Code optimizations

2023.04.17
- Organised features into clean clear sections for anyone creeping my code =p

2023.04.16
- Code optimizations

2023.04.15
- Enhanced Auto Bank Stacker & Auto Telvar Deposit functions to display current banked balances for gold(G), ap(AP), telvar(T) and writ vouchers(WV) when bank is opened or telvar auto deposited.
- Added proper number formatting for numbers greater than 999 like 1,000 instead of 1000 for banking, ap and telvar gains etc.
- Adjusted bank balance output spacing so there is always only one leading space.

2023.04.14
- *NEW* Leaderboards, Emperor & Group windows now follow your displayname preference(char name or @name). This feature is a port from a retired addon "Group User ID" Masteroshi430 recently revived. This feature is still in beta as I'm uncertain how it may affect other addons that manipulate these lists. If you have any issues please report them.

2023.04.13
- Fixed a bug where you attempt to teleport while effect is unavailable there would be no chat message stating where your teleporting to. For example after eating the event cake it would not permit momento use for some time after.

2023.04.12
- TY for patience while I adjust all these output messages. Finally got them to a place I can live with thats informative but not super annoying or bloating addon with 500 different messages and checks for them. This should be final update for a while other than bugs.
- Updated text output for various mounting and teleporting functions when your unable to perform that function for various reasons.

2023.04.11
- Code optimizations

2023.04.10
- Slightly increased finvir's trinket and token of root sunder effect timings to feel more smooth. You will need to cycle through them and re-select for new timings to be set.
- Code optimizations

2023.04.09
- Re-Added darkswarm talisman teleport effect.
- Adjusted teleport effect timings and logic.
- Adjusted name of travel home keybinding.
- Code optimizations.

2023.04.08
- Re-Added token of root sunder and fetish of anger teleport effects.
- Added finvir's trinket teleport effect because it's cool too.
- Adjusted mounting message logic.

2023.04.06
- *NEW* Taunted!! Displays if target is taunted and duration on the crosshair.
- Quick fix for taunted.

2023.04.04
- Adjusted teleport effects to show in red in settings if collectible not unlocked yet.
- Adjusted mounting to detect and display if "saved player" hasn't been set to mount.
- Adjusted AP gain message when repairing to "Keep Repair:" instead of "Gained:".
- Attempting to detect if "saved player" is in campaign or battle ground when trying to teleport to them.

2023.04.03
- Adjusted campaign auto accept timing again. Removed delay completely and testing a few days.
- Adjusted balance text output when gaining telvar to "Carried Balance:".
- Adjusted multi rider mounting logic to detect and notify if "saved player" is not in group or online.

2023.04.02
- Adjusted auto queue timings. This is for cyro group queues. Im working on accepting both messages to remove them from screen fast even though it works regardless.
- Optimized telvar event monitoring to only be activated in IC not cyrodiil as well.

2023.04.01
- Added NEW FEATURE ** LOOT BOOSTER **
- Minor mounting text output adjustments

2023.03.31
- FIXED a typo in the previous update causing and error after zoning. All fixed :)
- Added Telvar log to chat feature to AP log. Now does both! AP log and Telvar log merged into same option using same slider for minimum settings.

2023.03.30
- Slight renaming to RidinDirty (Group & Events) as it is designed for events as well.

2023.03.29 [Addon COMPLETE]
- Addon complete! Just bug fixing going forward.
- Removed unused code and functions.
- Cleaned up internal commenting and prepped as final version.

2023.03.28
- Fixed the Fix! TY Beartram! Settings menu callbacks now much more efficient and are only called for this addon instead of all addons silently.
- minor code cleanup and setup two minor manual toggles inside RidinDirty.lua for professionals to enable/disable the out of gems warning and the /ritualcasting effect during queued teleports etc. Added for those that either really like or really dislike the features.
- FIXED!! save player context menu error when settings panel hasn't been opened yet to create the controls. Now saves and updates properly anytime as a good menu should.

2023.03.27
- Temporary FIX for save player error if you haven't opened addon settings panel. Somehow I never noticed this while working on the settings panel that if you hadn't opened it yet there was no control to edit to display the saved player. Im currently working on a proper fix but for the time being im skipping editing that field if it doesnt exist yet which eliminates the error if you try to save player BEFORE opening addon settings and everything does work properly.

2023.03.26
- Adjusted travel home text output formatting to be inline with the other chat output messages.
- Added defaults for "saved player" and "teleport effects" for settings panel.
- optimized auto recharge code slightly

2023.03.25
- Tweaked some effect timings and done I hope.
- Fixed auto recharge not charging.. sorry was my fault when messing with the warning idea.

2023.03.24
- Added and removed low on soul gems warning. Tweaked out of soul gems warning to only display once but will display again everytime you zone to remind you.
- Moved backup recharge check from on_load to on_activate which should fire a little more often when loading, going through doors, zoning or any load screen to make sure weapons charged if they had been at 0 charges for an extended period of time. This scenario is unlikely but possible and I'm trying to make sure its covered.
- Tweaked campaign accept timings and effects.

2023.03.23 (Tomorrows Edition TODAY & Addon Complete)
- Adjusted Key binding names to reflect some of the recent changes.
- Added queue animation and /ritualcasting effect(if unlocked) when entering campaigns.

2023.03.22
- Enhanced settings menu visually. Also minimum charge and minimum ap logged sliders now disable upon feature being turned off.
- Adjusted settings menu colors slightly.
- Updated addon images.
- Adjusted alliance AP gained sounds from capture, defence and in general.

2023.03.21
- Removed mount player multi rider queue after combat. Was a cool feature but required coordination with them to stay in range for it to be useful and felt awkward.
- Added sounds to alliance keep capture and defense AP rewards.
- Added sounds for many of the previous on screen messages.
- Added sliders in settings menu to adjust the minimum weapon charge before charging and minimum AP to log in chat.*beta* still looking for any issues.

2023.03.20
- Removed a considerable amount of on screen display messages as the default ESO ones in top right corner are enough and less annoying.
- Lowered minimum weapon charge setting and AP logged to chat. Only checks on charge use and load/reload so if you were out of gems for an extended period of time you may need to manually charge or reloadui once you get some. Weapon swap was a good option before 1bar builds but now not much use so I'm lookin at other options still to remedy this without it checking every time you do anything at all.
- Adjusted on screen message entering campaign.

2023.03.19
- Attempting to fix a rare issue during heavy lag where cyrodiil auto queue didn't accept.
- Added onscreen msgs indicating when entering campaign.

2023.03.18
- Final Settings panel tweak
- Tightened up settings panel
- Cleaned up effects toggle code

2023.03.17
- Seperated Auto Bank Stacker and Auto Telvar Deposit into seperate options
- Fixed couple punctuation errors
- Added additional check before disabling on_player_activate between Font Boost and AP Log since they both require it, they now check that the other is off as well before disabling it.
- Fine tuned options panel as best I could with LibAddonMenu and now displays some other useful info.

2023.03.16
- Poilished up some feature descriptions in option menu.
- Fixed saved player not updating in setting window without reloadui.
- REMOVED "SAVE PLAYER" keybinding as it was a redundant feature and saving random people was useless since you had to be at least in group with them to mount or teleport. This change makes LibCustomMenu now required.
- I suggest going into SETTINGS / ADD-ONS and at the bottom hit "clear unused keybinds" after updating. *BE WARNED* this will clear any currently unused keybinds including INACTIVE addons as well so enable all addons with keybinds that matter to you 1st to prevent that.

- REQUIRED DEPENDENCY: LibAddonMenu-2.0, LibCustomMenu.
- UPDATE: Still working on effect button.

2023.03.15 *** MAJOR UPDATE ***
- Fixed auto bank getting all excited and trying to stack from house chests.
- Fixed auto queue not accepting campaign queues.
- ADDED AP Log to chat feature.
- REMOVED all slash commands and upgraded to a real settings menu but came with a saved variable reset. All settings are now in the normal addon settings with the other addons. Still looking for bugs but haven't found any.
- Known issue: Saved Player info and teleport effects button currently dont update after changing without reloadui BUT are working properly, its just not updating the settings window.. Temporarily using an onscreen display message for the teleport effects.
- NEW REQUIRED DEPENCENDY: LibAddonMenu for the new settings menu.

2023.03.14
- Permanantly removed chat window context menu feature as it was not needed.
- Code Optimizations. Increased both load and auto recharge performance.
- Still testing internally AP to Chat feature. Wanting to add it but not wanting to add any more /SLASH commands so I'm at a roadblock with it as it should be a toggleable feature but otherwise its working perfectly so far. I might merge it with autobank & telvar deposit feature but undecided.

2023.03.13
- API bump to update37
- Fixed a chat output bug. Was missing 1 digit on a color table and it stole the letter C from my chat output so those that dont know you "an't teleport while mounted" can still play! =p
- Edited the variable initialization down to 1 line as per Beartrams suggestion which may improve load performance and upset the gods much less! =p
- Testing internally a new very basic AP gained to chat feature.


2023.03.12
- Cleaned up chat messages and preparing for update 37.

2023.03.11
- Added Guild, Group & Friends list "Save to RidinDirty" context menu option via OPTIONAL: LibCustomMenu. TY Votan for the LibCustomMenu upgrades :)
- Temporarily disabled the chat window context menu feature. Depending on your interface settings it may have been saving players character name instead of @NAME. Disabled until I find a workaround to convert them or prevent that.

2023.03.11
- Fixed teleport attempting to use effects and teleport if you were mounted. Now warns you that you are mounted and obviously cannot teleport :)
- Added right click "Save to RidinDirty" chat window context menu to save player for teleport use and optional LibCustomMenu dependency to use it. Continuing to work on guild list, friends list and group list for a future update.

2023.03.10
- Fixed chat output bug when teleporting home. If it hadn't been set yet it was reporting traveling "outside" rather than the game default of "inside" where it was actually going.

2023.02.09
- Added additional weapon recharge check on load/reloadui. In the unlikely event your weapons reach 0 charges it will force a charge check otherwise it only triggers on charge use which could have had a scenario where it wouldn't recharge. For performance and due to the heavy attack build popularity im trying to avoid checking on weapon swaps etc.
- Added informative text when porting to home

2023.03.08
- Fixed double recharge bug. All known bugs fixed.

2023.03.07
- Fixed auto recharge bug. Is working again but trying repair twice with 2h. Fix that in another update.
- Added more descriptive text when porting to saved player ingroup stating the name and location your porting to so its inline with other messages.

2023.03.06
- OK bugs all fixed and fully tested. Moving forward
- Completely revamped the teleport ability. NOW teleports to saved player ONLY if they're in group or to anyone else locally in your current zone from friends list or guilds if your saved player is not in your group. I found this to be the most useful setup and much less accidental ports where u dont want to be.
SUPER useful for events, questing, dragons, harrowstorms etc in group or even solo.
- Some message tweaks. Im still working on a consistent text feedback feel for it and its all complete. :)

2023.03.05
- Reverted back to previous version for the moment.. Was several bugs i need time to work out.

2023.03.06
- Completely revamped the teleport ability. NOW teleports to saved player as before ONLY if they're in group allowing you to play solo because now it can port to friends or guild members locally IN SAME ZONE to bring you to nearest wayshrine if your saved player IS NOT in group. Usefull for events, questing, dragons, harrowstorms etc. Still in beta phase watching for issues.

2023.03.05
- Corrected some chat messages.

2023.03.04
- Added auto bank stacking to auto deposit Telvar function.. It now does both! Fills stacks in bank of anything already in there other than foods, drinks, potions, soul gems, lockpicks and some pvp related items. Thank you CrazyDutchGuy and Garkin for some of the code from an old addon "CDG Bank Stacker" which appears to be freeware to make this possible.
- Added teleport effects and combat queue to teleport to player when they're NOT in group but ARE a friend.
- Fixed a chat output bug and teleport to friend not recognizing them as online.

2023.03.03
- After much thought I have trimmed some of the effects as they didn't quite flow how I'd like and effects aren't the primary focus of this addon.
- Removed: Darkswarm Talisman, Token of Root Sunder and Fetish of Anger effects.
- Moved Ritual Casting effect to the travel/mount queue as an experiment if you have it unlocked. It may or may not stay there depending on how it feels.
- Performance improvements
- Added possibility of teleporting to "saved player" when they're not in group for convenience if they're your "friend" but without teleport effects. Its a group tool so traveling out of group drains all your magic! :)

2023.03.02
- Switched to date format for version.
- Fixed porting from cyro/ic/battlegrounds, now checks if in those zones and doesn't run effects.
- Adjusted some text output coloring for effects toggle so "disabled" is red and you can tell when the cycle has begun to repeat visually.

6.9
- Added Gryphon feather talisman teleport effect. You must have the collectible unlocked to use them.
- Added Ritual Casting EMOTE teleport effect.
- Added Darkswarm Talisman teleport effect.
- Fixed all onscreen and chat messages to be consistent and hopefully final version :)
- slightly increased ouroboros hourglass rotation speed so we dont fall into a trance watching it =p

6.8
- Fixed a settings display bug that would output both "disabled" and "not set" lines if you hadn't set your teleport home setting.
- Adjusted more text output to be short, clean and to the point.

6.7
- Adjusted some text descriptions and colors, mainly [RidinDirty] to a lighter shade everywhere.

6.6
- Added additional recharge weapon check for "IsItemInSlot" to eliminate the possibility of trying to charge non-existent weapons!
- Code optimizations

6.5
- Major code cleanup so all variables are local and can't interfere with other addons.
- Fixed telvar auto deposits showing previous balance after depositing.

6.4
- Added sound to auto recharge weapon and removed text spam as its not critical to know when its done and also avoids any possibility of spam should all yur weapons be broken at the same time.

6.3
- Added auto recharge weapons and /ridindirty_recharge slash command to toggle it on and off. Its still in a BETA phase as it took me 3days to get it working and its untested with dual wield and a few other scenarios. It also may spam chat multiple times repairing multiple items at the same time which should be a very rare occurance that theyre all nearly broken. Report any issue if you encounter any ty :).

6.2
- Added auto telvar deposit setting to settings display. Completely forgot this previously.

6.1
- Added auto deposit telvar into bank and /ridindirty_telvar slash command to toggle it on and off.

5.9
- Code optimizations and cleanup.

5.8
- Added IC auto accept queue function to the auto queue.
- Added or tweaked battleground auto accept queue as an actual feature to the auto queue since it unintentionally was already mostly working.

5.7
- Added cyrodiil auto accept function to auto queue. Now when auto queue is enabled it will auto accept cyrodiil queue's as well. Im reaching a little past just a group function here but its a feature I personally wanted. Working on battleground as well soon.

5.6
- Added mount player auto queue for those semi-rare occasions when your stuck in combat and cant mount them while they're waiting for you.
- Onscreen and chat message cleanup so they all match up better for aesthetics.
- Code optimizations.

5.5
- Added teleport home auto queue like the teleport to player function during combat.
- Fixed auto repair spamming chat with repair costs when interacting with assistant that cannot repair.

5.4
- Added teleport auto queue ANIMATED ICON & LABEL and removed the onscreen text messages. Now you can truely know if it is activated or not at all times. Also added the ability to toggle it on and off while in combat just pressing the same button.. TY guys on ESOUI.COM for the assistance.
- Code optimizations.

5.3
- After much thought I've decided to go with ACCOUNT-WIDE settings so you can swap toons and have same settings already functioning. I apologize but this change will force a saved variable reset and you'll have to redo your settings but never again hopefully and MUCH less between alts :). I may likely do one more reset in the semi-distant future to make sure everyone is on a clean slate.

5.2
- Fixed FontBoost requiring a reloadui and now applies it instantly.
- Cosmetic adjustments and added an auto teleport onscreen activation message so you know when its fired off. Am currently wanting to change that to some kind of hourglass thing while its active once I figure out how to do it, but this helps let you know if its still active or not for now.
- Code optimizations mostly to disable registered events for disabled features.

5.1
- *NEW* Added Font Boost! Slightly increases the nameplate font size for easier reading. Can be enabled/disabled via /ridindirty_fontboost. Currently forcing a reloadui when changing setting. Working still on a more "instant" way still but this works for now.

4.9
- Added onscreen display for auto teleport functions instead of chatbox. *beta*
- Tweaked some chatbox to onscreen messages.

4.8
- Added auto teleport to player after combat if you attempt to teleport during combat.
- Minor cosmetic adjustments.

4.7
- Fixed "is player online" check for porting. ty Baertram and ExoY of esoui.com for the help.

4.5
- Added /ridindirty_home to toggle between teleporting home INSIDE or OUTSIDE - minor cosmetic adjustments.

4.3
- Corrected several bugs with teleport effects being called improperly.. removed playeronline check for the moment untill i can find a workaround to get it working right.

4.2
- Correcting some intermittent port home inside instead of outside bugs.

4.1
- Added token of root sunder effect for those wanting a more druidic feel, tweaked some text formatting and effect timings and updated API version.
- Code optimizations.

3.9
- Added teleport to primary home "outside" function for a quick travel option.

3.8
- Added dragon flight illusion to teleport effects.
- slightly increased delay on effects for slower connections to be safe.

3.7
- Added /ridindirty_status info for the teleport effects feature.

3.6
- Added additional teleport effect "Neramos' Lighting Stick" and /ridindirty_effects slash command to toggle between them and disable effects completely. *** Effects require having the momento unlocked otherwise bypasses and uses normal teleport ***
- Code optimizations.

3.5
- Added teleporting effects using the fetish of anger momento if you have it unlocked for a more eerie feeling :).
- Code optimizations.

3.4
- Corrected some auto queue code issues - Polish - Likely final version for a while.

3.3
- Added auto queue function for the group finder and /ridindirty_queue to toggle on and off.

3.2
- Removed repair cost spam from chat and renamed slash commands to /ridindirty_status to display saved player and auto repair status and /ridindirty_repair to toggle auto repair on and off.
- Code optimizations.

3.1
- Added auto-repairs at merchant with /ridindirty_repair_toggle on/off toggle.

2.3
- Added /ridindirtysaved slash command to display current saved player added chat display of who your actually saving during save operation.

2.1
- Major re-write again & polish but now includes a teleport to saved player(in group) function as well.
**Requires re-saving the player again to update the saved variables file and updating your keybinds**

1.6
- Code optimizations.

1.5
- Removed mounting chat text as it was too much spam. Saving will continue to notify in chat. Also added leave group and reloadui functions

1.4 - Nearly total rewrite and polish but now has 2 keybinds to set/mount user that is independant of character/server and is presistant through reload/relog! Thanks Baertram and wookiefriseur for the help!

1.3
- Code optimizations.

1.2
- Code optimizations.

1.1
- Code optimizations.

1.0 - Original
Post A Reply Comment Options
Unread 02/08/23, 03:36 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Your APIversion in the txt files is old
Code:
## APIVersion: 100034 100036
This will show your addon as outdated.
The current APIversion can be found ingame via function GetAPIVersion() (current live is 101036, current PTS: 101037)
https://wiki.esoui.com/APIVersion

So maybe update that txt file with your next update.
Last edited by Baertram : 02/08/23 at 03:37 PM.
Report comment to moderator  
Reply With Quote
Unread 02/08/23, 06:42 PM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
Originally Posted by Baertram
Your APIversion in the txt files is old
Code:
## APIVersion: 100034 100036
This will show your addon as outdated.
The current APIversion can be found ingame via function GetAPIVersion() (current live is 101036, current PTS: 101037)
https://wiki.esoui.com/APIVersion

So maybe update that txt file with your next update.
damn didnt catch that.. ty bro..
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 03:38 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Your addon leaks variables to the global namespace and their name is not unique enough, so they might destroy other addons!
Please do a decent variable check ebfore releasing your addons, and add the local in front of them properly!

e.g.
hourglass -> Solution: Add that to RidinDirty.hourglass instead and it will be a least below your 1 global table!
effectEnabled -> Add a local in front and check where it's needed to be used. If more than 1 function need it define it at the top of your file as local. If only the 1 function needs it define it at the top of hat function as local

And your slash commands should be defined in your EVENT_ADD_ON_LOADED callback function first, and not before (makes no sense, in your addon's case, as your addon is not ready before that and your addon's code was not run properly before).
Last edited by Baertram : 02/27/23 at 03:38 AM.
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 04:08 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
Originally Posted by Baertram
Your addon leaks variables to the global namespace and their name is not unique enough, so they might destroy other addons!
Please do a decent variable check ebfore releasing your addons, and add the local in front of them properly!

e.g.
hourglass -> Solution: Add that to RidinDirty.hourglass instead and it will be a least below your 1 global table!
effectEnabled -> Add a local in front and check where it's needed to be used. If more than 1 function need it define it at the top of your file as local. If only the 1 function needs it define it at the top of hat function as local

And your slash commands should be defined in your EVENT_ADD_ON_LOADED callback function first, and not before (makes no sense, in your addon's case, as your addon is not ready before that and your addon's code was not run properly before).
OK thank you. ill get on it after a short break to enjoy it all working before all this breaks it =p
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 10:17 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
Originally Posted by Baertram
Your addon leaks variables to the global namespace and their name is not unique enough, so they might destroy other addons!
Please do a decent variable check ebfore releasing your addons, and add the local in front of them properly!

e.g.
hourglass -> Solution: Add that to RidinDirty.hourglass instead and it will be a least below your 1 global table!
effectEnabled -> Add a local in front and check where it's needed to be used. If more than 1 function need it define it at the top of your file as local. If only the 1 function needs it define it at the top of hat function as local

And your slash commands should be defined in your EVENT_ADD_ON_LOADED callback function first, and not before (makes no sense, in your addon's case, as your addon is not ready before that and your addon's code was not run properly before).
Ive been workin on it..

additional isunitdead check on the recharge execute CHECK!!
slash commands moved into onload CHECK!
hourglass converted into RidinDirty.HourGlass.... CHECK

working on all local variables now and done

OK!!! all variables now LOCAL with the exception of:
1. houglass lines are all RidinDirty.HourGlass.. now
2 RidinDirty.savedVariables.xxxxxxxxx = line are not as theyre just saving variables but if needs let me know
3. SetNameplateKeyboardFont(string.format(xxxxxxxx lines are not as well cuz theyre just setting the nameplate font

I think I got everything... one last test and uploading.. if you see anything else i apreciate the advice so noone has any issues.
Last edited by sinnereso : 02/27/23 at 10:46 AM.
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 11:41 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
Originally Posted by Baertram
Your addon leaks variables to the global namespace and their name is not unique enough, so they might destroy other addons!
Please do a decent variable check ebfore releasing your addons, and add the local in front of them properly!

e.g.
hourglass -> Solution: Add that to RidinDirty.hourglass instead and it will be a least below your 1 global table!
effectEnabled -> Add a local in front and check where it's needed to be used. If more than 1 function need it define it at the top of your file as local. If only the 1 function needs it define it at the top of hat function as local

And your slash commands should be defined in your EVENT_ADD_ON_LOADED callback function first, and not before (makes no sense, in your addon's case, as your addon is not ready before that and your addon's code was not run properly before).
as expected hittin a few issues but only found 1 so far which makes no sense to me. I even reformatted everything so this one is stumping me... getting errors on:

Code:
df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)

in this since changing them to local. its not liking the %s' effectEnabled) portion any longer:

Code:
if effectToggle == nil or effectToggle == "" or effectToggle == 0 then
		df("|c9900FF[RidinDirty]|r Teleport Effects Disabled")
	else
		if effectToggle == 347 then
			local effectEnabled = "Fetish of Anger"
			df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
		end
		if effectToggle == 349 then
			local effectEnabled = "Token of Root Sunder"
			df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
		end
		if effectToggle == 1228 then
			local effectEnabled = "Neramo's Lightning"
			df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
		end
		if effectToggle == 6046 then
			local effectEnabled = "Dragon Flight Illusion"
			df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
		end
	end
I cant get them any closer to where the variable is being set and theyre not used anywhere else.
Last edited by sinnereso : 02/27/23 at 11:43 AM.
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 01:03 PM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
ok got her all fixed up and caught a telvar bank bug in the process.. was displaying previous balance after depositing..

posting..
Report comment to moderator  
Reply With Quote
Unread 02/28/23, 10:29 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Originally Posted by sinnereso
df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
The error messages appear cuz you forgot to add the , between %s" and effectEnabled, and got nothing to do with local or not local
Last edited by Baertram : 02/28/23 at 10:29 AM.
Report comment to moderator  
Reply With Quote
Unread 02/28/23, 10:47 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
Originally Posted by Baertram
Originally Posted by sinnereso
df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
The error messages appear cuz you forgot to add the , between %s" and effectEnabled, and got nothing to do with local or not local
Yes i found that but then realized i had 4 lines for the options anyway so just went with pure text. I'm not an expert on the arrays etc yet so i work with 4 lines for now
Last edited by sinnereso : 02/28/23 at 10:48 AM.
Report comment to moderator  
Reply With Quote
Unread 03/12/23, 05:13 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
I currently have chat window context menu disabled but guild, group and friends list working amazing with optional LibCustomMenu. TY Votan for the upgrades to it.

I may remove the chat window feature since you need to be in group, guild or friends to be able to travel to anyone and in group to mount them anyway making it a nearly useless feature saving total randoms from chat.

I've left the original save reticle target with keybind as a backup leaving LibCustomMenu as optional instead of required. Most wont be changing they're saved player often and likely are playing with significant other. For those that require more hardcore use, LibCustomMenu is available to take it next level
Last edited by sinnereso : 03/12/23 at 05:36 AM.
Report comment to moderator  
Reply With Quote
Unread 03/12/23, 11:43 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Code:
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { savedPlayer = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { autoRepair = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { autoRecharge = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { autoBank = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { autoQueue = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { effectId = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { effectDelay = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { travelOutside = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { fontBoost = nil })
aehm WHY? You were already told weeks ago that this is bull****
Just call it ONCE with all that needed default values in 1 table:
RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { savedPlayer = nil, autoRepair= nil, ... })


And if the defalt values are all nil you do not even need to explicitly set them, just use
RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { } )
Report comment to moderator  
Reply With Quote
Unread 03/13/23, 10:40 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
Well.. because im still weak on tables! I only recently figure out what and how this works

If i dont fully understand it then its not going in is my general rule

I expect overtime ill be cleaning stuff up as it makes sense to me because Im the one that has to track down any bugs.

This hasn't been forgotten though from the previous mention of it and is on my todo list.

**EDIT OK added it that way and appears to be working.. ill leave my original stuff commented out for the moment incase of any issues.


Code:
RidinDirty = {
	name = "RidinDirty",
	author = "Michael Cullen(@sinnereso)",
	version = "2023.3.13",
	svName = "RidinDirtyVars",
	svVersion = 2,
}
Last edited by sinnereso : 03/13/23 at 11:06 AM.
Report comment to moderator  
Reply With Quote
Unread 03/14/23, 08:09 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Another hint for your performance:
EVENT_INVENTORY_SINGLE_SLOT_UPDATE
Events like these fire very often, for different kind of tasks.
e.g. some fire for the durability or item charge value -> your auto recharge check. But they also fire for stack split, item move, etc.

If you only want to have it fire for your addon for some of these cases use event filters to filter the events accordingly to your needs:
https://wiki.esoui.com/AddFilterForEvent
The event EVENT_INVENTORY_SINGLE_SLOT_UPDATE can use e.g. the REGISTER_FILTER_INVENTORY_UPDATE_REASON filter type.
Possible update reasons are:
https://wiki.esoui.com/Globals#InventoryUpdateReason


If you add an eventfilter make sure the name passed in as 1st parameter is the exactly same as used for your normal event, that you want to filter!
e.g.

Lua Code:
  1. local myAddonEventNameInvSingleSlotUpdate = "myAddonNameEventInventorySingleSlotUpdate"
  2. EVENT_MANAGER:RegisterForEvent(myAddonEventNameInvSingleSlotUpdate, EVENT_INVENTORY_SINGLE_SLOT_UPDATE, function() ...... end)
  3. EVENT_MANAGER:FilterForEvent(myAddonEventNameInvSingleSlotUpdate, EVENT_INVENTORY_SINGLE_SLOT_UPDATE, REGISTER_FILTER_INVENTORY_UPDATE_REASON, updateReasonFromTheListLinkedAboveHereWhichYouWanToFilter_forExample_TheDurabilityUpdate_or_TheItemChargeValue)

You could also check for the bagID be BAG_WORN so no items in your inventory will be checked which currently are not equipped.

This will make your addon not listen (and the event for your addon not even fire) for the other non-filtered inventory update reasons.
And this will make your callback function used in the event no need to check for parameter inventoryUpdateReason anymore! As it's prefiltered in C code, before it even hits lua code, already. -> Big performance gain and very needed as ppl run multiple addons at the same time and each addon in combination with vanilla game code slows down the stuff a bit, more and more and more...
Last edited by Baertram : 03/14/23 at 08:12 AM.
Report comment to moderator  
Reply With Quote
Unread 03/14/23, 08:50 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
ty ill look into it. I was trying to keep the performance high by only checking on charge use which only happens every few seconds while in combat usually. Ill see what i can do with this.
Last edited by sinnereso : 03/14/23 at 08:50 AM.
Report comment to moderator  
Reply With Quote
Unread 03/14/23, 09:20 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 244
File comments: 65
Uploads: 4
Originally Posted by Baertram
Another hint for your performance:

could i now trim it down to this since the filters are inplace?:

Code:
--addonloaded
EVENT_MANAGER:RegisterForEvent("RidinDirty", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, RidinDirty.InventoryUpdate)
EVENT_MANAGER:AddFilterForEvent("RidinDirty", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, REGISTER_FILTER_INVENTORY_UPDATE_REASON, INVENTORY_UPDATE_REASON_ITEM_CHARGE, REGISTER_FILTER_BAG_ID, BAG_WORN)

--functions
function RidinDirty.InventoryUpdate()
	if not IsUnitDead("player") then
		RidinDirty.AutoRecharge()
	else
		return
	end
end
Im testing this now and appears to be working fine but would u recomend it?
I'm going with it for now.. if you think its bad i welcome imput but otherwise seems to be perfect.
Last edited by sinnereso : 03/14/23 at 12:04 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: