Download
(57 Kb)
Download
Updated: 12/28/23 06:24 PM
Addon for:
Leo's Altholic.
Pictures
File Info
Compatibility:
Endless Archive (9.2.5)
Updated:12/28/23 06:24 PM
Created:03/17/23 05:09 PM
Monthly downloads:134
Total downloads:3,298
Favorites:8
MD5:
Leo's Altholic (Fix)
Version: 1.9.4
by: sshogrin [More]
This is a fixed, updated API version of https://www.esoui.com/downloads/info...sAltholic.html

There were a few fixes and clean up to the lua (thanks ckd), and fixes were implemented to show correct max level for some skill lines.

As of the latest update, lots of UI errors, so the xml was fixed there and tested.

I have read thru other comments on the original, not sure if I can implement any of those, as I have wish lists myself that I would like to add. If anybody would like to help with some of that, I would be more than interested in the help.

I have tried contacting the original author thru here, as well as thru email, and have not heard back in over a month. I thought I could at least share this updated version with everybody.
1.9.4 --Fixed Leo window to show all 20 characters without having to scroll. Inventory tab will still need to scroll to see all characters.

1.9.3 --Updated API. Fixed website link to this and added myself to the Author/fix line. Fixed research timers (thanks Shantarna for the code!)

1.9.2 --Fixed UI error for resizeToFitDescendent, API version, addon version update.

1.9.1 --Update fix (thanks ckd), fix to report some skill lines max level correctly.
Archived Files (3)
File Name
Version
Size
Uploader
Date
1.9.3
57kB
sshogrin
10/30/23 12:59 PM
1.9.3
57kB
sshogrin
10/29/23 07:07 PM
1.9.2
56kB
sshogrin
03/17/23 05:09 PM


Post A Reply Comment Options
Unread 12/28/23, 04:53 PM  
sshogrin
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 62
Uploads: 5
Originally Posted by SimpsForBreda
I can't tell from provided screenshots/changelog, does this expand the GUI to show the new maximum of 20 toons?
(currently I have to scroll to show toons #19 and #20 in full)


if not, down to incorporate that change?
I'm down to help to implement if I'm able, but keeping it maintained in one version would be ideal






EDIT:
I figured this out on the old 1.9.0 version...

in LeoAltholic.xml:
- replace
Code:
y="600"
with
Code:
y="650"
- replace
Code:
y="648"
with
Code:
y="700"
Yes, you currently have to scroll down to see all characters, but I can implement those changes very easily.
Thanks for your input.
Last edited by sshogrin : 12/28/23 at 06:21 PM.
Report comment to moderator  
Reply With Quote
Unread 12/08/23, 07:00 PM  
SimpsForBreda
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 9
Uploads: 2
I can't tell from provided screenshots/changelog, does this expand the GUI to show the new maximum of 20 toons?
(currently I have to scroll to show toons #19 and #20 in full)


if not, down to incorporate that change?
I'm down to help to implement if I'm able, but keeping it maintained in one version would be ideal






EDIT:
I figured this out on the old 1.9.0 version...

in LeoAltholic.xml:
- replace
Code:
y="600"
with
Code:
y="650"
- replace
Code:
y="648"
with
Code:
y="700"
Last edited by SimpsForBreda : 12/09/23 at 01:02 PM.
Report comment to moderator  
Reply With Quote
Unread 10/29/23, 07:00 PM  
sshogrin
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 62
Uploads: 5
Re: Fixing Research Timers

Originally Posted by Shantarna
I was finding that my research timers were on the summary window and on the toolbar were reporting the wrong times. So I looked into it and did some sleuthing into other mods and how they do it. I am not entirely sure why it works, but it seems to fix my problems. I verified it fixed the timers on the summary window and on the toolbar. It's a bit more complicated of a change but feel free to poach it if you like.

Fixing the Summary Window:

File: research.lua, Function: LeoAltholicResearchList:SetupEntry

2 x changes:

1) After Line 28, add two new lines to define some variables you need later:

local isCurrentPlayer = (data.name == LeoAltholic.CharName)
local now = GetTimeStamp()

2) Once above is in, add the following after Line 45 (in the for _, research in pairs... loop):

if isCurrentPlayer then
local _, remaining = GetSmithingResearchLineTraitTimes(craft, research.line, research.trait)
research.doneAt = remaining + now
else
local remaining = GetDiffBetweenTimeStamps(research.doneAt, now)
research.doneAt = remaining + now
end


Fixing the Toolbar:

File: LeoAltoholic_API.lua, Function: LeoAltholic.GetResearchCounters

After Line 205 add:

if charName == LeoAltholic.CharName then
local _, remaining = GetSmithingResearchLineTraitTimes(craft, research.line, research.trait)
if remaining ~= nil then
research.doneAt = remaining + GetTimeStamp()
end
else
local now = GetTimeStamp()
local remaining = GetDiffBetweenTimeStamps(research.doneAt, now)
research.doneAt = remaining + now
end


NOTE: Edited to fix an error in the LeoAltoholic_API.lua code (added null check).
Thanks for this. Edited my version and testing out currently. Will release update with API in a day or 2.
Report comment to moderator  
Reply With Quote
Unread 10/16/23, 10:51 AM  
Shantarna

Forum posts: 0
File comments: 2
Uploads: 0
Fixing Research Timers

I was finding that my research timers were on the summary window and on the toolbar were reporting the wrong times. So I looked into it and did some sleuthing into other mods and how they do it. I am not entirely sure why it works, but it seems to fix my problems. I verified it fixed the timers on the summary window and on the toolbar. It's a bit more complicated of a change but feel free to poach it if you like.

Fixing the Summary Window:

File: research.lua, Function: LeoAltholicResearchList:SetupEntry

2 x changes:

1) After Line 28, add two new lines to define some variables you need later:

local isCurrentPlayer = (data.name == LeoAltholic.CharName)
local now = GetTimeStamp()

2) Once above is in, add the following after Line 45 (in the for _, research in pairs... loop):

if isCurrentPlayer then
local _, remaining = GetSmithingResearchLineTraitTimes(craft, research.line, research.trait)
research.doneAt = remaining + now
else
local remaining = GetDiffBetweenTimeStamps(research.doneAt, now)
research.doneAt = remaining + now
end


Fixing the Toolbar:

File: LeoAltoholic_API.lua, Function: LeoAltholic.GetResearchCounters

After Line 205 add:

if charName == LeoAltholic.CharName then
local _, remaining = GetSmithingResearchLineTraitTimes(craft, research.line, research.trait)
if remaining ~= nil then
research.doneAt = remaining + GetTimeStamp()
end
else
local now = GetTimeStamp()
local remaining = GetDiffBetweenTimeStamps(research.doneAt, now)
research.doneAt = remaining + now
end


NOTE: Edited to fix an error in the LeoAltoholic_API.lua code (added null check).
Last edited by Shantarna : 10/16/23 at 05:32 PM.
Report comment to moderator  
Reply With Quote
Unread 09/25/23, 03:34 PM  
DohNotAgain

Forum posts: 1
File comments: 110
Uploads: 0
Originally Posted by sshogrin
I've had quite a few friends ask about companion info.
The only PvP info is for Emp in the Skills 2 tab.
The type of PVP info I was talking about is:

Assault and Support skill level. (Currently on Skills tab 2. They'd be nice on a multi item PVP info tab.)
Home campaign.
End of campaign reward tier.
AVA rank number and name.
Possibly AP needed for next AVA rank.

I love how this addon displays the information clearly, cleanly, and easy to read.
The views are not cluttered to look at or read.
Report comment to moderator  
Reply With Quote
Unread 09/23/23, 07:10 AM  
sshogrin
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 62
Uploads: 5
Originally Posted by DohNotAgain
I wish there were tabs for both PVP and companion info.

I'm guessing you are just keeping this operational.
THANK YOU!
Sadly, I am not a LUA programmer so can't help fix or create anything.
I've had quite a few friends ask about companion info.
The only PvP info is for Emp in the Skills 2 tab.
Report comment to moderator  
Reply With Quote
Unread 09/23/23, 07:09 AM  
sshogrin
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 62
Uploads: 5
Originally Posted by Vorkrunne
I'm in Pacific time.

I've noticed that after 11 PM, the checklist is appearing as if the daily timer was reset.
But reset isn't until 3 AM.

Is there a fix for this?
Not sure, I'd have to look at the LUA and see if they have a "time zone" set for this.
I'm mainly keeping this working when API gets changed.
Report comment to moderator  
Reply With Quote
Unread 09/22/23, 12:25 AM  
DohNotAgain

Forum posts: 1
File comments: 110
Uploads: 0
I wish there were tabs for both PVP and companion info.

I'm guessing you are just keeping this operational.
THANK YOU!
Sadly, I am not a LUA programmer so can't help fix or create anything.
Report comment to moderator  
Reply With Quote
Unread 08/30/23, 07:17 PM  
Vorkrunne

Forum posts: 0
File comments: 5
Uploads: 0
I'm in Pacific time.

I've noticed that after 11 PM, the checklist is appearing as if the daily timer was reset.
But reset isn't until 3 AM.

Is there a fix for this?
Report comment to moderator  
Reply With Quote
Unread 06/04/23, 11:26 AM  
sshogrin
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 62
Uploads: 5
Re: Re: Re: Re: Re: Research timers not updating correctly?

Originally Posted by Mr.Envy
Originally Posted by sshogrin
You could try manually deleting the SV file from within the SavedVariables folder.
Pretty much all of this has been working just fine for my main account, as well as alt account, and I haven't had any of my friends have issues with either of these.
Deleting the saved variables didn't help in any way. As for the checklist showing up again, it is because the daily reset time of the addon is 3 hours later than the server reset time. In my case, at 06:00 AM the server resets and I am able to do daily writs again, and the addons' daily reset is at 09:00 AM, so if I do the writs in that 3 hour interval, the checklist will eventually come back after 09:00 AM. Hope this helps you to deal with this issue ^^

Originally Posted by Mr.Envy
And also, another problem with the checklist I'm having and I'm pretty sure everyone else experiences, is that the arrow to shrink the checklist window isn't of much help. It works upon pressing it, does what it should but the window gets resized in a matter of seconds, making the feature useless.
Any feedback on this? Am I the only one experiencing this?
I haven't really "noticed" that, my daily writ tab goes away after completing the dailies.
Research timers for finished research, when it's the last items to be researched gets a little bugged too, not sure how that is handled since I didn't write the original addon...any help would be appreciated.
I would have to try to dig deeper in to the LUA code for the daily reset also. Sometimes closeing LEO's then reopening refreshes some things I've noticed...again, I've fixed a bunch of LUA code so there are no UI errors like what came up with a couple updates that changed some of the LUA event handlers.
Any help would be great, I will implement and update as I can.
Report comment to moderator  
Reply With Quote
Unread 05/27/23, 08:22 PM  
Mr.Envy
 
Mr.Envy's Avatar

Forum posts: 20
File comments: 99
Uploads: 0
Re: Re: Re: Re: Research timers not updating correctly?

Originally Posted by sshogrin
You could try manually deleting the SV file from within the SavedVariables folder.
Pretty much all of this has been working just fine for my main account, as well as alt account, and I haven't had any of my friends have issues with either of these.
Deleting the saved variables didn't help in any way. As for the checklist showing up again, it is because the daily reset time of the addon is 3 hours later than the server reset time. In my case, at 06:00 AM the server resets and I am able to do daily writs again, and the addons' daily reset is at 09:00 AM, so if I do the writs in that 3 hour interval, the checklist will eventually come back after 09:00 AM. Hope this helps you to deal with this issue ^^

Originally Posted by Mr.Envy
And also, another problem with the checklist I'm having and I'm pretty sure everyone else experiences, is that the arrow to shrink the checklist window isn't of much help. It works upon pressing it, does what it should but the window gets resized in a matter of seconds, making the feature useless.
Any feedback on this? Am I the only one experiencing this?
Last edited by Mr.Envy : 05/30/23 at 10:14 AM.
Report comment to moderator  
Reply With Quote
Unread 05/24/23, 10:06 AM  
sshogrin
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 62
Uploads: 5
Re: Re: Re: Research timers not updating correctly?

Originally Posted by Mr.Envy
Originally Posted by sshogrin
Not sure on this...I haven't had any issues like this. My timers seem to be working just fine.
Strange... it happened more than once to me in the last few weeks or so to have to relog on another toon to recraft researching items because the altholic gave false info (old info). I never had this problem before.
This also looks like an issue regarding SavedVars, just like the checklist one, at least that's how it seems to me.

Can it be because of my saved variables or is there something wrong with the coding inside the addon?
If it is indeed my saved vars, what can I do in this situation?
Doing a fresh reinstall of Altholic with deleted saved variables will work?
Originally Posted by sshogrin
If you have 2 computers and do writs on one computer, then load the character on a different computer, it will show that you haven't done writs on the toon, even though you have.
I believe it's because of the SavedVariable file.
Regarding this, I usually only play from one computer, very rarely, like once in 3-4 months my wife also logs on my account from hers. For example, it's been more than 3 months since my account has been logged into from another computer than mine. And I only play on the EU server, I don't even have an account on NA.

Okay, that put aside, the checklist issue happens pretty often to me lately, on at least 1 toon from 14. For some reason the addon doesn't see the writs as being done, even if I did them earlier in the same day, with the same addons, on the same computer, without even restarting the game, only switching characters.

And also, another problem with the checklist I'm having and I'm pretty sure everyone else experiences, is that the arrow to shrink the checklist window isn't of much help. It works upon pressing it, does what it should but the window gets resized in a matter of seconds, making the feature useless.

You could try manually deleting the SV file from within the SavedVariables folder.
Pretty much all of this has been working just fine for my main account, as well as alt account, and I haven't had any of my friends have issues with either of these.
Report comment to moderator  
Reply With Quote
Unread 05/24/23, 06:31 AM  
Mr.Envy
 
Mr.Envy's Avatar

Forum posts: 20
File comments: 99
Uploads: 0
Re: Re: Research timers not updating correctly?

Originally Posted by sshogrin
Not sure on this...I haven't had any issues like this. My timers seem to be working just fine.
Strange... it happened more than once to me in the last few weeks or so to have to relog on another toon to recraft researching items because the altholic gave false info (old info). I never had this problem before.
This also looks like an issue regarding SavedVars, just like the checklist one, at least that's how it seems to me.

Can it be because of my saved variables or is there something wrong with the coding inside the addon?
If it is indeed my saved vars, what can I do in this situation?
Doing a fresh reinstall of Altholic with deleted saved variables will work?
Originally Posted by sshogrin
If you have 2 computers and do writs on one computer, then load the character on a different computer, it will show that you haven't done writs on the toon, even though you have.
I believe it's because of the SavedVariable file.
Regarding this, I usually only play from one computer, very rarely, like once in 3-4 months my wife also logs on my account from hers. For example, it's been more than 3 months since my account has been logged into from another computer than mine. And I only play on the EU server, I don't even have an account on NA.

Okay, that put aside, the checklist issue happens pretty often to me lately, on at least 1 toon from 14. For some reason the addon doesn't see the writs as being done, even if I did them earlier in the same day, with the same addons, on the same computer, without even restarting the game, only switching characters.

And also, another problem with the checklist I'm having and I'm pretty sure everyone else experiences, is that the arrow to shrink the checklist window isn't of much help. It works upon pressing it, does what it should but the window gets resized in a matter of seconds, making the feature useless.
Last edited by Mr.Envy : 05/24/23 at 06:53 AM.
Report comment to moderator  
Reply With Quote
Unread 05/23/23, 09:47 PM  
sshogrin
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 62
Uploads: 5
Re: Research timers not updating correctly?

Originally Posted by Mr.Envy


This doesn't seem right... ^^


Also the checklist sometimes acts funny, for example I did the writs this morning, the checklist disappeared, and after I logged back in later today it showed up again.
Not sure on this...I haven't had any issues like this. My timers seem to be working just fine.
Report comment to moderator  
Reply With Quote
Unread 05/23/23, 09:45 PM  
sshogrin
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 62
Uploads: 5
Re: Re: Research timers not updating correctly?

Originally Posted by joerginger
Originally Posted by Mr.Envy
Also the checklist sometimes acts funny, for example I did the writs this morning, the checklist disappeared, and after I logged back in later today it showed up again.
I noticed that, too. If I do writs on the EU server early in the morning, the checklist buttons all turn red again when I log into the character later in the day. It looks like the addon uses the old writ reset time to reset daily writ progress.
I have fixed mainly LUA errors. I have noticed that doing things on both servers can mess up LeoAltholic because it isn't setup to do both servers.
If you have 2 computers and do writs on one computer, then load the character on a different computer, it will show that you haven't done writs on the toon, even though you have.
I believe it's because of the SavedVariable file.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: