Hi Zane,

Sounds like an interesting addon, just a quick question for further clarification of what your addon really does, does it encompass all possible enchants or only 'discovered' ones?

Off-topic for second question, what is the addon you are running that displays your research times in detail (Top left of screen in addon pic)

Sounds good.... ill hope for compatibility with german in future updates

This addon fails to initialize when used in conjunction with the Luminary (teleporter) addon

user:/AddOns/Enchanter.lua:79: in function 'Enchanter.initialize'
user:/AddOns/Enchanter.lua:111: in function 'on_addon_load'

Also a request :
any way to show/sort by level of the enchants?

Cheers for the reply to first question, I'd still like to know the addon that displays your research times in detail on the upper left of your addon info pic

Cheers Zane, loving your addon btw, makes life alot easier once having invested some points into the enchanting tree.

It appears you have Deni incorrectly listed as a component of an Armor Glyph of Health.

(v 1.0.0) Armor Glyph of Health - Additive/Deni/Aspect

Deni should affect stamina, not health, according to the below reference.

http://tamrieljournal.com/crafting-a...ns/enchanting/

At first thank you for your addon, it is really useful.

I have small request - please use local variables instead of global variables. It will save you and also other authors lots of troubles with debugging addons. When I was trying new code, I was wodering why "/zgoo self" gives me Enchater.listview...

1. Library Unicorn exposes variable self to global, so either ask author to update his library or change line 207 in List.lua to:
   
   Lua Code:

   local self = {

2. Your defined variables j, bagSize, bankSize and itemName leaks to global. As there is no point to use global variables, make them local. I suggest the following changes (line number: changed code):
   
   Code:

   001: local Enchater = {
   113:     EVENT_MANAGER:RegisterForEvent("Enchanter", EVENT_ADD_ON_LOADED, on_addon_load)
   114:end
   122:	local j, bagSize = GetBagInfo(1)
   123:	local j, bankSize = GetBagInfo(2)
   126:		local itemName = GetItemName(2, i)
   155:		local itemName = GetItemName(1, i)
   187:	local j, bagSize = GetBagInfo(1)
   188:	local j, bankSize = GetBagInfo(2)
   191:		local itemName = GetItemName(2, i)
   262:		local itemName = GetItemName(1, i)
   336:	local j, bagSize = GetBagInfo(1)
   337:	local j, bankSize = GetBagInfo(2)
   340:		local itemName = GetItemName(2, i)
   485:		local itemName = GetItemName(1, i)

Thank you.

Third line should be Stamina.

To do a quick self-fix for that arror, open up the Enchanter.lua file in Addons/Enchanter and scroll down to line 658 or use Ctrl+F to open up Find Next search box and copy+paste:

Armor Glyph of Health - Additive/Deni/Aspect") then hit next, which will bring you to the line you need to edit.

To implement the quick fix, edit the above line so it reads:

Armor Glyph of Stamina - Additive/Deni/Aspect")

Save the enchanter.lua file and your done.

More or less on topic, a few weeks back I messaged Zane with an edited version of Enchanter incorporating various variable fixes and that particular edit, unfortunately Zane seems to be MIA at present...