Download
(3 Kb)
Download
Updated: 02/07/23 02:57 PM
Compatibility:
Scribes of Fate (8.3.5)
Firesong (8.2.5)
Updated:02/07/23 02:57 PM
Created:12/15/22 11:26 AM
Monthly downloads:23
Total downloads:2,178
Favorites:1
MD5:
Breda's Magnificent Mead Reminder
Version: v1.69420
by: SimpsForBreda [More]
Shameless one-off of zetheras's excellent Zeth's Experience Scroll Reminder, modified to show status of Breda's Magnificent Mead for New Life Festival 2022 and The Pie of Misrule for Jester's Festival 2023

https://www.esoui.com/downloads/info3107-ZethsExperienceScrollReminder.html


You can run /BredaExp to see the current status of the addon
/BredaExp on to turn it back on
/BredaExp off to turn it off


[v1.69420 release]
- updated to support Jester's Festival 2023
- made icons more fun/thematic


[v0.69420 release]
- updated metadata
- updated GUI so text would not exceed width of field
Optional Files (0)


Archived Files (2)
File Name
Version
Size
Uploader
Date
v0.69420
3kB
SimpsForBreda
12/20/22 09:12 PM
v0.69
3kB
12/15/22 11:26 AM


Post A Reply Comment Options
Unread 12/22/22, 04:31 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
No problem, thanks for considering this.
If you need help write me a pm and send me a link to your changed files before upload, and I'll gladly check them and help you.

Originally Posted by SimpsForBreda
Originally Posted by Baertram
Hello and welcome to addon creation.
Your addon's txt file is using an outdated APIversion and thus shows outdated from the start.
Code:
## APIVersion: 100035
Please check the current api version here at the Wiki (live server):
https://wiki.esoui.com/APIVersion#live_API_version

or ingame via chat script:
Code:
/script d(GetAPIVersion())
And at leats for new addons update the APIversion in your addon's manifest (txt) file properly.
Thank you.


And in your addon's EVENT_ADD_ON_LOADED callback function you should always unregister the same event after it was run for your addon, as else the same code will be executed for EACH other enabled addon too!

Lua Code:
  1. function BredaExp.OnAddOnLoaded(event, addonName)
  2.   if addonName == BredaExp.name then
  3.     EVENT_MANAGER:UnregisterForEvent(BredaExp.name, EVENT_ADD_ON_LOADED) --unregister so BredaExp.OnAddOnLoaded won't be called for each other addon again and again, doing the if addonName == BredaExp.name check eacht ime for nuts!
  4.     BredaExp:Initialize()
  5.   end
  6. end


Also very important:
Your addon is leaking variables to the global namespace, e.g.
zethText

Please define that local at the start of your file OR even better: Add it to your global table BredaExp instead!

BredaExp.zethText = ""
And then always use BredaExp.zethText in your code instead of only zethText

Else it will be added to the global table _G and pollute this, where it is not needed anywhere else as in your 1 file BredaExp.lua and could be locally defned thus.

Also a best practice would be to NOT define the function name BredaExpTimeRemaining but instead add it to BredaExp.TimeRemaining so it's all connected to your 1 global table BredaExp, and not creating "unconnected" functions and variables here and there.


OK, thank you for the constructive feedback, it's much appreciated!
I'll try my best to implement these changes to be a good add-on citizen, but as you may have inferred, I'm not a great coder and have minimal experience with Lua.
Report comment to moderator  
Reply With Quote
Unread 12/21/22, 11:36 AM  
SimpsForBreda
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 9
Uploads: 2
Originally Posted by Baertram
Hello and welcome to addon creation.
Your addon's txt file is using an outdated APIversion and thus shows outdated from the start.
Code:
## APIVersion: 100035
Please check the current api version here at the Wiki (live server):
https://wiki.esoui.com/APIVersion#live_API_version

or ingame via chat script:
Code:
/script d(GetAPIVersion())
And at leats for new addons update the APIversion in your addon's manifest (txt) file properly.
Thank you.


And in your addon's EVENT_ADD_ON_LOADED callback function you should always unregister the same event after it was run for your addon, as else the same code will be executed for EACH other enabled addon too!

Lua Code:
  1. function BredaExp.OnAddOnLoaded(event, addonName)
  2.   if addonName == BredaExp.name then
  3.     EVENT_MANAGER:UnregisterForEvent(BredaExp.name, EVENT_ADD_ON_LOADED) --unregister so BredaExp.OnAddOnLoaded won't be called for each other addon again and again, doing the if addonName == BredaExp.name check eacht ime for nuts!
  4.     BredaExp:Initialize()
  5.   end
  6. end


Also very important:
Your addon is leaking variables to the global namespace, e.g.
zethText

Please define that local at the start of your file OR even better: Add it to your global table BredaExp instead!

BredaExp.zethText = ""
And then always use BredaExp.zethText in your code instead of only zethText

Else it will be added to the global table _G and pollute this, where it is not needed anywhere else as in your 1 file BredaExp.lua and could be locally defned thus.

Also a best practice would be to NOT define the function name BredaExpTimeRemaining but instead add it to BredaExp.TimeRemaining so it's all connected to your 1 global table BredaExp, and not creating "unconnected" functions and variables here and there.


OK, thank you for the constructive feedback, it's much appreciated!
I'll try my best to implement these changes to be a good add-on citizen, but as you may have inferred, I'm not a great coder and have minimal experience with Lua.
Report comment to moderator  
Reply With Quote
Unread 12/21/22, 02:37 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Hello and welcome to addon creation.
Your addon's txt file is using an outdated APIversion and thus shows outdated from the start.
Code:
## APIVersion: 100035
Please check the current api version here at the Wiki (live server):
https://wiki.esoui.com/APIVersion#live_API_version

or ingame via chat script:
Code:
/script d(GetAPIVersion())
And at leats for new addons update the APIversion in your addon's manifest (txt) file properly.
Thank you.


And in your addon's EVENT_ADD_ON_LOADED callback function you should always unregister the same event after it was run for your addon, as else the same code will be executed for EACH other enabled addon too!

Lua Code:
  1. function BredaExp.OnAddOnLoaded(event, addonName)
  2.   if addonName == BredaExp.name then
  3.     EVENT_MANAGER:UnregisterForEvent(BredaExp.name, EVENT_ADD_ON_LOADED) --unregister so BredaExp.OnAddOnLoaded won't be called for each other addon again and again, doing the if addonName == BredaExp.name check eacht ime for nuts!
  4.     BredaExp:Initialize()
  5.   end
  6. end


Also very important:
Your addon is leaking variables to the global namespace, e.g.
zethText

Please define that local at the start of your file OR even better: Add it to your global table BredaExp instead!

BredaExp.zethText = ""
And then always use BredaExp.zethText in your code instead of only zethText

Else it will be added to the global table _G and pollute this, where it is not needed anywhere else as in your 1 file BredaExp.lua and could be locally defned thus.

Also a best practice would be to NOT define the function name BredaExpTimeRemaining but instead add it to BredaExp.TimeRemaining so it's all connected to your 1 global table BredaExp, and not creating "unconnected" functions and variables here and there.
Last edited by Baertram : 12/21/22 at 02:46 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: