Go to Page... |
Updated: | 04/22/24 11:50 AM |
Created: | 03/21/21 11:05 AM |
Monthly downloads: | 198 |
Total downloads: | 4,834 |
Favorites: | 23 |
MD5: |
Comment Options |
03/24/21, 02:40 AM | |
|
Investigations!
Hey all,
Fellow story-loving AddOn author here. Saw this and just had to take a look. Anyway, seeing as I've done similar stuff in the past with some of my AddOns, figured I could chime in and potentially help out. Or at least confirm some things. With the SavedVars string issue, I've personally had no issue with Code:
length <= 1900 As for the map issue, I kinda solved that too. Kinda. I re-implemented it without LibGPS, because I've never used it before and don't know how it works. I've highlighted in red what I removed/changed, and green what I added. Code:
function StorySaverInterface:ShowOnMap(data) local eventData = data.eventData local zoneIndex = eventData.zoneIndex local globalX = eventData.x local globalY = eventData.y --SCENE_MANAGER:Show('worldMap') --I opted to use a base ZOS function to do the same thing ZO_WorldMap_ShowWorldMap() --Get MapIndex local zoneId = GetZoneId(zoneIndex) if GetParentZoneId(zoneId) ~= zoneId then --This implementation will only take you to the zone map. Therefore it's necessary to account for subzones zoneId = GetParentZoneId(zoneId) end local mapIndex = GetMapIndexByZoneId(zoneId) --Set to Map ZO_WorldMap_SetMapByIndex(mapIndex) --LibGPS3:MapZoomInMax(globalX, globalY) if LibMapPing ~= nil then local localX, localY = LibGPS3:GlobalToLocal(globalX, globalY) LibMapPing:SetMapPing(MAP_PIN_TYPE_RALLY_POINT, MAP_TYPE_LOCATION_CENTERED, localX, localY) zo_callLater(function() ZO_WorldMap_PanToNormalizedPosition(localX, localY) end, 1500) end end Also fun fact, this AddOn will store your interactions with custom books in The Librarium.
Last edited by Alianym : 03/24/21 at 02:42 AM.
|
|
Alianym |
View Public Profile |
Send a private message to Alianym |
Find More Posts by Alianym |
Add Alianym to Your Buddy List |
03/24/21, 01:51 PM | ||
|
Re: Investigations!
For now i am trying to do global refactoring of this addon. New feature is coming (deduplication). Variables structure will be changed and i write migration function, but this is dangerous, so i am trying to be careful and test all. Then i will try to do something with map. About Librarium. It overrides SetupBook function. My AddOn does same. And Librarian too. So question is in order, who did it last. So last will receive all calls of SetupBook function. I am not advanced AddOn creator, just beginner, but i think this is normal behavior. Correct me if i am wrong. Thank you |
|
|
f1rex |
View Public Profile |
Send a private message to f1rex |
Send email to f1rex |
Visit f1rex's homepage! |
Find More Posts by f1rex |
Add f1rex to Your Buddy List |
f1rex |
View Public Profile |
Send a private message to f1rex |
Send email to f1rex |
Visit f1rex's homepage! |
Find More Posts by f1rex |
Add f1rex to Your Buddy List |
03/24/21, 03:04 PM | |
|
Errors
Got this today upon login, after updating:
Code:
user:/AddOns/StorySaver/StorySaver.lua:71: unexpected symbol near 'for' Code:
user:/AddOns/StorySaver/Interface.lua:357: attempt to index a nil value stack traceback: user:/AddOns/StorySaver/Interface.lua:357: in function 'handler' user:/AddOns/StorySaver/Interface.lua:364: in function 'StorySaverInterface.SetupCheckableButton' |caaaaaa<Locals> control = ud, texturePrefix = "EsoUI/Art/MainMenu/menubar_not...", handler = user:/AddOns/StorySaver/Interface.lua:344 </Locals>|r StorySaverEventListFrameFilterAndSearchSubtitles_Initialized:3: in function '(main chunk)' |caaaaaa<Locals> self = ud </Locals>|r Code:
user:/AddOns/StorySaver/Interface.lua:357: attempt to index a nil value stack traceback: user:/AddOns/StorySaver/Interface.lua:357: in function 'handler' user:/AddOns/StorySaver/Interface.lua:364: in function 'StorySaverInterface.SetupCheckableButton' |caaaaaa<Locals> control = ud, texturePrefix = "EsoUI/Art/MainMenu/menubar_soc...", handler = user:/AddOns/StorySaver/Interface.lua:344 </Locals>|r StorySaverEventListFrameFilterAndSearchDialogues_Initialized:3: in function '(main chunk)' |caaaaaa<Locals> self = ud </Locals>|r Code:
user:/AddOns/StorySaver/Interface.lua:357: attempt to index a nil value stack traceback: user:/AddOns/StorySaver/Interface.lua:357: in function 'handler' user:/AddOns/StorySaver/Interface.lua:364: in function 'StorySaverInterface.SetupCheckableButton' |caaaaaa<Locals> control = ud, texturePrefix = "EsoUI/Art/MainMenu/menubar_jou...", handler = user:/AddOns/StorySaver/Interface.lua:344 </Locals>|r StorySaverEventListFrameFilterAndSearchBooks_Initialized:3: in function '(main chunk)' |caaaaaa<Locals> self = ud </Locals>|r |
|
NeuroticPixels |
View Public Profile |
Send a private message to NeuroticPixels |
Send email to NeuroticPixels |
Visit NeuroticPixels's homepage! |
Find More Posts by NeuroticPixels |
Add NeuroticPixels to Your Buddy List |
03/24/21, 08:57 PM | |||
|
Re: Re: Investigations!
So I use this one for local coordinates: Code:
GetMapPlayerPosition(unitTag) Returns: normalizedX, normalizedZ, heading, isShownInCurrentMap Code:
GetUnitWorldPosition(unitTag) Returns: zoneId, worldX, worldY, worldZ
Last edited by Alianym : 03/24/21 at 08:58 PM.
|
||
|
Alianym |
View Public Profile |
Send a private message to Alianym |
Send email to Alianym |
Visit Alianym's homepage! |
Find More Posts by Alianym |
Add Alianym to Your Buddy List |
03/25/21, 06:11 AM | ||
Forum posts: 0
File comments: 32
Uploads: 0
|
Re: Errors
|
|
|
tiker |
View Public Profile |
Send a private message to tiker |
Send email to tiker |
Visit tiker's homepage! |
Find More Posts by tiker |
Add tiker to Your Buddy List |
03/25/21, 06:15 AM | |
Forum posts: 0
File comments: 32
Uploads: 0
|
New bug:
Events are stored per character. The cache is stored globally. When a single character removes all events for a book, it is removed from the cache. If another character has an event for the book that was deleted, you get an error when trying to read the book (obviously since the cache for the book was deleted). Code:
bad argument #1 to 'table.concat' (table/struct expected, got nil) stack traceback: [C]: in function 'table.concat' user:/AddOns/StorySaver/Interface.lua:299: in function 'StorySaverInterface:Read' |caaaaaa<Locals> self = [table:1]{currentSortOrder = T, currentSortKey = "name", automaticallyColorRows = T}, data = [table:2]{name = "The Truth in Sequence: Volume ...", sortIndex = 95, when = "3/23/2021", eventType = 3, zoneName = "The Brass Fortress", eventId = "1616521957-3-3"}, eventData = [table:3]{name = "The Truth in Sequence: Volume ...", medium = 9, zoneIndex = 590, showTitle = T, x = 0.2623027939, y = 1.0371052354, hash = "3872171983-2490"}, title = "The Truth in Sequence: Volume ...", medium = 9, showTitle = T, hash = "3872171983-2490" </Locals>|r user:/AddOns/StorySaver/Interface.lua:60: in function 'callback' EsoUI/Libraries/ZO_KeybindStrip/ZO_KeybindStrip.lua:679: in function 'ZO_KeybindStrip:TryHandlingKeybindDown' |caaaaaa<Locals> self = [table:4]{insertionId = 5, batchUpdating = F, allowDefaultExit = T}, keybind = "UI_SHORTCUT_PRIMARY", buttonOrEtherealDescriptor = ud, keybindButtonDescriptor = [table:5]{keybind = "UI_SHORTCUT_PRIMARY", addedForSceneName = "storySaver", alignment = 3} </Locals>|r (tail call): ? (tail call): ?
Last edited by tiker : 03/25/21 at 06:16 AM.
|
|
tiker |
View Public Profile |
Send a private message to tiker |
Send email to tiker |
Visit tiker's homepage! |
Find More Posts by tiker |
Add tiker to Your Buddy List |
03/25/21, 01:38 PM | ||
|
Re: Errors
|
|
|
f1rex |
View Public Profile |
Send a private message to f1rex |
Send email to f1rex |
Visit f1rex's homepage! |
Find More Posts by f1rex |
Add f1rex to Your Buddy List |
03/25/21, 01:44 PM | ||
|
|
|
|
f1rex |
View Public Profile |
Send a private message to f1rex |
Send email to f1rex |
Visit f1rex's homepage! |
Find More Posts by f1rex |
Add f1rex to Your Buddy List |
03/25/21, 02:05 PM | ||||
|
Re: Re: Re: Investigations!
About SetupBook override chain: I think there is only one way to avoid conflicts with other addons. We need to check if SetupBook is already overrided by known list of addons (for example LORE_READER.SetupBook == StorySaver.OnBook) and retrieve real "core" SetupBook (YourAddon.coreSetupBook = StorySaver.coreSetupBook). It looks like workaround, but not pretty solution. |
|||
|
f1rex |
View Public Profile |
Send a private message to f1rex |
Send email to f1rex |
Visit f1rex's homepage! |
Find More Posts by f1rex |
Add f1rex to Your Buddy List |
03/26/21, 05:16 AM | ||
Forum posts: 0
File comments: 32
Uploads: 0
|
You may have to forget about deleting the cache like the way it is now. Or move the events to be shared across all characters. |
|
|
tiker |
View Public Profile |
Send a private message to tiker |
Send email to tiker |
Visit tiker's homepage! |
Find More Posts by tiker |
Add tiker to Your Buddy List |
04/04/21, 01:26 PM | |
|
New version
Today or tomorrow i will upload new version of addon. I have already tested it, but i think that i need more people to test character variables schema migration. If anybody wants to help me - please answer.
|
|
f1rex |
View Public Profile |
Send a private message to f1rex |
Send email to f1rex |
Visit f1rex's homepage! |
Find More Posts by f1rex |
Add f1rex to Your Buddy List |
04/07/21, 06:47 PM | |
Forum posts: 0
File comments: 32
Uploads: 0
|
I've been testing it. Looks good so far.
|
|
tiker |
View Public Profile |
Send a private message to tiker |
Send email to tiker |
Visit tiker's homepage! |
Find More Posts by tiker |
Add tiker to Your Buddy List |
04/07/21, 08:28 PM | |
Forum posts: 0
File comments: 32
Uploads: 0
|
Found a bug.
Talking to NPCs, the last option is usually "Goodbye." or when handing in a quest, the last option is "Nevermind". Story Saver picks this up and looks fine when viewing the history. Duplicates are not created if you keep opening the same window. Once you log out and log back on, if you view the same events, the last option of all events is missing. When talking to the NPC or whatever, the events are re-added again including the last option. Log out and back on again, the last line is missing again. |
|
tiker |
View Public Profile |
Send a private message to tiker |
Send email to tiker |
Visit tiker's homepage! |
Find More Posts by tiker |
Add tiker to Your Buddy List |
04/09/21, 05:58 PM | |
Forum posts: 0
File comments: 32
Uploads: 0
|
Found the cause of the bug. I have a partial fix so far but more testing is required.
|
|
tiker |
View Public Profile |
Send a private message to tiker |
Send email to tiker |
Visit tiker's homepage! |
Find More Posts by tiker |
Add tiker to Your Buddy List |