Download
(187 Kb)
Download
Updated: 05/24/19 01:12 PM
Patch for:
Shissu's Guild Tools.
Compatibility:
Elsweyr (5.0.5)
Updated:05/24/19 01:12 PM
Created:05/24/19 01:12 PM
Monthly downloads:62
Total downloads:8,560
Favorites:5
MD5:
Shissu Guild Tools Elsweyr Patch V1.3  Popular! (More than 5000 hits)
Version: 1.3
by: Splat, Sordrak
Update of all Shissu modules to enable functionality after the Elsweyr release.

This patch has been worked on by both Splat and Sodrak. Thank you to those who have helped with testing.

This patch file has been tested and is expected to work in most cases, although a number of bugs remain.
Most are related to the additional rank that was added to enable the new invite system to work. The 'Welcomer' module of shissu (whilst it will now place the correct message in the correct guild) has issue with dropping 2 message and is a known bug that will hopefully be addressed in a future update.

I strongly advise that you first BACKUP your AddOns and SavedVariables Folders before installing.

Install this at your own risk. No warranties are offered whatsoever.

Installation:
- Download zip file to a temporary directory (or your desktop)
- Extract all files
- Copy the file to your ...\Documents\Elder Scrolls Online\live\AddOns folder replacing all exisiting shissu files
Post A Reply Comment Options
Unread 05/25/19, 02:19 AM  
Verbalinkontinenz
 
Verbalinkontinenz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 247
Uploads: 2


Still failing to update some join dates. Those are people joining via guild search, but doesnt happen always. I dont know yet, wether its just saved wrong and doesnt update anymore due to that. When I am back home, I will check that wrong wrong infos, delete them from the savedvars and check, wether SGT restarts searching for that infos.... idk...
Report comment to moderator  
Reply With Quote
Unread 05/25/19, 07:45 PM  
orcashow

Forum posts: 1
File comments: 20
Uploads: 0
Started getting some errors in the Chat module. I removed the old mod folder & replaced it with your updated version so it was a clean install. After getting the errors, I renamed the ShissuChat.lua save file to re-create it. This seems to have fixed the issue for the last 7hrs. After re-loading the game, I'm now getting errors again. Thanks for your hard work maintaining this addon.

https://cdn.discordapp.com/attachmen...525_181747.png

It seems to be related to gchat or links in it? Hopefully helps.
https://cdn.discordapp.com/attachmen...525_204236.png
Last edited by orcashow : 05/26/19 at 01:49 AM.
Report comment to moderator  
Reply With Quote
Unread 05/26/19, 06:40 AM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Originally Posted by Verbalinkontinenz


Still failing to update some join dates. Those are people joining via guild search, but doesnt happen always. I dont know yet, wether its just saved wrong and doesnt update anymore due to that. When I am back home, I will check that wrong wrong infos, delete them from the savedvars and check, wether SGT restarts searching for that infos.... idk...
Hard to test for me as I'm not really using the new guild invite feature. It is likely that there are issues because the new rank isn't really a rank and the offline default time was a bit weird.

Originally Posted by orcashow
Started getting some errors in the Chat module. I removed the old mod folder & replaced it with your updated version so it was a clean install. After getting the errors, I renamed the ShissuChat.lua save file to re-create it. This seems to have fixed the issue for the last 7hrs. After re-loading the game, I'm now getting errors again. Thanks for your hard work maintaining this addon.

https://cdn.discordapp.com/attachmen...525_181747.png

It seems to be related to gchat or links in it? Hopefully helps.
https://cdn.discordapp.com/attachmen...525_204236.png
Got any sample input that is causing this issue?

I'm not sure if just verifying that the url isn't nil is enough as it might break some functionality. With some sample input that is causing this likelihood for a good fix increases
Report comment to moderator  
Reply With Quote
Unread 05/26/19, 07:00 AM  
Martigan02

Forum posts: 0
File comments: 12
Uploads: 0
Hi thanks for taking the time to update SGT.

Still major issues for me, the same as on Els release. I've turned off all other addons and libraries and loaded in Shissu one file at a a time to test.

Error message:




Roster is out of sync.

https://media.discordapp.net/attachm...tureRoster.JPG

I dont have the Member option in Addon > settings > Sissus addons / to be able to turn off player names.

https://media.discordapp.net/attachm...aptureName.JPG

Also:
- no donation history in roster
- joining history not universally loading

If anyone has any clues it would be helpful, thank you
Report comment to moderator  
Reply With Quote
Unread 05/26/19, 07:18 AM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Originally Posted by Martigan02
Hi thanks for taking the time to update SGT.

Still major issues for me, the same as on Els release. I've turned off all other addons and libraries and loaded in Shissu one file at a a time to test.

Error message:




Roster is out of sync.

https://media.discordapp.net/attachm...tureRoster.JPG

I dont have the Member option in Addon > settings > Sissus addons / to be able to turn off player names.

https://media.discordapp.net/attachm...aptureName.JPG

Also:
- no donation history in roster
- joining history not universally loading

If anyone has any clues it would be helpful, thank you
I guess some more input from Splat is required for this issue. I had copied the deepcopy function to the roster lua file, but it isn't there yet anymore. yet, on my client Splats version is working. So this issue doesn't make much sense for me currently.

If you open the ShissuRoster/ShissuRoster.lua file and add the following code:
Code:
local function deepcopy(orig)
    local orig_type = type(orig)
    local copy
    if orig_type == 'table' then
        copy = {}
        for orig_key, orig_value in next, orig, nil do
            copy[deepcopy(orig_key)] = deepcopy(orig_value)
        end
        setmetatable(copy, deepcopy(getmetatable(orig)))
    else -- number, string, boolean, etc
        copy = orig
    end
    return copy
end
above the function _addon.rosterUI(), does it work? (this function should be located around lin number 549, where the error occurs)
Last edited by Sordrak : 05/26/19 at 07:18 AM.
Report comment to moderator  
Reply With Quote
Unread 05/26/19, 01:21 PM  
elessar

Forum posts: 0
File comments: 1
Uploads: 0
Hi there

I totally adore your patch, but i was wondering if you could fix the countdown towards the new trader on the guild page. The timer doesn't take summertime into account, so now it's always an hour wrong. As it uses that same countdown for the donations to reset, it's extra work to check if people donated in the last hour.

Thanks a lot for this patch though.

Greetings

Elessar
Report comment to moderator  
Reply With Quote
Unread 05/27/19, 01:41 AM  
Martigan02

Forum posts: 0
File comments: 12
Uploads: 0
Fixed!!

Sordrak you genius!!

You fixed my roster and gold deposit issue - thank you so much

Well done

I have recent gold deposit back again in roster but not lifetime, unless I have just started at year 0 again?
Last edited by Martigan02 : 05/27/19 at 04:56 AM.
Report comment to moderator  
Reply With Quote
Unread 05/27/19, 07:48 PM  
SteveCampsOut
 
SteveCampsOut's Avatar

Forum posts: 38
File comments: 363
Uploads: 0
Thanks for the wonderful work on Shissu's.
Report comment to moderator  
Reply With Quote
Unread 05/29/19, 06:14 PM  
SteveCampsOut
 
SteveCampsOut's Avatar

Forum posts: 38
File comments: 363
Uploads: 0
I hope someone can find the fix for the missing button on the chat window which accesses notifications of guild members logging in and out. I have one new guild that is spamming me with logins and logouts.
Report comment to moderator  
Reply With Quote
Unread 05/30/19, 03:15 PM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
I think i found two issues in the notifications.

Original Code at line 405:
Code:
-- EVENT_GUILD_DESCRIPTION_CHANGED (integer eventCode, integer guildId) 
function _addon.guildDescriptionChanged(_, guildId)
  local guildId = GetGuildId(guildId)
  local guildName = GetGuildName(guildId)
  local guildDescription = GetGuildDescription(guildId)
New code:
Code:
-- EVENT_GUILD_DESCRIPTION_CHANGED (integer eventCode, integer guildId) 
function _addon.guildDescriptionChanged(_, guildId)
  --local guildId = GetGuildId(guildId)
  local guildName = GetGuildName(guildId)
  local guildDescription = GetGuildDescription(guildId)
Original Code at line #495:
Code:
function _addon.memberRankChanged(_, guildId, displayName, rankIndex)
  local guildId = GetGuildId(guildId)
  local guildName = GetGuildName(guildId)
  local guildAlliance = GetGuildAlliance(guildId)
Code:
function _addon.memberRankChanged(_, guildId, displayName, rankIndex)
  --local guildId = GetGuildId(guildId)
  local guildName = GetGuildName(guildId)
  local guildAlliance = GetGuildAlliance(guildId)
As far as I know both EVENTS should receive the guildId.
Report comment to moderator  
Reply With Quote
Unread 05/30/19, 03:22 PM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Originally Posted by Martigan02
Sordrak you genius!!

You fixed my roster and gold deposit issue - thank you so much

Well done

I have recent gold deposit back again in roster but not lifetime, unless I have just started at year 0 again?
?

As I was never really using that list, could you try to explain what the exact issue is?



Originally Posted by SteveCampsOut
I hope someone can find the fix for the missing button on the chat window which accesses notifications of guild members logging in and out. I have one new guild that is spamming me with logins and logouts.
Hmmm, in which of the modules was this? I can't see this anywhere and can't remember that this was a thing.

Edit: Are you sure that this isn't related to friends and not guilds?
Last edited by Sordrak : 05/30/19 at 03:25 PM.
Report comment to moderator  
Reply With Quote
Unread 05/30/19, 03:43 PM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Originally Posted by orcashow
Started getting some errors in the Chat module. I removed the old mod folder & replaced it with your updated version so it was a clean install. After getting the errors, I renamed the ShissuChat.lua save file to re-create it. This seems to have fixed the issue for the last 7hrs. After re-loading the game, I'm now getting errors again. Thanks for your hard work maintaining this addon.

https://cdn.discordapp.com/attachmen...525_181747.png

It seems to be related to gchat or links in it? Hopefully helps.
https://cdn.discordapp.com/attachmen...525_204236.png

First Issue:

Original Code at line ~417:
Code:
                  local charAlliance = charInfo[5]
		  charAlliance = zo_iconFormat(GetAllianceBannerIcon(charAlliance), 24, 24)
New code:
Code:
                  local charAlliance = charInfo[5]
		  if charAlliance ~= nil and charAlliance ~= 0 then
			charAlliance = zo_iconFormat(GetAllianceBannerIcon(charAlliance), 24, 24)
		  end

Second Issue (not so happy with the fix, rather a hack, but should work fine):

Original code at line ~209:
Code:
function _addon.core.createLinkURL(text)
  if (string.find(text, "www.") or string.find(text, "http://") or string.find(text, "https://")) then
    local cache = 0  
    local cache2 = 0
    local cache3 = 0
    
    local onlyWWW = string.find(text, "www.")
    
    if (onlyWWW and not string.find(text, "http")) then
      text = string.gsub(text, "www.", "http://www.")
    end
    
    if (string.sub(text, 1, 4) == "http" or string.sub(text, 1, 3) == "www") then
      cache2 = 1
      text = "shissu meow " .. text .. " meow shissu meow"
    end
               
    local preT, url, nextT = text:match( "(.+)%s+(https?%S+)%s+(.*)$" )
    
    if (nextT == nil) then
      cache3 = 1
      text = text .. " meow shissu meow"
      
      preT, url, nextT = text:match( "(.+)%s+(https?%S+)%s+(.*)$" )
    end

    local stringLen = string.len(url)  
    local last = string.sub(url, stringLen, stringLen)
        
    if (last== "," or last == ".") then
      url = string.sub(url, 0, stringLen-1)
      cache = 1
    end
   
    local urlLink = stdColor .. string.format("|H1:%s:%s:%s|h%s|h", _addon.LINK, 1, _addon.urlLINK, url) .. "|r"
  
    if (cache2 == 0) then  	
      local stringLen2 = string.len(preT)
      local stringLen3 = string.len(text)
         
      local newNextT = string.sub(text, stringLen + stringLen2 + 2, stringLen3)  
     
      if (cache3 == 1) then
        text = preT .. " " .. urlLink 
      elseif (cache == 1) then
        text = preT .. " " .. urlLink .. newNextT
      else
       text = preT .. " " .. urlLink .. " " .. newNextT
      end
    else
      text = urlLink
    end

  end
    
  return text
end
New code:
Code:
function _addon.core.createLinkURL(text)
  if (string.find(text, "www.") or string.find(text, "http://") or string.find(text, "https://")) then
    local oldText = text
    local cache = 0  
    local cache2 = 0
    local cache3 = 0
    
    local onlyWWW = string.find(text, "www.")
    
    if (onlyWWW and not string.find(text, "http")) then
      text = string.gsub(text, "www.", "http://www.")
    end
    
    if (string.sub(text, 1, 4) == "http" or string.sub(text, 1, 3) == "www") then
      cache2 = 1
      text = "shissu meow " .. text .. " meow shissu meow"
    end
               
    local preT, url, nextT = text:match( "(.+)%s+(https?%S+)%s+(.*)$" )
    
    if (nextT == nil) then
      cache3 = 1
      text = text .. " meow shissu meow"
      
      preT, url, nextT = text:match( "(.+)%s+(https?%S+)%s+(.*)$" )
    end
    if url ~= nil then
    local stringLen = string.len(url)  
    local last = string.sub(url, stringLen, stringLen)
        
    if (last== "," or last == ".") then
      url = string.sub(url, 0, stringLen-1)
      cache = 1
    end
   
    local urlLink = stdColor .. string.format("|H1:%s:%s:%s|h%s|h", _addon.LINK, 1, _addon.urlLINK, url) .. "|r"
  
    if (cache2 == 0) then  	
      local stringLen2 = string.len(preT)
      local stringLen3 = string.len(text)
         
      local newNextT = string.sub(text, stringLen + stringLen2 + 2, stringLen3)  
     
      if (cache3 == 1) then
        text = preT .. " " .. urlLink 
      elseif (cache == 1) then
        text = preT .. " " .. urlLink .. newNextT
      else
       text = preT .. " " .. urlLink .. " " .. newNextT
      end
    else
      text = urlLink
    end
	else
	  return oldText
	end
  end
    
  return text
end
@Splat: Please verify the fixes (all, incl. deepcopy) and update the addon, thx
Report comment to moderator  
Reply With Quote
Unread 05/30/19, 03:44 PM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Originally Posted by Verbalinkontinenz


Still failing to update some join dates. Those are people joining via guild search, but doesnt happen always. I dont know yet, wether its just saved wrong and doesnt update anymore due to that. When I am back home, I will check that wrong wrong infos, delete them from the savedvars and check, wether SGT restarts searching for that infos.... idk...
Is this still an issue or got some more feedback on this one?
Report comment to moderator  
Reply With Quote
Unread 05/31/19, 10:19 AM  
Verbalinkontinenz
 
Verbalinkontinenz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 247
Uploads: 2
Originally Posted by Sordrak
Originally Posted by Verbalinkontinenz


Still failing to update some join dates. Those are people joining via guild search, but doesnt happen always. I dont know yet, wether its just saved wrong and doesnt update anymore due to that. When I am back home, I will check that wrong wrong infos, delete them from the savedvars and check, wether SGT restarts searching for that infos.... idk...
Is this still an issue or got some more feedback on this one?
It is, and I dont see any reason to fix my savedvars now, since also newly joined members happen to sometimes not get a join date by sgt. So its nothing old, or wrong data. And i dont see any pattern, why it sometimes happens, and when not. Some people joining via guild finder have correct time stamp, others dont.
Last edited by Verbalinkontinenz : 05/31/19 at 10:19 AM.
Report comment to moderator  
Reply With Quote
Unread 05/31/19, 04:10 PM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Originally Posted by Verbalinkontinenz
Originally Posted by Sordrak
Originally Posted by Verbalinkontinenz


Still failing to update some join dates. Those are people joining via guild search, but doesnt happen always. I dont know yet, wether its just saved wrong and doesnt update anymore due to that. When I am back home, I will check that wrong wrong infos, delete them from the savedvars and check, wether SGT restarts searching for that infos.... idk...
Is this still an issue or got some more feedback on this one?
It is, and I dont see any reason to fix my savedvars now, since also newly joined members happen to sometimes not get a join date by sgt. So its nothing old, or wrong data. And i dont see any pattern, why it sometimes happens, and when not. Some people joining via guild finder have correct time stamp, others dont.
Can't reproduce it easily. I might have to use my second account to join a guild and test a few things, but i would need some assistance on that.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: