Quantcast
Download
(112 Kb)
Download
Updated: 11/29/18 03:26 PM
Pictures
File Info
Compatibility:
Murkmire (4.2)
Updated:11/29/18 03:26 PM
Created:02/12/17 08:54 PM
Monthly downloads:28,359
Total downloads:180,622
Favorites:201
MD5:
4.2
WritWorthy  Popular! (More than 5000 hits)
Version: 4.2.6
by: ziggr [More]
New as of 2018-11-15: Required, install separately: LibAddonMenu-2.0

New as of 2018-11-29: Required, install separately: LibPrice
  • Is a master writ worth doing?
  • Does this character have the skills to do so?
  • Want to craft it automatically?

Is this master writ worth doing?

Most writs consume less than 1000g worth of materials for each writ voucher they return. But some consume 2000g+ materials per voucher and might not be worth doing.

Shopping guild stores for Master Writs? What is the per-voucher cost of a writ, including both materials and purchase price?

This add-on adds text to each Master Writ's tooltip, showing the total material cost, purchase price (if any), and the cost per writ voucher reward.

It also optionally dumps a complete material list to chat. Surprisingly useful when filling Alchemy writs.

Requirements
Does this character have the skills to do so?

Not interested in writs that you cannot craft?

This add-on shows big red warnings when writ requires a motif, trait, or recipe that the current character does not yet know.

It also shows orange warnings for missing skills that are not required, but which reduce the cost of expensive writs, such as Temper Expertise.

(No, WritWorthy does not check inventory for required materials, or space to hold the the crafted item. I assume a master crafter can handle their own inventory management.)

Want to craft it automatically?
  1. Bind a key to "Show/Hide WritWorthy" or type /writworthy in chat.
  2. Use that key binding to see a list of all Sealed Master Writs in the current character's inventory.
  3. Check the ones you want to craft automatically next time the character visits the appropriate crafting station. Or "Enqueue All" if you want to craft them all.
  4. "Sort by Station" to see which crafting stations you need to visit.
  5. Walk up to a station, 'E' interact, and watch Dolgubon's LibLazyCrafter make your items.
  6. Wait patiently while the automatic crafting occurs. If you cancel interaction while still auto-crafting, you might end up auto-crafting an item twice, wasting materials. There is no indication for "all done". Sorry.
  7. Once you have crafted items for your writs, you can open them, accept their quest, and the quest will automatically advance to "Turn in".

Thanks to Dolgubon's LibLazyCrafting which makes automatic crafting possible.

Automatic crafting requires that the appropriate cost-reduction skills have been maxed out: Temper Expertise, Chef, Brewer, or Chemistry.

Follow development on GitHub
ESO-WritWorthy on GitHub

--Z
4.2.6 2018-11-29
  • Tamriel Trade Centre support.
  • New LibPrice is required. Install separately. Handles all price lookups now, supports Master Merchant, Arkadius' Trade Tools, Tamriel Trade Centre, and more.

4.2.5 2018-11-22
  • Yet another blind attempt to avoid UI Error during early call into ATT.

4.2.4 2018-11-21
  • Restore ATT/Arkadius' Trade Tools support. Thanks to Arkadius for the find!

4.2.3 2018-11-15
  • Remove library: LibAddonMenu-2.0. Install it separately.
  • Remove ATT/Arkadius' Trade Tools support. It caused too many error reports in the 4 months it existed.

4.2.2 2018-10-23
  • Library Update:
  • LibAddonMenu-2.0 26
  • LibCustomMenu 6.6 standalone
  • LibLazyCrafting 2.22

4.2.1 2018-09-17
  • Update 20/4.2.1/API 100025/Murkmire
  • Add Welkynar and Dremora motif knowledge.

4.1.5 2018-08-21
  • Update to LibLazyCrafting b62e972 (Smithing 2.5, use only 1 green material for jewelry)

4.1.4 2018-08-17
  • Jewelry: honor reduced material requirements in material cost display.

4.1.3 2018-08-16
  • Unofficial fix to LibLazyCrafting for jewelry crafting reduced improvement costs.
  • Bugfix: "SI_KEYBINDINGS_CATEGORY_WRIT_WORTHY" erroneously appearing in Controls/Keybindings
  • Minor text fixes.

4.1.2 2018-07-24
  • Support Arkadius' Trade Tools. Untested. Thank you, Patros, for the code.
  • Update M.M. fallback prices to PC NA 2018-07. Done mostly so that I could see how the PTS increase to Jewelry voucher rewards affects cost per voucher. (1500-5000g per voucher. Still 4x-8x what other tradeskills cost.)
  • Update to latest Dolgubon's LibLazyCrafter 2.2.
  • Minor text fixes.

4.1.1 2018-07-12
  • Update 19/4.1.1/API 100024/Wolfhunter
  • Typofix: Stalhrim not Stahlrim. Thank you, Lakashi, for the find.
  • Welkynar: Still not craftable in-game, but at least we have an item link for its crafting material "Gryphon Plume".
  • Sirinsidiator's LibSlashCommander now optional.

4.0.12 2018-07-04
  • Bugfix: string.format() error for jewelry crafter writs. Thank you, Dolgubon, for the report.

4.0.11 2018-07-04
  • Bugfix: Performance improvement cache never invalidated itself to load fresh prices. Now the cache lasts for 5 minutes before resetting.
  • Updated to LibSlashCommander 1.0 r5. Fixes the "cannot up-arrow through chat history" bug.
  • Typofix: "vitified malondo" broke parsing of Psijic Order writs.
  • Fix: Pyandonean motifs fixed.
  • New: "Unknown motif: 73" error tooltip for motifs such as Welkynar that appear in writs but whose crafting details are not yet in-game and programmed into WritWorthy. Also omit such writs from WritWorthy autocraft window: they are not yet worthy.

4.0.10 2018-06-01
  • Performance improvement. Internally cache Master Merchant prices to avoid duplicate lookups. Affects both the big WritWorthy window as well as the filter for Awesome Guild Store.

4.0.9 2018-05-22
  • Update to LibLazyCrafting 2.1. Fixes "LibLazyCrafting function missing" errors
  • Include style information for new styles. Fixes "inserted value must be specified" and "bad argument #1 to ipairs" errors in materials code. Thank you, XomRhoK for bug reports.

4.0.8 2018-05-19
  • Summerset: use final texture string to detect jewelry writs.

4.0.7 2018-05-18
  • bugfix: ESO+ subscriber bank now works. Thanks, Snow, for the fix!
  • bugfix: "Show material list in chat" setting works again. Thanks, XomRhoK for the bug report.
  • error reporting: "LibLazyCrafting function missing" now dumps more details to help ziggr figure out what's going wrong.
  • new: /writworthy count -- shows number of writs you have, and how many vouchers they're all worth.
  • add Sirinsidiator's most excellent LibSlashCommander 1.0 r4. Allows for command descriptions.

4.0.6 2018-05-04
  • Update to LibLazyCrafting 2.0 with its shiny new support for jewelry crafting.

4.0.5 2018-04-28
  • AwesomeGuildStore code review from Sirinsidiator: fix spacing so that WritWorthy and Master Merchant filters don't draw on top of each other. Internal caching to accelerate filter.

4.0.4 2018-04-27
  • AwesomeGuildStore filter! You can now search guild stores for master writs that cost X gold or less to purchase + craft. Look for a "Per Voucher:" field when on the Consumables/Master Writ shopping tab.
  • Preliminary Jewelry Crafting support. Disabled in this release.

4.0.3 2018-04-21
  • Fixed: motif names appear in "Detail 3" column again. Thank you, tomtomhotep for the bug report.
  • "Mat total: ?g" tooltip text now appears in red to better warn you that the per-voucher pricce ignores crafting cost. Thank you XomRhoK for the feature request.
  • Add "+ bank" to window subtitle when showing writs from both the character inventory and bank.

4.0.2 2018-04-20
  • Fixed: M.M. Fallback works again.
  • New option: showing price in tooltip is now optional. Because some people use WritWorthy more for the crafting and less for the pricing. Thank you @Jerkling for the feature request.
  • New option: Include bank when listing writs available to craft. Be careful with this: no warning if you craft the same banked writ on multiple characters. Thank you @UESP for the feature request.

4.0.1 2018-04-17
  • Update 18/4.0.0/API 100023/Summerset
  • Jewelry master writs parsed, materials listed, and knowledge checked.
  • Auto-crafting not yet implemented for jewelry
  • Manavortex's alternating colors for BS/CL/WW stations (thank you!).
  • Rename "Julianos" to full "Law of Julianos" to better match the stations's displayed name.

3.3.2 2018-02-22
  • Add HotR motif style IDs. Thank you, Rhyono for the numbers from CraftStore
  • Remove unwanted LibAddonMenu.txt manifest file from like 2 years ago that was 1. in the wrong directory, and 2. shouldn't have been there at all. Thank you, Marazota for the find and fix.
  • LibAddonMenu updated from r18 (!) to r25.

3.3.1 2018-01-29
  • Update 17 / ESO 3.3 / Dragon Bones / API 10022
  • /writworthy command toggles window
  • Exit crafting station after auto-crafting all we can at this station.
  • Update to LibLazyCrafting 1.1.9 8ef2e2, matching Dolgubon's Lazy Set Crafter 1.1.6 and Writ Crafter 36.19.

3.2.5 2017-12-16
  • by Dolgubon: Adapt to API in LibLazyCrafting 1.9.
  • Fixes the Provisioning and Alchemy checks.
  • Fix possible issues with the LLC callback, honor crafting response code.

3.2.4 2017-12-15
3.2.3 2017-12-13
3.2.2 2017-11-09
  • Update to LibLazyCrafting 1.5. Same library version as in Dolgubon's Lazy Writ Crafter v36.8 and Dolgubon's Lazy Set Crafter v1.0.19
  • Allow WritWorthy window to be moved partially offscreen. Zig finds it very handy to slide the window off to the right and just focus on crafting station names when doing dozens of master writs at a time.
  • Stop making an unnecessary extra crafted provisioning/alchemy item. Thank you Dolgubon for finding a 100% reproduction case.

3.2.1 2017-10-29
  • Update to LibLazyCrafting 1.4. This fixes the error "WritWorthy_Window.lua:1118: attempt to index a nil value"

3.1.5 2017-10-16
  • "Show material list in chat" has a new "Alchemy only" option for folks (like me!) who only check the material list for alchemy.
  • Bug Fix: check required materials right before attempting to craft alchemy or provisioning items. If you don't have enough Bugloss or Frost Mirriam, write that to chat and skip that item.
  • LibLazyCrafting: update to version 1.3 (circa October 2017)

3.1.4 2017-08-26
  • Refresh button
  • "prosperous" -> "invigorating"
  • LibLazyCrafting: update from version 0.4 to 1.2, adapt to some API changes
  • LibLazyCrafting: fix bugs/missing features in 1.2, bump version to 1.3. This is not an official Dolgubon library release, so I expect bugs/surprises next time Dolgubon updates any of their crafting add-ons.

3.1.3 2017-08-15
  • Manavortex's fix for autocraft window's error: "attempt to perform arithmetic on a nil value" if you run without Master Merchant.

3.1.2 2017-08-14
  • "Motif X not known" fixed. I was off by +1 for all motifs.
  • HotR Motifs added: Redoran, Hlaalu, Telvanni. Not sure if they'll show up in writs, but if they do, WritWorthy will now check Master Merchant for their style material prices, just likt it does for all other motifs.

3.1.1 2017-08-14
  • ESO 3.1 Horns of the Reach/API 20
  • Squelch errors for "table index is nil" for new item style constants.
  • Autocraft: no longer add mystery +1 to motif index. No longer required or correct.
  • KNOWN BUG: "Motif Barbaric not known" even though you do know this motif. For some reason the ESO API returns "false" for IsSmithingStyleKnown(barbaric=17+1) even if you know that motif. All motifs off by one.

3.0.7 2017-07-16
  • Public API Support: new function WritWorthy.ToMatCost(itemLink) returns material cost for a single writ.
  • Bugfix: Make WritWorthy global be the actual add-on, not the LibAddOnMenu pane. Thank you sirinsidiator and silvereyes for the report+fix!

3.0.6 2017-07-10
  • Bugfix: would inconsistently fail to report "Motif XXX not known" for some motifs. Thank you Rhyono for helping me debug this.

3.0.5 2017-06-22
  • Replace hardcoded skill indices with a runtime scan for localized skill name. Turns out those indices change from player to player, are not constants. And there are no "skillId" analogs to "itemId" constants. Oh well. Fall back to string matching. Hopefully this will end the many reports of nil errors on other people's ESO clients. I included the names for EN, DE, and FR. I do not have a JP client, so I lack those names, sorry.

3.0.4 2017-06-20
  • Bugfix: operator < is not supported for nil < nil. Thanks to Tonyleila for the report.

3.0.3 2017-06-18
  • New window with list of all master writs in backpack.
  • Automatic crafting of writs.
  • integrate Dolgubon's LibLazyCrafting 0.4, which is actually Dolgubon's LibLazyCrafting 0.3 but with Zig-added support for alchemy and provisioning. If those don't work, it's Zig's fault not Dolgubons. Thank you Dolgubon for all the help!

3.0.2 2017-05-28
  • Morrowind API: replace temporary workaround numbers with actual constants for new styles. Thank you @Rhyono for the CraftStore Morrowind update which had all the quest IDs I needed for the "which pages do you know?" query.
  • BugFix: never had a quest ID for the "Order of the Hour" motif. Now I do.

3.0.1 2017-05-21
  • ESO 3.0 Morrowind/API 19
  • Temporary workaround: some item style constants changed in the new API and until I can figure out the new ones, use magic numbers. WritWorthy might report incorrect known/unknown results for these three motifs: Skinchanger, Grim Harlequin, Hollowjack.
  • Provisioning: require 2x crafting attempts, since most Provisioning writs seem to require 8 servings. (I assume any character performing master writs will have Chef/Brewer/Chemistry passive skills maxxed out.)

2.7.10 2017-04-04
  • Option to fall back to hardcoded prices for common style and trait materials.

2.7.9 2017-03-22
  • AHA Found the "Trait not known" bug for medium armor: when a writ required a trait for some medium armor piece (such as belt), WritWorthy erroneously checked the light armor piece (such as sash).

2.7.8 2017-03-22
  • Debug log: records details about the 20 most recent writs. If there's a problem with a writ, send a screenshot of the offending writ (or the UI error), and a screenshot of the writ that caused the problem. This ought to help me figure out what's going wrong.

2.7.7 2017-02-25
  • Stop crashing auf Deutsch. When building recipe ingredient lists out of ZOS-returned data, use item links, not names, as element keys. All WritWorthy text is still in US English. The only change here is that it can run correctly when the ESO client is set to German.

2.7.6 2017-02-25
  • Survive without Master Merchant. If missing, or if its database lacks some required materials, display "?g" for "unknown amount of gold" and don't count materials costs when calculating per-voucher cost.

2.7.5 2017-02-24
  • Add big red text to tooltip if current character cannot craft the required item due to missing motif, traits or recipe.

2.7.4 2017-02-20
  • Add a table of recipes to Provisioning so that the provisioning writs can show a material list even if the current character does not know the required recipe. Fixes "Recipe not found" errors for such writs.

2.7.3 2017-02-16
  • Settings UI: checkbox to enable/disable material list dump to chat. Too much clutter in the chat window.
  • Bugfix: Alchemy materials had poison/potion = Alkahest/Lorkhan's Tears swapped.

2.7.2 2017-02-14
  • Replace string matching with item_link parsing

2.7.1 2017-02-12
  • First release. Uses string matching that worked only for US English clients.
Optional Files (0)


Archived Files (51)
File Name
Version
Size
Author
Date
4.2.5
113kB
ziggr
11/22/18 11:43 AM
4.2.4
113kB
ziggr
11/21/18 07:44 PM
4.2.3
113kB
ziggr
11/15/18 08:37 PM
4.2.2
162kB
ziggr
10/23/18 11:14 AM
4.2.1
160kB
ziggr
09/17/18 09:17 PM
4.1.5
160kB
ziggr
08/21/18 11:25 AM
4.1.4
160kB
ziggr
08/17/18 10:50 AM
4.1.3
188kB
ziggr
08/16/18 08:38 PM
4.1.2
152kB
ziggr
07/24/18 09:24 PM
4.1.1
141kB
ziggr
07/12/18 07:58 PM
4.0.12
149kB
ziggr
07/04/18 07:57 PM
4.0.11
149kB
ziggr
07/04/18 01:16 PM
4.0.10
149kB
ziggr
06/01/18 11:29 PM
4.0.9
148kB
ziggr
05/22/18 11:39 AM
4.0.8
147kB
ziggr
05/19/18 02:06 PM
4.0.7
147kB
ziggr
05/18/18 12:18 PM
4.0.6
139kB
ziggr
05/04/18 10:17 AM
4.0.5
136kB
ziggr
04/28/18 01:21 PM
4.0.4
136kB
ziggr
04/27/18 10:15 PM
4.0.3
130kB
ziggr
04/21/18 01:43 PM
4.0.2
130kB
ziggr
04/20/18 10:49 AM
4.0.1
128kB
ziggr
04/17/18 04:09 PM
3.3.2
127kB
ziggr
02/22/18 03:18 PM
3.3.1
118kB
ziggr
01/29/18 10:01 PM
3.2.5
342kB
ziggr
12/17/17 12:11 AM
3.2.4
342kB
ziggr
12/15/17 06:28 PM
3.2.3
117kB
ziggr
12/13/17 04:56 PM
3.2.2
117kB
ziggr
11/09/17 04:36 PM
3.2.1
117kB
ziggr
10/29/17 02:14 PM
3.1.5
116kB
ziggr
10/16/17 06:16 PM
3.1.4
114kB
ziggr
08/26/17 10:16 PM
3.1.3
113kB
ziggr
08/15/17 02:56 PM
3.1.2
113kB
ziggr
08/14/17 03:25 PM
3.1.1
113kB
ziggr
08/14/17 02:17 PM
3.0.7
113kB
ziggr
07/16/17 11:42 AM
3.0.6
113kB
ziggr
07/10/17 08:15 PM
3.0.5
113kB
ziggr
06/22/17 05:43 PM
3.0.4
111kB
ziggr
06/20/17 11:56 AM
3.0.3
111kB
ziggr
06/18/17 10:59 PM
3.0.2
71kB
ziggr
05/28/17 01:18 PM
3.0.1
71kB
ziggr
05/22/17 01:03 PM
2.7.10
71kB
ziggr
04/04/17 05:06 PM
2.7.9
69kB
ziggr
03/23/17 12:40 AM
2.7.8
69kB
ziggr
03/23/17 12:08 AM
2.7.7
67kB
ziggr
02/26/17 05:33 PM
2.7.6
67kB
ziggr
02/25/17 05:01 PM
2.7.5
66kB
ziggr
02/24/17 11:13 PM
2.7.4
68kB
ziggr
02/20/17 02:57 PM
2.7.3
55kB
ziggr
02/16/17 03:44 PM
2.7.2
19kB
ziggr
02/15/17 12:12 AM
2.7.1
17kB
ziggr
02/12/17 08:54 PM


Post A Reply Comment Options
Unread 11/29/18, 07:00 PM  
ziggr
 
ziggr's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 127
Uploads: 7
Why standalone libraries.

Originally Posted by Shadowshire
Can you tell us why this has happened and whether it signifies that the players must update these "libraries"?
Careful.

This is a hot-button issue for a few add-on authors and players, myself included. Angry shouting rants are just a hair-trigger away.

The short, patient, answer is:
  • Add-Ons had to be repackaged and uploaded every time any included library updated. This discouraged add-on authors from publishing.
  • Multiple add-ons with competing library versions occasionally caused conflicts. This was rare (thank you, LibStub!), but still happened.
  • In 2018, ZOS added code to ESO so that libraries could be installed separately, on their own, without a surrounding add-on.

--Z
Report comment to moderator  
Reply With Quote
Unread 11/29/18, 06:31 PM  
Shadowshire

Forum posts: 1
File comments: 193
Uploads: 0
Post Re: Re: Request for Writ Worthy to Accept Crown Style Mimic Stones

Originally Posted by tomtomhotep
Originally Posted by Shadowshire
I have never found an independent way to discover the name of the style material
TraitBuddy
Thank-you for the reply. I use Trait Buddy. It is loaded on all characters that craft regardless of whether a specific character has learned each of the traits for crafting all of the respective items. Unfortunately, in my experience, it has not been reliable with regard to displaying data about Motifs. I have tried deleting its ...\Saved Variables folder so that it will re-build the data file, but, IIRC, whether that has resolved the isssues remains uncertain. At the moment, I cannot recall whether I have posted a comment about the matter for the Trait Buddy author.
__________________
---- Shadowshire ..... nil carborundum illegitimi
Report comment to moderator  
Reply With Quote
Unread 11/29/18, 06:29 PM  
ziggr
 
ziggr's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 127
Uploads: 7
Re: Re: 4.2.6 Released with MM/ATT/TTC support

Originally Posted by Shadowshire
Install separately where?
Install LibPrice next to WritWorthy and all other add-ons.

Code:
Elder Scrolls Online/
|
└── live/
    |
    └── AddOns/
        |
        ├── (other add-ons)
        |
        ├── LibPrice/
        |   ├── LibPrice_Internal.lua
        |   ├── LibPrice.lua
        |   └── LibPrice.txt
        |
        ├── (more add-ons)
        |
        └── WritWorthy/
            ├── ...
            ├── WritWorthy.lua
            ├── WritWorthy.txt
            ├── WritWorthy.xml
            └── ...
PS: If you use Minion to install LibPrice, Minion will place it in the correct location. Thank you, Minion!
Last edited by ziggr : 11/29/18 at 06:38 PM.
Report comment to moderator  
Reply With Quote
Unread 11/29/18, 06:02 PM  
Shadowshire

Forum posts: 1
File comments: 193
Uploads: 0
Exclamation Re: 4.2.6 Released with MM/ATT/TTC support

Originally Posted by ziggr
I moved all price checking code to its own library, LibPrice.
....
Which also means that WritWorthy now requires the above library. Install separately.

--Z
Install separately where? Should they (1) be installed in the \Addons folder like the Writ Worthy add-on, or (2) must they be installed somewhere in the Writ Worthy folder itself? If they must be installed in the Writ Worthy add-on folder, then what is the point of requiring the users to maintain the updates for those two libraries?

For some time now the game client ESC > Add-Ons menu has a separate "Libraries" section, which lists various and sundry libraries, their respective versions, and whether each one is compatible with the current version of TESO. What this means -- if anything -- for each of the players remains unclear and uncertain. Can you tell us why this has happened and whether it signifies that the players must update these "libraries"?

Thank-you for your time and attention to this issue.
__________________
---- Shadowshire ..... nil carborundum illegitimi
Report comment to moderator  
Reply With Quote
Unread 11/29/18, 03:29 PM  
ziggr
 
ziggr's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 127
Uploads: 7
4.2.6 Released with MM/ATT/TTC support

I moved all price checking code to its own library, LibPrice.

This library knows how to fetch material price data from every source I know:
Which also means that WritWorthy now requires the above library. Install separately.

--Z
Last edited by ziggr : 11/29/18 at 03:30 PM.
Report comment to moderator  
Reply With Quote
Unread 11/25/18, 09:36 AM  
tomtomhotep
 
tomtomhotep's Avatar
AddOn Author - Click to view AddOns

Forum posts: 21
File comments: 168
Uploads: 6
Re: Request for Writ Worthy to Accept Crown Style Mimic Stones

Originally Posted by Shadowshire
I have never found an independent way to discover the name of the style material
TraitBuddy
Report comment to moderator  
Reply With Quote
Unread 11/25/18, 12:28 AM  
ziggr
 
ziggr's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 127
Uploads: 7
Re: Request for Writ Worthy to Accept Crown Style Mimic Stones

Originally Posted by Shadowshire
So I would personally appreciate it if Writ Worthy (in particular) will use a Crown Mimic Stone for the style material when the required Style material is not present in the character's Bags or in the Crafting Bag.
Feature Request 1720 noted:

Use mimic stones when auto-crafting master writs if no style materials left in bag/bank/craft bag.

Would be helpful. Certainly saves me a trip to a guild store to pick up the necessary materials on the rare occasion when I run out of materials.

But also treads dangerously close to adding inventory management/scanning to WritWorthy, which is something I am loathe to do. So I'm not implementing for now.

2018-11-24 Shadowshire also requested.
Report comment to moderator  
Reply With Quote
Unread 11/25/18, 12:24 AM  
ziggr
 
ziggr's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 127
Uploads: 7
Re: Writ Worthy 4.2.5 - Button not working now

Originally Posted by Shadowshire
After I updated the Writ Worthy installation to version 4.25, then used it to organize a set of (Sealed) Master Crafting Writs, the "Sort By Station" button did not respond. The writs apparently remained in the order in which Writ Worthy found them in the character's Bags. (The "Enque All" button worked, however.) Please remedy this error ASAP.
Thank you for your bug report. I cannot reproduce this bug.

I just tested it right now, and it worked for me:


Nothing I touched in the last several months should have affected the WritWorthy list window or its ability to sort.

--Z
Report comment to moderator  
Reply With Quote
Unread 11/25/18, 12:01 AM  
Shadowshire

Forum posts: 1
File comments: 193
Uploads: 0
Lightbulb Request for Writ Worthy to Accept Crown Style Mimic Stones

As the number and variety of Style motifs multiply, so does the corresponding number of Style materials which the player must (1) identify, and (2) obtain. Unfortunately, Patch Notes often omit the name of the Style material from descriptions of the Style Motif. I have never found an independent way to discover the name of the style material -- only to search style materials for sale in Guild Stores, and read the item tooltips for those I don't already know to see which Style each one is used to craft.

Frankly, for an increasingly large percentage of the Styles, I rarely receive a Master Crafting Writ for that particular Style. Given the usual price of the style material -- assuming that I can find it -- it saves so much time, effort, and Coin just to use a Crown Style Mimic Stone instead of searching for and buying the required material. The Mimic Stones aren't that expensive for something that I use so seldom.

So I would personally appreciate it if Writ Worthy (in particular) will use a Crown Mimic Stone for the style material when the required Style material is not present in the character's Bags or in the Crafting Bag. Else, I end-up identifying the undone Sealed Master Writ and doing the entire task manually while I am at the attunable crafting station in a Guild Hall.
__________________
---- Shadowshire ..... nil carborundum illegitimi
Last edited by Shadowshire : 11/25/18 at 12:04 AM.
Report comment to moderator  
Reply With Quote
Unread 11/24/18, 11:44 PM  
Shadowshire

Forum posts: 1
File comments: 193
Uploads: 0
Arrow Writ Worthy 4.2.5 - Button not working now

After I updated the Writ Worthy installation to version 4.25, then used it to organize a set of (Sealed) Master Crafting Writs, the "Sort By Station" button did not respond. The writs apparently remained in the order in which Writ Worthy found them in the character's Bags. (The "Enque All" button worked, however.) Please remedy this error ASAP.
__________________
---- Shadowshire ..... nil carborundum illegitimi
Report comment to moderator  
Reply With Quote
Unread 11/24/18, 10:49 AM  
ziggr
 
ziggr's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 127
Uploads: 7
Originally Posted by Snow
Hi,
the blind attempt of WritWorthy 4.2.5 to check addMenuItems works - at least on my system.
Excellent! Thank you so much for all your work on this.

Folks who use ATT can finally get useful price data in their WritWorthy tooltips.

And bonus: I finally tried ATT after years of Master Merchant use. And I love it. I don't know how it can scan and index all that data without crushing my FPS, but it runs smoothly and efficiently, so I'm switching.

--Z
Last edited by ziggr : 11/24/18 at 10:49 AM.
Report comment to moderator  
Reply With Quote
Unread 11/24/18, 09:36 AM  
Snow

Forum posts: 0
File comments: 29
Uploads: 0
Hi,
the blind attempt of WritWorthy 4.2.5 to check addMenuItems works - at least on my system.
Updated to version 4.2.5 and got no errors on the chars that normaly produced them - not all chars did it with the old support version - so there is no surprise that You did not see the error on Your installation.
Then to prove that it is the additional check - I commented out line 206
-- and ArkadiusTradeTools.Modules.Sales.addMenuItems
saved and did a /reloadui - and the error reappeared.


Thanks for digging into this an fixing it.
Report comment to moderator  
Reply With Quote
Unread 11/22/18, 01:30 PM  
Verbalinkontinenz
 
Verbalinkontinenz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 98
Uploads: 1
I highly appreciate that you apologized and digging deeper into this. I really love your addon, would be sh*t, if you guys wouldnt get it working
__________________
resigned GM
Just Traders (EU Belkarth)
Tamriel Stock Exchange (EU Rawl'Kha)
Bait Trading House (EU Wayrest)
Report comment to moderator  
Reply With Quote
Unread 11/22/18, 10:40 AM  
ziggr
 
ziggr's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 127
Uploads: 7
Re: Lua errors in WritWorthy Version 4.2.4 with ATT support

Originally Posted by Snow
First of all, I use both addons ATT and WrithWorthy and I love both of them - but they don't work together.
AHA! So that's what's going on. Thank you for investigating this.

The WritWorthy init code that eventually triggers the error is checking for any writs that were previously queued for crafting, so that it can restore its crafting queue. This has to happen early (although not so early as OnAddOnLoaded time), before any interaction with a crafting table. I could defer this, and then clean up any bugs caused by the change.

But the above WW init code doesn't really use or need price data at all. So I could either not check price data in this call (relatively easy), but that might just delay the error when some other WW code inadvertently asks for a writ's data. I could check yet one more ATT internal variable to see if it's fully initialized (also easy).

Not sure which path I'll attempt. It's early and the Thanksgiving Parade is on.

--Z

Edit: Okay, I've uploaded WritWorthy 4.2.5 with Yet Another blind attempt to fix this UI error. I installed ATT and tried to reproduce the error, but of course saw no error, even when addMenuItems is nil (?). But this additional check ought to at least avoid calling into ATT before it has had a chance to initialize its Sales module.

Lua Code:
  1. .
  2.                         -- Fallback to ATT if MM not installed.
  3.                         -- Thank you, Patros and Arkadius!
  4. function Util.ATTPrice(link)
  5.                         -- ATT might load after WW, so check some random
  6.                         -- internal "addMenuItems" that gets set during
  7.                         -- ATT initialization
  8.     if  not(    ArkadiusTradeTools
  9.             and ArkadiusTradeTools.Modules
  10.             and ArkadiusTradeTools.Modules.Sales
  11.             and ArkadiusTradeTools.Modules.Sales.addMenuItems  <== HERE
  12.             )
  13.         then
  14.         return nil
  15.     end
  16.                         -- Try for a recent price: last 3 days. If nothing
  17.                         -- that recent, reach back for last 3+ months or so.
  18.     local day_secs = 24*60*60
  19.     local att = ArkadiusTradeTools.Modules.Sales:GetAveragePricePerItem(
  20.                         link, GetTimeStamp() - (day_secs * 3))
  21.     if (not att) or (att <= 0) then
  22.         att = ArkadiusTradeTools.Modules.Sales:GetAveragePricePerItem(
  23.                         link, GetTimeStamp() - (day_secs * 100))
  24.     end
  25.     return att
  26. end
  27.  
  28. ------------------------------------------------------------------------------------
  29. function ArkadiusTradeToolsSales:Initialize(serverName, displayName)
  30.     ...
  31.     self:LoadSales()           <== HERE initializes TemporaryVariables
  32.     ...
  33.     self.addMenuItems = {}     <== HERE sets what WritWorthy 4.2.5 tests
  34. end
  35.  
  36. function ArkadiusTradeToolsSales:LoadSales()
  37.     ...
  38.     self:UpdateTemporaryVariables(sale)
  39.     ...
  40. end
Last edited by ziggr : 11/22/18 at 11:55 AM.
Report comment to moderator  
Reply With Quote
Unread 11/22/18, 04:25 AM  
Snow

Forum posts: 0
File comments: 29
Uploads: 0
Lua errors in WritWorthy Version 4.2.4 with ATT support

First of all, I use both addons ATT and WrithWorthy and I love both of them - but they don't work together.
Last WritWorthy version 4.2.4 gives the known error:
Warning: Spoiler

I had to comment out the ATT support again - as I was doing with all WritWorth versions with the ATT support.


@Arkadius - yes You identified the problem right - WW accesses ATT before ATT is ready but adding a simple addon is loaded check does not solve the problem - there already is one:
Lua Code:
  1. if      ArkadiusTradeTools
  2.         and ArkadiusTradeTools.Modules
  3.         and ArkadiusTradeTools.Modules.Sales then

And there is no official ATT api which tells check ATT.ready to see if ATT is done with init. Might be a valuable feature for a next version.



@ziggr - ATT is just not desinged to be accessed by other addons. Adding
Code:
## OptionalDependsOn: ArkadiusTradeTools
just insures that all ATT files are parsed and loaded before WW but not that the event onAddOnLoaded for ATT has successfully run. And the ATT function PrepareTemporaryVariables() that initializes the vars that lead to the lua error (if the function is not done) is called in the onAddOnLoaded event function.


So I do not see a simple solution to have ATT support in WW.
For a stable ATT support in WW the intitialization of ATT has to be redesigned to have all structures defined and accessible with ## OptionalDependsOn: or WW has to move the price initialization forward in time to e.g the tooltip creation or player activation with a check on ??? that has to be provided by ATT.
Both suggestions require time to check and code so removing the ATT support from WW is the simplest soulution.



Regards



Edit: fixed some typos ...
Last edited by Snow : 11/22/18 at 04:28 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: