Quantcast
Download
(2 Kb)
Download
Updated: 04/15/19 07:34 PM
Compatibility:
Wrathstone (4.3)
Updated:04/15/19 07:34 PM
Created:04/15/19 12:19 AM
Monthly downloads:48
Total downloads:122
Favorites:1
MD5:
SearchMemberNotesToo
Version: 1.1
by: Coorbin [More]
With this addon, when you type in the "Filter" text box in a guild roster, it will also search the Member Notes and display any results that match either the Member Note or the user's name / @handle. That's it! Very simple addon.

IMPORTANT: This addon conflicts with any addon that hooks GUILD_ROSTER_MANAGER:FilterScrollList(). I am only aware of one addon that does this currently -- ddShopKeeper. If you have ddShopKeeper please decide if you want this addon OR ddShopKeeper.

You can't have both this addon and another FilterScrollList hook working with the correct functionality of both at the same time until or unless a compatibility layer is developed and we can get all the addon authors to use it.

In a future release of this addon I will attempt to detect when one of your installed addons (other than SearchMemberNotesToo) is hooking into that function, and display a warning so you will know when this happens, but for now I am releasing this addon as-is.

If the addon doesn't work, ask yourself the question: Does any addon I currently have enabled, other than this addon, change the behavior of the search box in the guild roster?

If the answer is "yes", it probably hooks FilterScrollList, and is incompatible with this addon.
v1.1 just removes unneeded libraries. No code changes.
Optional Files (0)


Archived Files (1)
File Name
Version
Size
Uploader
Date
1.0
44kB
04/15/19 12:19 AM


Post A Reply Comment Options
Unread 04/16/19, 08:00 AM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2166
File comments: 2361
Uploads: 56
Originally Posted by Coorbin
Yeah, since this addon doesn't have any dependencies I should just remove that. I'm so used to needing LAM by now that I just include it in every addon, but this one turned out not to need it.

Of course, I may organically grow additional functionality that touches GUILD_ROSTER_MANAGER or GUILD_ROSTER_KEYBOARD in the future, but right now this was the low-hanging fruit that I really wanted to implement. If I think of anything else that isn't niche, I'll slap it into this addon. Would make the name a little weird then though...
As said below you do not need to and shouldn't include ANY library into your addons anymore as they all work as standalone (at least 99%) and can be updated like addons using Minion since months now. Ppl got them installed already and you gain time to spend on playing/real coding instead of updating addons because of outdated libraries It also assures there is no unneeded download size + hdd/sdd space wasted.
With already existing ##AddOnVersion: <signed integer> manifest txt parameter and on PTS the new manifest txt parameter ##IsLibrary: true, this can be used to even identify them properly.
But ONLY IF they got THEIR OWN txt file, which won't be the case if you bundle them within your addons subfolders without own txt.
Last edited by Baertram : 04/16/19 at 08:02 AM.
Report comment to moderator  
Reply With Quote
Unread 04/15/19, 07:27 PM  
Coorbin
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 8
Uploads: 8
Yeah, since this addon doesn't have any dependencies I should just remove that. I'm so used to needing LAM by now that I just include it in every addon, but this one turned out not to need it.

Of course, I may organically grow additional functionality that touches GUILD_ROSTER_MANAGER or GUILD_ROSTER_KEYBOARD in the future, but right now this was the low-hanging fruit that I really wanted to implement. If I think of anything else that isn't niche, I'll slap it into this addon. Would make the name a little weird then though...
Report comment to moderator  
Reply With Quote
Unread 04/15/19, 05:17 AM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2166
File comments: 2361
Uploads: 56
This a great idea, thanks! Will make searching for a tank and healer easier

Edit:
Good news: Searched my local addons for GUILD_ROSTER_MANAGER and only found one, but it's not using FilterScrollList so no additional addon info which might break yours.

Edit2:
I just saw you have included LibAddonMenu. Better not include them anymore and add them simply to your manifest txt file as ##DependsOn:

This will make updating your addon if the lib updates non-needed anymore and assure ppl are always using the newest version + they can update it via Minion e.g.

Same with LibStub!
It's NOT included but you reference on it in your manifest txt: lib/LibStub/LibStub.lua
This won't work

Simply don't add it to the txt file and remove the libs folder completeley, provide the libs needed in the ##DependsOn: LibStub LibAddOnMenu-2.0
entry and you are fine.

Or leave it in and correct the paths in the txt file at least + change ##OptionalDependsOn to ##DependsOn if LibAddonMenu-2.0 is needed for this addon.
Last edited by Baertram : 04/15/19 at 05:23 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.