Quantcast
Download
(15 Kb)
Download
Updated: 06/01/21 05:26 AM
Pictures
File Info
Compatibility:
Blackwood (7.0.5)
Flames of Ambition (6.3.5)
Markarth (6.2.5)
Updated:06/01/21 05:26 AM
Created:01/06/21 05:55 AM
Monthly downloads:110
Total downloads:3,511
Favorites:7
MD5:
Next Boss Stage(Custom Boss Frame)
Version: 1.1.6
by: awfuldead [More]
At the moment, the addon works correctly only with the English, Russian and German clients.

The addon can track the current health of the bosses and show the percentage of the next key phase (the release of mini bosses in the cloudrest, etc.) (Idea by HOFT). There are 2 modes:
- Separate simple (text frame)
- Creates a custom frame if you do not use supported UI or use FTC and sync with custom LUI and AUI addon frames

This addon requires the LibAddonMenu-2.0 library to work.
1.1.5

-- Added pre-data for the new trial (German)

1.1.5

-- Added pre-data for the new trial (English and Russian)
-- API update

1.1.4

-- Added German language support (thanks Snow)
-- Localization of boss names is now structured as separate files (thanks Snow)

1.1.3

-- Added bosses stages in Black Drake Villa Dungeon

1.1.2

-- Fixed bug with LUI compability
-- API bump

1.1.1

-- When using AUI, the boss bar now has a "glass" style just like in AUI
-- When using AUI, the single-boss bar is now located in the same place as the standard AUI boss bar

1.1

-- Synchronization mode with third-party UI is now enabled by selecting a "custom" frame
-- Now has a full-fledged custom boss frame that turns on if you use FTC or don't use third-party UI
-- Added support for synchronization with AUI

1.0.8-1.0.8.2

-- Fixed error of rendering condition on custom LUI frame

1.0.7

-- Fixed a bug that appeared in 1.0.6

1.0.6

-- Added support for the Russian client (the names of the bosses are taken from the Internet, so if someone sees an error in one of them, please let me know)

1.0.5

-- Added stages for some number of bosses


1.0.4

-- Fixes by Baertram(ty again)

1.0.3

-- Removed permanent update of addon (outside of boss and combat)

1.0.2

-- Made the functions local (thanks Baertram)
-- Added to the description information about the library needed for the addon to function

1.0.1

-- Fixed a bug with moving frames
Optional Files (0)


Archived Files (14)
File Name
Version
Size
Uploader
Date
1.1.5
15kB
awfuldead
05/30/21 06:43 AM
1.1.4
15kB
awfuldead
03/22/21 01:50 PM
1.1.3
9kB
awfuldead
03/20/21 12:21 PM
1.1.2
10kB
awfuldead
03/16/21 10:10 AM
1.1.1
10kB
awfuldead
02/01/21 11:57 AM
1.1
9kB
awfuldead
01/30/21 02:37 PM
1.0.8.2
7kB
awfuldead
01/12/21 09:17 AM
1.0.8.1
7kB
awfuldead
01/12/21 05:21 AM
1.0.8.1
7kB
awfuldead
01/12/21 05:02 AM
1.0.7
7kB
awfuldead
01/10/21 03:18 PM
1.0.6
7kB
awfuldead
01/10/21 12:36 PM
1.0.5
6kB
awfuldead
01/07/21 05:48 AM
1.0.5
5kB
awfuldead
01/07/21 05:47 AM
1.0.4
5kB
awfuldead
01/06/21 04:07 PM


Post A Reply Comment Options
Unread 03/16/21, 03:24 AM  
awfuldead
AddOn Author - Click to view AddOns

Forum posts: 16
File comments: 26
Uploads: 7
Originally Posted by Kamaros
One of my guildmates encountered the following error:

It seems there's an edge case where a user can have the entire LUI unit frames module disabled, but still have checkLUI() return true because checkLUI() only checks for LUIE.UnitFrames.SV.CustomFramesBosses, which can still be true even if the module-level unit frame setting is disabled.

I think you'll want to update line 276 to read
Code:
if LUIE.SV.UnitFrames_Enabled and LUIE.UnitFrames.SV.CustomFramesBosses then return true
Actually, you could probably just simplify the entire checkLUI() function to
Code:
local function checkLUI()
    return LUIE and LUIE.SV.UnitFrames_Enabled and LUIE.UnitFrames.SV.CustomFramesBosses
end
and not have to deal with all those nested conditionals and explicit return values.
thanks, I'll fix it soon
Report comment to moderator  
Reply With Quote
Unread 03/15/21, 05:47 PM  
Kamaros
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 2
Uploads: 2
One of my guildmates encountered the following error:
user/AddOns/ZBNS/ZBNS.lua:351: attempt to index a nil value
It seems there's an edge case where a user can have the entire LUI unit frames module disabled, but still have checkLUI() return true because checkLUI() only checks for LUIE.UnitFrames.SV.CustomFramesBosses, which can still be true even if the module-level unit frame setting is disabled.

I think you'll want to update line 276 to read
Code:
if LUIE.SV.UnitFrames_Enabled and LUIE.UnitFrames.SV.CustomFramesBosses then return true
Actually, you could probably just simplify the entire checkLUI() function to
Code:
local function checkLUI()
    return LUIE and LUIE.SV.UnitFrames_Enabled and LUIE.UnitFrames.SV.CustomFramesBosses
end
and not have to deal with all those nested conditionals and explicit return values.
Report comment to moderator  
Reply With Quote
Unread 02/02/21, 09:44 AM  
awfuldead
AddOn Author - Click to view AddOns

Forum posts: 16
File comments: 26
Uploads: 7
Originally Posted by sonwon
Is there something special I need to do to move the location? I tried unlocking and I still could not move.
just checked, everything works with custom. it's another matter if you use AUI/LUI, you need to move the boss frames of the AUI/LUI itself
Last edited by awfuldead : 02/02/21 at 09:45 AM.
Report comment to moderator  
Reply With Quote
Unread 02/02/21, 09:36 AM  
awfuldead
AddOn Author - Click to view AddOns

Forum posts: 16
File comments: 26
Uploads: 7
Originally Posted by sonwon
Is there something special I need to do to move the location? I tried unlocking and I still could not move.
everything worked, I will definitely check. which UI are you using?or just custom frame?
Last edited by awfuldead : 02/02/21 at 09:38 AM.
Report comment to moderator  
Reply With Quote
Unread 02/02/21, 09:19 AM  
sonwon

Forum posts: 0
File comments: 243
Uploads: 0
Is there something special I need to do to move the location? I tried unlocking and I still could not move.
Report comment to moderator  
Reply With Quote
Unread 01/06/21, 03:02 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 3763
File comments: 4631
Uploads: 69
Your txt file is missing the space after the :

Code:
## OptionalDependsOn:LuiExtended
->
Code:
## OptionalDependsOn: LuiExtended
Without the space the addon name won't be recognized properly and your addon might load before LuiExtended.


Your function here is leaking the variable name "number" to global namespace! Very dangerous!
Code:
local function LineA(name, parent, dims, anchor, color, thickness, hidden)
	--Validate arguments
	if not name then name="UnnamedFrame"..number number=number+1 end
number was not defined anywhere so it will be global.

You should do this e.g.

Lua Code:
  1. local number = 0
  2. local function LineA(name, parent, dims, anchor, color, thickness, hidden)
  3.     --Validate arguments
  4.     if not name then name="UnnamedFrame"..number number=number+1 end
  5. ...
  6. end
Last edited by Baertram : 01/06/21 at 03:05 PM.
Report comment to moderator  
Reply With Quote
Unread 01/06/21, 09:18 AM  
Targets

Forum posts: 8
File comments: 46
Uploads: 0
Should add option to move all the locations at once
Report comment to moderator  
Reply With Quote
Unread 01/06/21, 08:31 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 3763
File comments: 4631
Uploads: 69
Re: Error

Originally Posted by Targets
BNSFrame_MoveStop:3: attempt to index a nil value
stack traceback:
BNSFrame_MoveStop:3: in function '(main chunk)'
<Locals> self = ud </Locals>
Change file ZBNS.xml, line 22:
<OnMoveStop>
ZBNS.OnMoveStop()
</OnMoveStop>
Report comment to moderator  
Reply With Quote
Unread 01/06/21, 08:29 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 3763
File comments: 4631
Uploads: 69
Please always add the neede dependencies in the addon description so that one sees at Minin/esoui already what to install as well:
LibAddonMenu-2.0

And the same about the global leaking variables and function names as with you other addon MyDung applies here (please read the other addon#s comments).

function LineA
LabelA
ControlA
...

etc. they are all too generic and might overwrite other addons! Add local up inf ront OR add them to your global table ZBNS properly, so they are "unique".

Many thanks.
Last edited by Baertram : 01/06/21 at 08:29 AM.
Report comment to moderator  
Reply With Quote
Unread 01/06/21, 08:18 AM  
Targets

Forum posts: 8
File comments: 46
Uploads: 0
Error

BNSFrame_MoveStop:3: attempt to index a nil value
stack traceback:
BNSFrame_MoveStop:3: in function '(main chunk)'
<Locals> self = ud </Locals>
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: