| Results: 17Comments by: Borath |
| File: MiniMap by Fyrakin [Masteroshi430's branch]06/09/23 |
 Tell me what addon do your lorebook...
Posted By: Borath
Tell me what addon do your lorebook pins come from, I will try to improve compatibility, I know there are problems with the map pins addon and quest map addon, it is mostly a timing problem, it looks like the pins are sometimes asked to be removed at a moment the minimap is already updating them so the minimap skips the pin remove in...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]06/01/23 |
|
I have near to no problems with lor...
Posted By: Borath
I have near to no problems with lore books from the lorebooks addon removing themselves, it only happens once every 300ish time and it looks like it's when I get the book when I'm in combat.
I already tried using that last year but it was causing problems (I don't remember of what type) and I improved the function to remove pins sin...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]06/01/23 |
|
EVENT_LORE_BOOK_LEARNED can be used...
Posted By: Borath
EVENT_LORE_BOOK_LEARNED can be used as a event register to cleanup lorebook pins. I tried a few functions that seemed right but they reappeared after a little bit. (CleanUpMisc() appears to work but gives an error on the first time for me)
(Lorebooks when grabbed usually clear the pin that it was picked up at, but the same lorebook...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/15/23 |
|
just uploaded 2023.05.15 which shou...
Posted By: Borath
just uploaded 2023.05.15 which should fix bug #2
I'm not sure I understand bug #1, all looks always centered to me when I test.
#2 works now
#1 was fixed with your implementation of it.
Though #1 can be slightly improved, I've included better screenshots and had a good nights rest so I can hopefully articulate my thought acro...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/15/23 |
|
Zone Frame now shows in free mode (...
Posted By: Borath
Zone Frame now shows in free mode (yay!) though I had to reload ui after changing it for it to show (now it works changing back and forth)
The anchor wasn't working though.
When I set it where I want and the UI gets reloaded (like opening the a menu(esc/inv)) the frame got set to a different location entirely.
I fixed it, idk...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/09/23 |
|
Group Rally displays on the world m...
Posted By: Borath
Group Rally displays on the world map when you are not grouped but doesn"t trigger the event EVENT_MAP_PING or populate the GetMapRallyPoint() data until you are grouped.
So it works but only when grouped.
I figured that was the case but didn't test when i was in a group today thanks :)
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/08/23 |
|
Edit:
I looked at FyrMM.Waypoint...
Posted By: Borath
Edit:
I looked at FyrMM.WaypointPins and realized it repeats the same code every time. So I made a generic helper function, and a table that holds the data for each type. Cut down the lines it took up by about half
https://pastebin.com/02zwLdFy
I also realized the Group Rally wasn't showing on the minimap and found that when...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/08/23 |
|
Edit:
we can use`(condition and...
Posted By: Borath
Edit:
we can use`(condition and {ifTrue} or {ifFalse})` actually, this will apply the first condition even if its falsey
`Visible = (FyrMM.SV.WheelMap and {Is_PinInsideWheel(pin)} or {FyrMM.IsPinVisible(pin)})`
This should work just fine
Edit2: I fixed it, your "FyrMM.IsValidBorderPin: change Visible to a oneliner" was a...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/08/23 |
|
edit: ah I fixed it, we have to tes...
Posted By: Borath
edit: ah I fixed it, we have to test pin:GetScale() against nil
Yeah this was the if statement that broke my brain that day.
I had worked on it today when I was playing, I believe it as from `if not (pin and targetscale)`, they should be separated with an `or` and not combined. I believe this is now the exact proper combination o...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/07/23 |
|
Edit:
- Zone Name set to free po...
Posted By: Borath
Edit:
- Zone Name set to free position makes it disappear, happens in 2023.05.05-3
OK I will have to investigate
- Waypoints / Rally pins / ping pins not displaying
- Errors when hovering on pins on minimap
Destination/waypoint pins can be fixed in function SpeedMeasure()
FyrMM.WaypointPins()
if not FyrM...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/07/23 |
|
Apparently it's a confusion between...
Posted By: Borath
Apparently it's a confusion between angle (table) and angleValue?
Should we use angle.angleValue in the math part or call the function with angleValue straight?
user:/AddOns/MiniMap/MiniMap.lua:911: operator - is not supported for table - number
stack traceback:
user:/AddOns/MiniMap/MiniMap.lua:911: in function 'FyrMM.AxisPosit...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/06/23 |
|
edit2:
Been playing on this one...
Posted By: Borath
edit2:
Been playing on this one below for 4 hours straight no errors for me performance good.
edit:
https://pastebin.com/raw/ctBZ9F3Z
When i logged in today i got an error for FyrMM.SetTargetScale which i believe was caused by the if statement not being correct. I've updated it and should be fine now
This contains the fi...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/05/23 |
|
Last update for the weekend. It's m...
Posted By: Borath
Last update for the weekend. It's my Friday night so wanted to get it out by now. Will leave the rest to the great dev work here :) Love the constant updates
https://pastebin.com/v7rMBdP7
something i found was that SpeedMeasure was being ran regardless if it was being shown, the current integration requires it being ran otherwi...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/04/23 |
|
Cool, thanks!
It looks like instru...
Posted By: Borath
Cool, thanks!
It looks like instructions from a programming teacher :)
I would prefer your full modified Minimap.lua file though so I can use more easily (If you don't mind)
Here's a paste of the full file
https://pastebin.com/XbyS9dAB
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/04/23 |
|
Ok thanks a lot , I will have a loo...
Posted By: Borath
Ok thanks a lot , I will have a look when you're done. :)
Finished for the day. Take a look at everything and add/update anything you think is worthwhile.
I only put the updated functions in the pastebin compared to 2023.05.03-2
Again, for the table.empty -> TableIsEmpty, I didn't include the functions where that was the only onl...
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/04/23 |
|
Based on which version ?
2023.05.0...
Posted By: Borath
Based on which version ?
2023.05.03-2 should be the version. it may be the one before it.
I've done a lot more work and have gotten to ~ ln 757 GetCurrentMapSize() on version 2023.05.03-2
Going to do a bit more work then head to bed. Will post an updated link when I'm done for the day.
|
| File: MiniMap by Fyrakin [Masteroshi430's branch]05/03/23 |
|
https://pastebin.com/raw/zCQSSFqw...
Posted By: Borath
https://pastebin.com/raw/zCQSSFqw
I did some work the lua, feel free to incorporate any changes
This hasn't really been tested all that well. But i'm currently playing with the changes so ill update my post if i find a bug with my changes. Hope this helps, cheers
I'll work on it some more and update this post.
IsCustomPins...
|
AddOn Sites
© 2014 - 2022 MMOUI