Results: 213Comments by: merlight
File: sidTools11/10/15
Great stuff! My favourite is the ev...
Posted By: merlight
Great stuff! My favourite is the event viewer, big helper. Now some feature requests. /lang XY * I've had this in a private add-on for a long time: SLASH_COMMANDS = function(args) SetCVar("language.2", zo_strtrim(args)) end /stevents * I never played with RegisterForAllEvents, but I'm wondering. Is there a reason /...
File: ESO Data Relay11/04/15
A little nitpicking... what diaboli...
Posted By: merlight
A little nitpicking... what diabolic zip archiver do you use? unzip gave me a warning the .zip uses backslashes as path separators, but converted them to forward and unpacked correctly. 7zip quietly unpacked files with backslashes in their names, total fail :D
File: sidWarTools11/03/15
edit sidWarTools.txt change not...
Posted By: merlight
edit sidWarTools.txt change notifications/CampaignQueue_$(APIVersion).lua to notifications/CampaignQueue_100012.lua
File: LibAddonMenu-2.011/03/15
After thinking about this some more...
Posted By: merlight
After thinking about this some more I changed my mind on the fail scenario. If were going to go that route and prevent setting/selecting items that aren't in the dataItems table then I would actually rather have it throw an assert() error than just fail the selection if the item doesn't exist in the list so I know something needs fix...
File: LibAddonMenu-2.011/03/15
I'm focused on usage with saved var...
Posted By: merlight
I'm focused on usage with saved vars. You won't have the name or the full entry table in saved vars, you'll have a value that will need to be looked up in the choices' custom data. I think I misunderstood what you mean, but that's exactly what everyone has or will have? name is just the key for value and that key is always calle...
File: LibAddonMenu-2.011/01/15
Then if we want backwards compatabi...
Posted By: merlight
Then if we want backwards compatability just check if the value passed to getFunc is a string & if so pack it for them: I'm focused on usage with saved vars. You won't have the name or the full entry table in saved vars, you'll have a value that will need to be looked up in the choices' custom data. This lookup could be done by...
File: LibAddonMenu-2.011/01/15
DropDown Request: I don't know ab...
Posted By: merlight
DropDown Request: I don't know about anyone else, but many times when creating a dropdown box I wish I had the ability to pass choices a table with key/value pair rather than just values. Agreed. I do realize addons that use dropdowns would have to update their LAM code. Although it may not be desired, a check could be adde...
File: Harven's Trait and Style10/09/15
If you modify this function anyway,...
Posted By: merlight
If you modify this function anyway, I would like to suggest not to do a massive use of the .. operator and build text as a table with table.concat at the end. I heard the .. operator used that way produces a lot intermediate strings. Good point. Done ;)
File: Harven's Trait and Style10/09/15
Got error in PTS from "Diagnan Haub...
Posted By: merlight
Got error in PTS from "Diagnan Hauberk" |H1:item:71004:282:50:0:0:0:0:0:0:0:0:0:0:0:0:35:0:0:0:10000:0|h|h and from some others by moving mouse over it: Got it. I knew my stupid usage of outdated color constants would bite me one day :mad: Will post a fix once I squash another bug I've found.
File: AwesomeGuildStore10/07/15
@Jekkyl click one of the sort heade...
Posted By: merlight
@Jekkyl click one of the sort headers (name, time left, price), that should fix it
File: Mer Band-Aid ZO-UI Fixes09/29/15
Well, Daggerfall Outlaws Refuge was...
Posted By: merlight
Well, Daggerfall Outlaws Refuge was actually fixed when I checked it. The coordinates were correct and barred exits removed from the map in 2.1.4. It must've disappeared in a later patch.
File: Mer Band-Aid ZO-UI Fixes09/14/15
Not needed as of 2.1.5
Posted By: merlight
Not needed as of 2.1.5
File: Stock Up09/13/15
GatherBackpackInfo isn't needed at...
Posted By: merlight
GatherBackpackInfo isn't needed at all if you use GetItemLinkStacks (use link from the store). GatherStoreInfo could return just the interesting items, the buying loop could then go over those instead of all wanted: diff -ru /tmp/esoui-unpacked/StockUp/StockUp.lua modified/StockUp/StockUp.lua --- /tmp/esoui-unpacked/StockUp/...
File: Stock Up09/13/15
Ah, you've actually found the probl...
Posted By: merlight
Ah, you've actually found the problem. Iterating list control data is not the correct way to scan backpack contents, it's never guaranteed to contain everything. The add-on should either scan SHARED_INVENTORY, or use GetItemLinkStacks (not sure the results would include repair kits from reward mails, but they're just a few and don't...
File: AwesomeGuildStore09/11/15
Sorting by unit price is a bit tric...
Posted By: merlight
Sorting by unit price is a bit tricky as it is not supported by the game API. I can only sort on the currently shown result page in that case which I plan to implement, but haven't gotten around to do yet. Has it been brought up to ZOS that not only sorting, but also searching by stack price is pretty much pointless? It'd be gr...
File: Advanced Filters09/08/15
Wet Gunny Sack shows under Misc->Al...
Posted By: merlight
Wet Gunny Sack shows under Misc->All, but no subfilter |H1:item:43757:1:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h
File: Mer Band-Aid ZO-UI Fixes09/06/15
Re: Current verison GUI scale fix?
Posted By: merlight
Yes, when you set UI scale, it saves it in saved vars, and every time you login / teleport, it checks and restores the value. Currently it's the only thing the add-on does, as all other previous bugs were fixed by ZOS.
File: Potion Maker Extended09/06/15
Blessed Thistle has Restore Stamina...
Posted By: merlight
Blessed Thistle has Restore Stamina, Ravage Health
File: The Rolling TelVar Stones09/06/15
I just can't stop laughing. I know...
Posted By: merlight
I just can't stop laughing. I know only two of their songs by name: Paint It Black and Angie :D
File: Circonians FilterIt09/06/15
This may sound stupid, but have you...
Posted By: merlight
This may sound stupid, but have you tried (after the first removal) moving your mouse away from the next item you want to remove, then back to it and then hit E? Also, switching to deposit tab and back to withdraw doesn't help?
File: The Rolling TelVar Stones09/05/15
lol so every time you get stones yo...
Posted By: merlight
lol so every time you get stones you want them to rain down your screen? I think the novelty would wear off very quickly ;) Down, sideways, bouncing... possibilities are endless!
File: Harven's Trait and Style09/05/15
Found the cause of the bug. Upon lo...
Posted By: merlight
Found the cause of the bug. Upon login, GetSmithingResearchLineTraitInfo returns known=false and GetSmithingResearchLineTraitTimes returns remaining=nil for the trait that finished researching offline. I'm going to fix it with lazy initialization of the traitTable, as I think deferring that from add-on load to when it's actually need...
File: Advanced Filters09/05/15
hi, randy! you may wanna change th...
Posted By: merlight
hi, randy! you may wanna change the icon for trophies in the consumable subfilter for a "fishy" one, as real "trophies" are under misc now, only white fishes stay here as far as I know. glass style motif fragments go to consumables/trophies as well
File: Package09/04/15
There's one problem though with usi...
Posted By: merlight
There's one problem though with using *, if the manifest has something like: $(language).lua Then it becomes *.lua. That's not exactly bad but not right either. It might contain a lua file that's not in the manifest, that we don't want to load. Hm, true. Does path expansion in windows support character classes already? .lua...
File: Package09/04/15
Looks useful, at least for people n...
Posted By: merlight
Looks useful, at least for people not using git archive ;) I'm using a similar script written in bash. Few suggestions: - add some means of including files not in the manifest, e.g, README, (UN)LICENSE - language extensions should not be hardcoded if the manifest contains l10n/lang_$(language).lua, you should copy l10n/lang_*.lua