ESOUI - What changed in ESO 1.4.4?

ESOUI (https://www.esoui.com/forums/index.php)

- General Authoring Discussion (https://www.esoui.com/forums/forumdisplay.php?f=174)

- - What changed in ESO 1.4.4? (https://www.esoui.com/forums/showthread.php?t=2267)

SnowmanDK

09/22/14 01:24 PM

What changed in ESO 1.4.4?

What changed in ESO 1.4.4?

Some addons started to throw errors, my Bank Manager Revived included.

It seems like it's not all clients having the issues though.
That is causing problems for me as I can't get the error others get on my addon, which makes it kinda hard to fix it.
I did try running my client in both french, english and german, all with no errors.

SnowmanDK

09/22/14 03:40 PM

Quote:

Originally Posted by Tierney11290 (Post 12270)

Not sure of everything, but they did indeed fix the character limitation for Addon names. For instance, if there was a color code in an addon name, the name was cut off short.

Lua Code:

return language[BankManager.Saved["language"]][text]

That's the line that fails in my addon.
Problem is I can't get that error but other people do.
They also report similar errors in other addons.

SnowmanDK

09/22/14 04:04 PM

So far I have been told of the following addons showing the same or similar errors after ESO v1.4.4 was released:

Bank Manager Revived 2.9.7/2.9.8/2.9.9 (the last 2 was attempts to fix the issue with no luck)
Crafting Stations 0.6
PublicDungeonChampions 1.1.0

My problem is I can't reproduce those errors.

Garkin

09/22/14 04:15 PM

It could be some kind of conflict between addons. Bank Manager Revived uses a lots of global functions and variables such as "init(eventCode, addOnName)", "options()", "showUI()" or "language". Those functions and variables could be easily overwritten by another addon and you can get unexpected results.

My guess is, that your global table "language" gets overwritten by another addon, because "language" is very common name for variables.

SnowmanDK

09/22/14 04:58 PM

Quote:

Originally Posted by Garkin (Post 12274)

Thanks, "language" was used in my addon, so changed that. Hope it fixed it :)

Garkin

09/22/14 05:07 PM

Quote:

Originally Posted by SnowmanDK (Post 12275)

Thanks, "language" was used in my addon, so changed that. Hope it fixed it :)

It's definitely step to the right direction. But I'd recommend to take it a bit further - move all your global functions and variables to the global table BankManager, so you will be sure that variable "dirty" is truly yours and that init(...) really initializes your addon. I.e. init(...) -> BankManager.init(...), dirty -> BankManager.dirty, language -> BankManager.language etc.

Seerah

09/23/14 08:10 PM

If a variable cannot be local, then it *must* either
a) have a non-generic name
b) be stored inside a (non-generically named) global table

This is good, responsible programming.

SnowmanDK

09/24/14 06:34 PM

Quote:

Originally Posted by Seerah (Post 12295)

If a variable cannot be local, then it *must* either
a) have a non-generic name
b) be stored inside a (non-generically named) global table

This is good, responsible programming.

Thanks to Garkin I solved the issue. It was the global variable "language" that was used.
It is in "Bank Manager Revived", which was originally developed by Todo as "Bank Manager".
But thanks for the heads-up :)

All times are GMT -6. The time now is 11:40 AM.