ESOUI - EVENT_ANTIQUITY_SCRYING_RESULT causes game crash

Are you sure it was ONLY GetDigSpotAntiquityId() you have removed or did you after that call to the function do any further checks with the return value?
ZOs always checks this e.g.

Lua Code:

local antiquityId = GetDigSpotAntiquityId()
if antiquityId ~= 0 then

before it hands in the antiquityId to the antiquity data manager, e.g. to get the current dig data:

Lua Code:

ANTIQUITY_DATA_MANAGER:GetAntiquityData(antiquityId)

Else check the original ZOs handler for that event, it does check the "RESULT" parameter of the evet before it uses GetDigSpotAntiquityId, or further more it does not use that function but another one called "GetScryingCurrentAntiquityId()"!

https://github.com/esoui/esoui/blob/...lers.lua#L1162

Lua Code:

CENTER_SCREEN_EVENT_HANDLERS[EVENT_ANTIQUITY_SCRYING_RESULT] = function(result)
    --The map handles the case where you improved and unlocked more goals than before
    if result == ANTIQUITY_SCRYING_RESULT_NO_PROGRESS or result == ANTIQUITY_SCRYING_RESULT_NO_ADDITIONAL_PROGRESS then
        local antiquityId = GetScryingCurrentAntiquityId()
        local antiquityData = ANTIQUITY_DATA_MANAGER:GetAntiquityData(antiquityId)
        if antiquityData then
            local numGoalsAchieved = antiquityData:GetNumGoalsAchieved()
            local messageParams = CENTER_SCREEN_ANNOUNCE:CreateMessageParams(CSA_CATEGORY_SCRYING_PROGRESS_TEXT)
            messageParams:SetText(GetString("SI_ANTIQUITYSCRYINGRESULT", result))
            messageParams:SetCSAType(CENTER_SCREEN_ANNOUNCE_TYPE_ANTIQUITY_SCRYING_RESULT)
            messageParams:SetScryingProgressData(numGoalsAchieved, numGoalsAchieved, antiquityData:GetTotalNumGoals())
            return messageParams
        end
    end
end