3.1 Update
Hello there,
As we know, the next update of game will be launched this week on PTS (consider the opening today or tomorrow). So the old new update thread. Please leave any comment, or issues you may encounter while doing your updates. Now, back to business, so some placeholders :
|
This compatibility function is broken
GetSmithingStyleItemInfo() in addoncompatibilityaliases.lua Lua Code:
Vvariable validItemStyleId does not exist on the 2nd and 3rd lines so styleItemLink and alwaysHideIfLocked are always blank |
Just a little note for others, item style constants such as ITEMSTYLE_GLASS etc are on the way out. They will work for now as they are in the addoncompatibilityaliases.lua file but I am checking to see how to code without them with the PTS patch.
Will let you know what I figure out |
use styleItemIndex? but I do agree all addons are coded with the ITEMSTYLE constant.
|
StyleItemIndex is great for dynamic lists, but the constants always made it easier for holding my own information on it. I'm surprised they are doing away with them so soon after cleaning them up in the last update.
|
Quote:
|
Quote:
|
Quote:
Instead of creating millions of global constants, an Enum class like ITEM_STYLE, ITEM_TRAIT, ABILITY. In Lua there is close to no difference reading a continous index based list and an ID based hash-table: Lua Code:
The Enum classes may get auto-generated from work-sheets of your designers. You may allow us to override and/or extend these Enum instances for things like :GetNameWithQualityColor. |
@Ayantir, you might want to put the .txt in your post:
https://forums.elderscrollsonline.co...change-log-pts @Chip Quote:
|
Cool changes but it does mean I have some learning and re-writting to do, all good :cool:
I will be trying to make use of these Code:
GetItemStyleName(styleId) – styleName Code:
GetSkillLineIndicesFromSkillId(skillId) – SkillType, skillIndex. Code:
NON_COMBAT_BONUS_BLACKSMITHING_BOOSTER_BONUS |
Was GetSmithingStyleItemLink supposed to be removed? If so, could someone point me in the direction of its replacement?
|
Quote:
If so this is the kind of thing Lua Code:
|
Thanks, that is what I needed. Still trying to fix the rest of the code now, though...
Also: Clockwork is a lie. It's in the books area, the items exist in the data, but the style and achievement do not. Whoever transcribed the style names to GetItemStyleName() used the constants verbatim. E.g. Celestial is now called Craglorn which is...not good. Is Mimic being in the valid style list as "Universal" intentional? If so, I'm going to have to write a work around to make that non-style not appear in CraftStore. |
Yes I saw one of the style names from GetItemStyleName(validItemStyleId) was Craglorn which did not fit.
|
Quote:
|
Oh no my brain only just kicked in, I am going to have to add code to my crafting addon to cover when someone cancels researching EVENT_SMITHING_TRAIT_RESEARCH_CANCELED durrr me
|
About Methods of Controls :
ColorSelectControl New: * GetThumbNormalizedPosition() ** _Returns:_ *number* _normalizedX_, *number* _normalizedY_ New: * SetThumbNormalizedPosition(*number* _normalizedX_, *number* _normalizedY_) Control Changed: * Set3DRenderSpaceOrigin(*number* _xM_, *number* _yM_, *number* _zM_) LabelControl New: * Clean() TooltipControl Changed: * SetSmithingStyleItem(*integer* _itemStyleId_) New: * SetVerticalPadding(*number* _paddingY_) |
Is there any point checking for EVENT_ESO_PLUS_SUBSCRIPTION_STATUS_CHANGED?
Would it be enough to just check IsESOPlusSubscriber() on player activation? |
I guess it could make sense if you got eso plus activated ingame like during the free eso+ event last weekend or if it ran out while you are ingame.
Btw @Chip, would it be possible to deactivate ESO+ on PTS and permanently add the activation thingy for 1 day of ESO+ to the crownstore there? Or instead of making it last only 1 day, add a second item to turn it off again. |
Quote:
|
All times are GMT -6. The time now is 07:53 AM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI