ESOUI - Getting a lua error with worldmap, if you choose the revive location

ESOUI (https://www.esoui.com/forums/index.php)

- Lua/XML Help (https://www.esoui.com/forums/forumdisplay.php?f=175)

- - Getting a lua error with worldmap, if you choose the revive location (https://www.esoui.com/forums/showthread.php?t=5131)

Getting a lua error with worldmap, if you choose the revive location

I'm getting an error message if I try to choose my revive location, after a death.

Code:

Map/WorldMapFilters_Shared.lua:40 - attempt to index a nil value

Here is a screenshot with the error message:

It appears the most inside the imperial city.
Anyone knows where this comes from, and if we can fix this?

Thanks

This issue is caused by some addon which is trying to access map filters in Imperial City context which does not exist. It could be for example old version of LibMapPins library, but I believe that it was fixed in LMP r10.

If its an add-on using outdated library it would be better to fix it there. Though technically it can be fixed by adding a patch add-on.

Thx for the infos guys. I'll check the addons and their librarys.

got same error, checked, all my active addons use r10 of libmappins.
ps: in the error, it's CustomCompassPins the guilty. Does this one is IC ready?

Looks like nil instead of callback error to me.

Map/WorldMapFilters_Shared.lua:40

Lua Code:

return self.modeVars.filters[self.mapFilterType][mapPinGroup]

My guess is that filters[self.mapFilterType] is nil there. If you check ./ingame/map/worldmap.lua +6238, you'll see there aren't filters[mapFilterType] tables for every mapMode/mapFilterType combination.

Edit: specifically, MAP_MODE_AVA_RESPAWN doesn't have filters for MAP_FILTER_TYPE_AVA_IMPERIAL

Edit2: Can't test it myself

Lua Code:

CALLBACK_MANAGER:RegisterCallback("OnWorldMapSavedVarsReady", function(savedVars)
    local filters = savedVars[MAP_MODE_AVA_RESPAWN].filters
    if not filters[MAP_FILTER_TYPE_AVA_IMPERIAL] then
        filters[MAP_FILTER_TYPE_AVA_IMPERIAL] = {}
    end
end)

Quote:

Originally Posted by Ayantir (Post 23352)

got same error, checked, all my active addons use r10 of libmappins.
ps: in the error, it's CustomCompassPins the guilty. Does this one is IC ready?

CustomCompassPins fires callback "OnWorldMapChanged" and error occurs in callback handler. Is it really CustomCompassPins fault?

Error occurs in this function:

Lua Code:

function ZO_WorldMapFilterPanel_Shared:GetPinFilter(mapPinGroup)
    if self.modeVars then
        return self.modeVars.filters[self.mapFilterType][mapPinGroup]
    end
    return nil
end

Because self.modeVars.filters[self.mapFilterType] is nil.
(In this case self = WORLD_MAP_FILTERS.imperialPvPPanel and self.modeVars = self.savedVars[mapMode])

I wonder if it is because ZO_WorldMap_GetMode() returns invalid value (mapMode is invalid or nil). But I can't be sure unless I do some tests.

Quote:

Originally Posted by Garkin (Post 23355)

CustomCompassPins fires callback "OnWorldMapChanged" and error occurs in callback handler. Is it really CustomCompassPins fault?

Error occurs in this function:

Lua Code:

function ZO_WorldMapFilterPanel_Shared:GetPinFilter(mapPinGroup)
    if self.modeVars then
        return self.modeVars.filters[self.mapFilterType][mapPinGroup]
    end
    return nil
end

I would write a patch add-on for this problem (or maybe add it to MapFix?)

Lua Code:

local _GetPinFilter = _G["ZO_WorldMapFilterPanel_Shared"].GetPinFilter
local function GetPinFilter (obj, mapPinGroup)
    if obj.modeVars then
        if obj.modeVars.filters and obj.mapFilterType then
            if obj.modeVars.filters[obj.mapFilterType] then
                return obj.modeVars.filters[obj.mapFilterType][mapPinGroup]
            end
        end
    end
    return nil
end
_G["ZO_WorldMapFilterPanel_Shared"].GetPinFilter = GetPinFilter

In response to this thread I implemented a fix for this error internally this morning. We'll get it out to you as soon as we're able. Thanks!

Thanks for the information.