Crash at stablemaster
Hi, it took me a while to narrow down the suspects but I managed to.
I have Inventory Grid View, JunkIt, and Sous Chef addons, and upon changing mounts at the stable master the game will either hang for 2-5 seconds or just crash. I'm not sure what other info would be helpful to solving it :\ |
Quote:
Either way that is a lot of slots to call updates on at once. I can see the possibility of JunkIt causing a slight second delay, but I don't see any reason it would cause a crash. I'm looking at it now I'll let you know what I find. |
thanks, it is only when all 3 of those are enabled at the same time. Inventory grid view by itself causes a 2 second hang, the others just cause the normal hiccup.
|
Quote:
|
well hopefully ingeniousclown, katkat, or crazydutchguy see this and can provide more insight on the other addons :\
Client crashes using a different computer so I don't think its hardware. I also did a client repair but it didn't help any. |
Do you have SousChef set to sort ingredients in your inventory? (It's the last option in the menu.) If so, you might try turning that off first, to see if it has any impact. The issue might be LibSort. Otherwise, there's a little bit of optimization that can be squeezed out of the AddRankToSlot function, but not much.
Randactyl, can you speak for InventoryGridView? |
3 Attachment(s)
I do not have SousChef set to sort ingredients. I attached the saved variables for the 3 addons if that helps any. let me know if there is anything else I can get to help.
I posted on the inventory grid view comments earlier also and linked to this thread. |
inventory updates
Hi,
I worked around a similar issue with my addon. Changing a horse can lead to many item update events. Since 1.3 or so the client crashes seemingly on purpose when the response takes too long. I solved it by only calculating results when my window was actually visible as well as throttling the recalculation frequency. So if there is now something like horse change start and or post event you could throttle it easily. |
Echoing what I said on IGV's comments:
I'm with circonian. I have no idea why each inventory slot needs to be updated when switching mounts - seems silly. IGV and I'm guessing Sous Chef adds its (our) info to items when the item controls are created. It sounds like the slowdown is because each of the item controls are being recreated when changing mounts. The problem is we cant really change when we assign this info - it would possibly not be ready when the user needed it. Maybe we can get in touch with ZOS_ChipHilseberg and figure out why those slots need to be recreated or possibly work on changing that practice. Expanding on that: I don't want to say too much, as I still haven't had time to thoroughly look through the issue. If there are horse events, maybe we can ignore updating info if the reason comes from opening the stable/changing your horse - provided our added data isn't erased in that refresh process. |
Quote:
- slot indexes not guaranteed filled 1-20 for 20 items (probably true) - no item can have a slotIndex greater than the capacity Example: You're 120/120, remove items with slotIndex 1-30 to get to 90/120. Switch to 100-capacity horse. There'd still be items with slotIndex >100, so they'd have to be moved down. Now, they could still rework how they repack stuff to limit the number of items that have to switch slots (only move those that'd be over capacity) or even remove that 2nd limitation altogether. I suppose there's a chance they'd do something, since it does hiccup on even normal game switch, but I wouldn't count on it. ---------------------------------------- From the author end, the best bet is probably to just make sure you don't do slotUpdate during a horse swap. If there isn't an event for that, you can tie into showing/hiding the stable scene. It's possible you might not have to even do a scan afterwords. (If you cache slotIndex, you probably will, but think that's probably it.) |
Quote:
|
I've had the same problem with my Addon Mobile Bank Extended.
Since i never switched my Horse, i never had the experience myself, but one of the Users reported that problem. The Solution was simpel: only do your logic if the Item is "New" ,which is one of the parameters of the Event. Lua Code:
Hope this info helps the Authors to fix their Addons. |
Nice, farangkao.
Better yet, put the check right at the beginning so you exit as quickly as possible: Lua Code:
Though as circonian noted, it does remove details in the dataEntry table. So if you use that or cache the slotIndex values, you're going to need to update the slots instead of this (and should probably do it as a delayed full scan). |
Yeah, that makes sense Sasky.
I've got some rewriting in my future ;) |
All times are GMT -6. The time now is 08:20 PM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI