[circonian]

Originally Posted by DrGerm Both of these work when I test them. I've seen examples in other addons like Example 1, but Example 2 seems simpler. However, I have a feeling that I'm missing something about how to code correctly.

Either way it does the same thing.

Some of what you saw (written either way) may have just been personal prefference &/or to make the code easier to read. Think if you nested a few of these (this is a slightly exagerated example, but will hopefully let you see the problem):

d(func1(func1Param1, func1Param2, func2(func2Param1, func2Param2, func3(func3Param1, func3Param2), func2Param4), func1Param4))

It gets hard to read and I gave all of the functions very short names. So in some cases it might be beneficial to save the return value in local variables and then pass it into whatever else needs it just to make it easier to read:

local func3ReturnValue = func3(func3Param1, func3Param2)
local func2ReturnValue = func2(func2Param1, func2Param2, func3ReturnValue, func2Param4)
local func1ReturnValue = func1(func1Param1, func1Param2, func2ReturnValue, func1Param4)
d(func1ReturnValue)

Also if the value is used anywhere else in the code it would be more beneficial to save the value in a local variable and then use that throughout the code instead of calling GetSetting(..) every time you want that value. One exception to that is if you were calling a function to grab a value that could possibly change as your code is running and you need to make sure you always have the most up to date value then you might be better off calling the function more than once.