View Single Post
07/21/15, 03:37 PM   #15
circonian
AddOn Author - Click to view addons
Join Date: May 2014
Posts: 613
Originally Posted by merlight View Post
Perhaps I found a way. My lib does its overrides in EVENT_PLAYER_ACTIVATED. Unless an add-on calls lib:disableGuildStoreSellFilters() in their EVENT_ADD_ON_LOADED handler, the lib proceeds to enable the default filters.
  1. That would put all of the work on AGS (and any other addon) to have a setting to turn it off & not call that function if they want to see the filter bars of another addon though. Another addon wanting to use the default inventory menu bar would have no way of overriding anyone else who runs that function if the user wants to display those bars via a setting they chose (unless that setting is in AGS, everyone else would be dependent upon the setting in AGS).
  2. It would also not solve any problems if more than one addon called that so they could each display their own menu bars.

No matter what though there is going to be an unsolvable conflict if the user chooses to show the menu bars for multiple addons...although ??? would it be a good thing to allow it? Yes it would be a mess several menu bars showing, but it would help the user figure out whats wrong rather than wondering why xxx addons menu bars aren't visible and some other menu bars are.

How about instead of using a lib function to "block" the default inventory menu bars create a function that must be called to enable the defualt menu bars. This way each addon can handle its own code & not worry about any other addon. Each addon would be required only to have a setting that would allow users to turn the given addons menu bars ON/OFF.
  • If ON the addon does what it needs to show its menu bars. If their custom, run whatever code you need. If its the default menu bars call that lib function.
  • If OFF the addon just does nothing & does not call the lib function and does not create its own menu bars.

If a user turns on menu bars from multiple addons then they just need to turn some of them off in the settings.
  Reply With Quote