View Single Post
08/25/23, 05:16 AM   #3
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,989
hook to EVENT_COMBAT_EVENT
Hooking into an event is not possible, unless you meant you want to hook into a vanilla code callback function of that event? Which makes no sense as you can register your own callback to get the same information (I guess you meant that by hook).


I don't think that this library would be needed as you can simply register that extra EVENT_COMBAT_EVENT with event filters to get that abilityId -> As you need to check the killing blow of ALL others around you this will be a big performance thing though I believe!
Beside that I doubt it will fire all combat events cyrodiil wide, only near yourself right?
And the library would not help here as it does the same like EVENT_MANAGER does.


In the end it would be better/more performant if ZOs provides the data directly within EVENT_PVP_KILL_FEED_DEATH , right.
But:

That could lead to "too much information" as you could spy class and other info by that help? Which maybe not wanted in PvP areas and leads to APi restrictions in the end again (unless the current EVENT_PVP_KILL_FEED_DEATH already provides that info by the displayName/characterName and you can get that char's data like class etc. by their name already now, without having to build lookup tables of before seen characters etc.).

Last edited by Baertram : 08/25/23 at 05:18 AM.
  Reply With Quote