Event_smithing_trait_research_completed

[Weolo]

This event is not always firing when crafting research finishes.
Sometimes it does, sometimes it doesn't.
I am trying to monitor it to get more information.

I log on to a character that I know has finished researching a trait, and sometimes the event fires but not everytime. I am always seeing xp gain show from the lootdrop addon, it seems when the event is not firing then no text appears in to the top right of the screen telling you which item was researched.

This is the code I have right now.
Is this the best way to use the event?
Has anyone else had a problem like this?

local ADDON_NAME = "something"
local player_activated = false
 
local function OnResearchCompleted(eventCode, craftingSkillType, researchLineIndex, traitIndex)
    LogMe:add("Function OnResearchCompleted("..tostring(eventCode)..", "..craftingSkillType..", "..researchLineIndex..", "..traitIndex..")")
end
 
local function OnPlayerActivated()
    if player_activated then return end --Only the first time
    player_activated = true
    EVENT_MANAGER:UnregisterForEvent(ADDON_NAME, EVENT_PLAYER_ACTIVATED)
    LogMe:add("Event OnPlayerActivated")
end
 
local function OnLoaded(eventType, addonName)
    if addonName ~= ADDON_NAME then return end
    EVENT_MANAGER:UnregisterForEvent(ADDON_NAME, EVENT_ADD_ON_LOADED)
    LogMe:add("Event OnLoaded")
 
    EVENT_MANAGER:RegisterForEvent(ADDON_NAME, EVENT_SMITHING_TRAIT_RESEARCH_COMPLETED, OnResearchCompleted)
    EVENT_MANAGER:RegisterForEvent(ADDON_NAME, EVENT_PLAYER_ACTIVATED, OnPlayerActivated)
end
 
EVENT_MANAGER:RegisterForEvent(ADDON_NAME, EVENT_ADD_ON_LOADED, OnLoaded)

[circonian]

Originally Posted by Weolo This event is not always firing when crafting research finishes. Sometimes it does, sometimes it doesn't. I am trying to monitor it to get more information. I log on to a character that I know has finished researching a trait, and sometimes the event fires but not everytime. Has anyone else had a problem like this?

I don't think it fires when you log in if the trait finished while you were offline.
You could use EVENT_SMITHING_TRAIT_RESEARCH_STARTED, to mark traits as known. To start research the game/character has to be active so the addon is running so your guaranteed not to miss it and since you can't cancel research or research it again, the trait is as good as known.

If you didn't want to mark them early like that I think you have to just check all of the unknown traits on login to see if anything new was learned while offline.

[Weolo]

Originally Posted by circonian I don't think it fires when you log in if the trait finished while you were offline.

Okay I can work with that.

Originally Posted by circonian You could use EVENT_SMITHING_TRAIT_RESEARCH_STARTED, to mark traits as known.

I am already using this event but to mark traits as being researched.

Originally Posted by circonian I think you have to just check all of the unknown traits on login

I am doing this already

Keeping all your advice in mind I think I will re-write the way I am capturing the trait information just to rule out any potential problems.

Thanks for the help.