|
09/16/15, 05:26 PM | #1 | ||
|
slot 204 ... 21 Sanded Maple ... GetItemLink(2, 204) returns "sanded maple^ns" slot 236 ... 1 Sanded Maple ... GetItemLink(2, 236) returns "sanded maple^ns" Item links don't carry information about quantity. edit: tried it with and without the 's' flag out of curiosity: Lua Code:
Last edited by merlight : 09/16/15 at 05:30 PM. |
||
09/16/15, 05:53 PM | #2 | |
|
What good would changing my working code? Again, I'm not writing 1 line of LUA, just parsing it. OK, I was wrong about it's use. As I said this is just for my code and I was just asking other users for items. You are correct I do use replacement: Code:
line = Replace(line, "^p", "", 1, -1) line = Replace(line, "^ns", "", 1, -1) line = Replace(line, "^n", "", 1, -1) here is the only thing I can tell you for sure then, it works for me and my program so the data is consistent. I said this has no bearing on ANY in game code and I thought maybe I found something (which you proved incorrect). There is only ^ns on the type of items I showed you, you can draw your own conclusions, I just needed a marker to correct incoming data. For me the ^ns was a gift from the LUA gods. Lua Code:
Feel free to draw your own conclusion - I just pointed out a pattern I saw and it works for me. All I wanted to do was get a few more items from users of GSA before the update. My new version works fine, I made the necessary changes and that's all I was looking to do. Now maybe someone can figure out why only raw crafting items have that ^ns ... maybe it's useful for something. There is no denying there is a pattern. -d |
|
09/16/15, 06:22 PM | #3 | |
Wandamey
Guest
Posts: n/a
|
i'd say ^ns = neutral singular (forces singular form even with qtt > 1). kinda obvious for materials but there are others.
you can safely make a pattern to remove everything after ^ (lua or not) imo these ^gendernumber are in almost every word in french and german, with more variations, so it wouldn't be a waste to do like that Last edited by Wandamey : 09/16/15 at 06:29 PM. |
|
Wandamey |
09/17/15, 12:01 AM | #4 | |||
|
||||
09/17/15, 03:19 AM | #5 | |
|
Whatever - thats great - I'm done with this.
I wrote GSA over a year ago. My routines work fine and all I am doing is supporting an addon for a game I hardly play anymore. I'm doing what an author should do, support your own work! It survived Patch 6 with zero changes. This is the first time I HAVE EVER had to update the database format. Did you know I get the rarity of the item and change the color? Please, now tell me how my code is wrong and how I could do it better without ever seeing what I wrote or knowing how I did it? I came here looking to get a few more items to check for since in the offline database the items are already written incorrectly. I easily fixed incoming data and I fixed the users existing database (most of them have 6 months of data or more) -- that was 10x harder than parsing the item link. I came here to maybe get some more items from GSA users and I got none, so my post was a complete failure. My code was already done. The last thing I needed was tons of advice on something I don't need (how to parse a string) and LUA code for my VB.NET program. I'm done with this thread, it's closed to me. It was actually more frustrating than useful. You guys can argue the best way to write code to do something I never needed help with. I'll go back to supporting my users. You know, the ones who put you on the top of their "Recommended Addons!" list. That's who I code for. That's who I was trying to get more items for. The people who use my addon. -d Last edited by dopiate : 09/17/15 at 03:23 AM. |
|
09/17/15, 04:09 AM | #6 |
I don't believe your thread was a failure. After reading the posts I arrived at the conclusion that the item names did not get changed, but the parsing in your .NET program was not future proof enough to handle the latest changes to the formatting strings. If they did add a 'q' instead of an 's' you might have immediately seen that, but with the 's' thrown in you arrived at the conclusion that the names changed to plural when in fact they did not.
The code example was just something I threw together because I happened to have a visual studio with a c# application open at that moment. It was free advice which in no way was meant to offend you and I don't know why you think your code might be wrong because of it (I don't know your code). If you don't want to use it, then don't use it. Writing angry sounding responses might make me think about it twice before answering to your posts again in the future. |
|
09/17/15, 04:38 AM | #7 | |
|
the tone was unintentional
It's very early and I'm just getting ready for work so please do not take any of that post as angry or hostile. I respect you and everyone you who replied. After, getting some caffeine in me (and waking up more brain cells) I will say that I was disappointed I couldn't get anymore items before release but you are right it was not time wasted. You and merlight helped me come to the conclusion that the s was not what I thought it was, even though I had dealt with it already, it's more satisfying to fully understand the changes to the item link string. And I do appreciate the code suggestions. No one here has to help or get involved and I appreciate everyone who did. The only emotion that should be read into that post was disappointment. First, for not getting more items but to be 100% honest after this thread I figured out a way to get all the items I needed without ANY user interaction and I think walking through it with you helped me realize that. So the biggest disappointment was personal in that I didn't think of that solution first. I'm very critical of my code, I have a PERL mindset. Do more with less and my fix doesn't do that, but the next release will. If I offended you, I apologize completely. There is no hostility from me and I thank everyone who replied. Again, my apologies to you and anyone who might have taken offense to that post. I even retract my conclusion because I now realize that everyone's insight (and code suggestions) helped me figure out a more elegant/efficient fix. Thanks, -d PS the good news is so far no error reports! Last edited by dopiate : 09/17/15 at 04:43 AM. |
|
ESOUI » AddOns » AddOn Help/Support » Help With Item Name Changes |
«
Previous Thread
|
Next Thread
»
|
Display Modes |
Switch to Linear Mode |
Hybrid Mode |
Switch to Threaded Mode |
|
|