Thread Tools Display Modes
01/28/21, 05:38 AM   #1
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 5,028
Thanks for this addon + description what it does. Sounds handy.

Just an idea and I do not know what the python poll will use for system ressources and how it checks if changes were done at the sv file (like read last changed date and time only or open the file, parse and read a line to see if a flag "updated = true" was set?
Every 3 second seems a bit too quick/often imo. SV only update at loading screens or logout so 10seconds or even 30 should be enough.

Maybe python is also able to see if the process eso64.exe is running and if not auto load the sv fle data once as it was updated for sure at logout then.
But this would need to poll for the exe file/process in a short timeframe again so this wouldn't be a win :-)

Last edited by Baertram : 01/28/21 at 05:54 AM.
  Reply With Quote
01/28/21, 10:26 AM   #2
marcjordan
AddOn Author - Click to view addons
Join Date: Sep 2020
Posts: 14
Originally Posted by Baertram View Post
Thanks for this addon + description what it does. Sounds handy.

Just an idea and I do not know what the python poll will use for system ressources and how it checks if changes were done at the sv file (like read last changed date and time only or open the file, parse and read a line to see if a flag "updated = true" was set?
Every 3 second seems a bit too quick/often imo. SV only update at loading screens or logout so 10seconds or even 30 should be enough.

Maybe python is also able to see if the process eso64.exe is running and if not auto load the sv fle data once as it was updated for sure at logout then.
But this would need to poll for the exe file/process in a short timeframe again so this wouldn't be a win :-)
I played around with the polling initially a long time ago and in frustration defaulted to using the filecmp.cmp(shallow=False) command to compare the save file to a local copy of the last changed file - with shallow=False it compares the files, not timestamps. I'm not sure of the performance but I don't seem to notice any issues while playing. I'll be adding some timing measurements to the Python soon.

Thanks for taking a look.
  Reply With Quote
02/19/21, 11:29 PM   #3
marcjordan
AddOn Author - Click to view addons
Join Date: Sep 2020
Posts: 14
Originally Posted by Baertram View Post
Thanks for this addon + description what it does. Sounds handy.

Just an idea and I do not know what the python poll will use for system ressources and how it checks if changes were done at the sv file (like read last changed date and time only or open the file, parse and read a line to see if a flag "updated = true" was set?
Every 3 second seems a bit too quick/often imo. SV only update at loading screens or logout so 10seconds or even 30 should be enough.

Maybe python is also able to see if the process eso64.exe is running and if not auto load the sv fle data once as it was updated for sure at logout then.
But this would need to poll for the exe file/process in a short timeframe again so this wouldn't be a win :-)
I fixed the file change detection with the watchdog Python module. Check it out.
  Reply With Quote

ESOUI » AddOns » Released AddOns » [Data Mods] ESO Grinder


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off