Bank Item Not Showing

[kendaron]

Hi all,

For those that do not know, I am the author of CookeryWiz.

It has the ability to collect writ items that need to be crafted, and I have just implemented the ability to automatically collect them from the bank.

Now! I thought it was working fine.. but then I found that it would not work with Garlic Pumpkin Seeds (so far this is the only one I have encountered)

When I enumerate the bank, I see that this particular item is simply not showing up. Has anyone else experienced an item not showing? Is there perhaps a secret to this that I am overlooking?

Apologies if this has been discussed before but I want not quite sure what to search on

Thanks

[Baertram]

Do you enumerate from slotindex 0 to slot count -1?

for slotIndex = 0, GetBagSize(bagId) - 1 do 
---
end

[Ayantir]

How do you enumerate gbank ?

PS: You should use n.data.slotIndex to get the real slotindex of an item. where n is your slot.

I personally use ZO_GuildBankBackpack.data, but I think SHARED_INVENTORY should be better.

[kendaron]

its basically the following

local bagSize = GetBagSize(BAG_BANK)
for i = 1, bagSize do
<snip>
local itemLink = GetItemLink(BAG_BANK, i, linkStyle)
local itemType = GetItemLinkItemType(itemLink)
local itemName = GetItemLinkName(itemLink)
<snip>
end

Is the indexing actually 0 based? I was under the impression most things were 1 based>

[Ayantir]

no, as I said, your enumeration isn't correct.

local bankbag = SHARED_INVENTORY.bagCache[BAG_BANK]
 
for i, data in ipairs(bankbag)
    <snip>
    local itemLink = GetItemLink(BAG_BANK, data.slotIndex, linkStyle)
    local itemType = GetItemLinkItemType(itemLink)
    local itemName = data.name
    <snip>
end

If when you open the GBank, i == index,
do some restacks, ask a guildmate to change some stuff while scanning bank and you'll get your index changed a lot

Take care, if someone change something in bank between the moment of your scan and the moment of you move something, data couldn't be correct.

[Baertram]

Yes the inventories are 0 based, not 1 based!

This happens for the guild bank but not for your own, local bank (isn't it?)
So is there any advantage to use the SHARED_INVENTORY here instead of PLAYER_INVENTORIES.inventories[inventoryType], where inventory type could be the backpack or bank?

[Garkin]

Originally Posted by Ayantir no, as I said, your enumeration isn't correct. local bankbag = SHARED_INVENTORY.bagCache[BAG_BANK]   for i, data in ipairs(bankbag)     <snip>     local itemLink = GetItemLink(BAG_BANK, data.slotIndex, linkStyle)     local itemType = GetItemLinkItemType(itemLink)     local itemName = data.name     <snip> end If when you open the GBank, i == index, do some restacks, ask a guildmate to change some stuff while scanning bank and you'll get your index changed a lot Take care, if someone change something in bank between the moment of your scan and the moment of you move something, data couldn't be correct.

If you use SHARED_INVENTORY this way, it's possible that cache won't be updated. Also I'm not really sure if you can use ipairs, I believe that some indexes could be empty (nil).

You should get bank cache this way:

local bankCache = SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK)
 
for slotIndex, itemData in pairs(bankCache) do
    --
    local itemLink = GetItemLink(itemData.bagId, itemData.slotIndex, LINK_STYLE_BRACKETS)
    local itemType = itemData.itemType
    local itemName = itemData.rawName
    --
end

[kendaron]

Yay

I enumerated the player bank as per Garkin's example and those pesky Garlic Pumpkin Seeds popped out of hiding!

Thanks everyone for your assistance

Originally Posted by Garkin If you use SHARED_INVENTORY this way, it's possible that cache won't be updated. Also I'm not really sure if you can use ipairs, I believe that some indexes could be empty (nil). You should get bank cache this way: local bankCache = SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK)   for slotIndex, itemData in pairs(bankCache) do     --     local itemLink = GetItemLink(itemData.bagId, itemData.slotIndex, LINK_STYLE_BRACKETS)     local itemType = itemData.itemType     local itemName = itemData.rawName     -- end