question regarding tables and number of entries

[sinnereso]

Im looking for a way to determine the number of entries on the fly for a chat multiiple event filter im working on for the "FOR" statement. Ive been getting errors stating its expecting a number with this setup.

MyAddon.killFilterList = {}

function MyAddon.PvpKillFeedFilter(victomDisplayName)--<< PVP CHAT FEED MULTIPLE EVENT FILTER
	for i = 1, MyAddon.killFilterList do
		if (nil == MyAddon.killFilterList[victomDisplayName]) then
			table.insert(MyAddon.killFilterList, victomDisplayName)
			return false
		end
	end
	return true
end

I'd like to to just scan the list and add entries theyre not present.

then later clear the list which I think I can do with "MyAddon.killFilterList = {}" but untested untill the 1st part is working.

Suggestions?

[ExoY]

can you explain with a small simple example what you want to do.

maybe it is just me, but i have no idea what you are trying to achieve with the text you posted.

[sinnereso]

Originally Posted by ExoY can you explain with a small simple example what you want to do. maybe it is just me, but i have no idea what you are trying to achieve with the text you posted.

im trying to filter the new pvp kill feel chat events that appear to fire multiple times.. so im adding playernames to a list to prevent displaying the same kill multiple times.. So if the player is in the list do nothing.. if not then add to the list and display chat output.. the chat output code i didnt post here but my primary issue is the error im getting from the "for i = 1, MyAddon.killFilterList do" line stating its expecting a number of current entries i guess.

[sinnereso]

Originally Posted by ExoY can you explain with a small simple example what you want to do. maybe it is just me, but i have no idea what you are trying to achieve with the text you posted.

one of the dev's posted a way to fix this after the kill feed was released but I didnt understand it at the time and cant find it now so ive been trying to create my own.

[FlatBadger]

You need to iterate the table, but it depends on the structure of your table. You need to use either

pairs

or

ipairs

e.g.

local myTable = {[key1]="value1",[key2]=value2}
 
for key, value in pairs(myTable) do
 d("key: " .. key .. " value: " .. value)
 
end
 
local myOtherTable ={value1, value2, value3}
 
for index, value in ipairs(myOtherTable) do
  d("item number " .. index .. " = " .. value)
end

instead of ipairs you could also use:

for index = 1, #myOtherTable do
  d("value = " .. myOtherTable[index])
end

[sirinsidiator]

Originally Posted by sinnereso Im looking for a way to determine the number of entries on the fly for a chat multiiple event filter im working on for the "FOR" statement. Ive been getting errors stating its expecting a number with this setup. MyAddon.killFilterList = {} function MyAddon.PvpKillFeedFilter(victomDisplayName)--<< PVP CHAT FEED MULTIPLE EVENT FILTER for i = 1, MyAddon.killFilterList do if (nil == MyAddon.killFilterList[victomDisplayName]) then table.insert(MyAddon.killFilterList, victomDisplayName) return false end end return true end I'd like to to just scan the list and add entries theyre not present. then later clear the list which I think I can do with "MyAddon.killFilterList = {}" but untested untill the 1st part is working. Suggestions?

You are passing the table "MyAddon.killFilterList" to "for .. do" instead of the length of the table "#MyAddon.killFilterList".

Other than you are mixing two different approaches on how to use tables and end up not filtering anything at all.
You iterate over the table and insert new entries into it with numeric indexes, but at the same time try to access entries in the table by using the displayName as a key (instead of the numeric index).

MyAddon.killFilterList = {}

function MyAddon.PvpKillFeedFilter(victomDisplayName)--<< PVP CHAT FEED MULTIPLE EVENT FILTER
	if not MyAddon.killFilterList[victomDisplayName] then
		MyAddon.killFilterList[victomDisplayName] = true
		return false
	end
	return true
end

Aside of that you will have to unset the entry in the killFilterList at some point, otherwise you won't ever show the name again after it got filtered the first time.

[sinnereso]

Originally Posted by sirinsidiator You are passing the table "MyAddon.killFilterList" to "for .. do" instead of the length of the table "#MyAddon.killFilterList". Other than you are mixing two different approaches on how to use tables and end up not filtering anything at all. You iterate over the table and insert new entries into it with numeric indexes, but at the same time try to access entries in the table by using the displayName as a key (instead of the numeric index). MyAddon.killFilterList = {} function MyAddon.PvpKillFeedFilter(victomDisplayName)--<< PVP CHAT FEED MULTIPLE EVENT FILTER if not MyAddon.killFilterList[victomDisplayName] then MyAddon.killFilterList[victomDisplayName] = true return false end return true end Aside of that you will have to unset the entry in the killFilterList at some point, otherwise you won't ever show the name again after it got filtered the first time.

yes im aware of the resetting the list which is next and I think a non issue but populating the list has been my issue. Im using similar code to populate a list of char names on account though and works fine.

what im trying to do is add victoms to the list and NOT display them(and return false) if in the list because the ingame killfeed fires twice per kill.

will "#MyAddon.killFilterList" work in the for .. do statement for length of list or number of entries? I've never seen this example before.

The devs posted a fix for the pvp kill feed double spam but I cant find it anywhere.. Anyone have a link?

[Baertram]

Originally Posted by sinnereso will "#MyAddon.killFilterList" work in the for .. do statement for length of list or number of entries? I've never seen this example before.

Depends on if your table #MyAddon.killFilterList uses a non-gap index key (1, 2, 3, 4, 5, ...) or not.
# means "count of" and only works (afaik) with non-gap index tables, same as "for key, value in ipairs(tableName) do " would iterate.

If your key is a string like a characteror accountName, it will not work.
You will have to read above then where the guys explainend you alreay how to iterate that -> "in pairs" (not in ipairs)

[sinnereso]

Originally Posted by Baertram Depends on if your table #MyAddon.killFilterList uses a non-gap index key (1, 2, 3, 4, 5, ...) or not. # means "count of" and only works (afaik) with non-gap index tables, same as "for key, value in ipairs(tableName) do " would iterate. If your key is a string like a characteror accountName, it will not work. You will have to read above then where the guys explainend you alreay how to iterate that -> "in pairs" (not in ipairs)

Thank you for all the help.. I found the dev post regarding my issue and have come up with another workaround thats more effective and more efficient.. ty

[ExoY]

Originally Posted by sinnereso Thank you for all the help.. I found the dev post regarding my issue and have come up with another workaround thats more effective and more efficient.. ty

Can you post the link to the dev post and your improved solutions, so others can benefit from it as well?

[sinnereso]

Originally Posted by ExoY Can you post the link to the dev post and your improved solutions, so others can benefit from it as well?

Sure but this question here was more generalized to assist me with a pvp kill feed doouble spam filter which is why I didnt go more into detail on my resolution.. Here's the link and solution.

https://www.esoui.com/forums/showthr...8153#post48153

the event sends these variables twice when firing:

(eventCode, killLocation, killerDisplayName, killerCharacterName, killerAlliance, killerRank, victomDisplayName, victomCharacterName, victomAlliance, victomRank, isKillLocation)

apparently my double spam issue is caused by one being "isKillLocation" location based 10cell radius and one not which is using the standard 2cell radius. I just filter by " if isKillLocation then" or "if not isKillLocation then" and imediately solved the issue.