Saved vars and API version (or: I might have screwed up)

[zgrssd]

There has been some trouble with the saved vars beign reset (due do changes how they are saved/accessed). And suddenly I reliased:
Damn, that is good so. Becuase my addon (UTC) might break/damage the chat if it is apllying 100003 version settings for version 100007 chat (I am not sure it actually will. Would need the patchnotes and tests for that).

My Addon stores and applies data on wich ChatTab has wich Chatcategory enabeled (is listening to those channels). Categories are identified by a int. It also synchs Category Colors.
So naturally when gathering the data I go over all categories from 1 too GetNumChatCategories().
When applying it I go over all the int's from 1 to #StoredCategories.

This works if the number of chat categories stayed the same or increases and new were appended at the end.
This fails horribly if they changed the order of Chat Categories and/or added new ones in the middle. It is like Race Condition 101 all over.
I just need to figure out how to get the API version and use default data in the OnLoaded if the version differs.

I just thought I mention that because you might run into similar issues if you itterate over anything and write it back to the UI.

[farangkao]

I have a similar thing with my Addon ,it saved the Item Links ,however since they changed in this Patch, the old Data needs to be cleaned

If you want to make sure, you just need to increase the Version number in your SavedVars call, then it will automatically discard the old data.

[zgrssd]

Originally Posted by farangkao I have a similar thing with my Addon ,it saved the Item Links ,however since they changed in this Patch, the old Data needs to be cleaned If you want to make sure, you just need to increase the Version number in your SavedVars call, then it will automatically discard the old data.

I mean "autoamtically" as in:

IF SAVED_VAR.Version ~= Current.API_VERSION then ...

Having to manually do that will result in not properly getting all cases. I did it via "disable addon in code, the make update with increasesd settings version" for this time.
But I want to directly couple that to the API version. As long as the data is gathered from the proper API version, wich version of the Addon has gathered it does not mater for now. It's a possible conflict between data from different API versions, not a conflict between data from different versions of the Addon.
For that I need some way to get the API version from the client, of course...

[Sasky]

For a workaround at least, you could try detection of some of the added/deleted global functions or variables.
Not perfect of course, as there's no way to know future versions before they're on PTS.

[zgrssd]

Originally Posted by Sasky For a workaround at least, you could try detection of some of the added/deleted global functions or variables. Not perfect of course, as there's no way to know future versions before they're on PTS.

The only thing I found was among the global variables:
["_VERSION"] = 2013.1.0 r13331
Resetting after every client patch might be a bit overagressive. But I might have no other choice. Unless of course they alreay added/add a "GetAPIVersion()" function. I actually wrote something on the Wishlist for that:
http://www.esoui.com/forums/showthread.php?p=9751

But then again those Global Variables have not been udpate for a while and we are still waiting for the patchnotes. Maybe they added something for that already?

[Kentarii]

I store data in SV for my Quest Journal which isn't something I want to discard.. ZO really f..ked up this time.

I can fix it for my own use, but how can I expect the people using my addon to be able to fix it themselves?

[zgrssd]

Originally Posted by Kentarii I store data in SV for my Quest Journal which isn't something I want to discard.. ZO really f..ked up this time. I can fix it for my own use, but how can I expect the people using my addon to be able to fix it themselves?

This is not about Zenimax mistake. That one will be fixed, just not sure when. And it just belongs to the normal issues of a major update. Next content update we will have to remind people of this, when they say "worst update ever".

This thread was about my mistake in addon design.
It was a mistake not to guard against API changes. My addons stored chat data should be reset (once) when the API has changed. That is the only saveguard against "changing order of categories" I have and entirely my responsibility.
And unlike most addons, the bulk of stuff it writes too is not even player setable (without other addons).