Thread Tools Display Modes
01/09/24, 05:50 AM   #1
Marazota
AddOn Author - Click to view addons
Join Date: Sep 2015
Posts: 260
duplication of items in addon

hello i have old addon similar to inventory insight, where is scans all your item and add them in one list in separate UI. author mia long ago so i want to ask here

every time i open it i need to push re-scan button, because it duplciates each item
if i will not re-scan and open it many times again and again items will duplicate each time and list will be come bigger and bigger

here is addon itself, anyone can help, what need to be fixed there?

https://drive.usercontent.google.com...xport=download
  Reply With Quote
01/09/24, 06:25 AM   #2
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,989
Sounds like a Clear of the table for the list was not done, unless you press the rescan button.
So check the rescan function what it does to clear the list's table, and then do the same on open of the UI so it does not duplicate the entries anymore.

briefly looking at the code it should be the function

IA_InventoryAssistant:Refresh ( reload )

So check where IA_InventoryAssistant is created via <objectName> = IA_InventoryAssistant:New

and then where <objectName>:Refresh(<reload>) is called (should be in the rescan function).
And call the same at the open of the list then.

But to tell you the truth: The code is way to complex to fix that "simply". So better switch to anoher addon please, as it's too old imo.

Last edited by Baertram : 01/09/24 at 06:30 AM.
  Reply With Quote
01/09/24, 01:35 PM   #3
Marazota
AddOn Author - Click to view addons
Join Date: Sep 2015
Posts: 260
thanks for input i will try to look into it

this addon has some essential features other addons never had
so honestly no alternatives to it, at least for now
  Reply With Quote
01/09/24, 02:05 PM   #4
Dolgubon
 
Dolgubon's Avatar
AddOn Author - Click to view addons
Join Date: Jan 2016
Posts: 409
What are those features? Maybe they have been or could be implemented somewhere else.
  Reply With Quote
01/11/24, 09:13 AM   #5
Marazota
AddOn Author - Click to view addons
Join Date: Sep 2015
Posts: 260
Originally Posted by Dolgubon View Post
What are those features? Maybe they have been or could be implemented somewhere else.
group loot
you can click on the item to link in chat or on the player who received item to whisper to
hero doll where you can check what parts or set you already have, when mouseover set name category
all loot organized into categories by set names and other parameters, and newest acquired loot showed first
total number of items across all characters
overall good UI design
  Reply With Quote
01/11/24, 10:23 AM   #6
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,989
Loot https://www.esoui.com/downloads/info1455-LootLog.html
Doll at banks https://www.esoui.com/downloads/info...angeStuff.html
Total number of items across all characters https://www.esoui.com/downloads/info...ryInsight.html

Yes I know it's not 1 addon but you can forget to get 1 addon for all of your needs.
And I bet you can also forget to (get) fix(ed) an old addon (https://www.esoui.com/downloads/info...Assistant.html), that barely anyone uses anymore, to be working with all stuff properly today again (after 5+ years -> Updated: 2018-09-28 00:28).

Last edited by Baertram : 01/11/24 at 10:26 AM.
  Reply With Quote
01/13/24, 10:47 AM   #7
Marazota
AddOn Author - Click to view addons
Join Date: Sep 2015
Posts: 260
yeah i already made many fixes to Inventory Assistant, like get rid of libStub (that was not hard)

but ty for the links, Baertram
for now if i will not fix it will just use as it is, rescan every time i open
  Reply With Quote

ESOUI » Developer Discussions » Lua/XML Help » duplication of items in addon


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off