"borrowing" code snippets

[esothomas]

(didn't know where else to put this, so...)

in reference to this thread, what do we do to emphasize the (potentially) questionable morality displayed?

i know we work in a copy/paste milieu, but that doesn't mean acknowledgements can't be made. it just seems so dishonest to not even mention the source(s).

[Harven]

Hey,
I really don't like when people do copy/paste work without even stating that they used someones else code, but I think in this case accusations are exaggerated. I see only one copy/paste function from LightWeightMinimap (16 lines of code). The addon structure (folders and file names) are similar to RMM and so are few function names. You can say that the structure is inspired by RMM. But generally the code is very different from LightWeightMinimap and RMM. I don't think it deserves to be blocked or something because this isn't staight copy/paste/mix work. I agree that the author should write in the description that his addon was inspired by RMM and LightWeightMinimap but again this accusation: "The author has copied LightWeightMinimap and RMM in a new addon." is really exaggerated and unjust.
My opinion is based on about 30 minutes of looking at these three addons so maybe more deep review will reveal more copy/paste work but I think will be no more than few percent of the whole code.

[zgrssd]

If you think it really was stolen, just report it. The team will take a closer look at it. And if they disagree nothing will happen.

It is hard to know where exactly the border between insipiration, copy&paste and "great minds think alike" lies.
And it is quite possible that the functions look simialr is only conincidence:
There is often only one way to solve a given problem. That two people who solved the same problem happened to have the same solution is nothing odd.

I don't need to look at the code to guess that UnifiedChatTabs and ChatSetup propably have a few pieces of code in common. They work on the same thing (reading and writing of chat tab data & category colors). They solve the same issues. So naturally they might do so in the same way.
If not I propably look wich solution is better (mine or Xerovan) and just adapt it.

[esothomas]

yeah, i just wanted to run it by someone before i got all up in arms and stuff.

of course, i'd like for creators to be honest enough to state their "borrowing" clearly, but such is not always the case...

is there even a "report" function on this site?

[zgrssd]

Originally Posted by esothomas yeah, i just wanted to run it by someone before i got all up in arms and stuff. of course, i'd like for creators to be honest enough to state their "borrowing" clearly, but such is not always the case... is there even a "report" function on this site?

At the bottom of the Addon Page.
Just above the Category Jump System.
It is called "report this File".

[esothomas]

Originally Posted by zgrssd At the bottom of the Addon Page.

yeah i guess one of those categories would do. ah well... monitoring the situation for now, methinks.

[deathangel1479]

Goes on with zrmm...
Or I am paranoid?
I give two example...

1.
Abstract function, created by me. Its a bad result, but it works great for cyrodil links update...
That is one thing with a impossible chance, that two author make same...
RMM:

--Show Map Hidden
function RMM.WorldMapUpdate()
    ZO_WorldMap_UpdateMap()
    ZO_WorldMap:SetAlpha(0)
    ZO_WorldMap:SetHidden(false)
    zo_callLater(RMM.WorldMapReset, 100)
end
 
--Hide Map
function RMM.WorldMapReset()
    ZO_WorldMap:SetHidden(true)
    ZO_WorldMap:SetAlpha(1)
end

zrmm:

--------------------------------------------------
-- WorlMap refresh 
--------------------------------------------------
function MM_WorldMapRefresh()
    ZO_WorldMap:SetAlpha(0)
    ZO_WorldMap:SetHidden(false)
    ZO_WorldMap_PanToPlayer()
    zo_callLater(MM_WorldMapRefreshStop,20)
end
 
function MM_WorldMapRefreshStop()
    ZO_WorldMap:SetHidden(true)
    ZO_WorldMap:SetAlpha(1)
end

OK, its not the same, he changed a line and changed callLater value... :P

2.
zrmm now has tooltips, I added it two weeks ago(two days work to understand correctly, rebuild from worldmap and much testing).

True, some thinks you must do like worldmap, so there must be parallels, but so exactly same?

The worldmap build a list of tooltips when you hover more than one pins.
I dont do it, because to much work, single was ok for me...
WOW, what a coincidence, same for zrmm author...



What he thinking?
That I code new features for him?
"I can concentrate on stable and performans and all other I get from other addons." Or what?

I got the result for nearly no fps drop(much better as worldmap itself), but I wont build it, because it is real much work and I am sure, other will be copy it then...

[Sasky]

Yes, it does look very similar. However, this isn't something that should be aired in the forums unless the ESOUI admins are completely unresponsive.

1. Contact the author directly for him to remove the code or add credit.
2. If that doesn't go well, contact one of the admins - PM or using the Report File option. Note sections to make your point and indicate any results from (1).
3. If you don't get a response or appropriate action from the admins, then consider airing in the forums.

#1 and #2 can get something done about it. #3 cannot, unless the author or an admin review the thread, in which case #1 or #2 would've gotten you directly there.

[Cairenn]

Originally Posted by Sasky Yes, it does look very similar. However, this isn't something that should be aired in the forums unless the ESOUI admins are completely unresponsive. 1. Contact the author directly for him to remove the code or add credit. 2. If that doesn't go well, contact one of the admins - PM or using the Report File option. Note sections to make your point and indicate any results from (1). 3. If you don't get a response or appropriate action from the admins, then consider airing in the forums. #1 and #2 can get something done about it. #3 cannot, unless the author or an admin review the thread, in which case #1 or #2 would've gotten you directly there.

This. A thousand times, this.