Added control in stat screen doesn't hide correctly

[coolmodi]

I made a addon to show me the mitigation from resistances, and someone wanted the same feature "MitigationValue" had to show it in the char screen too.

I basically used the same code that addon did for adding it to the stat screen:

function MitigationPercent:displayInCharScreen()
	
		ZO_StatsPanelPaneScrollChildStatsRow6:SetHeight(40)
		ZO_StatsPanelPaneScrollChildStatsRow6Stat1:SetAnchor(TOPLEFT, ZO_StatsPanelPaneScrollChildStatsRow6, TOPLEFT)
		ZO_StatsPanelPaneScrollChildStatsRow6Stat2:SetAnchor(TOPRIGHT, ZO_StatsPanelPaneScrollChildStatsRow6, TOPRIGHT)
		
		MitigationPercentSpell:SetParent(ZO_StatsPanel)
		local width = ZO_StatsPanelPaneScrollChildStatsRow6Stat1:GetWidth()
		width = width - ZO_StatsPanelPaneScrollChildStatsRow6Stat1DiminishingReturns:GetWidth()
		MitigationPercentSpell:SetWidth(width)
		MitigationPercentSpell:ClearAnchors()	
		MitigationPercentSpell:SetAnchor(TOPLEFT, ZO_StatsPanelPaneScrollChildStatsRow6Stat1, BOTTOMLEFT)
		MitigationPercentSpell:SetHidden(false)
		
		MitigationPercentPhys:SetParent(ZO_StatsPanel)
		width = ZO_StatsPanelPaneScrollChildStatsRow6Stat2:GetWidth()
		width = width - ZO_StatsPanelPaneScrollChildStatsRow6Stat2DiminishingReturns:GetWidth()
		MitigationPercentPhys:SetWidth(width)
		MitigationPercentPhys:ClearAnchors()	
		MitigationPercentPhys:SetAnchor(TOPLEFT, ZO_StatsPanelPaneScrollChildStatsRow6Stat2, BOTTOMLEFT)
		MitigationPercentPhys:SetHidden(false)
		
		MitigationPercent.OnStatsUpdated()
end

which is executed by

ZO_PreHook(ZO_Stats, "InitializeKeybindButtons", function() self:displayInCharScreen() end)

But while it mostly works as it should, it will not hide correctly the first time you close the stat screen and will only show and hide correctly after i open the map, use a buff, scroll in stat screen etc.

I have no clue why this is the case. I'm no programmer or anything (only do small things like this here), but i just can't see why it only works after one of those things happens. MitigationValue seems to have the same problem (now), so i think the game itself is at fault here, but i can't find a workaround that is possible to setup with the api tools i know of.

I hope someone here can help me

Edit:
Things i thought of but miss knowledge to do:
-Open and close the map (or any other thing that has the same effect, are there such functions?)
-showing and hiding my controls whenever the statscreen opens/closes (i can do hiding on close wit hthe popped event, but how can i check when it opens again?)

[Garkin]

It would be much easier if you do not add new line, but just modify text already in there.
For example line:
Spell Resistance: 10000
becomes:
Spell Resistance: 10000 (15.63%)


Simple code how to do that:

local function GetDisplayValue(self)
    local value = self:GetValue()
    local percentage = value / ((GetUnitLevel("player") + GetUnitVeteranRank("player"))  * 10)
 
    return ("%d (%04.02f%%)"):format(value, percentage)
end
 
local SetUpStat_Orig = ZO_Stats.SetUpStat
local function SetUpStat(self, statEntry, statType)
    SetUpStat_Orig(self, statEntry, statType)
    if statType == STAT_SPELL_RESIST or statType == STAT_PHYSICAL_RESIST then
        self.statEntries[statType].GetDisplayValue = GetDisplayValue
    end
end
ZO_Stats.SetUpStat = SetUpStat

[Garkin]

Small hack how to add mitigation values:

local function GetDisplayValue(self)
    local value = self:GetValue() / ((GetUnitLevel("player") + GetUnitVeteranRank("player")) * 10)
    return zo_strformat(SI_STAT_VALUE_PERCENT, value)
end
 
local CreateAttributesSection_Orig = ZO_Stats.CreateAttributesSection
local function CreateAttributesSection(self)
    CreateAttributesSection_Orig(self)
    self:SetNextControlPadding(0)
    self:AddStatRow(STAT_SPELL_MITIGATION, STAT_MITIGATION)
    self.statEntries[STAT_SPELL_MITIGATION].name:SetText("Spell Resistance Value")
    self.statEntries[STAT_SPELL_MITIGATION].value.statType = STAT_SPELL_RESIST
    self.statEntries[STAT_SPELL_MITIGATION].GetDisplayValue = GetDisplayValue
    self.statEntries[STAT_MITIGATION].name:SetText("Physical Resistance Value")
    self.statEntries[STAT_MITIGATION].value.statType = STAT_PHYSICAL_RESIST
    self.statEntries[STAT_MITIGATION].GetDisplayValue = GetDisplayValue
end
ZO_Stats.CreateAttributesSection = CreateAttributesSection

Result:

[coolmodi]

WOW thanks very much!
This really helps alot.

If i have time later i'll look into it and try to understand it

[merlight]

Regarding your non-hiding issue, that's because you defined your controls as <TopLevelControl>. Those are not supposed to have a parent, and thus hide with it. Change that to <Control>.